From: Gerd Hoffmann <kraxel@redhat.com>
To: Ian McKellar <ianloic@google.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/1] Improve Cocoa modifier key handling
Date: Tue, 23 May 2017 12:03:16 +0200 [thread overview]
Message-ID: <1495533796.30747.2.camel@redhat.com> (raw)
In-Reply-To: <20170522180217.18234-1-ianloic@google.com>
Hi,
> looked at the keyCode to determine what modifier key changed. This
> usually works fine but sometimes the keyCode is 0 and the app should
> instead be looking at the modifierFlags bitmask. Key code 0 is the
> 'a'
> key.
>
> I added code that handles keyCode == 0 differently. It checks the
> modifierFlags and if they differ from QEMU's idea of which modifier
> keys are currently pressed it toggles those changed keys.
Sounds like this happens in case there is a modifier state change
without linked key event, such as state change while qemu did not have
the keyboard focus. Nice that macos sends notifications in that case.
I'm wondering whenever we should just use modifierFlags all the time.
cheers,
Gerd
next prev parent reply other threads:[~2017-05-23 10:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 18:02 [Qemu-devel] [PATCH 1/1] Improve Cocoa modifier key handling Ian McKellar
2017-05-23 10:03 ` Gerd Hoffmann [this message]
2017-05-23 15:52 ` Ian McKellar
2017-05-23 17:39 ` Ian McKellar
2017-05-24 6:17 ` Gerd Hoffmann
2017-05-26 23:39 ` Ian McKellar
[not found] <mailman.71687.1494691106.22739.qemu-devel@nongnu.org>
2017-05-18 0:23 ` G 3
-- strict thread matches above, loose matches on Subject: below --
2017-05-12 22:25 Ian McKellar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495533796.30747.2.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=ianloic@google.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).