From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: Greg Kurz <groug@kaod.org>
Subject: [Qemu-devel] [PULL 1/9] scripts/qmp/qom-set: fix the value argument passed to srv.command()
Date: Tue, 23 May 2017 14:30:30 +0200 [thread overview]
Message-ID: <1495542638-12335-2-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1495542638-12335-1-git-send-email-armbru@redhat.com>
From: Greg Kurz <groug@kaod.org>
When invoking the script with -s, we end up passing a bogus value
to QEMU:
$ ./scripts/qmp/qom-set -s /var/tmp/qmp-sock-exp /machine.accel kvm
{}
$ ./scripts/qmp/qom-get -s /var/tmp/qmp-sock-exp /machine.accel
/var/tmp/qmp-sock-exp
This happens because sys.argv[2] isn't necessarily the command line
argument that holds the value. It is sys.argv[4] when -s was also
passed.
Actually, the code already has a variable to handle that. This patch
simply uses it.
Signed-off-by: Greg Kurz <groug@kaod.org>
Message-Id: <149373610338.5144.9635049015143453288.stgit@bahia.lan>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
scripts/qmp/qom-set | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/qmp/qom-set b/scripts/qmp/qom-set
index 54ecfec..94e2778 100755
--- a/scripts/qmp/qom-set
+++ b/scripts/qmp/qom-set
@@ -61,4 +61,4 @@ else:
srv = QEMUMonitorProtocol(socket_path)
srv.connect()
-print srv.command('qom-set', path=path, property=prop, value=sys.argv[2])
+print srv.command('qom-set', path=path, property=prop, value=value)
--
2.7.4
next prev parent reply other threads:[~2017-05-23 12:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 12:30 [Qemu-devel] [PULL 0/9] QAPI patches for 2017-05-23 Markus Armbruster
2017-05-23 12:30 ` Markus Armbruster [this message]
2017-05-23 12:30 ` [Qemu-devel] [PULL 2/9] sockets: Plug memory leak in socket_address_flatten() Markus Armbruster
2017-05-23 12:30 ` [Qemu-devel] [PULL 3/9] shutdown: Simplify shutdown_signal Markus Armbruster
2017-05-23 12:30 ` [Qemu-devel] [PULL 4/9] shutdown: Prepare for use of an enum in reset/shutdown_request Markus Armbruster
2017-05-23 12:30 ` [Qemu-devel] [PULL 5/9] shutdown: Preserve shutdown cause through replay Markus Armbruster
2017-05-23 12:30 ` [Qemu-devel] [PULL 6/9] shutdown: Add source information to SHUTDOWN and RESET Markus Armbruster
2017-05-23 12:30 ` [Qemu-devel] [PULL 7/9] shutdown: Expose bool cause in SHUTDOWN and RESET events Markus Armbruster
2017-05-23 12:30 ` [Qemu-devel] [PULL 8/9] block: Use QDict helpers for --force-share Markus Armbruster
2017-05-23 12:30 ` [Qemu-devel] [PULL 9/9] qapi-schema: Remove obsolete note from ObjectTypeInfo Markus Armbruster
2017-05-30 8:37 ` [Qemu-devel] [PULL 0/9] QAPI patches for 2017-05-23 Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495542638-12335-2-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).