From: Suraj Jitindar Singh <sjitindarsingh@gmail.com>
To: Bharata B Rao <bharata@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, david@gibson.dropbear.id.au,
sam.bobroff@au1.ibm.com, rnsastry@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH v3 3/3] spapr: Fix migration of Radix guests
Date: Wed, 24 May 2017 16:16:50 +1000 [thread overview]
Message-ID: <1495606610.2305.0.camel@gmail.com> (raw)
In-Reply-To: <1495601614-18586-4-git-send-email-bharata@linux.vnet.ibm.com>
On Wed, 2017-05-24 at 10:23 +0530, Bharata B Rao wrote:
> Fix migration of radix guests by ensuring that we issue
> KVM_PPC_CONFIGURE_V3_MMU for radix case post migration.
>
> Reported-by: Nageswara R Sastry <rnsastry@linux.vnet.ibm.com>
> Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
Reviewed-by: Suraj Jitindar Singh <sjitindarsingh@gmail.com>
> ---
> hw/ppc/spapr.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index daf335c..ea14bed 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -1400,6 +1400,18 @@ static int spapr_post_load(void *opaque, int
> version_id)
> err = spapr_rtc_import_offset(&spapr->rtc, spapr-
> >rtc_offset);
> }
>
> + if (spapr->patb_entry) {
> + PowerPCCPU *cpu = POWERPC_CPU(first_cpu);
> + bool radix = !!(spapr->patb_entry & PATBE1_GR);
> + bool gtse = !!(cpu->env.spr[SPR_LPCR] & LPCR_GTSE);
> +
> + err = kvmppc_configure_v3_mmu(cpu, radix, gtse, spapr-
> >patb_entry);
> + if (err) {
> + error_report("Process table config unsupported by the
> host");
> + return -EINVAL;
> + }
> + }
> +
> return err;
> }
>
next prev parent reply other threads:[~2017-05-24 6:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 4:53 [Qemu-devel] [PATCH v3 0/3] ppc/spapr: Fix migration of radix guests Bharata B Rao
2017-05-24 4:53 ` [Qemu-devel] [PATCH v3 1/3] migration: Introduce unregister_savevm_live() Bharata B Rao
2017-05-24 6:28 ` Juan Quintela
2017-05-24 6:36 ` David Gibson
2017-05-24 7:18 ` Juan Quintela
2017-05-24 4:53 ` [Qemu-devel] [PATCH v3 2/3] spapr: Unregister HPT savevm handlers for radix guests Bharata B Rao
2017-05-26 4:11 ` Bharata B Rao
2017-05-24 4:53 ` [Qemu-devel] [PATCH v3 3/3] spapr: Fix migration of Radix guests Bharata B Rao
2017-05-24 6:16 ` Suraj Jitindar Singh [this message]
2017-05-26 5:55 ` [Qemu-devel] [PATCH v3 0/3] ppc/spapr: Fix migration of radix guests David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495606610.2305.0.camel@gmail.com \
--to=sjitindarsingh@gmail.com \
--cc=bharata@linux.vnet.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rnsastry@linux.vnet.ibm.com \
--cc=sam.bobroff@au1.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).