From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37948) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dDPbx-0006y8-9D for qemu-devel@nongnu.org; Wed, 24 May 2017 02:17:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dDPbu-0007IO-5o for qemu-devel@nongnu.org; Wed, 24 May 2017 02:17:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34364) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dDPbu-0007I6-0H for qemu-devel@nongnu.org; Wed, 24 May 2017 02:17:30 -0400 Message-ID: <1495606647.30747.10.camel@redhat.com> From: Gerd Hoffmann Date: Wed, 24 May 2017 08:17:27 +0200 In-Reply-To: References: <20170522180217.18234-1-ianloic@google.com> <1495533796.30747.2.camel@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/1] Improve Cocoa modifier key handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ian McKellar , qemu-devel@nongnu.org Hi, > After a little more experimentation I think that the approach in this > patch is the right one. modifierFlags doesn't[1] indicate which > instance of a modifier (ie: left or right) is being held. Ok, makes sense. One more thing: I think capslock must be handled differently as keydown + keyup toggle state. cheers, Gerd