Re: [Qemu-devel] [PULL 00/22] Docker and block patches

[no-reply@patchew.org]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20170526075246.20265-1-famz@redhat.com
Subject: [Qemu-devel] [PULL 00/22] Docker and block patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20170526082925.2888-1-maozy.fnst@cn.fujitsu.com -> patchew/20170526082925.2888-1-maozy.fnst@cn.fujitsu.com
Switched to a new branch 'test'
16cb74a block: make accounting thread-safe
8239635 block: introduce block_account_one_io
63bcf13 block: protect modification of dirty bitmaps with a mutex
f58097c migration/block: reset dirty bitmap before reading
ed83d5e block: introduce dirty_bitmap_mutex
f046d70 block: protect tracked_requests and flush_queue with reqs_lock
a7745ae block: access write_gen with atomics
1541938 block: use Stat64 for wr_highest_offset
6ebccfc util: add stats64 module
d0f217d throttle-groups: protect throttled requests with a CoMutex
0e06e5a throttle-groups: do not use qemu_co_enter_next
31d6860 throttle-groups: only start one coroutine from drained_begin
68c0e16 block: access io_plugged with atomic ops
621c393 block: access wakeup with atomic ops
c1c29f6 block: access serialising_in_flight with atomic ops
87f6654 block: access io_limits_disabled with atomic ops
16e5db1 block: access quiesce_counter with atomic ops
018cb8b block: access copy_on_read with atomic ops
f57b4b1 docker: Add flex and bison to centos6 image
6ac5045 docker: Add libaio to fedora image
7a2103e docker: Add bzip2 and hostname to fedora image
7e83232 docker: Run tests with current user

=== OUTPUT BEGIN ===
Checking PATCH 1/22: docker: Run tests with current user...
Checking PATCH 2/22: docker: Add bzip2 and hostname to fedora image...
Checking PATCH 3/22: docker: Add libaio to fedora image...
Checking PATCH 4/22: docker: Add flex and bison to centos6 image...
Checking PATCH 5/22: block: access copy_on_read with atomic ops...
Checking PATCH 6/22: block: access quiesce_counter with atomic ops...
Checking PATCH 7/22: block: access io_limits_disabled with atomic ops...
Checking PATCH 8/22: block: access serialising_in_flight with atomic ops...
Checking PATCH 9/22: block: access wakeup with atomic ops...
Checking PATCH 10/22: block: access io_plugged with atomic ops...
Checking PATCH 11/22: throttle-groups: only start one coroutine from drained_begin...
Checking PATCH 12/22: throttle-groups: do not use qemu_co_enter_next...
Checking PATCH 13/22: throttle-groups: protect throttled requests with a CoMutex...
Checking PATCH 14/22: util: add stats64 module...
ERROR: memory barrier without comment
#330: FILE: util/stats64.c:101:
+        smp_wmb();

ERROR: memory barrier without comment
#359: FILE: util/stats64.c:130:
+        smp_wmb();

total: 2 errors, 0 warnings, 334 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 15/22: block: use Stat64 for wr_highest_offset...
Checking PATCH 16/22: block: access write_gen with atomics...
Checking PATCH 17/22: block: protect tracked_requests and flush_queue with reqs_lock...
Checking PATCH 18/22: block: introduce dirty_bitmap_mutex...
Checking PATCH 19/22: migration/block: reset dirty bitmap before reading...
Checking PATCH 20/22: block: protect modification of dirty bitmaps with a mutex...
WARNING: line over 80 characters
#306: FILE: migration/block.c:539:
+            bdrv_reset_dirty_bitmap_locked(bmds->dirty_bitmap, sector, nr_sectors);

total: 0 errors, 1 warnings, 272 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 21/22: block: introduce block_account_one_io...
Checking PATCH 22/22: block: make accounting thread-safe...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org