qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Peter Xu <peterx@redhat.com>, Jason Wang <jasowang@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <rth@twiddle.net>,
	Eduardo Habkost <ehabkost@redhat.com>
Subject: [Qemu-devel] [PULL 06/13] intel_iommu: use IOMMU_ACCESS_FLAG()
Date: Mon, 29 May 2017 03:18:45 +0300	[thread overview]
Message-ID: <1496017081-24032-7-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1496017081-24032-1-git-send-email-mst@redhat.com>

From: Peter Xu <peterx@redhat.com>

We have that now, so why not use it.

Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Jason Wang <jasowang@redhat.com>
---
 hw/i386/intel_iommu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
index b477143..3240e5d 100644
--- a/hw/i386/intel_iommu.c
+++ b/hw/i386/intel_iommu.c
@@ -1010,7 +1010,7 @@ out:
     entry->iova = addr & page_mask;
     entry->translated_addr = vtd_get_slpte_addr(slpte) & page_mask;
     entry->addr_mask = ~page_mask;
-    entry->perm = (writes ? 2 : 0) + (reads ? 1 : 0);
+    entry->perm = IOMMU_ACCESS_FLAG(reads, writes);
 }
 
 static void vtd_root_table_setup(IntelIOMMUState *s)
-- 
MST

  parent reply	other threads:[~2017-05-29  0:18 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-29  0:18 [Qemu-devel] [PULL 00/13] pci, virtio, vhost: fixes Michael S. Tsirkin
2017-05-29  0:18 ` [Qemu-devel] [PULL 01/13] memory: tune last param of iommu_ops.translate() Michael S. Tsirkin
2017-05-29  0:18 ` [Qemu-devel] [PULL 02/13] memory: remove the last param in memory_region_iommu_replay() Michael S. Tsirkin
2017-05-29  0:18 ` [Qemu-devel] [PULL 03/13] x86-iommu: use DeviceClass properties Michael S. Tsirkin
2017-05-29  0:18 ` [Qemu-devel] [PULL 04/13] intel_iommu: renaming context entry helpers Michael S. Tsirkin
2017-05-29  0:18 ` [Qemu-devel] [PULL 05/13] intel_iommu: provide vtd_ce_get_type() Michael S. Tsirkin
2017-05-29  0:18 ` Michael S. Tsirkin [this message]
2017-05-29  0:18 ` [Qemu-devel] [PULL 07/13] intel_iommu: allow dev-iotlb context entry conditionally Michael S. Tsirkin
2017-05-29  0:18 ` [Qemu-devel] [PULL 09/13] intel_iommu: turn off pt before 2.9 Michael S. Tsirkin
2017-05-29  0:18 ` [Qemu-devel] [PULL 10/13] virtio_net: Bypass backends for MTU feature negotiation Michael S. Tsirkin
2017-05-29  0:18 ` [Qemu-devel] [PULL 11/13] vhost-user: pass message as a pointer to process_message_reply() Michael S. Tsirkin
2017-05-29  0:19 ` [Qemu-devel] [PULL 12/13] pc: ACPI BIOS: use highest NUMA node for hotplug mem hole SRAT entry Michael S. Tsirkin
2017-05-29  0:19 ` [Qemu-devel] [PULL 13/13] acpi-test: update expected files Michael S. Tsirkin
2017-05-29  0:19 ` [Qemu-devel] [PULL 08/13] intel_iommu: support passthrough (PT) Michael S. Tsirkin
2017-05-30  9:41 ` [Qemu-devel] [PULL 00/13] pci, virtio, vhost: fixes Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1496017081-24032-7-git-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).