From: Greg Kurz <groug@kaod.org>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Stefan Hajnoczi <stefanha@redhat.com>, Greg Kurz <groug@kaod.org>
Subject: [Qemu-devel] [PULL 06/11] 9pfs: assume utimensat() and futimens() are present
Date: Mon, 29 May 2017 11:05:35 +0200 [thread overview]
Message-ID: <1496048740-26578-7-git-send-email-groug@kaod.org> (raw)
In-Reply-To: <1496048740-26578-1-git-send-email-groug@kaod.org>
The utimensat() and futimens() syscalls have been around for ages (ie,
glibc 2.6 and linux 2.6.22), and the decision was already taken to
switch to utimensat() anyway when fixing CVE-2016-9602 in 2.9.
Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
fsdev/virtfs-proxy-helper.c | 3 ++-
hw/9pfs/9p-handle.c | 5 -----
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c
index 4c4238f62e53..6c066ec9a0ce 100644
--- a/fsdev/virtfs-proxy-helper.c
+++ b/fsdev/virtfs-proxy-helper.c
@@ -945,7 +945,8 @@ static int process_requests(int sock)
&spec[0].tv_sec, &spec[0].tv_nsec,
&spec[1].tv_sec, &spec[1].tv_nsec);
if (retval > 0) {
- retval = qemu_utimens(path.data, spec);
+ retval = utimensat(AT_FDCWD, path.data, spec,
+ AT_SYMLINK_NOFOLLOW);
if (retval < 0) {
retval = -errno;
}
diff --git a/hw/9pfs/9p-handle.c b/hw/9pfs/9p-handle.c
index 1687661bc95a..9875f1894cc5 100644
--- a/hw/9pfs/9p-handle.c
+++ b/hw/9pfs/9p-handle.c
@@ -378,7 +378,6 @@ static int handle_utimensat(FsContext *ctx, V9fsPath *fs_path,
const struct timespec *buf)
{
int ret;
-#ifdef CONFIG_UTIMENSAT
int fd;
struct handle_data *data = (struct handle_data *)ctx->private;
@@ -388,10 +387,6 @@ static int handle_utimensat(FsContext *ctx, V9fsPath *fs_path,
}
ret = futimens(fd, buf);
close(fd);
-#else
- ret = -1;
- errno = ENOSYS;
-#endif
return ret;
}
--
2.7.4
next prev parent reply other threads:[~2017-05-29 9:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-29 9:05 [Qemu-devel] [PULL 00/11] 9pfs patches for 2.10 20170525 Greg Kurz
2017-05-29 9:05 ` [Qemu-devel] [PULL 01/11] virtio-9p/xen-9p: move 9p specific bits to core 9p code Greg Kurz
2017-05-29 9:05 ` [Qemu-devel] [PULL 02/11] fsdev: don't allow unknown format in marshal/unmarshal Greg Kurz
2017-05-29 9:05 ` [Qemu-devel] [PULL 03/11] 9pfs: drop pdu_push_and_notify() Greg Kurz
2017-05-29 9:05 ` [Qemu-devel] [PULL 04/11] 9pfs: local: fix unlink of alien files in mapped-file mode Greg Kurz
2017-05-29 9:05 ` [Qemu-devel] [PULL 05/11] fsdev: fix virtfs-proxy-helper cwd Greg Kurz
2017-05-29 9:05 ` Greg Kurz [this message]
2017-05-29 9:05 ` [Qemu-devel] [PULL 07/11] util: drop old utimensat() compat code Greg Kurz
2017-05-29 9:05 ` [Qemu-devel] [PULL 08/11] 9pfs: check return value of v9fs_co_name_to_path() Greg Kurz
2017-05-29 9:05 ` [Qemu-devel] [PULL 09/11] 9pfs: local: resolve special directories in paths Greg Kurz
2017-05-29 9:05 ` [Qemu-devel] [PULL 10/11] 9pfs: local: simplify file opening Greg Kurz
2017-05-29 9:05 ` [Qemu-devel] [PULL 11/11] 9pfs: local: metadata file for the VirtFS root Greg Kurz
2017-05-29 9:19 ` [Qemu-devel] [PULL 00/11] 9pfs patches for 2.10 20170525 no-reply
2017-05-30 9:42 ` Stefan Hajnoczi
2017-05-30 10:21 ` Greg Kurz
2017-05-30 10:26 ` Daniel P. Berrange
2017-05-30 10:33 ` Greg Kurz
2017-05-30 10:50 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496048740-26578-7-git-send-email-groug@kaod.org \
--to=groug@kaod.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).