* [Qemu-devel] [PATCH] spice: Use proper enum type for kbd led state
@ 2017-05-10 20:20 Jonathon Jongsma
2017-05-25 12:50 ` Marc-André Lureau
0 siblings, 1 reply; 3+ messages in thread
From: Jonathon Jongsma @ 2017-05-10 20:20 UTC (permalink / raw)
To: qemu-devel
Although the Qemu and spice flags currently have the same value, it
seems more correct to pass the spice flag values to
spice_server_kbd_leds(), especially considering that this function
already makes an effort to convert between the QEMU_*_LED and
SPICE_KEYBOARD_MODIFIER_* values.
Signed-off-by: Jonathon Jongsma <jjongsma@redhat.com>
---
ui/spice-input.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/spice-input.c b/ui/spice-input.c
index 8eeebdb..7fd283b 100644
--- a/ui/spice-input.c
+++ b/ui/spice-input.c
@@ -87,7 +87,7 @@ static void kbd_leds(void *opaque, int ledstate)
if (ledstate & QEMU_CAPS_LOCK_LED) {
kbd->ledstate |= SPICE_KEYBOARD_MODIFIER_FLAGS_CAPS_LOCK;
}
- spice_server_kbd_leds(&kbd->sin, ledstate);
+ spice_server_kbd_leds(&kbd->sin, kbd->ledstate);
}
/* mouse bits */
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] spice: Use proper enum type for kbd led state
2017-05-10 20:20 [Qemu-devel] [PATCH] spice: Use proper enum type for kbd led state Jonathon Jongsma
@ 2017-05-25 12:50 ` Marc-André Lureau
2017-05-29 12:17 ` Gerd Hoffmann
0 siblings, 1 reply; 3+ messages in thread
From: Marc-André Lureau @ 2017-05-25 12:50 UTC (permalink / raw)
To: Jonathon Jongsma, qemu-devel; +Cc: Gerd Hoffmann
On Thu, May 11, 2017 at 6:16 AM Jonathon Jongsma <jjongsma@redhat.com>
wrote:
> Although the Qemu and spice flags currently have the same value, it
> seems more correct to pass the spice flag values to
> spice_server_kbd_leds(), especially considering that this function
> already makes an effort to convert between the QEMU_*_LED and
> SPICE_KEYBOARD_MODIFIER_* values.
>
> Signed-off-by: Jonathon Jongsma <jjongsma@redhat.com>
>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> ui/spice-input.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ui/spice-input.c b/ui/spice-input.c
> index 8eeebdb..7fd283b 100644
> --- a/ui/spice-input.c
> +++ b/ui/spice-input.c
> @@ -87,7 +87,7 @@ static void kbd_leds(void *opaque, int ledstate)
> if (ledstate & QEMU_CAPS_LOCK_LED) {
> kbd->ledstate |= SPICE_KEYBOARD_MODIFIER_FLAGS_CAPS_LOCK;
> }
> - spice_server_kbd_leds(&kbd->sin, ledstate);
> + spice_server_kbd_leds(&kbd->sin, kbd->ledstate);
> }
>
> /* mouse bits */
> --
> 2.9.3
>
>
> --
Marc-André Lureau
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] spice: Use proper enum type for kbd led state
2017-05-25 12:50 ` Marc-André Lureau
@ 2017-05-29 12:17 ` Gerd Hoffmann
0 siblings, 0 replies; 3+ messages in thread
From: Gerd Hoffmann @ 2017-05-29 12:17 UTC (permalink / raw)
To: Marc-André Lureau, Jonathon Jongsma, qemu-devel
On Thu, 2017-05-25 at 12:50 +0000, Marc-André Lureau wrote:
>
>
> On Thu, May 11, 2017 at 6:16 AM Jonathon Jongsma <jjongsma@redhat.com
> > wrote:
> > Although the Qemu and spice flags currently have the same value, it
> > seems more correct to pass the spice flag values to
> > spice_server_kbd_leds(), especially considering that this function
> > already makes an effort to convert between the QEMU_*_LED and
> > SPICE_KEYBOARD_MODIFIER_* values.
> >
> > Signed-off-by: Jonathon Jongsma <jjongsma@redhat.com>
>
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>
>
Added to ui queue.
thanks,
Gerd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-29 12:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-10 20:20 [Qemu-devel] [PATCH] spice: Use proper enum type for kbd led state Jonathon Jongsma
2017-05-25 12:50 ` Marc-André Lureau
2017-05-29 12:17 ` Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).