From: Gerd Hoffmann <kraxel@redhat.com>
To: Ladi Prosek <lprosek@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] usb-hub: set PORT_STAT_C_SUSPEND on host-initiated wake-up
Date: Mon, 29 May 2017 14:20:26 +0200 [thread overview]
Message-ID: <1496060426.5201.2.camel@redhat.com> (raw)
In-Reply-To: <20170522123325.2199-1-lprosek@redhat.com>
On Mon, 2017-05-22 at 14:33 +0200, Ladi Prosek wrote:
> PORT_STAT_C_SUSPEND should be set even on host-initiated wake-up,
> i.e. on ClearPortFeature(PORT_SUSPEND). Windows is known to not
> work properly otherwise.
>
> Side note, since PORT_ENABLE looks similar and might appear to
> have the same issue: According to 11.24.2.7.2.2 C_PORT_ENABLE:
>
> "This bit is set when the PORT_ENABLE bit changes from one to
> zero as a result of a Port Error condition (see Section 11.8.1).
> This bit is not set on any other changes to PORT_ENABLE."
>
> Signed-off-by: Ladi Prosek <lprosek@redhat.com>
Added to usb queue.
thanks,
Gerd
prev parent reply other threads:[~2017-05-29 12:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 12:33 [Qemu-devel] [PATCH] usb-hub: set PORT_STAT_C_SUSPEND on host-initiated wake-up Ladi Prosek
2017-05-29 12:20 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496060426.5201.2.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=lprosek@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).