From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 12/15] qemu-img: Fix leakage of options on error
Date: Mon, 29 May 2017 17:06:51 +0200 [thread overview]
Message-ID: <1496070414-6744-13-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1496070414-6744-1-git-send-email-kwolf@redhat.com>
From: Fam Zheng <famz@redhat.com>
Reported by Coverity.
Signed-off-by: Fam Zheng <famz@redhat.com>
Message-id: 20170515141014.25793-1-famz@redhat.com
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
qemu-img.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/qemu-img.c b/qemu-img.c
index 0bf941b..5aef8ef 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -295,6 +295,7 @@ static BlockBackend *img_open_opts(const char *optstr,
if (qdict_haskey(options, BDRV_OPT_FORCE_SHARE)
&& !qdict_get_bool(options, BDRV_OPT_FORCE_SHARE)) {
error_report("--force-share/-U conflicts with image options");
+ QDECREF(options);
return NULL;
}
qdict_put(options, BDRV_OPT_FORCE_SHARE, qbool_from_bool(true));
--
1.8.3.1
next prev parent reply other threads:[~2017-05-29 15:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-29 15:06 [Qemu-devel] [PULL 00/15] Block layer patches Kevin Wolf
2017-05-29 15:06 ` [Qemu-devel] [PULL 01/15] stream: fix crash in stream_start() when block_job_create() fails Kevin Wolf
2017-05-29 15:06 ` [Qemu-devel] [PULL 02/15] qemu-iotests: Test streaming with missing job ID Kevin Wolf
2017-05-29 15:06 ` [Qemu-devel] [PULL 03/15] iotests: 147: Don't test inet6 if not available Kevin Wolf
2017-05-29 15:06 ` [Qemu-devel] [PULL 04/15] nvme: Add support for Controller Memory Buffers Kevin Wolf
2017-05-29 15:06 ` [Qemu-devel] [PULL 05/15] mirror: Drop permissions on s->target on completion Kevin Wolf
2017-05-29 15:06 ` [Qemu-devel] [PULL 06/15] qcow2: remove extra local_error variable Kevin Wolf
2017-05-29 15:06 ` [Qemu-devel] [PULL 07/15] qemu-img: Fix documentation of convert Kevin Wolf
2017-05-29 15:06 ` [Qemu-devel] [PULL 08/15] qemu-img: add support for --object with 'dd' command Kevin Wolf
2017-05-29 15:06 ` [Qemu-devel] [PULL 09/15] qemu-img: fix --image-opts usage with dd command Kevin Wolf
2017-05-29 15:06 ` [Qemu-devel] [PULL 10/15] qemu-img: introduce --target-image-opts for 'convert' command Kevin Wolf
2017-05-29 15:06 ` [Qemu-devel] [PULL 11/15] qemu-img: copy *key-secret opts when opening newly created files Kevin Wolf
2017-05-29 15:06 ` Kevin Wolf [this message]
2017-05-29 15:06 ` [Qemu-devel] [PULL 13/15] block: Tweak error message related to qemu-img amend Kevin Wolf
2017-05-29 15:06 ` [Qemu-devel] [PULL 14/15] block: Fix backing paths for filenames with colons Kevin Wolf
2017-05-29 15:06 ` [Qemu-devel] [PULL 15/15] block/file-*: *_parse_filename() and colons Kevin Wolf
2017-05-30 9:44 ` [Qemu-devel] [Qemu-block] [PULL 00/15] Block layer patches Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496070414-6744-13-git-send-email-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).