qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 13/15] block: Tweak error message related to qemu-img amend
Date: Mon, 29 May 2017 17:06:52 +0200	[thread overview]
Message-ID: <1496070414-6744-14-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1496070414-6744-1-git-send-email-kwolf@redhat.com>

From: Eric Blake <eblake@redhat.com>

When converting a 1.1 image down to 0.10, qemu-iotests 060 forces
a contrived failure where allocating a cluster used to replace a
zero cluster reads unaligned data.  Since it is a zero cluster
rather than a data cluster being converted, changing the error
message to match our earlier change in 'qcow2: Make distinction
between zero cluster types obvious' is worthwhile.

Suggested-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-id: 20170508171302.17805-1-eblake@redhat.com
[mreitz: Commit message fixes]
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
 block/qcow2-cluster.c      | 3 ++-
 tests/qemu-iotests/060.out | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index 347d94b..d779ea1 100644
--- a/block/qcow2-cluster.c
+++ b/block/qcow2-cluster.c
@@ -1797,7 +1797,8 @@ static int expand_zero_clusters_in_l1(BlockDriverState *bs, uint64_t *l1_table,
             }
 
             if (offset_into_cluster(s, offset)) {
-                qcow2_signal_corruption(bs, true, -1, -1, "Data cluster offset "
+                qcow2_signal_corruption(bs, true, -1, -1,
+                                        "Cluster allocation offset "
                                         "%#" PRIx64 " unaligned (L2 offset: %#"
                                         PRIx64 ", L2 index: %#x)", offset,
                                         l2_offset, j);
diff --git a/tests/qemu-iotests/060.out b/tests/qemu-iotests/060.out
index 9e8f5b9..3bc1461 100644
--- a/tests/qemu-iotests/060.out
+++ b/tests/qemu-iotests/060.out
@@ -143,7 +143,7 @@ read failed: Input/output error
 Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864
 wrote 65536/65536 bytes at offset 0
 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
-qcow2: Marking image as corrupt: Data cluster offset 0x52a00 unaligned (L2 offset: 0x40000, L2 index: 0); further corruption events will be suppressed
+qcow2: Marking image as corrupt: Cluster allocation offset 0x52a00 unaligned (L2 offset: 0x40000, L2 index: 0); further corruption events will be suppressed
 qemu-img: Error while amending options: Input/output error
 
 === Testing unaligned reftable entry ===
-- 
1.8.3.1

  parent reply	other threads:[~2017-05-29 15:07 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-29 15:06 [Qemu-devel] [PULL 00/15] Block layer patches Kevin Wolf
2017-05-29 15:06 ` [Qemu-devel] [PULL 01/15] stream: fix crash in stream_start() when block_job_create() fails Kevin Wolf
2017-05-29 15:06 ` [Qemu-devel] [PULL 02/15] qemu-iotests: Test streaming with missing job ID Kevin Wolf
2017-05-29 15:06 ` [Qemu-devel] [PULL 03/15] iotests: 147: Don't test inet6 if not available Kevin Wolf
2017-05-29 15:06 ` [Qemu-devel] [PULL 04/15] nvme: Add support for Controller Memory Buffers Kevin Wolf
2017-05-29 15:06 ` [Qemu-devel] [PULL 05/15] mirror: Drop permissions on s->target on completion Kevin Wolf
2017-05-29 15:06 ` [Qemu-devel] [PULL 06/15] qcow2: remove extra local_error variable Kevin Wolf
2017-05-29 15:06 ` [Qemu-devel] [PULL 07/15] qemu-img: Fix documentation of convert Kevin Wolf
2017-05-29 15:06 ` [Qemu-devel] [PULL 08/15] qemu-img: add support for --object with 'dd' command Kevin Wolf
2017-05-29 15:06 ` [Qemu-devel] [PULL 09/15] qemu-img: fix --image-opts usage with dd command Kevin Wolf
2017-05-29 15:06 ` [Qemu-devel] [PULL 10/15] qemu-img: introduce --target-image-opts for 'convert' command Kevin Wolf
2017-05-29 15:06 ` [Qemu-devel] [PULL 11/15] qemu-img: copy *key-secret opts when opening newly created files Kevin Wolf
2017-05-29 15:06 ` [Qemu-devel] [PULL 12/15] qemu-img: Fix leakage of options on error Kevin Wolf
2017-05-29 15:06 ` Kevin Wolf [this message]
2017-05-29 15:06 ` [Qemu-devel] [PULL 14/15] block: Fix backing paths for filenames with colons Kevin Wolf
2017-05-29 15:06 ` [Qemu-devel] [PULL 15/15] block/file-*: *_parse_filename() and colons Kevin Wolf
2017-05-30  9:44 ` [Qemu-devel] [Qemu-block] [PULL 00/15] Block layer patches Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1496070414-6744-14-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).