qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kurz <groug@kaod.org>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Stefan Hajnoczi <stefanha@redhat.com>, Greg Kurz <groug@kaod.org>
Subject: [Qemu-devel] [PULL v2 02/11] fsdev: don't allow unknown format in marshal/unmarshal
Date: Tue, 30 May 2017 15:40:31 +0200	[thread overview]
Message-ID: <1496151640-29919-3-git-send-email-groug@kaod.org> (raw)
In-Reply-To: <1496151640-29919-1-git-send-email-groug@kaod.org>

The code only uses well known format strings. An unknown format token is a
bug.

Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
---
 fsdev/9p-iov-marshal.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fsdev/9p-iov-marshal.c b/fsdev/9p-iov-marshal.c
index 1d16f8df4bd4..a1c9beddd2e7 100644
--- a/fsdev/9p-iov-marshal.c
+++ b/fsdev/9p-iov-marshal.c
@@ -168,7 +168,7 @@ ssize_t v9fs_iov_vunmarshal(struct iovec *out_sg, int out_num, size_t offset,
             break;
         }
         default:
-            break;
+            g_assert_not_reached();
         }
         if (copied < 0) {
             return copied;
@@ -281,7 +281,7 @@ ssize_t v9fs_iov_vmarshal(struct iovec *in_sg, int in_num, size_t offset,
             break;
         }
         default:
-            break;
+            g_assert_not_reached();
         }
         if (copied < 0) {
             return copied;
-- 
2.7.5

  parent reply	other threads:[~2017-05-30 13:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-30 13:40 [Qemu-devel] [PULL v2 00/11] 9pfs patches for 2.10 20170530 Greg Kurz
2017-05-30 13:40 ` [Qemu-devel] [PULL v2 01/11] virtio-9p/xen-9p: move 9p specific bits to core 9p code Greg Kurz
2017-05-30 13:40 ` Greg Kurz [this message]
2017-05-30 13:40 ` [Qemu-devel] [PULL v2 03/11] 9pfs: drop pdu_push_and_notify() Greg Kurz
2017-05-30 13:40 ` [Qemu-devel] [PULL v2 04/11] 9pfs: local: fix unlink of alien files in mapped-file mode Greg Kurz
2017-05-30 13:40 ` [Qemu-devel] [PULL v2 05/11] fsdev: fix virtfs-proxy-helper cwd Greg Kurz
2017-05-30 13:40 ` [Qemu-devel] [PULL v2 06/11] 9pfs: assume utimensat() and futimens() are present Greg Kurz
2017-05-30 13:40 ` [Qemu-devel] [PULL v2 07/11] util: drop old utimensat() compat code Greg Kurz
2017-05-30 13:40 ` [Qemu-devel] [PULL v2 08/11] 9pfs: check return value of v9fs_co_name_to_path() Greg Kurz
2017-05-30 13:40 ` [Qemu-devel] [PULL v2 09/11] 9pfs: local: resolve special directories in paths Greg Kurz
2017-05-30 13:40 ` [Qemu-devel] [PULL v2 10/11] 9pfs: local: simplify file opening Greg Kurz
2017-05-30 13:40 ` [Qemu-devel] [PULL v2 11/11] 9pfs: local: metadata file for the VirtFS root Greg Kurz
2017-06-01 12:12 ` [Qemu-devel] [PULL v2 00/11] 9pfs patches for 2.10 20170530 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1496151640-29919-3-git-send-email-groug@kaod.org \
    --to=groug@kaod.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).