From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 2/4] qapi: Document visit_type_any() issues with keyval input
Date: Wed, 31 May 2017 19:09:05 +0200 [thread overview]
Message-ID: <1496250547-20701-3-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1496250547-20701-1-git-send-email-armbru@redhat.com>
It's already documented in keyval.c (commit 0ee9ae7), but visitor.h
can use a note, too.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <1495471335-23707-3-git-send-email-armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
include/qapi/visitor.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/include/qapi/visitor.h b/include/qapi/visitor.h
index b0e233d..4721c39 100644
--- a/include/qapi/visitor.h
+++ b/include/qapi/visitor.h
@@ -607,6 +607,10 @@ void visit_type_number(Visitor *v, const char *name, double *obj,
* @obj must be non-NULL. Input visitors set *@obj to the value;
* other visitors will leave *@obj unchanged. *@obj must be non-NULL
* for output visitors.
+ *
+ * Note that some kinds of input can't express arbitrary QObject.
+ * E.g. the visitor returned by qobject_input_visitor_new_keyval()
+ * can't create numbers or booleans, only strings.
*/
void visit_type_any(Visitor *v, const char *name, QObject **obj, Error **errp);
--
2.7.4
next prev parent reply other threads:[~2017-05-31 17:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 17:09 [Qemu-devel] [PULL 0/4] QAPI patches for 2017-05-31 Markus Armbruster
2017-05-31 17:09 ` [Qemu-devel] [PULL 1/4] qobject-input-visitor: Reject non-finite numbers with keyval Markus Armbruster
2017-05-31 17:09 ` Markus Armbruster [this message]
2017-05-31 17:09 ` [Qemu-devel] [PULL 3/4] tests/qapi-schema: Avoid 'str' in alternate test cases Markus Armbruster
2017-05-31 17:09 ` [Qemu-devel] [PULL 4/4] qapi: Reject alternates that can't work with keyval_parse() Markus Armbruster
2017-06-01 17:10 ` [Qemu-devel] [PULL 0/4] QAPI patches for 2017-05-31 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496250547-20701-3-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).