qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Michael S . Tsirkin" <mst@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Maxime Coquelin <maxime.coquelin@redhat.com>,
	peterx@redhat.com, Jason Wang <jasowang@redhat.com>
Subject: [Qemu-devel] [PATCH 0/3] exec: further refine address_space_get_iotlb_entry()
Date: Fri,  2 Jun 2017 19:50:51 +0800	[thread overview]
Message-ID: <1496404254-17429-1-git-send-email-peterx@redhat.com> (raw)

With the patch applied:

  [PATCH v3] exec: fix address_space_get_iotlb_entry page mask
  (already in Paolo's pull request but not yet merged)

Now we can have valid address masks. However it is still not ideal,
considering that the mask may not be aligned to guest page sizes. One
example would be when huge page is used in guest (please see commit
message in patch 1 for details). It applies to normal pages too. So we
not only need a valid address mask, we should make sure it is page
mask (for x86, it should be either 4K/2M/1G pages).

Patch 1+2 fixes the problem. Tested with both kernel net driver or
testpmd, on either 4K/2M pages, to make sure the page mask is correct.

Patch 3 is cherry picked from PT series, after fixing from 1+2, we'll
definitely want patch 3 now. Here's the simplest TCP streaming test
using vhost dmar and iommu=pt in guest:

  without patch 3:    12.0Gbps
  with patch 3:       33.5Gbps

Please review, thanks.

Peter Xu (3):
  exec: add page_mask for address_space_do_translate
  exec: simplify address_space_get_iotlb_entry
  vhost: iommu: cache static mapping if there is

 exec.c                 | 73 +++++++++++++++++++++++++++++++++-----------------
 hw/virtio/trace-events |  4 +++
 hw/virtio/vhost.c      | 66 +++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 119 insertions(+), 24 deletions(-)

-- 
2.7.4

             reply	other threads:[~2017-06-02 11:51 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-02 11:50 Peter Xu [this message]
2017-06-02 11:50 ` [Qemu-devel] [PATCH 1/3] exec: add page_mask for address_space_do_translate Peter Xu
2017-06-02 16:45   ` Michael S. Tsirkin
2017-06-05  2:52     ` Peter Xu
2017-06-02 11:50 ` [Qemu-devel] [PATCH 2/3] exec: simplify address_space_get_iotlb_entry Peter Xu
2017-06-02 16:49   ` Michael S. Tsirkin
2017-06-05  3:07     ` Peter Xu
2017-06-06 14:34       ` Paolo Bonzini
2017-06-06 23:47         ` David Gibson
2017-06-07  3:44           ` Peter Xu
2017-06-07 13:07             ` Michael S. Tsirkin
2017-06-08  6:11               ` Peter Xu
2017-06-08 18:59                 ` Michael S. Tsirkin
2017-06-09  1:58                   ` Peter Xu
2017-06-09  2:37                     ` David Gibson
2017-06-11 10:09                     ` Michael S. Tsirkin
2017-06-11 12:10                       ` David Gibson
2017-06-12  2:34                         ` Peter Xu
2017-06-12  3:07                           ` Michael S. Tsirkin
2017-06-12  4:04                             ` Peter Xu
2017-06-14 18:34                               ` Michael S. Tsirkin
2017-06-15  2:31                                 ` Peter Xu
2017-06-15  2:57                                   ` Peter Xu
2017-06-16 15:33                                   ` Michael S. Tsirkin
2017-06-07 13:01           ` Paolo Bonzini
2017-06-02 11:50 ` [Qemu-devel] [PATCH 3/3] vhost: iommu: cache static mapping if there is Peter Xu
2017-06-02 15:45   ` Michael S. Tsirkin
2017-06-05  3:15     ` Peter Xu
2017-06-05  4:07       ` Jason Wang
2017-06-05 15:05       ` Michael S. Tsirkin
2017-06-02 16:51   ` Michael S. Tsirkin
2017-06-02 14:51 ` [Qemu-devel] [PATCH 0/3] exec: further refine address_space_get_iotlb_entry() Michael S. Tsirkin
2017-06-05  3:20   ` Peter Xu
2017-06-06 15:29     ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1496404254-17429-1-git-send-email-peterx@redhat.com \
    --to=peterx@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).