From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: [Qemu-devel] [PULL 2/8] virtio: add virtqueue_alloc_element tracepoint
Date: Fri, 2 Jun 2017 19:34:34 +0300 [thread overview]
Message-ID: <1496421247-857-3-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1496421247-857-1-git-send-email-mst@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
This tracepoint can help diagnosing failures due to memory
fragmentation in the guest.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/virtio/virtio.c | 1 +
hw/virtio/trace-events | 1 +
2 files changed, 2 insertions(+)
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index f99d99f..464947f 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.c
@@ -815,6 +815,7 @@ static void *virtqueue_alloc_element(size_t sz, unsigned out_num, unsigned in_nu
assert(sz >= sizeof(VirtQueueElement));
elem = g_malloc(out_sg_end);
+ trace_virtqueue_alloc_element(elem, sz, in_num, out_num);
elem->out_num = out_num;
elem->in_num = in_num;
elem->in_addr = (void *)elem + in_addr_ofs;
diff --git a/hw/virtio/trace-events b/hw/virtio/trace-events
index 1f7a7c1..e24d8fa 100644
--- a/hw/virtio/trace-events
+++ b/hw/virtio/trace-events
@@ -1,6 +1,7 @@
# See docs/tracing.txt for syntax documentation.
# hw/virtio/virtio.c
+virtqueue_alloc_element(void *elem, size_t sz, unsigned in_num, unsigned out_num) "elem %p size %zd in_num %u out_num %u"
virtqueue_fill(void *vq, const void *elem, unsigned int len, unsigned int idx) "vq %p elem %p len %u idx %u"
virtqueue_flush(void *vq, unsigned int count) "vq %p count %u"
virtqueue_pop(void *vq, void *elem, unsigned int in_num, unsigned int out_num) "vq %p elem %p in_num %u out_num %u"
--
MST
next prev parent reply other threads:[~2017-06-02 16:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 16:34 [Qemu-devel] [PULL 0/8] virtio, vhost: fixes, features Michael S. Tsirkin
2017-06-02 16:34 ` [Qemu-devel] [PULL 1/8] virtio-serial-bus: Unset hotplug handler when unrealize Michael S. Tsirkin
2017-06-02 16:34 ` Michael S. Tsirkin [this message]
2017-06-02 16:34 ` [Qemu-devel] [PULL 3/8] virtio-serial: fix segfault on disconnect Michael S. Tsirkin
2017-06-02 16:34 ` [Qemu-devel] [PULL 4/8] vhost: propagate errors in vhost_device_iotlb_miss() Michael S. Tsirkin
2017-06-02 16:34 ` [Qemu-devel] [PULL 5/8] vhost: rework IOTLB messaging Michael S. Tsirkin
2017-06-02 16:34 ` [Qemu-devel] [PULL 6/8] vhost-user: add vhost_user to hold the chr Michael S. Tsirkin
2017-06-02 16:34 ` [Qemu-devel] [PULL 7/8] vhost-user: add slave-req-fd support Michael S. Tsirkin
2017-06-02 16:34 ` [Qemu-devel] [PULL 8/8] spec/vhost-user spec: Add IOMMU support Michael S. Tsirkin
2017-06-02 17:36 ` [Qemu-devel] [PULL 0/8] virtio, vhost: fixes, features Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496421247-857-3-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).