qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: Markus Armbruster <armbru@redhat.com>,
	Laurent Vivier <lvivier@redhat.com>,
	Juan Quintela <quintela@redhat.com>,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
	peterx@redhat.com
Subject: [Qemu-devel] [PATCH 3/6] migration: use compat bit for global_state
Date: Tue,  6 Jun 2017 18:30:39 +0800	[thread overview]
Message-ID: <1496745042-2379-4-git-send-email-peterx@redhat.com> (raw)
In-Reply-To: <1496745042-2379-1-git-send-email-peterx@redhat.com>

Removing two callers of global_state_set_optional() since now we can use
HW_COMPAT_2_3. However there is still one more caller (xen_init), so we
still need to keep the function until it disappears.

Signed-off-by: Peter Xu <peterx@redhat.com>
---
 hw/i386/pc_piix.c   | 1 -
 hw/ppc/spapr.c      | 1 -
 include/hw/compat.h | 4 ++++
 3 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index 2234bd0..c83cec5 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -317,7 +317,6 @@ static void pc_compat_2_3(MachineState *machine)
     if (kvm_enabled()) {
         pcms->smm = ON_OFF_AUTO_OFF;
     }
-    global_state_set_optional();
     savevm_skip_configuration();
 }
 
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index ab3aab1..3e78bb9 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -3593,7 +3593,6 @@ static void spapr_machine_2_3_instance_options(MachineState *machine)
 {
     spapr_machine_2_4_instance_options(machine);
     savevm_skip_section_footers();
-    global_state_set_optional();
     savevm_skip_configuration();
 }
 
diff --git a/include/hw/compat.h b/include/hw/compat.h
index 400c64b..5b5c8de 100644
--- a/include/hw/compat.h
+++ b/include/hw/compat.h
@@ -177,6 +177,10 @@
         .driver   = TYPE_PCI_DEVICE,\
         .property = "x-pcie-lnksta-dllla",\
         .value    = "off",\
+    },{\
+        .driver   = "migration",\
+        .property = "store-global-state",\
+        .value    = "off",\
     },
 
 #define HW_COMPAT_2_2 \
-- 
2.7.4

  parent reply	other threads:[~2017-06-06 10:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-06 10:30 [Qemu-devel] [PATCH 0/6] migration: objectify MigrationState Peter Xu
2017-06-06 10:30 ` [Qemu-devel] [PATCH 1/6] migration: let MigrationState be a qdev Peter Xu
2017-06-07 16:52   ` Juan Quintela
2017-06-06 10:30 ` [Qemu-devel] [PATCH 2/6] migration: move global_state.optional out Peter Xu
2017-06-07 17:42   ` Juan Quintela
2017-06-08 10:41     ` Peter Xu
2017-06-08 11:12       ` Juan Quintela
2017-06-08 12:44         ` Peter Xu
2017-06-08 13:24           ` Juan Quintela
2017-06-06 10:30 ` Peter Xu [this message]
2017-06-07 17:44   ` [Qemu-devel] [PATCH 3/6] migration: use compat bit for global_state Juan Quintela
2017-06-06 10:30 ` [Qemu-devel] [PATCH 4/6] migration: move only_migratable to MigrationState Peter Xu
2017-06-06 10:30 ` [Qemu-devel] [PATCH 5/6] migration: move skip_configuration out Peter Xu
2017-06-07 17:48   ` Juan Quintela
2017-06-06 10:30 ` [Qemu-devel] [PATCH 6/6] migration: move skip_section_footers Peter Xu
2017-06-07 17:52   ` Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1496745042-2379-4-git-send-email-peterx@redhat.com \
    --to=peterx@redhat.com \
    --cc=armbru@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).