From: "Emilio G. Cota" <cota@braap.org>
To: qemu-devel@nongnu.org
Cc: Richard Henderson <rth@twiddle.net>,
alex.bennee@linaro.org, Peter Maydell <peter.maydell@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Pranith Kumar <bobby.prani@gmail.com>,
Geert Martin Ijewski <gm.ijewski@web.de>
Subject: [Qemu-devel] [PATCH v3 0/2] tcg: allocate TB structs preceding translate
Date: Tue, 6 Jun 2017 19:12:23 -0400 [thread overview]
Message-ID: <1496790745-314-1-git-send-email-cota@braap.org> (raw)
v2: https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg01147.html
Changes from v2:
- Dropped the configure-time check. Instead, do this at init-time
as suggested by Richard.
- Added Pranith's R-b tag to the TCG patch.
- Added cache info query for Windows thanks to Geerd's help.
- Added cache info query for MacOS [ #ifdef __APPLE__ ] via sysctl. (Note:
I only tested the code on a standalone program, since I cannot install
QEMU's dependences on the MacOS machine I got access to)
- Use int instead of unsigned int for the line sizes. This allows
us to use ROUND_UP without having to cast to int (ROUND_UP negates
the alignment parameter)
Question: is it worth adding a paranoid check to make sure the linesizes
we obtain are a pow2? If there's a bug somewhere in the reporting,
we'll get in trouble due to ROUND_UP, which only works with pow2
parameters. A safer alternative is to use QEMU_ALIGN_UP, but it's slower.
This patchset applies cleanly on top of the current master (65dfad62a).
Thanks,
Emilio
next reply other threads:[~2017-06-06 23:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 23:12 Emilio G. Cota [this message]
2017-06-06 23:12 ` [Qemu-devel] [PATCH v3 1/2] util: add cacheinfo Emilio G. Cota
2017-06-07 0:17 ` [Qemu-devel] [PATCH v3 1/2 -- fixed] " Emilio G. Cota
2017-06-07 14:05 ` Pranith Kumar
2017-06-06 23:12 ` [Qemu-devel] [PATCH v3 2/2] tcg: allocate TB structs before the corresponding translated code Emilio G. Cota
2017-06-06 23:38 ` [Qemu-devel] [PATCH v3 0/2] tcg: allocate TB structs preceding translate no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496790745-314-1-git-send-email-cota@braap.org \
--to=cota@braap.org \
--cc=alex.bennee@linaro.org \
--cc=bobby.prani@gmail.com \
--cc=gm.ijewski@web.de \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).