[Qemu-devel] [PATCH] net/colo-compare.c: Add no-need-checkpoint period to optimize performance

[Qemu-devel] [PATCH] net/colo-compare.c: Add no-need-checkpoint period to optimize performance

[Zhang Chen]

If colo-compare find out the first different packet that means
the following packet almost is different. we needn't do a lot
of checkpoint in one second, so we set the no-need-checkpoint
period, default just set 3 second.

Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
---
 net/colo-compare.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/net/colo-compare.c b/net/colo-compare.c
index 6d500e1..8fb1c9c 100644
--- a/net/colo-compare.c
+++ b/net/colo-compare.c
@@ -39,6 +39,8 @@
 
 /* TODO: Should be configurable */
 #define REGULAR_PACKET_CHECK_MS 3000
+/* TODO: Should be configurable */
+#define CHECKPOINT_MIN_TIME 3000
 
 /*
   + CompareState ++
@@ -455,6 +457,7 @@ static void colo_compare_connection(void *opaque, void *user_data)
     Packet *pkt = NULL;
     GList *result = NULL;
     int ret;
+    static int64_t checkpoint_time_ms;
 
     while (!g_queue_is_empty(&conn->primary_list) &&
            !g_queue_is_empty(&conn->secondary_list)) {
@@ -494,7 +497,11 @@ static void colo_compare_connection(void *opaque, void *user_data)
              */
             trace_colo_compare_main("packet different");
             g_queue_push_tail(&conn->primary_list, pkt);
-            /* TODO: colo_notify_checkpoint();*/
+
+            if (pkt->creation_ms - checkpoint_time_ms > CHECKPOINT_MIN_TIME) {
+                /* TODO: colo_notify_checkpoint();*/
+                checkpoint_time_ms = pkt->creation_ms;
+            }
             break;
         }
     }
-- 
2.7.4