From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36272) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dIx2t-0005Tt-46 for qemu-devel@nongnu.org; Thu, 08 Jun 2017 09:00:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dIx2o-00047L-Nm for qemu-devel@nongnu.org; Thu, 08 Jun 2017 09:00:15 -0400 From: Thomas Huth Date: Thu, 8 Jun 2017 14:59:59 +0200 Message-Id: <1496926799-13040-1-git-send-email-thuth@redhat.com> Subject: [Qemu-devel] [PATCH v3] Makefile: Do not generate files if "configure" has not been run yet List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Fam Zheng , Paolo Bonzini , qemu-trivial@nongnu.org, Peter Maydell , Eric Blake When doing a "make -j10" in the vanilla QEMU source tree (without running "configure" first), the Makefile currently generates two files already, qemu-version.h and qemu-options.def. This should not happen, so let's only build the generated files if config-host.mak is available (i.e. "configure" has been run already). Signed-off-by: Thomas Huth --- v3: - Check for config-host.mak at the place where we add the dependencies for $(GENERATED_FILES) instead of adding single dependencies all over the place Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Makefile b/Makefile index c830d7a..32d4441 100644 --- a/Makefile +++ b/Makefile @@ -791,9 +791,11 @@ endif # CONFIG_WIN # Add a dependency on the generated files, so that they are always # rebuilt before other object files +ifneq ($(wildcard config-host.mak),) ifneq ($(filter-out $(UNCHECKED_GOALS),$(MAKECMDGOALS)),$(if $(MAKECMDGOALS),,fail)) Makefile: $(GENERATED_FILES) endif +endif .SECONDARY: $(TRACE_HEADERS) $(TRACE_HEADERS:%=%-timestamp) \ $(TRACE_SOURCES) $(TRACE_SOURCES:%=%-timestamp) \ -- 1.8.3.1