qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [Qemu-devel] [PULL 14/41] object: use more specific property type names
Date: Fri,  9 Jun 2017 15:46:58 +0200	[thread overview]
Message-ID: <1497016045-6009-15-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1497016045-6009-1-git-send-email-armbru@redhat.com>

From: Marc-André Lureau <marcandre.lureau@redhat.com>

Use the actual unsigned integer type name.

The type name change impacts the following externally visible area:

* vl.c's machine_help_func() puts it in help for -machine NAME,help.

* QMP command qom-list exposes it in ObjectPropertyInfo member @type.

* QMP command device-list-properties exposes it in DevicePropertyInfo
  member @type.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20170607163635.17635-15-marcandre.lureau@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 backends/cryptodev.c |  2 +-
 hw/pci-host/piix.c   |  8 ++++----
 hw/pci-host/q35.c    | 10 +++++-----
 hw/ppc/pnv.c         |  2 +-
 net/dump.c           |  2 +-
 net/filter-buffer.c  |  2 +-
 6 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/backends/cryptodev.c b/backends/cryptodev.c
index 832f056..1764c17 100644
--- a/backends/cryptodev.c
+++ b/backends/cryptodev.c
@@ -222,7 +222,7 @@ cryptodev_backend_can_be_deleted(UserCreatable *uc, Error **errp)
 
 static void cryptodev_backend_instance_init(Object *obj)
 {
-    object_property_add(obj, "queues", "int",
+    object_property_add(obj, "queues", "uint32",
                           cryptodev_backend_get_queues,
                           cryptodev_backend_set_queues,
                           NULL, NULL, NULL);
diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
index 4ce201e..a2c1033 100644
--- a/hw/pci-host/piix.c
+++ b/hw/pci-host/piix.c
@@ -273,19 +273,19 @@ static void i440fx_pcihost_initfn(Object *obj)
     memory_region_init_io(&s->data_mem, obj, &pci_host_data_le_ops, s,
                           "pci-conf-data", 4);
 
-    object_property_add(obj, PCI_HOST_PROP_PCI_HOLE_START, "int",
+    object_property_add(obj, PCI_HOST_PROP_PCI_HOLE_START, "uint32",
                         i440fx_pcihost_get_pci_hole_start,
                         NULL, NULL, NULL, NULL);
 
-    object_property_add(obj, PCI_HOST_PROP_PCI_HOLE_END, "int",
+    object_property_add(obj, PCI_HOST_PROP_PCI_HOLE_END, "uint32",
                         i440fx_pcihost_get_pci_hole_end,
                         NULL, NULL, NULL, NULL);
 
-    object_property_add(obj, PCI_HOST_PROP_PCI_HOLE64_START, "int",
+    object_property_add(obj, PCI_HOST_PROP_PCI_HOLE64_START, "uint64",
                         i440fx_pcihost_get_pci_hole64_start,
                         NULL, NULL, NULL, NULL);
 
-    object_property_add(obj, PCI_HOST_PROP_PCI_HOLE64_END, "int",
+    object_property_add(obj, PCI_HOST_PROP_PCI_HOLE64_END, "uint64",
                         i440fx_pcihost_get_pci_hole64_end,
                         NULL, NULL, NULL, NULL);
 }
diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c
index e8a04d3..c2f2af5 100644
--- a/hw/pci-host/q35.c
+++ b/hw/pci-host/q35.c
@@ -175,23 +175,23 @@ static void q35_host_initfn(Object *obj)
     qdev_prop_set_uint32(DEVICE(&s->mch), "addr", PCI_DEVFN(0, 0));
     qdev_prop_set_bit(DEVICE(&s->mch), "multifunction", false);
 
-    object_property_add(obj, PCI_HOST_PROP_PCI_HOLE_START, "int",
+    object_property_add(obj, PCI_HOST_PROP_PCI_HOLE_START, "uint32",
                         q35_host_get_pci_hole_start,
                         NULL, NULL, NULL, NULL);
 
-    object_property_add(obj, PCI_HOST_PROP_PCI_HOLE_END, "int",
+    object_property_add(obj, PCI_HOST_PROP_PCI_HOLE_END, "uint32",
                         q35_host_get_pci_hole_end,
                         NULL, NULL, NULL, NULL);
 
-    object_property_add(obj, PCI_HOST_PROP_PCI_HOLE64_START, "int",
+    object_property_add(obj, PCI_HOST_PROP_PCI_HOLE64_START, "uint64",
                         q35_host_get_pci_hole64_start,
                         NULL, NULL, NULL, NULL);
 
-    object_property_add(obj, PCI_HOST_PROP_PCI_HOLE64_END, "int",
+    object_property_add(obj, PCI_HOST_PROP_PCI_HOLE64_END, "uint64",
                         q35_host_get_pci_hole64_end,
                         NULL, NULL, NULL, NULL);
 
-    object_property_add(obj, PCIE_HOST_MCFG_SIZE, "int",
+    object_property_add(obj, PCIE_HOST_MCFG_SIZE, "uint64",
                         q35_host_get_mmcfg_size,
                         NULL, NULL, NULL, NULL);
 
diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
index 89b6801..a4cd733 100644
--- a/hw/ppc/pnv.c
+++ b/hw/ppc/pnv.c
@@ -1111,7 +1111,7 @@ static void powernv_machine_initfn(Object *obj)
 
 static void powernv_machine_class_props_init(ObjectClass *oc)
 {
-    object_class_property_add(oc, "num-chips", "uint32_t",
+    object_class_property_add(oc, "num-chips", "uint32",
                               pnv_get_num_chips, pnv_set_num_chips,
                               NULL, NULL, NULL);
     object_class_property_set_description(oc, "num-chips",
diff --git a/net/dump.c b/net/dump.c
index 442eb53..15df9a4 100644
--- a/net/dump.c
+++ b/net/dump.c
@@ -328,7 +328,7 @@ static void filter_dump_instance_init(Object *obj)
 
     nfds->maxlen = 65536;
 
-    object_property_add(obj, "maxlen", "int", filter_dump_get_maxlen,
+    object_property_add(obj, "maxlen", "uint32", filter_dump_get_maxlen,
                         filter_dump_set_maxlen, NULL, NULL, NULL);
     object_property_add_str(obj, "file", file_dump_get_filename,
                             file_dump_set_filename, NULL);
diff --git a/net/filter-buffer.c b/net/filter-buffer.c
index cc6bd94..9ce96aa 100644
--- a/net/filter-buffer.c
+++ b/net/filter-buffer.c
@@ -191,7 +191,7 @@ out:
 
 static void filter_buffer_init(Object *obj)
 {
-    object_property_add(obj, "interval", "int",
+    object_property_add(obj, "interval", "uint32",
                         filter_buffer_get_interval,
                         filter_buffer_set_interval, NULL, NULL, NULL);
 }
-- 
2.7.5

  parent reply	other threads:[~2017-06-09 13:47 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-09 13:46 [Qemu-devel] [PULL 00/41] QAPI patches for 2017-06-09 Markus Armbruster
2017-06-09 13:46 ` [Qemu-devel] [PULL 01/41] qdev: remove PropertyInfo.qtype field Markus Armbruster
2017-06-09 13:46 ` [Qemu-devel] [PULL 02/41] object: fix potential leak in getters Markus Armbruster
2017-06-09 13:46 ` [Qemu-devel] [PULL 03/41] tests: Remove test cases for alternates of 'number' and 'int' Markus Armbruster
2017-06-09 13:46 ` [Qemu-devel] [PULL 04/41] tests: add more int/number ranges checks Markus Armbruster
2017-06-09 13:46 ` [Qemu-devel] [PULL 05/41] qapi: Clean up qobject_input_type_number() control flow Markus Armbruster
2017-06-09 13:46 ` [Qemu-devel] [PULL 06/41] qapi: merge QInt and QFloat in QNum Markus Armbruster
2017-06-09 13:46 ` [Qemu-devel] [PULL 07/41] qapi: Remove visit_start_alternate() parameter promote_int Markus Armbruster
2017-06-09 13:46 ` [Qemu-devel] [PULL 08/41] tests: remove /{qnum, qlist, dict}/destroy test Markus Armbruster
2017-06-09 13:46 ` [Qemu-devel] [PULL 09/41] qnum: add uint type Markus Armbruster
2017-06-09 13:46 ` [Qemu-devel] [PULL 10/41] json: learn to parse uint64 numbers Markus Armbruster
2017-06-09 13:46 ` [Qemu-devel] [PULL 11/41] qapi: update the qobject visitor to use QNUM_U64 Markus Armbruster
2017-06-09 13:46 ` [Qemu-devel] [PULL 12/41] object: add uint property setter/getter Markus Armbruster
2017-06-09 13:46 ` [Qemu-devel] [PULL 13/41] q35: fix get_mmcfg_size to use uint64 visitor Markus Armbruster
2017-06-09 13:46 ` Markus Armbruster [this message]
2017-06-09 13:46 ` [Qemu-devel] [PULL 15/41] qdev: Rename DEFINE_PROP_DEFAULT() to DEFINE_PROP_SIGNED() Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 16/41] qdev: wrap default property value in an union Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 17/41] qdev: avoid type casts between signed and unsigned Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 18/41] apic-common: make "id" property a uint32 Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 19/41] qdev: Use appropriate getter/setters type Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 20/41] isa: use get_uint() for "io-base" Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 21/41] pc-dimm: use get_uint() for dimm properties Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 22/41] pc-dimm: make "size" property uint64 Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 23/41] pcihp: use get_uint() for "bsel" property Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 24/41] aspeed: use {set, get}_uint() for "ram-size" property Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 25/41] bcm2835_fb: use {get, set}_uint() for "vcram-size" and "vcram-base" Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 26/41] platform-bus: use get_uint() for "addr" property Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 27/41] acpi: use get_uint() for "acpi-pcihp-io*" properties Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 28/41] acpi: use get_uint() for various acpi properties Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 29/41] acpi: use get_uint() for "pci-hole*" properties Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 30/41] pc: use get_uint() for "iobase" property Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 31/41] pc: use get_uint() for "apic-id" property Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 32/41] pc: use get_uint() for "hpet-intcap" property Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 33/41] xen: use get_uint() for "max-ram-below-4g" property Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 34/41] arm: use get_uint() for "mp-affinity" property Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 35/41] auxbus: use get_uint() for "addr" property Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 36/41] pvpanic: use get_uint() for "ioport" property Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 37/41] pnv-core: use get_uint() for "core-pir" property Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 38/41] numa: use get_uint() for "size" property Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 39/41] i386/cpu: use get_uint() for "min-level"/"min-xlevel" properties Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 40/41] console: use get_uint() for "head" property Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 41/41] tests/qdict: check more get_try_int() cases Markus Armbruster
2017-06-09 15:05 ` [Qemu-devel] [PULL 00/41] QAPI patches for 2017-06-09 no-reply
2017-06-09 15:38 ` no-reply
2017-06-12 10:39 ` Peter Maydell
2017-06-12 10:52   ` Marc-André Lureau
2017-06-12 11:50     ` Peter Maydell
2017-06-20 11:59   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1497016045-6009-15-git-send-email-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).