From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [Qemu-devel] [PULL 25/41] bcm2835_fb: use {get, set}_uint() for "vcram-size" and "vcram-base"
Date: Fri, 9 Jun 2017 15:47:09 +0200 [thread overview]
Message-ID: <1497016045-6009-26-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1497016045-6009-1-git-send-email-armbru@redhat.com>
From: Marc-André Lureau <marcandre.lureau@redhat.com>
Both properties are defined with DEFINE_PROP_UINT32().
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20170607163635.17635-26-marcandre.lureau@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
hw/arm/bcm2835_peripherals.c | 9 ++++-----
hw/arm/raspi.c | 4 ++--
2 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/hw/arm/bcm2835_peripherals.c b/hw/arm/bcm2835_peripherals.c
index 502f04c..12e0dd1 100644
--- a/hw/arm/bcm2835_peripherals.c
+++ b/hw/arm/bcm2835_peripherals.c
@@ -125,7 +125,7 @@ static void bcm2835_peripherals_realize(DeviceState *dev, Error **errp)
Object *obj;
MemoryRegion *ram;
Error *err = NULL;
- uint32_t ram_size, vcram_size;
+ uint64_t ram_size, vcram_size;
int n;
obj = object_property_get_link(OBJECT(dev), "ram", &err);
@@ -207,15 +207,14 @@ static void bcm2835_peripherals_realize(DeviceState *dev, Error **errp)
INTERRUPT_ARM_MAILBOX));
/* Framebuffer */
- vcram_size = (uint32_t)object_property_get_int(OBJECT(s), "vcram-size",
- &err);
+ vcram_size = object_property_get_uint(OBJECT(s), "vcram-size", &err);
if (err) {
error_propagate(errp, err);
return;
}
- object_property_set_int(OBJECT(&s->fb), ram_size - vcram_size,
- "vcram-base", &err);
+ object_property_set_uint(OBJECT(&s->fb), ram_size - vcram_size,
+ "vcram-base", &err);
if (err) {
error_propagate(errp, err);
return;
diff --git a/hw/arm/raspi.c b/hw/arm/raspi.c
index 2b295f1..32cdc98 100644
--- a/hw/arm/raspi.c
+++ b/hw/arm/raspi.c
@@ -153,8 +153,8 @@ static void raspi2_init(MachineState *machine)
qdev_prop_set_drive(carddev, "drive", blk, &error_fatal);
object_property_set_bool(OBJECT(carddev), true, "realized", &error_fatal);
- vcram_size = object_property_get_int(OBJECT(&s->soc), "vcram-size",
- &error_abort);
+ vcram_size = object_property_get_uint(OBJECT(&s->soc), "vcram-size",
+ &error_abort);
setup_boot(machine, 2, machine->ram_size - vcram_size);
}
--
2.7.5
next prev parent reply other threads:[~2017-06-09 13:47 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 13:46 [Qemu-devel] [PULL 00/41] QAPI patches for 2017-06-09 Markus Armbruster
2017-06-09 13:46 ` [Qemu-devel] [PULL 01/41] qdev: remove PropertyInfo.qtype field Markus Armbruster
2017-06-09 13:46 ` [Qemu-devel] [PULL 02/41] object: fix potential leak in getters Markus Armbruster
2017-06-09 13:46 ` [Qemu-devel] [PULL 03/41] tests: Remove test cases for alternates of 'number' and 'int' Markus Armbruster
2017-06-09 13:46 ` [Qemu-devel] [PULL 04/41] tests: add more int/number ranges checks Markus Armbruster
2017-06-09 13:46 ` [Qemu-devel] [PULL 05/41] qapi: Clean up qobject_input_type_number() control flow Markus Armbruster
2017-06-09 13:46 ` [Qemu-devel] [PULL 06/41] qapi: merge QInt and QFloat in QNum Markus Armbruster
2017-06-09 13:46 ` [Qemu-devel] [PULL 07/41] qapi: Remove visit_start_alternate() parameter promote_int Markus Armbruster
2017-06-09 13:46 ` [Qemu-devel] [PULL 08/41] tests: remove /{qnum, qlist, dict}/destroy test Markus Armbruster
2017-06-09 13:46 ` [Qemu-devel] [PULL 09/41] qnum: add uint type Markus Armbruster
2017-06-09 13:46 ` [Qemu-devel] [PULL 10/41] json: learn to parse uint64 numbers Markus Armbruster
2017-06-09 13:46 ` [Qemu-devel] [PULL 11/41] qapi: update the qobject visitor to use QNUM_U64 Markus Armbruster
2017-06-09 13:46 ` [Qemu-devel] [PULL 12/41] object: add uint property setter/getter Markus Armbruster
2017-06-09 13:46 ` [Qemu-devel] [PULL 13/41] q35: fix get_mmcfg_size to use uint64 visitor Markus Armbruster
2017-06-09 13:46 ` [Qemu-devel] [PULL 14/41] object: use more specific property type names Markus Armbruster
2017-06-09 13:46 ` [Qemu-devel] [PULL 15/41] qdev: Rename DEFINE_PROP_DEFAULT() to DEFINE_PROP_SIGNED() Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 16/41] qdev: wrap default property value in an union Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 17/41] qdev: avoid type casts between signed and unsigned Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 18/41] apic-common: make "id" property a uint32 Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 19/41] qdev: Use appropriate getter/setters type Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 20/41] isa: use get_uint() for "io-base" Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 21/41] pc-dimm: use get_uint() for dimm properties Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 22/41] pc-dimm: make "size" property uint64 Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 23/41] pcihp: use get_uint() for "bsel" property Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 24/41] aspeed: use {set, get}_uint() for "ram-size" property Markus Armbruster
2017-06-09 13:47 ` Markus Armbruster [this message]
2017-06-09 13:47 ` [Qemu-devel] [PULL 26/41] platform-bus: use get_uint() for "addr" property Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 27/41] acpi: use get_uint() for "acpi-pcihp-io*" properties Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 28/41] acpi: use get_uint() for various acpi properties Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 29/41] acpi: use get_uint() for "pci-hole*" properties Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 30/41] pc: use get_uint() for "iobase" property Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 31/41] pc: use get_uint() for "apic-id" property Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 32/41] pc: use get_uint() for "hpet-intcap" property Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 33/41] xen: use get_uint() for "max-ram-below-4g" property Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 34/41] arm: use get_uint() for "mp-affinity" property Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 35/41] auxbus: use get_uint() for "addr" property Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 36/41] pvpanic: use get_uint() for "ioport" property Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 37/41] pnv-core: use get_uint() for "core-pir" property Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 38/41] numa: use get_uint() for "size" property Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 39/41] i386/cpu: use get_uint() for "min-level"/"min-xlevel" properties Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 40/41] console: use get_uint() for "head" property Markus Armbruster
2017-06-09 13:47 ` [Qemu-devel] [PULL 41/41] tests/qdict: check more get_try_int() cases Markus Armbruster
2017-06-09 15:05 ` [Qemu-devel] [PULL 00/41] QAPI patches for 2017-06-09 no-reply
2017-06-09 15:38 ` no-reply
2017-06-12 10:39 ` Peter Maydell
2017-06-12 10:52 ` Marc-André Lureau
2017-06-12 11:50 ` Peter Maydell
2017-06-20 11:59 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497016045-6009-26-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).