From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54661) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dKKdo-000159-OU for qemu-devel@nongnu.org; Mon, 12 Jun 2017 04:24:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dKKdk-0006V3-Qi for qemu-devel@nongnu.org; Mon, 12 Jun 2017 04:24:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48072) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dKKdk-0006Uh-Ls for qemu-devel@nongnu.org; Mon, 12 Jun 2017 04:24:00 -0400 Message-ID: <1497255838.6334.6.camel@redhat.com> From: Gerd Hoffmann Date: Mon, 12 Jun 2017 10:23:58 +0200 In-Reply-To: References: <20170606110459.9771-1-kraxel@redhat.com> <20170606110459.9771-4-kraxel@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 3/4] sdl2: use framebuffer helper functions. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Marc-Andr=E9?= Lureau , qemu-devel@nongnu.org Hi, > It's a bit weird to have win_fb used without being really > initialized. >=20 > Furthermore, there doesn't seem to be guarantee that > glGenFramebuffers(1, &fb->framebuffer) will make only non-0 values. 0 is reserved for the default framebuffer of the current context, i.e. the sdl window in this case. cheers, Gerd