From: Gerd Hoffmann <kraxel@redhat.com>
To: Li Qiang <liq3ea@gmail.com>, qemu-devel@nongnu.org
Cc: liqiang6-s@360.cn, ppandit@redhat.com
Subject: Re: [Qemu-devel] [PATCH] usb: xhci: fix info leak when writing event to the guest
Date: Wed, 14 Jun 2017 08:30:05 +0200 [thread overview]
Message-ID: <1497421805.11748.3.camel@redhat.com> (raw)
In-Reply-To: <1497411544-80213-1-git-send-email-liqiang6-s@360.cn>
On Tue, 2017-06-13 at 20:39 -0700, Li Qiang wrote:
> From: Li Qiang <liq3ea@gmail.com>
>
> In 'xhci_write_event' function, the 'ev_trb' is not full initialized.
> This will lead an info leak issue. This patch avoid this.
I don't think so. Note that only the first 16 bytes (TRB_SIZE) and not
the whole struct is copied to guest memory.
cheers,
Gerd
next prev parent reply other threads:[~2017-06-14 6:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 3:39 [Qemu-devel] [PATCH] usb: xhci: fix info leak when writing event to the guest Li Qiang
2017-06-14 3:47 ` no-reply
2017-06-14 4:20 ` Li Qiang
2017-06-14 6:23 ` Gerd Hoffmann
2017-06-14 11:16 ` Juan Quintela
2017-06-14 6:30 ` Gerd Hoffmann [this message]
2017-06-14 6:36 ` Li Qiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497421805.11748.3.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=liq3ea@gmail.com \
--cc=liqiang6-s@360.cn \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).