From: "Gabriel L. Somlo" <gsomlo@gmail.com>
To: qemu-devel@nongnu.org
Cc: agraf@suse.de, pbonzini@redhat.com, f4bug@amsat.org, eshelton@pobox.com
Subject: [Qemu-devel] [PATCH v3 0/3] Update AppleSMC for OS X 10.12.4+ guests
Date: Fri, 16 Jun 2017 14:55:13 -0400 [thread overview]
Message-ID: <1497639316-22202-1-git-send-email-gsomlo@gmail.com> (raw)
As of 10.12.4, OS X refuses to boot unless the AppleSMC supports a
third I/O port, which provides the current error status when read.
New since v2:
- updated "reviewd-by" fields
- ping ?
>New since v1:
>
> - 1/3: don't touch the default OSK string, as it's unnecessary
> at this time
>
> - 2/3: don't consolidate I/O regions, leave as-is for data
> and cmd; This patch now implements the error-code state
> machine, AND adds an i/o region dedicaded to the error
> status port, complete with read/write access methods.
>
> - 3/3: set access width to 1-byte on data and cmd i/o regions.
> Tested on OS X versions 10.[6..12].
>
>> This series consists of three patches:
>>
>> - 1/3: indentation/whitespace cleanup for applesmc.c to the point
>> where it now passes scripts/checkpatc.pl, and allows
>> subsequent changes to look nice in diff-patch format :)
>>
>> - 2/3: consolidate Port I/O into a single region, and invoke
>> appropriate read/write methods based on the offset being
>> accessed
>>
>> - 3/3: implement read-only error/status port, and update
>> data and command read/write methods to correctly
>> maintain the state machine for keeping the status_1e
>> value up to date.
Gabriel L. Somlo (3):
applesmc: cosmetic whitespace and indentation cleanup
applesmc: implement error status port
applesmc: fix port i/o access width
hw/misc/applesmc.c | 219 +++++++++++++++++++++++++++++++++++++----------------
1 file changed, 155 insertions(+), 64 deletions(-)
--
2.7.4
next reply other threads:[~2017-06-16 18:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-16 18:55 Gabriel L. Somlo [this message]
2017-06-16 18:55 ` [Qemu-devel] [PATCH v3 1/3] applesmc: cosmetic whitespace and indentation cleanup Gabriel L. Somlo
2017-06-16 18:55 ` [Qemu-devel] [PATCH v3 2/3] applesmc: implement error status port Gabriel L. Somlo
2017-06-16 18:55 ` [Qemu-devel] [PATCH v3 3/3] applesmc: fix port i/o access width Gabriel L. Somlo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497639316-22202-1-git-send-email-gsomlo@gmail.com \
--to=gsomlo@gmail.com \
--cc=agraf@suse.de \
--cc=eshelton@pobox.com \
--cc=f4bug@amsat.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).