qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Pradeep Jagadeesh <pradeepkiruvale@gmail.com>
To: eric blake <eblake@redhat.com>, greg kurz <groug@kaod.org>
Cc: Pradeep Jagadeesh <pradeep.jagadeesh@huawei.com>,
	alberto garcia <berto@igalia.com>,
	jani kokkonen <jani.kokkonen@huawei.com>,
	qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v5 0/5] fsdev: qmp interface for io throttling
Date: Mon, 19 Jun 2017 09:11:31 -0400	[thread overview]
Message-ID: <1497877896-35700-1-git-send-email-pradeep.jagadeesh@huawei.com> (raw)

These patches provide the qmp interface, to query the io throttle 
status of the all fsdev devices that are present in a vm.
also, it provides an interface to set the io throttle parameters of a
fsdev to a required value. some of the patches also remove the duplicate
code that was present in block and fsdev files. 

Pradeep Jagadeesh (5):
  throttle: factor out duplicate code
  qmp: Create IOThrottle structure
  qmp: refactor duplicate code
  fsdev: hmp interface for throttling
  fsdev: QMP interface for throttling

 Makefile                        |   3 +
 blockdev.c                      |  97 ++-------------------------------
 fsdev/qemu-fsdev-dummy.c        |  10 ++++
 fsdev/qemu-fsdev-throttle.c     | 118 ++++++++++++++++++++++++++--------------
 fsdev/qemu-fsdev-throttle.h     |  13 +++++
 fsdev/qemu-fsdev.c              |  37 +++++++++++++
 hmp-commands-info.hx            |  18 ++++++
 hmp-commands.hx                 |  19 +++++++
 hmp.c                           |  87 +++++++++++++++++++++++++++--
 hmp.h                           |   4 ++
 include/qemu/throttle-options.h |   7 +++
 monitor.c                       |   5 ++
 qapi-schema.json                |   3 +
 qapi/block-core.json            |  76 +-------------------------
 qapi/fsdev.json                 |  84 ++++++++++++++++++++++++++++
 qapi/iothrottle.json            |  88 ++++++++++++++++++++++++++++++
 qmp.c                           |  15 +++++
 util/throttle.c                 | 110 +++++++++++++++++++++++++++++++++++++
 18 files changed, 580 insertions(+), 214 deletions(-)
 create mode 100644 qapi/fsdev.json
 create mode 100644 qapi/iothrottle.json

v0 -> v1:
 Addressed comments from Eric Blake, Greg Kurz and Daniel P.Berrange
 Mainly renaming the functions and removing the redundant code.

v1 -> v2:
 Addressed comments from Eric Blake and Greg Kurz.
 As per the suggestion I split the patches into smaller patches.
 Removed some more duplicate code.

v2 -> v3:
 Addresssed comments from Alberto Garcia.
 Changed the comment from block to iothrottle in the iothrottle.json 
 Added the dummy functions in qemu-fsdev-dummy.c to address the compilation
 issues that were observed.

v3 -> v4:
 Addressed comments from Eric Blake and Greg Kurz
 Re-ordered the patches
 Added the dummy functions in qmp.c to address the cross compilation issues

v4 -> v5:
 Addressed comments from Eric Blake and Greg Kurz
 Split the fsdev qmp patch into hmp and qmp related patches
 Moved the common functionalities to throttle.c instead of creating a new file

-- 
1.8.3.1

             reply	other threads:[~2017-06-19 13:12 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-19 13:11 Pradeep Jagadeesh [this message]
2017-06-19 13:11 ` [Qemu-devel] [PATCH v5 1/5] throttle: factor out duplicate code Pradeep Jagadeesh
2017-06-20 15:46   ` Greg Kurz
2017-06-21 12:55   ` Alberto Garcia
2017-06-21 13:43     ` Greg Kurz
2017-06-21 14:21       ` Alberto Garcia
2017-06-22 14:38   ` Markus Armbruster
2017-06-22 16:23     ` Greg Kurz
2017-06-29  9:50     ` Pradeep Jagadeesh
2017-06-19 13:11 ` [Qemu-devel] [PATCH v5 2/5] qmp: Create IOThrottle structure Pradeep Jagadeesh
2017-06-20 15:51   ` Greg Kurz
2017-06-19 13:11 ` [Qemu-devel] [PATCH v5 3/5] qmp: refactor duplicate code Pradeep Jagadeesh
2017-06-20 16:05   ` Greg Kurz
2017-06-21  8:34     ` Pradeep Jagadeesh
2017-06-21 10:00       ` Greg Kurz
2017-06-29 13:35         ` Pradeep Jagadeesh
2017-06-19 13:11 ` [Qemu-devel] [PATCH v5 4/5] fsdev: hmp interface for throttling Pradeep Jagadeesh
2017-06-19 13:11 ` [Qemu-devel] [PATCH v5 5/5] fsdev: QMP " Pradeep Jagadeesh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1497877896-35700-1-git-send-email-pradeep.jagadeesh@huawei.com \
    --to=pradeepkiruvale@gmail.com \
    --cc=berto@igalia.com \
    --cc=eblake@redhat.com \
    --cc=groug@kaod.org \
    --cc=jani.kokkonen@huawei.com \
    --cc=pradeep.jagadeesh@huawei.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).