qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: qemu-devel@nongnu.org
Cc: rth@twiddle.net, alistai@xilinx.com, sai.pavan.boddu@xilinx.com,
	edgar.iglesias@xilinx.com
Subject: [Qemu-devel] [PATCH v2 6/7] target-microblaze: dec_barrel: Add BSIFI
Date: Wed, 21 Jun 2017 14:59:14 +0200	[thread overview]
Message-ID: <1498049955-28646-7-git-send-email-edgar.iglesias@gmail.com> (raw)
In-Reply-To: <1498049955-28646-1-git-send-email-edgar.iglesias@gmail.com>

From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>

Add support for BSIFI.

Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
---
 target/microblaze/translate.c | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c
index 3fad13c..cb65d1e 100644
--- a/target/microblaze/translate.c
+++ b/target/microblaze/translate.c
@@ -661,7 +661,7 @@ static void dec_barrel(DisasContext *dc)
 {
     TCGv t0;
     unsigned int imm_w, imm_s;
-    bool s, t, e = false;
+    bool s, t, e = false, i = false;
 
     if ((dc->tb_flags & MSR_EE_FLAG)
           && (dc->cpu->env.pvr.regs[2] & PVR2_ILL_OPCODE_EXC_MASK)
@@ -673,6 +673,7 @@ static void dec_barrel(DisasContext *dc)
 
     if (dc->type_b) {
         /* Insert and extract are only available in immediate mode.  */
+        i = extract32(dc->imm, 15, 1);
         e = extract32(dc->imm, 14, 1);
     }
     s = extract32(dc->imm, 10, 1);
@@ -692,6 +693,17 @@ static void dec_barrel(DisasContext *dc)
         } else {
             tcg_gen_extract_i32(cpu_R[dc->rd], cpu_R[dc->ra], imm_s, imm_w);
         }
+    } else if (i) {
+        int width = imm_w - imm_s + 1;
+
+        if (imm_w < imm_s) {
+            /* These inputs have an undefined behavior.  */
+            qemu_log_mask(LOG_GUEST_ERROR, "bsifi: Bad input w=%d s=%d\n",
+                          imm_w, imm_s);
+        } else {
+            tcg_gen_deposit_i32(cpu_R[dc->rd], cpu_R[dc->rd], cpu_R[dc->ra],
+                                imm_s, width);
+        }
     } else {
         t0 = tcg_temp_new();
 
-- 
2.7.4

  parent reply	other threads:[~2017-06-21 12:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-21 12:59 [Qemu-devel] [PATCH v2 0/7] target-microblaze: Add support for BSXFI Edgar E. Iglesias
2017-06-21 12:59 ` [Qemu-devel] [PATCH v2 1/7] target-microblaze: dec_barrel: Use bool instead of unsigned int Edgar E. Iglesias
2017-06-21 12:59 ` [Qemu-devel] [PATCH v2 2/7] target-microblaze: dec_barrel: Use extract32 Edgar E. Iglesias
2017-06-21 12:59 ` [Qemu-devel] [PATCH v2 3/7] target-microblaze: dec_barrel: Add braces around if-statements Edgar E. Iglesias
2017-06-21 12:59 ` [Qemu-devel] [PATCH v2 4/7] target-microblaze: dec_barrel: Plug TCG temp leak Edgar E. Iglesias
2017-06-21 12:59 ` [Qemu-devel] [PATCH v2 5/7] target-microblaze: dec_barrel: Add BSEFI Edgar E. Iglesias
2017-06-21 12:59 ` Edgar E. Iglesias [this message]
2017-06-21 14:00   ` [Qemu-devel] [PATCH v2 6/7] target-microblaze: dec_barrel: Add BSIFI Richard Henderson
2017-06-21 12:59 ` [Qemu-devel] [PATCH v2 7/7] target-microblaze: Add CPU version 10.0 Edgar E. Iglesias

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1498049955-28646-7-git-send-email-edgar.iglesias@gmail.com \
    --to=edgar.iglesias@gmail.com \
    --cc=alistai@xilinx.com \
    --cc=edgar.iglesias@xilinx.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=sai.pavan.boddu@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).