From: Gerd Hoffmann <kraxel@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
"Fam Zheng" <famz@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [RFC PATCH v2 21/21] ui/vnc: silent unuseful OSX clang warning
Date: Thu, 22 Jun 2017 09:33:20 +0200 [thread overview]
Message-ID: <1498116800.25651.3.camel@redhat.com> (raw)
In-Reply-To: <20170622033231.19344-22-f4bug@amsat.org>
diff --git a/ui/Makefile.objs b/ui/Makefile.objs
> index 3369451285..08fb573a48 100644
> --- a/ui/Makefile.objs
> +++ b/ui/Makefile.objs
> @@ -6,6 +6,14 @@ vnc-obj-y += vnc-auth-vencrypt.o
> vnc-obj-$(CONFIG_VNC_SASL) += vnc-auth-sasl.o
> vnc-obj-y += vnc-ws.o
> vnc-obj-y += vnc-jobs.o
> +ifeq ($(CONFIG_VNC_SASL),y)
> +# silent OSX SASL warnings (from https://stackoverflow.com/a/7406994
> ):
> +# because OpenSSL doesn’t offer API compatibility between versions,
> [...] Apple
> +# can't provide security updates without breaking existing apps, so
> is migrating
> +# from OpenSSL to Common Crypto.
> +vnc.o-cflags := -Wno-deprecated-declarations
> +vnc-auth-sasl.o-cflags := -Wno-deprecated-declarations
> +endif
Hmm, does clang understand "#pragma GCC diagnostic" ?
If so, then this can be done in in the code not the makefiles, and also
selectively for osx only.
See include/ui/gtk.h for an example.
cheers,
Gerd
next prev parent reply other threads:[~2017-06-22 7:33 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-22 3:32 [Qemu-devel] [PATCH v2 00/21] travis: speedup to reduce failures Philippe Mathieu-Daudé
2017-06-22 3:32 ` [Qemu-devel] [PATCH v2 01/21] tests: add missing dependency to build QTEST_QEMU_BINARY Philippe Mathieu-Daudé
2017-06-22 9:55 ` Alex Bennée
2017-06-23 18:43 ` Philippe Mathieu-Daudé
2017-06-22 13:00 ` Stefan Hajnoczi
2017-06-23 19:27 ` John Snow
2017-06-22 3:32 ` [Qemu-devel] [PATCH v2 02/21] travis: retry if llvm.org timeouts Philippe Mathieu-Daudé
2017-06-22 3:32 ` [Qemu-devel] [PATCH v2 03/21] travis: install more library dependencies Philippe Mathieu-Daudé
2017-06-22 3:32 ` [Qemu-devel] [PATCH v2 04/21] " Philippe Mathieu-Daudé
2017-06-22 3:32 ` [Qemu-devel] [PATCH v2 05/21] scripts/run-coverity-scan: Script to run Coverity Scan build Philippe Mathieu-Daudé
2017-06-22 3:32 ` [Qemu-devel] [PATCH v2 06/21] travis: Add config to do a Coverity Scan upload Philippe Mathieu-Daudé
2017-06-22 9:56 ` Alex Bennée
2017-06-23 13:32 ` Philippe Mathieu-Daudé
2017-06-22 3:32 ` [Qemu-devel] [PATCH v2 07/21] travis: update sudo-enabled Trusty images Philippe Mathieu-Daudé
2017-06-22 9:58 ` Alex Bennée
2017-06-23 13:35 ` Philippe Mathieu-Daudé
2017-06-22 3:32 ` [Qemu-devel] [PATCH v2 08/21] travis: use gcc-6 sanitizers Philippe Mathieu-Daudé
2017-06-22 3:32 ` [Qemu-devel] [PATCH v2 09/21] travis: enable multiple caching features Philippe Mathieu-Daudé
2017-06-22 10:16 ` Alex Bennée
2017-06-22 3:32 ` [Qemu-devel] [PATCH v2 10/21] travis: increase S3 cache timeout Philippe Mathieu-Daudé
2017-06-22 10:17 ` Alex Bennée
2017-06-22 3:32 ` [Qemu-devel] [PATCH v2 11/21] travis: cache git submodules Philippe Mathieu-Daudé
2017-06-22 10:17 ` Alex Bennée
2017-06-22 13:51 ` Alex Bennée
2017-06-22 3:32 ` [Qemu-devel] [PATCH v2 12/21] travis: build using all available cores Philippe Mathieu-Daudé
2017-06-22 10:21 ` Alex Bennée
2017-06-22 3:32 ` [Qemu-devel] [PATCH v2 13/21] travis: improve ccache use Philippe Mathieu-Daudé
2017-06-22 10:22 ` Alex Bennée
2017-06-23 13:41 ` Philippe Mathieu-Daudé
2017-06-22 10:57 ` Paolo Bonzini
2017-06-22 3:32 ` [Qemu-devel] [PATCH v2 14/21] travis: dump config.log if ./configure script fails Philippe Mathieu-Daudé
2017-06-22 10:23 ` Alex Bennée
2017-06-23 13:45 ` Philippe Mathieu-Daudé
2017-06-22 3:32 ` [Qemu-devel] [PATCH v2 15/21] travis: retry when git submodules initialization fails Philippe Mathieu-Daudé
2017-06-22 10:24 ` Alex Bennée
2017-06-22 3:32 ` [Qemu-devel] [PATCH v2 16/21] travis: split the gprof/gcov job Philippe Mathieu-Daudé
2017-06-22 10:24 ` Alex Bennée
2017-06-22 3:32 ` [Qemu-devel] [PATCH v2 17/21] travis/osx: don't update Homebrew cache Philippe Mathieu-Daudé
2017-06-22 3:32 ` [Qemu-devel] [PATCH v2 18/21] travis/osx: silent texinfo warnings Philippe Mathieu-Daudé
2017-06-22 3:32 ` [Qemu-devel] [PATCH v2 19/21] travis/osx: build using more Xcode versions Philippe Mathieu-Daudé
2017-06-22 3:32 ` [Qemu-devel] [PATCH v2 20/21] MAINTAINERS: self-appoint me as reviewer in build/test automation Philippe Mathieu-Daudé
2017-06-22 3:32 ` [Qemu-devel] [RFC PATCH v2 21/21] ui/vnc: silent unuseful OSX clang warning Philippe Mathieu-Daudé
2017-06-22 7:28 ` Peter Maydell
2017-06-22 7:33 ` Gerd Hoffmann [this message]
2017-06-22 7:35 ` Peter Maydell
2017-06-22 13:50 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1498116800.25651.3.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=f4bug@amsat.org \
--cc=famz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).