From: Greg Kurz <groug@kaod.org>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Greg Kurz" <groug@kaod.org>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [Qemu-devel] [PULL 3/8] 9pfs: replace g_malloc()+memcpy() with g_memdup()
Date: Thu, 29 Jun 2017 15:43:46 +0200 [thread overview]
Message-ID: <1498743831-28676-4-git-send-email-groug@kaod.org> (raw)
In-Reply-To: <1498743831-28676-1-git-send-email-groug@kaod.org>
From: Marc-André Lureau <marcandre.lureau@redhat.com>
I found these pattern via grepping the source tree. I don't have a
coccinelle script for it!
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
hw/9pfs/9p-synth.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/9pfs/9p-synth.c b/hw/9pfs/9p-synth.c
index 4b6d4e6a3f1c..df0a8de08aed 100644
--- a/hw/9pfs/9p-synth.c
+++ b/hw/9pfs/9p-synth.c
@@ -494,8 +494,7 @@ static int synth_name_to_path(FsContext *ctx, V9fsPath *dir_path,
}
out:
/* Copy the node pointer to fid */
- target->data = g_malloc(sizeof(void *));
- memcpy(target->data, &node, sizeof(void *));
+ target->data = g_memdup(&node, sizeof(void *));
target->size = sizeof(void *);
return 0;
}
--
2.7.5
next prev parent reply other threads:[~2017-06-29 13:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 13:43 [Qemu-devel] [PULL 0/8] 9pfs patches for 2.10 20170629 Greg Kurz
2017-06-29 13:43 ` [Qemu-devel] [PULL 1/8] 9pfs: local: remove: use correct path component Greg Kurz
2017-06-29 13:43 ` [Qemu-devel] [PULL 2/8] 9pfs: local: Add support for custom fmode/dmode in 9ps mapped security modes Greg Kurz
2017-06-29 13:43 ` Greg Kurz [this message]
2017-06-29 13:43 ` [Qemu-devel] [PULL 4/8] virtio-9p: record element after sanity checks Greg Kurz
2017-06-29 13:43 ` [Qemu-devel] [PULL 5/8] virtio-9p: message header is 7-byte long Greg Kurz
2017-06-29 13:43 ` [Qemu-devel] [PULL 6/8] virtio-9p: break device if buffers are misconfigured Greg Kurz
2017-06-29 13:43 ` [Qemu-devel] [PULL 7/8] xen-9pfs: disconnect " Greg Kurz
2017-06-29 13:43 ` [Qemu-devel] [PULL 8/8] 9pfs: handle transport errors in pdu_complete() Greg Kurz
2017-06-29 16:00 ` [Qemu-devel] [PULL 0/8] 9pfs patches for 2.10 20170629 Peter Maydell
2017-06-29 16:59 ` Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1498743831-28676-4-git-send-email-groug@kaod.org \
--to=groug@kaod.org \
--cc=marcandre.lureau@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).