From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52615) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dRrLc-000757-7G for qemu-devel@nongnu.org; Sun, 02 Jul 2017 22:44:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dRrLb-0006qL-FB for qemu-devel@nongnu.org; Sun, 02 Jul 2017 22:44:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42120) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dRrLa-0006pk-U1 for qemu-devel@nongnu.org; Sun, 02 Jul 2017 22:44:23 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 01DE880E72 for ; Mon, 3 Jul 2017 02:44:22 +0000 (UTC) From: Peter Xu Date: Mon, 3 Jul 2017 10:44:08 +0800 Message-Id: <1499049848-18012-5-git-send-email-peterx@redhat.com> In-Reply-To: <1499049848-18012-1-git-send-email-peterx@redhat.com> References: <1499049848-18012-1-git-send-email-peterx@redhat.com> Subject: [Qemu-devel] [PATCH 4/4] doc: update TYPE_MIGRATION documents List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Eduardo Habkost , Laurent Vivier , Juan Quintela , "Dr . David Alan Gilbert" , peterx@redhat.com [Peter collected Eduardo's patch comment and formatted into patch] Suggested-by: Eduardo Habkost Signed-off-by: Peter Xu --- migration/migration.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index dbdc121..6c64b99 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -2052,12 +2052,15 @@ static void migration_instance_init(Object *obj) static const TypeInfo migration_type = { .name = TYPE_MIGRATION, /* - * NOTE: "migration" itself is not really a device. We used - * TYPE_DEVICE here only to leverage some existing QDev features - * like "-global" properties, and HW_COMPAT_* fields (which are - * finally applied as global properties as well). If one day the - * global property feature can be migrated from QDev to QObject in - * general, then we can switch to QObject as well. + * NOTE: + * + * TYPE_MIGRATION is not really a device, as the object is not + * created using qdev_create(), it is not attached to the qdev + * device tree, and it is never realized. + * + * If one day we allow non-device QOM objects to use the global + * property system, we can switch this from TYPE_DEVICE to + * TYPE_OBJECT. */ .parent = TYPE_DEVICE, .class_init = migration_class_init, -- 2.7.4