qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: rth@twiddle.net, thuth@redhat.com, anthony.xu@intel.com,
	berrange@redhat.com, a.rigo@virtualopensystems.com,
	yang.zhong@intel.com
Subject: [Qemu-devel] [PATCH 13/22] exec: elide calls to tb_lock and tb_unlock
Date: Mon,  3 Jul 2017 18:34:44 +0200	[thread overview]
Message-ID: <1499099693-22903-14-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1499099693-22903-1-git-send-email-pbonzini@redhat.com>

Adding assertions fixes link errors.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 exec.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/exec.c b/exec.c
index ee61915..a083ff8 100644
--- a/exec.c
+++ b/exec.c
@@ -2317,6 +2317,7 @@ static void notdirty_mem_write(void *opaque, hwaddr ram_addr,
 {
     bool locked = false;
 
+    assert(tcg_enabled());
     if (!cpu_physical_memory_get_dirty_flag(ram_addr, DIRTY_MEMORY_CODE)) {
         locked = true;
         tb_lock();
@@ -2375,6 +2376,7 @@ static void check_watchpoint(int offset, int len, MemTxAttrs attrs, int flags)
     CPUWatchpoint *wp;
     uint32_t cpu_flags;
 
+    assert(tcg_enabled());
     if (cpu->watchpoint_hit) {
         /* We re-entered the check after replacing the TB. Now raise
          * the debug interrupt so that is will trigger after the
@@ -2820,6 +2822,7 @@ static void invalidate_and_set_dirty(MemoryRegion *mr, hwaddr addr,
             cpu_physical_memory_range_includes_clean(addr, length, dirty_log_mask);
     }
     if (dirty_log_mask & (1 << DIRTY_MEMORY_CODE)) {
+        assert(tcg_enabled());
         tb_lock();
         tb_invalidate_phys_range(addr, addr + length);
         tb_unlock();
-- 
1.8.3.1

  parent reply	other threads:[~2017-07-03 16:36 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-03 16:34 [Qemu-devel] [PATCH v3 00/22] add disable-tcg option for x86 build Paolo Bonzini
2017-07-03 16:34 ` [Qemu-devel] [PATCH 01/22] configure: factor out list of supported Xen/KVM/HAX targets Paolo Bonzini
2017-07-03 19:30   ` Richard Henderson
2017-07-04  8:28   ` Daniel P. Berrange
2017-07-04  9:44     ` Paolo Bonzini
2017-07-04  9:50       ` Daniel P. Berrange
2017-07-03 16:34 ` [Qemu-devel] [PATCH 02/22] configure: early test for supported targets Paolo Bonzini
2017-07-03 19:32   ` Richard Henderson
2017-07-04  8:32   ` Daniel P. Berrange
2017-07-04 11:08     ` Paolo Bonzini
2017-07-03 16:34 ` [Qemu-devel] [PATCH 03/22] configure: add --disable-tcg configure option Paolo Bonzini
2017-07-03 19:37   ` Richard Henderson
2017-07-04  8:33   ` Daniel P. Berrange
2017-07-03 16:34 ` [Qemu-devel] [PATCH 04/22] vl: convert -tb-size to qemu_strtoul Paolo Bonzini
2017-07-03 19:46   ` Richard Henderson
2017-07-04  9:33     ` Paolo Bonzini
2017-07-04  9:37     ` Daniel P. Berrange
2017-07-03 16:34 ` [Qemu-devel] [PATCH 05/22] vl: add tcg_enabled() for tcg related code Paolo Bonzini
2017-07-03 19:46   ` Richard Henderson
2017-07-03 16:34 ` [Qemu-devel] [PATCH 06/22] tcg: move page_size_init() function Paolo Bonzini
2017-07-03 19:58   ` Richard Henderson
2017-07-03 16:34 ` [Qemu-devel] [PATCH 07/22] tcg: tcg_handle_interrupt() function Paolo Bonzini
2017-07-03 19:59   ` Richard Henderson
2017-07-03 16:34 ` [Qemu-devel] [PATCH 08/22] tcg: make tcg_allowed global Paolo Bonzini
2017-07-03 20:01   ` Richard Henderson
2017-07-03 16:34 ` [Qemu-devel] [PATCH 09/22] monitor: disable "info jit" and "info opcount" if !TCG Paolo Bonzini
2017-07-03 20:02   ` Richard Henderson
2017-07-03 16:34 ` [Qemu-devel] [PATCH 10/22] vapic: use tcg_enabled Paolo Bonzini
2017-07-03 20:02   ` Richard Henderson
2017-07-03 16:34 ` [Qemu-devel] [PATCH 11/22] tcg: add the tcg-stub.c file into accel/stubs/ Paolo Bonzini
2017-07-03 20:03   ` Richard Henderson
2017-07-03 16:34 ` [Qemu-devel] [PATCH 12/22] tcg: move tb_lock out of translate-all.h Paolo Bonzini
2017-07-03 20:04   ` Richard Henderson
2017-07-03 16:34 ` Paolo Bonzini [this message]
2017-07-03 20:07   ` [Qemu-devel] [PATCH 13/22] exec: elide calls to tb_lock and tb_unlock Richard Henderson
2017-07-03 16:34 ` [Qemu-devel] [PATCH 14/22] tcg: add CONFIG_TCG guards in headers Paolo Bonzini
2017-07-03 20:10   ` Richard Henderson
2017-07-04  9:35     ` Paolo Bonzini
2017-07-03 16:34 ` [Qemu-devel] [PATCH 15/22] tcg: add the CONFIG_TCG into Makefiles Paolo Bonzini
2017-07-03 20:10   ` Richard Henderson
2017-07-03 16:34 ` [Qemu-devel] [PATCH 16/22] target/i386: move cpu_sync_bndcs_hflags() function Paolo Bonzini
2017-07-03 20:11   ` Richard Henderson
2017-07-03 16:34 ` [Qemu-devel] [PATCH 17/22] target/i386: make cpu_get_fp80()/cpu_set_fp80() static Paolo Bonzini
2017-07-03 20:12   ` Richard Henderson
2017-07-03 16:34 ` [Qemu-devel] [PATCH 18/22] target/i386: split cpu_set_mxcsr() and make cpu_set_fpuc() inline Paolo Bonzini
2017-07-03 20:14   ` Richard Henderson
2017-07-04  9:41     ` Paolo Bonzini
2017-07-03 16:34 ` [Qemu-devel] [PATCH 19/22] target/i386: move TLB refill function out of helper.c Paolo Bonzini
2017-07-03 20:15   ` Richard Henderson
2017-07-03 16:34 ` [Qemu-devel] [PATCH 20/22] target/i386: add the tcg_enabled() in target/i386/ Paolo Bonzini
2017-07-03 20:19   ` Richard Henderson
2017-07-04  9:58     ` Paolo Bonzini
2017-07-03 16:34 ` [Qemu-devel] [PATCH 21/22] target/i386: add the CONFIG_TCG into Makefiles Paolo Bonzini
2017-07-03 20:20   ` Richard Henderson
2017-07-03 16:34 ` [Qemu-devel] [PATCH 22/22] configure: warn on untested --disable-tcg Paolo Bonzini
2017-07-03 20:21   ` Richard Henderson
2017-07-04  8:33   ` Daniel P. Berrange
  -- strict thread matches above, loose matches on Subject: below --
2017-07-04 11:11 [Qemu-devel] [PATCH v4 00/22] add disable-tcg option for x86 build Paolo Bonzini
2017-07-04 11:12 ` [Qemu-devel] [PATCH 13/22] exec: elide calls to tb_lock and tb_unlock Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1499099693-22903-14-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=a.rigo@virtualopensystems.com \
    --cc=anthony.xu@intel.com \
    --cc=berrange@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=thuth@redhat.com \
    --cc=yang.zhong@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).