From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: rth@twiddle.net, thuth@redhat.com, anthony.xu@intel.com,
berrange@redhat.com, a.rigo@virtualopensystems.com,
yang.zhong@intel.com
Subject: [Qemu-devel] [PATCH 20/22] target/i386: add the tcg_enabled() in target/i386/
Date: Mon, 3 Jul 2017 18:34:51 +0200 [thread overview]
Message-ID: <1499099693-22903-21-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1499099693-22903-1-git-send-email-pbonzini@redhat.com>
From: Yang Zhong <yang.zhong@intel.com>
Add the tcg_enabled() where the x86 target needs to disable
TCG-specific code.
Signed-off-by: Yang Zhong <yang.zhong@intel.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
target/i386/bpt_helper.c | 32 +++++++++++++++++++++++---------
target/i386/cpu.c | 4 +++-
target/i386/cpu.h | 8 +++++++-
target/i386/machine.c | 5 +++--
4 files changed, 36 insertions(+), 13 deletions(-)
diff --git a/target/i386/bpt_helper.c b/target/i386/bpt_helper.c
index b3efdc7..e0fa54c 100644
--- a/target/i386/bpt_helper.c
+++ b/target/i386/bpt_helper.c
@@ -215,10 +215,12 @@ void breakpoint_handler(CPUState *cs)
if (cs->watchpoint_hit) {
if (cs->watchpoint_hit->flags & BP_CPU) {
cs->watchpoint_hit = NULL;
- if (check_hw_breakpoints(env, false)) {
- raise_exception(env, EXCP01_DB);
- } else {
- cpu_loop_exit_noexc(cs);
+ if (tcg_enabled()) {
+ if (check_hw_breakpoints(env, false)) {
+ raise_exception(env, EXCP01_DB);
+ } else {
+ cpu_loop_exit_noexc(cs);
+ }
}
}
} else {
@@ -226,7 +228,9 @@ void breakpoint_handler(CPUState *cs)
if (bp->pc == env->eip) {
if (bp->flags & BP_CPU) {
check_hw_breakpoints(env, true);
- raise_exception(env, EXCP01_DB);
+ if (tcg_enabled()) {
+ raise_exception(env, EXCP01_DB);
+ }
}
break;
}
@@ -241,7 +245,9 @@ void helper_single_step(CPUX86State *env)
check_hw_breakpoints(env, true);
env->dr[6] |= DR6_BS;
#endif
- raise_exception(env, EXCP01_DB);
+ if (tcg_enabled()) {
+ raise_exception(env, EXCP01_DB);
+ }
}
void helper_rechecking_single_step(CPUX86State *env)
@@ -282,7 +288,9 @@ void helper_set_dr(CPUX86State *env, int reg, target_ulong t0)
cpu_x86_update_dr7(env, t0);
return;
}
- raise_exception_err_ra(env, EXCP06_ILLOP, 0, GETPC());
+ if (tcg_enabled()) {
+ raise_exception_err_ra(env, EXCP06_ILLOP, 0, GETPC());
+ }
#endif
}
@@ -304,7 +312,11 @@ target_ulong helper_get_dr(CPUX86State *env, int reg)
return env->dr[7];
}
}
- raise_exception_err_ra(env, EXCP06_ILLOP, 0, GETPC());
+ if (tcg_enabled()) {
+ raise_exception_err_ra(env, EXCP06_ILLOP, 0, GETPC());
+ } else {
+ return 0;
+ }
}
/* Check if Port I/O is trapped by a breakpoint. */
@@ -329,7 +341,9 @@ void helper_bpt_io(CPUX86State *env, uint32_t port,
if (hit) {
env->dr[6] = (env->dr[6] & ~0xf) | hit;
env->eip = next_eip;
- raise_exception(env, EXCP01_DB);
+ if (tcg_enabled()) {
+ raise_exception(env, EXCP01_DB);
+ }
}
#endif
}
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 642519a..c571772 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -4040,8 +4040,10 @@ static void x86_cpu_common_class_init(ObjectClass *oc, void *data)
cc->class_by_name = x86_cpu_class_by_name;
cc->parse_features = x86_cpu_parse_featurestr;
cc->has_work = x86_cpu_has_work;
+#ifdef CONFIG_TCG
cc->do_interrupt = x86_cpu_do_interrupt;
cc->cpu_exec_interrupt = x86_cpu_exec_interrupt;
+#endif
cc->dump_state = x86_cpu_dump_state;
cc->get_crash_info = x86_cpu_get_crash_info;
cc->set_pc = x86_cpu_set_pc;
@@ -4070,7 +4072,7 @@ static void x86_cpu_common_class_init(ObjectClass *oc, void *data)
cc->gdb_core_xml_file = "i386-32bit.xml";
cc->gdb_num_core_regs = 41;
#endif
-#ifndef CONFIG_USER_ONLY
+#if defined(CONFIG_TCG) && !defined(CONFIG_USER_ONLY)
cc->debug_excp_handler = breakpoint_handler;
#endif
cc->cpu_exec_enter = x86_cpu_exec_enter;
diff --git a/target/i386/cpu.h b/target/i386/cpu.h
index 67a6091..27732ad 100644
--- a/target/i386/cpu.h
+++ b/target/i386/cpu.h
@@ -52,7 +52,9 @@
#include "exec/cpu-defs.h"
+#ifdef CONFIG_TCG
#include "fpu/softfloat.h"
+#endif
#define R_EAX 0
#define R_ECX 1
@@ -1598,7 +1600,11 @@ void update_fp_status(CPUX86State *env);
static inline uint32_t cpu_compute_eflags(CPUX86State *env)
{
- return env->eflags | cpu_cc_compute_all(env, CC_OP) | (env->df & DF_MASK);
+ uint32_t eflags = env->eflags;
+ if (tcg_enabled()) {
+ eflags |= cpu_cc_compute_all(env, CC_OP) | (env->df & DF_MASK);
+ }
+ return eflags;
}
/* NOTE: the translator must set DisasContext.cc_op to CC_OP_EFLAGS
diff --git a/target/i386/machine.c b/target/i386/machine.c
index 53587ae..b78b36c 100644
--- a/target/i386/machine.c
+++ b/target/i386/machine.c
@@ -280,8 +280,9 @@ static int cpu_post_load(void *opaque, int version_id)
for(i = 0; i < 8; i++) {
env->fptags[i] = (env->fptag_vmstate >> i) & 1;
}
- update_fp_status(env);
-
+ if (tcg_enabled()) {
+ update_fp_status(env);
+ }
cpu_breakpoint_remove_all(cs, BP_CPU);
cpu_watchpoint_remove_all(cs, BP_CPU);
{
--
1.8.3.1
next prev parent reply other threads:[~2017-07-03 16:36 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-03 16:34 [Qemu-devel] [PATCH v3 00/22] add disable-tcg option for x86 build Paolo Bonzini
2017-07-03 16:34 ` [Qemu-devel] [PATCH 01/22] configure: factor out list of supported Xen/KVM/HAX targets Paolo Bonzini
2017-07-03 19:30 ` Richard Henderson
2017-07-04 8:28 ` Daniel P. Berrange
2017-07-04 9:44 ` Paolo Bonzini
2017-07-04 9:50 ` Daniel P. Berrange
2017-07-03 16:34 ` [Qemu-devel] [PATCH 02/22] configure: early test for supported targets Paolo Bonzini
2017-07-03 19:32 ` Richard Henderson
2017-07-04 8:32 ` Daniel P. Berrange
2017-07-04 11:08 ` Paolo Bonzini
2017-07-03 16:34 ` [Qemu-devel] [PATCH 03/22] configure: add --disable-tcg configure option Paolo Bonzini
2017-07-03 19:37 ` Richard Henderson
2017-07-04 8:33 ` Daniel P. Berrange
2017-07-03 16:34 ` [Qemu-devel] [PATCH 04/22] vl: convert -tb-size to qemu_strtoul Paolo Bonzini
2017-07-03 19:46 ` Richard Henderson
2017-07-04 9:33 ` Paolo Bonzini
2017-07-04 9:37 ` Daniel P. Berrange
2017-07-03 16:34 ` [Qemu-devel] [PATCH 05/22] vl: add tcg_enabled() for tcg related code Paolo Bonzini
2017-07-03 19:46 ` Richard Henderson
2017-07-03 16:34 ` [Qemu-devel] [PATCH 06/22] tcg: move page_size_init() function Paolo Bonzini
2017-07-03 19:58 ` Richard Henderson
2017-07-03 16:34 ` [Qemu-devel] [PATCH 07/22] tcg: tcg_handle_interrupt() function Paolo Bonzini
2017-07-03 19:59 ` Richard Henderson
2017-07-03 16:34 ` [Qemu-devel] [PATCH 08/22] tcg: make tcg_allowed global Paolo Bonzini
2017-07-03 20:01 ` Richard Henderson
2017-07-03 16:34 ` [Qemu-devel] [PATCH 09/22] monitor: disable "info jit" and "info opcount" if !TCG Paolo Bonzini
2017-07-03 20:02 ` Richard Henderson
2017-07-03 16:34 ` [Qemu-devel] [PATCH 10/22] vapic: use tcg_enabled Paolo Bonzini
2017-07-03 20:02 ` Richard Henderson
2017-07-03 16:34 ` [Qemu-devel] [PATCH 11/22] tcg: add the tcg-stub.c file into accel/stubs/ Paolo Bonzini
2017-07-03 20:03 ` Richard Henderson
2017-07-03 16:34 ` [Qemu-devel] [PATCH 12/22] tcg: move tb_lock out of translate-all.h Paolo Bonzini
2017-07-03 20:04 ` Richard Henderson
2017-07-03 16:34 ` [Qemu-devel] [PATCH 13/22] exec: elide calls to tb_lock and tb_unlock Paolo Bonzini
2017-07-03 20:07 ` Richard Henderson
2017-07-03 16:34 ` [Qemu-devel] [PATCH 14/22] tcg: add CONFIG_TCG guards in headers Paolo Bonzini
2017-07-03 20:10 ` Richard Henderson
2017-07-04 9:35 ` Paolo Bonzini
2017-07-03 16:34 ` [Qemu-devel] [PATCH 15/22] tcg: add the CONFIG_TCG into Makefiles Paolo Bonzini
2017-07-03 20:10 ` Richard Henderson
2017-07-03 16:34 ` [Qemu-devel] [PATCH 16/22] target/i386: move cpu_sync_bndcs_hflags() function Paolo Bonzini
2017-07-03 20:11 ` Richard Henderson
2017-07-03 16:34 ` [Qemu-devel] [PATCH 17/22] target/i386: make cpu_get_fp80()/cpu_set_fp80() static Paolo Bonzini
2017-07-03 20:12 ` Richard Henderson
2017-07-03 16:34 ` [Qemu-devel] [PATCH 18/22] target/i386: split cpu_set_mxcsr() and make cpu_set_fpuc() inline Paolo Bonzini
2017-07-03 20:14 ` Richard Henderson
2017-07-04 9:41 ` Paolo Bonzini
2017-07-03 16:34 ` [Qemu-devel] [PATCH 19/22] target/i386: move TLB refill function out of helper.c Paolo Bonzini
2017-07-03 20:15 ` Richard Henderson
2017-07-03 16:34 ` Paolo Bonzini [this message]
2017-07-03 20:19 ` [Qemu-devel] [PATCH 20/22] target/i386: add the tcg_enabled() in target/i386/ Richard Henderson
2017-07-04 9:58 ` Paolo Bonzini
2017-07-03 16:34 ` [Qemu-devel] [PATCH 21/22] target/i386: add the CONFIG_TCG into Makefiles Paolo Bonzini
2017-07-03 20:20 ` Richard Henderson
2017-07-03 16:34 ` [Qemu-devel] [PATCH 22/22] configure: warn on untested --disable-tcg Paolo Bonzini
2017-07-03 20:21 ` Richard Henderson
2017-07-04 8:33 ` Daniel P. Berrange
-- strict thread matches above, loose matches on Subject: below --
2017-07-04 11:11 [Qemu-devel] [PATCH v4 00/22] add disable-tcg option for x86 build Paolo Bonzini
2017-07-04 11:12 ` [Qemu-devel] [PATCH 20/22] target/i386: add the tcg_enabled() in target/i386/ Paolo Bonzini
2017-07-04 18:33 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1499099693-22903-21-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=a.rigo@virtualopensystems.com \
--cc=anthony.xu@intel.com \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
--cc=yang.zhong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).