From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36327) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSfZ9-0005sY-BK for qemu-devel@nongnu.org; Wed, 05 Jul 2017 04:21:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSfZ8-0000Tk-Bh for qemu-devel@nongnu.org; Wed, 05 Jul 2017 04:21:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47650) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dSfZ8-0000Ta-5e for qemu-devel@nongnu.org; Wed, 05 Jul 2017 04:21:42 -0400 From: Peter Xu Date: Wed, 5 Jul 2017 16:21:21 +0800 Message-Id: <1499242883-2184-3-git-send-email-peterx@redhat.com> In-Reply-To: <1499242883-2184-1-git-send-email-peterx@redhat.com> References: <1499242883-2184-1-git-send-email-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH v2 2/4] vl: move global property, migrate init earlier List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Eduardo Habkost , Juan Quintela , peterx@redhat.com, haoqf@linux.vnet.ibm.com, Laurent Vivier , Markus Armbruster , "Dr . David Alan Gilbert" Currently drive_init_func() may call migrate_get_current() while the migrate object is still not ready yet at that time. Move the migration object init earlier, along with the global properties, right after acceleration init. This fixes a breakage for iotest 055, which caused an assertion failure. Reported-by: Max Reitz Reported-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Eduardo Habkost Tested-by: QingFeng Hao Fixes: 3df663 ("migration: move only_migratable to MigrationState") Signed-off-by: Peter Xu --- vl.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/vl.c b/vl.c index 0c497a3..2ae4313 100644 --- a/vl.c +++ b/vl.c @@ -4414,6 +4414,18 @@ int main(int argc, char **argv, char **envp) =20 configure_accelerator(current_machine); =20 + /* + * Register all the global properties, including accel properties, + * machine properties, and user-specified ones. + */ + register_global_properties(current_machine); + + /* + * Migration object can only be created after global properties + * are applied correctly. + */ + migration_object_init(); + if (qtest_chrdev) { qtest_init(qtest_chrdev, qtest_log, &error_fatal); } @@ -4595,18 +4607,6 @@ int main(int argc, char **argv, char **envp) exit (i =3D=3D 1 ? 1 : 0); } =20 - /* - * Register all the global properties, including accel properties, - * machine properties, and user-specified ones. - */ - register_global_properties(current_machine); - - /* - * Migration object can only be created after global properties - * are applied correctly. - */ - migration_object_init(); - /* This checkpoint is required by replay to separate prior clock reading from the other reads, because timer polling functions que= ry clock values from the log. */ --=20 2.7.4