From: Anton Nefedov <anton.nefedov@virtuozzo.com>
To: qemu-devel@nongnu.org
Cc: den@virtuozzo.com, pbonzini@redhat.com,
marcandre.lureau@redhat.com, amit@kernel.org, mst@redhat.com,
Anton Nefedov <anton.nefedov@virtuozzo.com>
Subject: [Qemu-devel] [PATCH v5 09/13] test-char: add hotswap test
Date: Wed, 5 Jul 2017 17:02:00 +0300 [thread overview]
Message-ID: <1499263324-15184-10-git-send-email-anton.nefedov@virtuozzo.com> (raw)
In-Reply-To: <1499263324-15184-1-git-send-email-anton.nefedov@virtuozzo.com>
Signed-off-by: Anton Nefedov <anton.nefedov@virtuozzo.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
tests/test-char.c | 71 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 71 insertions(+)
diff --git a/tests/test-char.c b/tests/test-char.c
index de72974..9ca233f 100644
--- a/tests/test-char.c
+++ b/tests/test-char.c
@@ -662,6 +662,76 @@ static void char_invalid_test(void)
g_assert_null(chr);
}
+static int chardev_change(void *opaque)
+{
+ return 0;
+}
+
+static int chardev_change_denied(void *opaque)
+{
+ return -1;
+}
+
+static void char_hotswap_test(void)
+{
+ char *chr_args;
+ Chardev *chr;
+ CharBackend be;
+
+ gchar *tmp_path = g_dir_make_tmp("qemu-test-char.XXXXXX", NULL);
+ char *filename = g_build_filename(tmp_path, "file", NULL);
+ ChardevFile file = { .out = filename };
+ ChardevBackend backend = { .type = CHARDEV_BACKEND_KIND_FILE,
+ .u.file.data = &file };
+ ChardevReturn *ret;
+
+ int port;
+ int sock = make_udp_socket(&port);
+ g_assert_cmpint(sock, >, 0);
+
+ chr_args = g_strdup_printf("udp:127.0.0.1:%d", port);
+
+ chr = qemu_chr_new("chardev", chr_args);
+ qemu_chr_fe_init(&be, chr, &error_abort);
+
+ /* check that chardev operates correctly */
+ char_udp_test_internal(chr, sock);
+
+ /* set the handler that denies the hotswap */
+ qemu_chr_fe_set_handlers(&be, NULL, NULL,
+ NULL, chardev_change_denied, NULL, NULL, true);
+
+ /* now, change is denied and has to keep the old backend operating */
+ ret = qmp_chardev_change("chardev", &backend, NULL);
+ g_assert(!ret);
+ g_assert(be.chr == chr);
+
+ char_udp_test_internal(chr, sock);
+
+ /* now allow the change */
+ qemu_chr_fe_set_handlers(&be, NULL, NULL,
+ NULL, chardev_change, NULL, NULL, true);
+
+ /* has to succeed now */
+ ret = qmp_chardev_change("chardev", &backend, &error_abort);
+ g_assert(be.chr != chr);
+
+ close(sock);
+ chr = be.chr;
+
+ /* run the file chardev test */
+ char_file_test_internal(chr, filename);
+
+ object_unparent(OBJECT(chr));
+
+ qapi_free_ChardevReturn(ret);
+ g_unlink(filename);
+ g_free(filename);
+ g_rmdir(tmp_path);
+ g_free(tmp_path);
+ g_free(chr_args);
+}
+
int main(int argc, char **argv)
{
qemu_init_main_loop(&error_abort);
@@ -696,6 +766,7 @@ int main(int argc, char **argv)
#ifdef HAVE_CHARDEV_SERIAL
g_test_add_func("/char/serial", char_serial_test);
#endif
+ g_test_add_func("/char/hotswap", char_hotswap_test);
return g_test_run();
}
--
2.7.4
next prev parent reply other threads:[~2017-07-05 14:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 14:01 [Qemu-devel] [PATCH v5 00/13] chardevice hotswap Anton Nefedov
2017-07-05 14:01 ` [Qemu-devel] [PATCH v5 01/13] char: move QemuOpts->ChardevBackend translation to a separate func Anton Nefedov
2017-07-05 14:01 ` [Qemu-devel] [PATCH v5 02/13] char: add backend hotswap handler Anton Nefedov
2017-07-05 14:01 ` [Qemu-devel] [PATCH v5 03/13] char: chardevice hotswap Anton Nefedov
2017-07-05 15:09 ` Paolo Bonzini
2017-07-05 17:33 ` Anton Nefedov
2017-07-05 21:39 ` Paolo Bonzini
2017-07-05 14:01 ` [Qemu-devel] [PATCH v5 04/13] char: forbid direct chardevice access for hotswap devices Anton Nefedov
2017-07-05 14:01 ` [Qemu-devel] [PATCH v5 05/13] char: avoid chardevice direct access Anton Nefedov
2017-07-05 14:01 ` [Qemu-devel] [PATCH v5 06/13] test-char: destroy chardev-udp after test Anton Nefedov
2017-07-05 14:01 ` [Qemu-devel] [PATCH v5 07/13] test-char: split char_udp_test Anton Nefedov
2017-07-05 14:01 ` [Qemu-devel] [PATCH v5 08/13] test-char: split char_file_test Anton Nefedov
2017-07-05 14:02 ` Anton Nefedov [this message]
2017-07-05 14:02 ` [Qemu-devel] [PATCH v5 10/13] hmp: add hmp analogue for qmp-chardev-change Anton Nefedov
2017-07-05 14:02 ` [Qemu-devel] [PATCH v5 11/13] virtio-console: chardev hotswap support Anton Nefedov
2017-07-05 15:12 ` Paolo Bonzini
2017-07-05 14:02 ` [Qemu-devel] [PATCH v5 12/13] serial: move TIOCM update to a separate function Anton Nefedov
2017-07-05 14:02 ` [Qemu-devel] [PATCH v5 13/13] serial: chardev hotswap support Anton Nefedov
2017-07-05 14:15 ` Michael S. Tsirkin
2017-07-05 15:12 ` Paolo Bonzini
2017-07-05 15:12 ` [Qemu-devel] [PATCH v5 00/13] chardevice hotswap Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1499263324-15184-10-git-send-email-anton.nefedov@virtuozzo.com \
--to=anton.nefedov@virtuozzo.com \
--cc=amit@kernel.org \
--cc=den@virtuozzo.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).