From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44858) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSkt4-0004nE-H7 for qemu-devel@nongnu.org; Wed, 05 Jul 2017 10:02:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSkt0-0007p6-GW for qemu-devel@nongnu.org; Wed, 05 Jul 2017 10:02:38 -0400 Received: from mail-eopbgr40115.outbound.protection.outlook.com ([40.107.4.115]:5184 helo=EUR03-DB5-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dSkt0-0007nB-7D for qemu-devel@nongnu.org; Wed, 05 Jul 2017 10:02:34 -0400 From: Anton Nefedov Date: Wed, 5 Jul 2017 17:02:00 +0300 Message-ID: <1499263324-15184-10-git-send-email-anton.nefedov@virtuozzo.com> In-Reply-To: <1499263324-15184-1-git-send-email-anton.nefedov@virtuozzo.com> References: <1499263324-15184-1-git-send-email-anton.nefedov@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH v5 09/13] test-char: add hotswap test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: den@virtuozzo.com, pbonzini@redhat.com, marcandre.lureau@redhat.com, amit@kernel.org, mst@redhat.com, Anton Nefedov Signed-off-by: Anton Nefedov Reviewed-by: Marc-Andr=C3=A9 Lureau --- tests/test-char.c | 71 +++++++++++++++++++++++++++++++++++++++++++++++++++= ++++ 1 file changed, 71 insertions(+) diff --git a/tests/test-char.c b/tests/test-char.c index de72974..9ca233f 100644 --- a/tests/test-char.c +++ b/tests/test-char.c @@ -662,6 +662,76 @@ static void char_invalid_test(void) g_assert_null(chr); } =20 +static int chardev_change(void *opaque) +{ + return 0; +} + +static int chardev_change_denied(void *opaque) +{ + return -1; +} + +static void char_hotswap_test(void) +{ + char *chr_args; + Chardev *chr; + CharBackend be; + + gchar *tmp_path =3D g_dir_make_tmp("qemu-test-char.XXXXXX", NULL); + char *filename =3D g_build_filename(tmp_path, "file", NULL); + ChardevFile file =3D { .out =3D filename }; + ChardevBackend backend =3D { .type =3D CHARDEV_BACKEND_KIND_FILE, + .u.file.data =3D &file }; + ChardevReturn *ret; + + int port; + int sock =3D make_udp_socket(&port); + g_assert_cmpint(sock, >, 0); + + chr_args =3D g_strdup_printf("udp:127.0.0.1:%d", port); + + chr =3D qemu_chr_new("chardev", chr_args); + qemu_chr_fe_init(&be, chr, &error_abort); + + /* check that chardev operates correctly */ + char_udp_test_internal(chr, sock); + + /* set the handler that denies the hotswap */ + qemu_chr_fe_set_handlers(&be, NULL, NULL, + NULL, chardev_change_denied, NULL, NULL, true= ); + + /* now, change is denied and has to keep the old backend operating */ + ret =3D qmp_chardev_change("chardev", &backend, NULL); + g_assert(!ret); + g_assert(be.chr =3D=3D chr); + + char_udp_test_internal(chr, sock); + + /* now allow the change */ + qemu_chr_fe_set_handlers(&be, NULL, NULL, + NULL, chardev_change, NULL, NULL, true); + + /* has to succeed now */ + ret =3D qmp_chardev_change("chardev", &backend, &error_abort); + g_assert(be.chr !=3D chr); + + close(sock); + chr =3D be.chr; + + /* run the file chardev test */ + char_file_test_internal(chr, filename); + + object_unparent(OBJECT(chr)); + + qapi_free_ChardevReturn(ret); + g_unlink(filename); + g_free(filename); + g_rmdir(tmp_path); + g_free(tmp_path); + g_free(chr_args); +} + int main(int argc, char **argv) { qemu_init_main_loop(&error_abort); @@ -696,6 +766,7 @@ int main(int argc, char **argv) #ifdef HAVE_CHARDEV_SERIAL g_test_add_func("/char/serial", char_serial_test); #endif + g_test_add_func("/char/hotswap", char_hotswap_test); =20 return g_test_run(); } --=20 2.7.4