qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anton Nefedov <anton.nefedov@virtuozzo.com>
To: qemu-devel@nongnu.org
Cc: den@virtuozzo.com, pbonzini@redhat.com,
	marcandre.lureau@redhat.com, amit@kernel.org, mst@redhat.com,
	Anton Nefedov <anton.nefedov@virtuozzo.com>
Subject: [Qemu-devel] [PATCH v5 13/13] serial: chardev hotswap support
Date: Wed,  5 Jul 2017 17:02:04 +0300	[thread overview]
Message-ID: <1499263324-15184-14-git-send-email-anton.nefedov@virtuozzo.com> (raw)
In-Reply-To: <1499263324-15184-1-git-send-email-anton.nefedov@virtuozzo.com>

for a backend change, a number of ioctls has to be replayed to sync
the current setup of a frontend to a backend tty. This is hopefully
enough so we don't have to track, store and replay the whole original
control byte sequence.

Signed-off-by: Anton Nefedov <anton.nefedov@virtuozzo.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
 hw/char/serial.c | 32 ++++++++++++++++++++++++++++++--
 1 file changed, 30 insertions(+), 2 deletions(-)

diff --git a/hw/char/serial.c b/hw/char/serial.c
index e47f0b6..9aec6c6 100644
--- a/hw/char/serial.c
+++ b/hw/char/serial.c
@@ -891,9 +891,37 @@ static void serial_reset(void *opaque)
     s->msr &= ~UART_MSR_ANY_DELTA;
 }
 
+static int serial_be_change(void *opaque)
+{
+    SerialState *s = opaque;
+
+    qemu_chr_fe_set_handlers(&s->chr, serial_can_receive1, serial_receive1,
+                             serial_event, serial_be_change, s, NULL, true);
+
+    serial_update_parameters(s);
+
+    qemu_chr_fe_ioctl(&s->chr, CHR_IOCTL_SERIAL_SET_BREAK,
+                      &s->last_break_enable);
+
+    s->poll_msl = (s->ier & UART_IER_MSI) ? 1 : 0;
+    serial_update_msl(s);
+
+    if (s->poll_msl >= 0 && !(s->mcr & UART_MCR_LOOP)) {
+        serial_update_tiocm(s);
+    }
+
+    if (s->watch_tag > 0) {
+        g_source_remove(s->watch_tag);
+        s->watch_tag = qemu_chr_fe_add_watch(&s->chr, G_IO_OUT | G_IO_HUP,
+                                             serial_watch_cb, s);
+    }
+
+    return 0;
+}
+
 void serial_realize_core(SerialState *s, Error **errp)
 {
-    if (!qemu_chr_fe_get_driver(&s->chr)) {
+    if (!qemu_chr_fe_backend_connected(&s->chr)) {
         error_setg(errp, "Can't create serial device, empty char device");
         return;
     }
@@ -904,7 +932,7 @@ void serial_realize_core(SerialState *s, Error **errp)
     qemu_register_reset(serial_reset, s);
 
     qemu_chr_fe_set_handlers(&s->chr, serial_can_receive1, serial_receive1,
-                             serial_event, NULL, s, NULL, true);
+                             serial_event, serial_be_change, s, NULL, true);
     fifo8_create(&s->recv_fifo, UART_FIFO_LENGTH);
     fifo8_create(&s->xmit_fifo, UART_FIFO_LENGTH);
     serial_reset(s);
-- 
2.7.4

  parent reply	other threads:[~2017-07-05 14:02 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-05 14:01 [Qemu-devel] [PATCH v5 00/13] chardevice hotswap Anton Nefedov
2017-07-05 14:01 ` [Qemu-devel] [PATCH v5 01/13] char: move QemuOpts->ChardevBackend translation to a separate func Anton Nefedov
2017-07-05 14:01 ` [Qemu-devel] [PATCH v5 02/13] char: add backend hotswap handler Anton Nefedov
2017-07-05 14:01 ` [Qemu-devel] [PATCH v5 03/13] char: chardevice hotswap Anton Nefedov
2017-07-05 15:09   ` Paolo Bonzini
2017-07-05 17:33     ` Anton Nefedov
2017-07-05 21:39       ` Paolo Bonzini
2017-07-05 14:01 ` [Qemu-devel] [PATCH v5 04/13] char: forbid direct chardevice access for hotswap devices Anton Nefedov
2017-07-05 14:01 ` [Qemu-devel] [PATCH v5 05/13] char: avoid chardevice direct access Anton Nefedov
2017-07-05 14:01 ` [Qemu-devel] [PATCH v5 06/13] test-char: destroy chardev-udp after test Anton Nefedov
2017-07-05 14:01 ` [Qemu-devel] [PATCH v5 07/13] test-char: split char_udp_test Anton Nefedov
2017-07-05 14:01 ` [Qemu-devel] [PATCH v5 08/13] test-char: split char_file_test Anton Nefedov
2017-07-05 14:02 ` [Qemu-devel] [PATCH v5 09/13] test-char: add hotswap test Anton Nefedov
2017-07-05 14:02 ` [Qemu-devel] [PATCH v5 10/13] hmp: add hmp analogue for qmp-chardev-change Anton Nefedov
2017-07-05 14:02 ` [Qemu-devel] [PATCH v5 11/13] virtio-console: chardev hotswap support Anton Nefedov
2017-07-05 15:12   ` Paolo Bonzini
2017-07-05 14:02 ` [Qemu-devel] [PATCH v5 12/13] serial: move TIOCM update to a separate function Anton Nefedov
2017-07-05 14:02 ` Anton Nefedov [this message]
2017-07-05 14:15   ` [Qemu-devel] [PATCH v5 13/13] serial: chardev hotswap support Michael S. Tsirkin
2017-07-05 15:12   ` Paolo Bonzini
2017-07-05 15:12 ` [Qemu-devel] [PATCH v5 00/13] chardevice hotswap Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1499263324-15184-14-git-send-email-anton.nefedov@virtuozzo.com \
    --to=anton.nefedov@virtuozzo.com \
    --cc=amit@kernel.org \
    --cc=den@virtuozzo.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).