From: Christian Borntraeger <borntraeger@de.ibm.com>
To: qemu-devel <qemu-devel@nongnu.org>
Cc: Alexander Graf <agraf@suse.de>,
Richard Henderson <rth@twiddle.net>,
Cornelia Huck <cohuck@redhat.com>,
Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>
Subject: [Qemu-devel] [PULL 2/8] s390x/3270: fix instruction interception handler
Date: Thu, 6 Jul 2017 09:23:31 +0200 [thread overview]
Message-ID: <1499325817-9166-3-git-send-email-borntraeger@de.ibm.com> (raw)
In-Reply-To: <1499325817-9166-1-git-send-email-borntraeger@de.ibm.com>
From: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>
Commit bab482d7405f ("s390x/css: ccw translation infrastructure")
introduced instruction interception handler for different types of
subchannels. For emulated 3270 devices, we should assign the virtual
subchannel handler to them during device realization process, or 3270
will not work.
Fixes: bab482d7405f ("s390x/css: ccw translation infrastructure")
Reviewed-by: Jing Liu <liujbjl@linux.vnet.ibm.com>
Reviewed-by: Halil Pasic <pasic@linux.vnet.ibm.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
hw/s390x/3270-ccw.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/s390x/3270-ccw.c b/hw/s390x/3270-ccw.c
index 6e6eee4..1554aa2 100644
--- a/hw/s390x/3270-ccw.c
+++ b/hw/s390x/3270-ccw.c
@@ -126,6 +126,7 @@ static void emulated_ccw_3270_realize(DeviceState *ds, Error **errp)
sch->id.cu_type = EMULATED_CCW_3270_CU_TYPE;
css_sch_build_virtual_schib(sch, (uint8_t)chpid,
EMULATED_CCW_3270_CHPID_TYPE);
+ sch->do_subchannel_work = do_subchannel_work_virtual;
sch->ccw_cb = emulated_ccw_3270_cb;
ck->init(dev, &err);
--
2.7.4
next prev parent reply other threads:[~2017-07-06 7:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 7:23 [Qemu-devel] [PULL 0/8] s390x/kvm/migration: fixes, enhancements and cleanups Christian Borntraeger
2017-07-06 7:23 ` [Qemu-devel] [PULL 1/8] s390x: vmstatify config migration for virtio-ccw Christian Borntraeger
2017-07-06 7:23 ` Christian Borntraeger [this message]
2017-07-06 7:23 ` [Qemu-devel] [PULL 3/8] s390x: fix error propagation in kvm-flic's realize Christian Borntraeger
2017-07-06 7:23 ` [Qemu-devel] [PULL 4/8] s390x: fix realize inheritance for kvm-flic Christian Borntraeger
2017-07-06 7:23 ` [Qemu-devel] [PULL 5/8] s390x/MAINTAINERS: Update my email address Christian Borntraeger
2017-07-06 7:23 ` [Qemu-devel] [PULL 6/8] s390x: return unavailable features via query-cpu-definitions Christian Borntraeger
2017-07-06 7:23 ` [Qemu-devel] [PULL 7/8] virtio-scsi-ccw: use ioeventfd even when KVM is disabled Christian Borntraeger
2017-07-06 7:23 ` [Qemu-devel] [PULL 8/8] hw/s390x/ipl: Fix endianness problem with netboot_start_addr Christian Borntraeger
2017-07-06 12:00 ` [Qemu-devel] [PULL 0/8] s390x/kvm/migration: fixes, enhancements and cleanups Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1499325817-9166-3-git-send-email-borntraeger@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=agraf@suse.de \
--cc=bjsdjshi@linux.vnet.ibm.com \
--cc=cohuck@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).