From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: patches@linaro.org, "Markus Armbruster" <armbru@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [Qemu-devel] [PATCH 0/3] Allow int props with no default, use them in ARM
Date: Tue, 11 Jul 2017 16:53:25 +0100 [thread overview]
Message-ID: <1499788408-10096-1-git-send-email-peter.maydell@linaro.org> (raw)
This patchset follows up on a suggestion by Markus for
allowing devices to implement integer properties which
don't have a default value specified in their Property
struct.
My use case for this is ARM, where we have a property
pmsav7-dregion whose correct default value depends on
which exact ARM CPU this is. That means we can't have
a single constant default value specified in the
DEFINE_PROP_UINT32(), but on the other hand if we just
prevent the qdev prop system from setting a default itself
we can naturally get the right default value by having
the structure field be correctly set to the default for
the CPU in the first place.
Patch 1 cleans up a corner case where we had just one
Property struct which was using the default value
(because it has a PropertyInfo with a non-NULL set_default_value
field) but not explicitly setting .defval.[ui].
Patch 2 adds .set_default to Property, uses it as the gate
on calling .set_default_value rather than just whether
.set_default_value is non-NULL, and adds some macros
so that devices can use the new no-default-value int props.
Patch 3 uses this so M3 and M4 have the right default
for the number of PMSA regions rather than getting the
different R7 default.
thanks
-- PMM
Peter Maydell (3):
qdev-properties.h: Explicitly set the default value for arraylen
properties
qdev: support properties which don't set a default value
target/arm: Make Cortex-M3 and M4 default to 8 PMSA regions
include/hw/qdev-core.h | 1 +
include/hw/qdev-properties.h | 21 +++++++++++++++++++++
hw/core/qdev.c | 2 +-
target/arm/cpu.c | 12 +++++++++++-
4 files changed, 34 insertions(+), 2 deletions(-)
--
2.7.4
next reply other threads:[~2017-07-11 15:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 15:53 Peter Maydell [this message]
2017-07-11 15:53 ` [Qemu-devel] [PATCH 1/3] qdev-properties.h: Explicitly set the default value for arraylen properties Peter Maydell
2017-07-11 16:46 ` Marc-André Lureau
2017-07-13 14:11 ` Markus Armbruster
2017-07-13 14:26 ` Peter Maydell
2017-07-13 16:21 ` Markus Armbruster
2017-07-11 15:53 ` [Qemu-devel] [PATCH 2/3] qdev: support properties which don't set a default value Peter Maydell
2017-07-11 17:15 ` Marc-André Lureau
2017-07-11 17:25 ` Peter Maydell
2017-07-12 11:22 ` Markus Armbruster
2017-07-12 12:27 ` Peter Maydell
2017-07-13 15:38 ` Peter Maydell
2017-07-13 17:10 ` Markus Armbruster
2017-07-13 17:18 ` Peter Maydell
2017-07-13 18:25 ` Markus Armbruster
2017-07-11 15:53 ` [Qemu-devel] [PATCH 3/3] target/arm: Make Cortex-M3 and M4 default to 8 PMSA regions Peter Maydell
2017-07-11 17:18 ` Marc-André Lureau
2017-07-11 17:27 ` Peter Maydell
2017-07-11 17:30 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1499788408-10096-1-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=armbru@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=patches@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).