From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: Alistair Francis <alistair.francis@xilinx.com>
Subject: [Qemu-devel] [PULL 7/9] char-socket: Report TCP socket waiting as information
Date: Thu, 13 Jul 2017 15:27:54 +0200 [thread overview]
Message-ID: <1499952476-3454-8-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1499952476-3454-1-git-send-email-armbru@redhat.com>
From: Alistair Francis <alistair.francis@xilinx.com>
When QEMU is waiting for a TCP socket connection it reports that message as
an error. This isn't an error it is just information so let's change the
report to use info_report() instead.
Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <b3f3601c52843afca9a9b12c7a4fefd68e60de32.1499866456.git.alistair.francis@xilinx.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
chardev/char-socket.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/chardev/char-socket.c b/chardev/char-socket.c
index ccc499c..a050a68 100644
--- a/chardev/char-socket.c
+++ b/chardev/char-socket.c
@@ -765,8 +765,8 @@ static int tcp_chr_wait_connected(Chardev *chr, Error **errp)
* in TLS and telnet cases, only wait for an accepted socket */
while (!s->ioc) {
if (s->is_listen) {
- error_report("QEMU waiting for connection on: %s",
- chr->filename);
+ info_report("QEMU waiting for connection on: %s",
+ chr->filename);
qio_channel_set_blocking(QIO_CHANNEL(s->listen_ioc), true, NULL);
tcp_chr_accept(QIO_CHANNEL(s->listen_ioc), G_IO_IN, chr);
qio_channel_set_blocking(QIO_CHANNEL(s->listen_ioc), false, NULL);
--
2.7.5
next prev parent reply other threads:[~2017-07-13 13:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 13:27 [Qemu-devel] [PULL 0/9] Error reporting patches for 2017-07-13 Markus Armbruster
2017-07-13 13:27 ` [Qemu-devel] [PULL 1/9] xilinx: Fix latent error handling bug Markus Armbruster
2017-07-13 13:27 ` [Qemu-devel] [PULL 2/9] block: Don't try to set *errp directly Markus Armbruster
2017-07-13 13:27 ` [Qemu-devel] [PULL 3/9] websock: " Markus Armbruster
2017-07-13 13:27 ` [Qemu-devel] [PULL 4/9] util/qemu-error: Rename error_print_loc() to be more generic Markus Armbruster
2017-07-13 13:27 ` [Qemu-devel] [PULL 5/9] error: Functions to report warnings and informational messages Markus Armbruster
2017-07-13 13:27 ` [Qemu-devel] [PULL 6/9] Convert error_report() to warn_report() Markus Armbruster
2017-07-17 10:19 ` Kevin Wolf
2017-07-18 5:17 ` Markus Armbruster
2017-07-24 6:30 ` Markus Armbruster
2017-07-24 7:30 ` Paolo Bonzini
2017-07-25 19:08 ` [Qemu-devel] Slow tests on "make check" (was Re: [PULL 6/9] Convert error_report() to warn_report()) Eduardo Habkost
2017-07-25 23:24 ` Alistair Francis
2017-07-25 23:26 ` Alistair Francis
2017-07-26 10:17 ` Richard W.M. Jones
2017-07-26 10:35 ` Daniel P. Berrange
2017-07-26 10:30 ` [Qemu-devel] [PULL 6/9] Convert error_report() to warn_report() Daniel P. Berrange
2017-07-27 8:25 ` Markus Armbruster
2017-07-27 8:45 ` Kevin Wolf
2017-07-27 9:14 ` Markus Armbruster
2017-07-27 11:45 ` Max Reitz
2017-07-13 13:27 ` Markus Armbruster [this message]
2017-07-13 13:27 ` [Qemu-devel] [PULL 8/9] error: Implement the warn and free Error functions Markus Armbruster
2017-07-13 13:27 ` [Qemu-devel] [PULL 9/9] Convert error_report*_err() to warn_report*_err() Markus Armbruster
2017-07-13 13:46 ` [Qemu-devel] [PULL 0/9] Error reporting patches for 2017-07-13 no-reply
2017-07-14 10:05 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1499952476-3454-8-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=alistair.francis@xilinx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).