qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Anton Nefedov <anton.nefedov@virtuozzo.com>
Subject: [Qemu-devel] [PULL 16/41] test-char: add hotswap test
Date: Thu, 13 Jul 2017 16:24:09 +0200	[thread overview]
Message-ID: <1499955874-10954-17-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1499955874-10954-1-git-send-email-pbonzini@redhat.com>

From: Anton Nefedov <anton.nefedov@virtuozzo.com>

Signed-off-by: Anton Nefedov <anton.nefedov@virtuozzo.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <1499342940-56739-10-git-send-email-anton.nefedov@virtuozzo.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 tests/test-char.c | 71 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 71 insertions(+)

diff --git a/tests/test-char.c b/tests/test-char.c
index c654eea..7ac25ff 100644
--- a/tests/test-char.c
+++ b/tests/test-char.c
@@ -658,6 +658,76 @@ static void char_invalid_test(void)
     g_assert_null(chr);
 }
 
+static int chardev_change(void *opaque)
+{
+    return 0;
+}
+
+static int chardev_change_denied(void *opaque)
+{
+    return -1;
+}
+
+static void char_hotswap_test(void)
+{
+    char *chr_args;
+    Chardev *chr;
+    CharBackend be;
+
+    gchar *tmp_path = g_dir_make_tmp("qemu-test-char.XXXXXX", NULL);
+    char *filename = g_build_filename(tmp_path, "file", NULL);
+    ChardevFile file = { .out = filename };
+    ChardevBackend backend = { .type = CHARDEV_BACKEND_KIND_FILE,
+                               .u.file.data = &file };
+    ChardevReturn *ret;
+
+    int port;
+    int sock = make_udp_socket(&port);
+    g_assert_cmpint(sock, >, 0);
+
+    chr_args = g_strdup_printf("udp:127.0.0.1:%d", port);
+
+    chr = qemu_chr_new("chardev", chr_args);
+    qemu_chr_fe_init(&be, chr, &error_abort);
+
+    /* check that chardev operates correctly */
+    char_udp_test_internal(chr, sock);
+
+    /* set the handler that denies the hotswap */
+    qemu_chr_fe_set_handlers(&be, NULL, NULL,
+                             NULL, chardev_change_denied, NULL, NULL, true);
+
+    /* now, change is denied and has to keep the old backend operating */
+    ret = qmp_chardev_change("chardev", &backend, NULL);
+    g_assert(!ret);
+    g_assert(be.chr == chr);
+
+    char_udp_test_internal(chr, sock);
+
+    /* now allow the change */
+    qemu_chr_fe_set_handlers(&be, NULL, NULL,
+                             NULL, chardev_change, NULL, NULL, true);
+
+    /* has to succeed now */
+    ret = qmp_chardev_change("chardev", &backend, &error_abort);
+    g_assert(be.chr != chr);
+
+    close(sock);
+    chr = be.chr;
+
+    /* run the file chardev test */
+    char_file_test_internal(chr, filename);
+
+    object_unparent(OBJECT(chr));
+
+    qapi_free_ChardevReturn(ret);
+    g_unlink(filename);
+    g_free(filename);
+    g_rmdir(tmp_path);
+    g_free(tmp_path);
+    g_free(chr_args);
+}
+
 int main(int argc, char **argv)
 {
     qemu_init_main_loop(&error_abort);
@@ -692,6 +762,7 @@ int main(int argc, char **argv)
 #ifdef HAVE_CHARDEV_SERIAL
     g_test_add_func("/char/serial", char_serial_test);
 #endif
+    g_test_add_func("/char/hotswap", char_hotswap_test);
 
     return g_test_run();
 }
-- 
1.8.3.1

  parent reply	other threads:[~2017-07-13 14:25 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-13 14:23 [Qemu-devel] [PULL 00/41] Misc patches for QEMU 2.10 soft freeze Paolo Bonzini
2017-07-13 14:23 ` [Qemu-devel] [PULL 01/41] build: add -Wexpansion-to-defined Paolo Bonzini
2017-07-13 14:23 ` [Qemu-devel] [PULL 02/41] MAINTAINERS: update TCG entries Paolo Bonzini
2017-07-13 14:23 ` [Qemu-devel] [PULL 03/41] MAINTAINERS: update KVM entries Paolo Bonzini
2017-07-13 14:23 ` [Qemu-devel] [PULL 04/41] MAINTAINERS: update Xen entries Paolo Bonzini
2017-07-13 14:23 ` [Qemu-devel] [PULL 05/41] MAINTAINERS: update TCI entry Paolo Bonzini
2017-07-13 14:23 ` [Qemu-devel] [PULL 06/41] MAINTAINERS: add entry for "Unimplemented" device Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 07/41] chardev: block during sync read Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 08/41] char: move QemuOpts->ChardevBackend translation to a separate func Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 09/41] char: add backend hotswap handler Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 10/41] char: chardevice hotswap Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 11/41] char: forbid direct chardevice access for hotswap devices Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 12/41] char: avoid chardevice direct access Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 13/41] test-char: destroy chardev-udp after test Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 14/41] test-char: split char_udp_test Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 15/41] test-char: split char_file_test Paolo Bonzini
2017-07-13 14:24 ` Paolo Bonzini [this message]
2017-07-13 14:24 ` [Qemu-devel] [PULL 17/41] hmp: add hmp analogue for qmp-chardev-change Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 18/41] virtio-console: chardev hotswap support Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 19/41] serial: move TIOCM update to a separate function Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 20/41] serial: chardev hotswap support Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 21/41] exec: use qemu_ram_ptr_length to access guest ram Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 22/41] Revert "exec.c: Fix breakpoint invalidation race" Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 23/41] mttcg/i386: Patch instruction using async_safe_* framework Paolo Bonzini
2017-07-13 15:16   ` Alex Bennée
2017-07-14  8:24     ` Thomas Huth
2017-07-13 14:24 ` [Qemu-devel] [PULL 24/41] gdbstub: modernise DEBUG_GDB Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 25/41] gdbstub: rename cpu_index -> cpu_gdb_index Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 26/41] qom/cpu: remove host_tid field Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 27/41] gdbstub: don't fail on vCont; C04:0; c packets Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 28/41] chardev: fix parallel device can't be reconnect Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 29/41] memory/iommu: QOM'fy IOMMU MemoryRegion Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 30/41] memory/iommu: introduce IOMMUMemoryRegionClass Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 31/41] nbd: Create struct for tracking export info Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 32/41] nbd: Don't bother tracing an NBD_OPT_ABORT response failure Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 33/41] nbd: Expose and debug more NBD constants Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 34/41] nbd: Simplify trace of client flags in negotiation Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 35/41] nbd: Refactor reply to NBD_OPT_EXPORT_NAME Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 36/41] nbd: Implement NBD_OPT_GO on server Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 37/41] nbd: Implement NBD_OPT_GO on client Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 38/41] nbd: Implement NBD_INFO_BLOCK_SIZE on server Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 39/41] nbd: Implement NBD_INFO_BLOCK_SIZE on client Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 40/41] vl: fix breakage of -tb-size Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 41/41] translate-all: remove redundant !tcg_enabled check in dump_exec_info Paolo Bonzini
2017-07-13 16:05 ` [Qemu-devel] [PULL 00/41] Misc patches for QEMU 2.10 soft freeze no-reply
2017-07-13 17:01   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1499955874-10954-17-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=anton.nefedov@virtuozzo.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).