qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Prasad J Pandit <pjp@fedoraproject.org>
Subject: [Qemu-devel] [PULL 21/41] exec: use qemu_ram_ptr_length to access guest ram
Date: Thu, 13 Jul 2017 16:24:14 +0200	[thread overview]
Message-ID: <1499955874-10954-22-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1499955874-10954-1-git-send-email-pbonzini@redhat.com>

From: Prasad J Pandit <pjp@fedoraproject.org>

When accessing guest's ram block during DMA operation, use
'qemu_ram_ptr_length' to get ram block pointer. It ensures
that DMA operation of given length is possible; And avoids
any OOB memory access situations.

Reported-by: Alex <broscutamaker@gmail.com>
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
Message-Id: <20170712123840.29328-1-ppandit@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 exec.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/exec.c b/exec.c
index a083ff8..ad103ce 100644
--- a/exec.c
+++ b/exec.c
@@ -2929,7 +2929,7 @@ static MemTxResult address_space_write_continue(AddressSpace *as, hwaddr addr,
             }
         } else {
             /* RAM case */
-            ptr = qemu_map_ram_ptr(mr->ram_block, addr1);
+            ptr = qemu_ram_ptr_length(mr->ram_block, addr1, &l);
             memcpy(ptr, buf, l);
             invalidate_and_set_dirty(mr, addr1, l);
         }
@@ -3020,7 +3020,7 @@ MemTxResult address_space_read_continue(AddressSpace *as, hwaddr addr,
             }
         } else {
             /* RAM case */
-            ptr = qemu_map_ram_ptr(mr->ram_block, addr1);
+            ptr = qemu_ram_ptr_length(mr->ram_block, addr1, &l);
             memcpy(buf, ptr, l);
         }
 
-- 
1.8.3.1

  parent reply	other threads:[~2017-07-13 14:25 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-13 14:23 [Qemu-devel] [PULL 00/41] Misc patches for QEMU 2.10 soft freeze Paolo Bonzini
2017-07-13 14:23 ` [Qemu-devel] [PULL 01/41] build: add -Wexpansion-to-defined Paolo Bonzini
2017-07-13 14:23 ` [Qemu-devel] [PULL 02/41] MAINTAINERS: update TCG entries Paolo Bonzini
2017-07-13 14:23 ` [Qemu-devel] [PULL 03/41] MAINTAINERS: update KVM entries Paolo Bonzini
2017-07-13 14:23 ` [Qemu-devel] [PULL 04/41] MAINTAINERS: update Xen entries Paolo Bonzini
2017-07-13 14:23 ` [Qemu-devel] [PULL 05/41] MAINTAINERS: update TCI entry Paolo Bonzini
2017-07-13 14:23 ` [Qemu-devel] [PULL 06/41] MAINTAINERS: add entry for "Unimplemented" device Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 07/41] chardev: block during sync read Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 08/41] char: move QemuOpts->ChardevBackend translation to a separate func Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 09/41] char: add backend hotswap handler Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 10/41] char: chardevice hotswap Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 11/41] char: forbid direct chardevice access for hotswap devices Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 12/41] char: avoid chardevice direct access Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 13/41] test-char: destroy chardev-udp after test Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 14/41] test-char: split char_udp_test Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 15/41] test-char: split char_file_test Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 16/41] test-char: add hotswap test Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 17/41] hmp: add hmp analogue for qmp-chardev-change Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 18/41] virtio-console: chardev hotswap support Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 19/41] serial: move TIOCM update to a separate function Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 20/41] serial: chardev hotswap support Paolo Bonzini
2017-07-13 14:24 ` Paolo Bonzini [this message]
2017-07-13 14:24 ` [Qemu-devel] [PULL 22/41] Revert "exec.c: Fix breakpoint invalidation race" Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 23/41] mttcg/i386: Patch instruction using async_safe_* framework Paolo Bonzini
2017-07-13 15:16   ` Alex Bennée
2017-07-14  8:24     ` Thomas Huth
2017-07-13 14:24 ` [Qemu-devel] [PULL 24/41] gdbstub: modernise DEBUG_GDB Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 25/41] gdbstub: rename cpu_index -> cpu_gdb_index Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 26/41] qom/cpu: remove host_tid field Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 27/41] gdbstub: don't fail on vCont; C04:0; c packets Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 28/41] chardev: fix parallel device can't be reconnect Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 29/41] memory/iommu: QOM'fy IOMMU MemoryRegion Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 30/41] memory/iommu: introduce IOMMUMemoryRegionClass Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 31/41] nbd: Create struct for tracking export info Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 32/41] nbd: Don't bother tracing an NBD_OPT_ABORT response failure Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 33/41] nbd: Expose and debug more NBD constants Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 34/41] nbd: Simplify trace of client flags in negotiation Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 35/41] nbd: Refactor reply to NBD_OPT_EXPORT_NAME Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 36/41] nbd: Implement NBD_OPT_GO on server Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 37/41] nbd: Implement NBD_OPT_GO on client Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 38/41] nbd: Implement NBD_INFO_BLOCK_SIZE on server Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 39/41] nbd: Implement NBD_INFO_BLOCK_SIZE on client Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 40/41] vl: fix breakage of -tb-size Paolo Bonzini
2017-07-13 14:24 ` [Qemu-devel] [PULL 41/41] translate-all: remove redundant !tcg_enabled check in dump_exec_info Paolo Bonzini
2017-07-13 16:05 ` [Qemu-devel] [PULL 00/41] Misc patches for QEMU 2.10 soft freeze no-reply
2017-07-13 17:01   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1499955874-10954-22-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=pjp@fedoraproject.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).