From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: patches@linaro.org, Kamil Rytarowski <n54@gmx.com>,
Markus Armbruster <armbru@redhat.com>
Subject: [Qemu-devel] [PATCH 0/3] Fix NetBSD build (don't build ivshmem tools)
Date: Thu, 13 Jul 2017 18:03:43 +0100 [thread overview]
Message-ID: <1499965423-13517-1-git-send-email-peter.maydell@linaro.org> (raw)
This patchset fixes the build on NetBSD by making sure we only
build the ivshmem-client and ivshmem-server tools if the host OS
actually supports ivshmem. (Previously we were only gating building
of the within-QEMU ivshmem PCI device.)
Most of this patchset is the work of Kamil Rytarowski; I just
split it up into easily-reviewable patches and fixed a few bugs.
Tested on Linux, on NetBSD, and on Linux with a '--disable-linux-user
--disable-system' config (which was the one that was failing with
our previous attempt to fix this bug).
NB: we still have some things we need to fix to be able to put
NetBSD into the build-test set. The next issue is that 'make check'
fails with
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$((RANDOM % 255 + 1))} gtester -k --verbose -m=quick tests/check-qdict
sh: arith: syntax error: "RANDOM % 255 + 1"
likely because we're using a bashism there.
thanks
-- PMM
Kamil Rytarowski (2):
configure: Use an explicit CONFIG_IVSHMEM rather than CONFIG_EVENTFD
configure: Don't build ivshmem tools unless CONFIG_IVSHMEM is set
Peter Maydell (1):
configure: Rename CONFIG_IVSHMEM to CONFIG_IVSHMEM_DEVICE
configure | 11 +++++++++++
Makefile | 2 ++
Makefile.objs | 4 ++--
hw/misc/Makefile.objs | 2 +-
tests/Makefile.include | 4 ++--
default-configs/pci.mak | 2 +-
6 files changed, 19 insertions(+), 6 deletions(-)
--
2.7.4
next reply other threads:[~2017-07-13 17:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 17:03 Peter Maydell [this message]
2017-07-13 18:40 ` [Qemu-devel] [PATCH 0/3] Fix NetBSD build (don't build ivshmem tools) Kamil Rytarowski
2017-07-13 20:12 ` Eric Blake
2017-07-14 8:34 ` Peter Maydell
-- strict thread matches above, loose matches on Subject: below --
2017-07-14 8:33 Peter Maydell
2017-07-20 9:43 ` Peter Maydell
2017-07-20 11:20 ` Markus Armbruster
2017-07-20 15:35 ` Peter Maydell
2017-07-20 16:59 ` Kamil Rytarowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1499965423-13517-1-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=armbru@redhat.com \
--cc=n54@gmx.com \
--cc=patches@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).