qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
	"patches@linaro.org" <patches@linaro.org>,
	Thomas Huth <thuth@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] scripts/checkpatch.pl: Enforce multiline comment syntax
Date: Fri, 10 Aug 2018 14:45:04 +0200	[thread overview]
Message-ID: <14a92c80-4aec-bd60-68fd-d6a68c8a63b6@redhat.com> (raw)
In-Reply-To: <CAFEAcA_4M195VD57LyNVyWTLos140v2e7ymvuiY+rtJ4ZTCXwg@mail.gmail.com>

On 10/08/2018 11:10, Peter Maydell wrote:
>> So my proposal, which is actually consistent with what QEMU is doing, is
>> the following:
>>
>> 1) the first line of a file should always be "/*", otherwise warn
>>
>> 2) a comment that starts with "/**" should have it on a lone line
>>
>> 3) every other multiline comment should start with
>> "/*<whitespace><something>"
> Personally I would prefer your suggestion, but as I say, there
> was no consensus in the thread for it, and there was consensus
> for "use the kernel's style here". I don't think we gain much
> from reopening the debate at this point.

What we lose is that 3000 more new warnings appear.  So if we make an
exception and convert all of the comments, I'm okay.

But otherwise, at least Eric, you, me (only now I admit), Thomas
expressed a preference for the other style; on the other side it's
Markus, Stefan, Conny and Alex, some of whom were okay with applying
maintainer discretion; John and rth wanted a third one but disagreed on
their second choice.  I appreciate your writing the patch, but I'm not
sure that's consensus...

Paolo

  reply	other threads:[~2018-08-10 12:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-09 16:00 [Qemu-devel] [PATCH] scripts/checkpatch.pl: Enforce multiline comment syntax Peter Maydell
2018-08-09 16:43 ` Paolo Bonzini
2018-08-09 17:03   ` Peter Maydell
2018-08-10  8:34     ` Paolo Bonzini
2018-08-10  9:10       ` Peter Maydell
2018-08-10 12:45         ` Paolo Bonzini [this message]
2018-08-10 12:53           ` Peter Maydell
2018-08-10 17:06             ` Paolo Bonzini
2018-08-13  6:18           ` Thomas Huth
2018-08-13  8:01             ` Paolo Bonzini
2018-08-10  9:41       ` Markus Armbruster
2018-08-10 12:44         ` Paolo Bonzini
2018-08-10 13:19           ` Markus Armbruster
2018-08-10  6:22 ` Markus Armbruster
2018-08-10  9:07   ` Peter Maydell
2018-08-10 12:08     ` Markus Armbruster
2018-08-13  6:26 ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14a92c80-4aec-bd60-68fd-d6a68c8a63b6@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=patches@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).