From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97FEDC4363A for ; Tue, 20 Oct 2020 20:02:45 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B5EBD21BE5 for ; Tue, 20 Oct 2020 20:02:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Z1Huf/2n" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B5EBD21BE5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37966 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUxqF-0003Hc-E2 for qemu-devel@archiver.kernel.org; Tue, 20 Oct 2020 16:02:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47930) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUxp9-0002hg-7U for qemu-devel@nongnu.org; Tue, 20 Oct 2020 16:01:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:36731) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kUxp7-00049c-IW for qemu-devel@nongnu.org; Tue, 20 Oct 2020 16:01:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603224092; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=THlaDKbJEFCutmmeqfkP4Jmoe9Jej0ffnYNg0LDwHtg=; b=Z1Huf/2nFx0HR5XfGX8wzTvnUAEI2VKvfybw//Q0Hxvq0c5wIltAbNjU6mgh83Vxdsm84v AqBJYWVuq6TDiOZC47XpAkfQKODLYVCfkZ6o9iucH9SfI25wRTNrgH2ax9VztWMPPvV+Ev o0mHcje/j149B3qciFsA07JIn3NH7yI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-499-dQ7I_x4dMfaFWPbPKYAfqg-1; Tue, 20 Oct 2020 16:01:30 -0400 X-MC-Unique: dQ7I_x4dMfaFWPbPKYAfqg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A33C6803F5F; Tue, 20 Oct 2020 20:01:29 +0000 (UTC) Received: from [10.36.114.141] (ovpn-114-141.ams2.redhat.com [10.36.114.141]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6C7462C31E; Tue, 20 Oct 2020 20:01:13 +0000 (UTC) Subject: Re: [PATCH PROTOTYPE 3/6] vfio: Implement support for sparse RAM memory regions To: Peter Xu References: <20200924160423.106747-1-david@redhat.com> <20200924160423.106747-4-david@redhat.com> <20201020194434.GD200400@xz-x1> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <14aaf9f1-9aa4-3a6b-ff25-8a4c7e29c2a6@redhat.com> Date: Tue, 20 Oct 2020 22:01:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201020194434.GD200400@xz-x1> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=david@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/20 01:16:16 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Pankaj Gupta , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Luiz Capitulino , Auger Eric , Alex Williamson , Wei Yang , Igor Mammedov , Paolo Bonzini , "Dr . David Alan Gilbert" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 20.10.20 21:44, Peter Xu wrote: > On Thu, Sep 24, 2020 at 06:04:20PM +0200, David Hildenbrand wrote: >> Implement support for sparse RAM, to be used by virtio-mem. Handling >> is somewhat-similar to memory_region_is_iommu() handling, which also >> notifies on changes. >> >> Instead of mapping the whole region, we only map selected pieces (and >> unmap previously selected pieces) when notified by the SparseRAMHandler. > > It works with vIOMMU too, right? :) As long as vfio_get_vaddr() works as > expected with virtio-mem plugging new memories, then I think the answer should > be yes. > I haven't tried, but I guess as it's simply mapped into &address_space_memory, it should work just fine. > If it's true, maybe worth mention it somewhere either in the commit message or > in the code comment, because it seems not that obvious. I will test and add, thanks for the hint! > > So if you have plan to do some real IOs in your future tests, may also worth > try with the "-device intel-iommu" and intel_iommu=on in the guest against the > same test. Thanks ... but I have an AMD system. Will try to find out how to get that running with AMD :) -- Thanks, David / dhildenb