From: Laurent Vivier <laurent@vivier.eu>
To: KONRAD Frederic <frederic.konrad@adacore.com>
Cc: huth@tuxfamily.org, alex.bennee@linaro.org, f4bug@amsat.org,
qemu-devel@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
pierre@freepascal.org
Subject: Re: [PATCH v1] target/m68k: fix gdb for m68xxx
Date: Mon, 20 Apr 2020 21:59:37 +0200 [thread overview]
Message-ID: <14d2e9b5-e712-5adb-6715-3f9dba921028@vivier.eu> (raw)
In-Reply-To: <268c0a26-9ed2-4812-a985-1321e35eb00a@adacore.com>
Le 20/04/2020 à 21:08, KONRAD Frederic a écrit :
>
>
> Le 4/20/20 à 5:46 PM, Laurent Vivier a écrit :
>> Le 20/04/2020 à 16:01, frederic.konrad@adacore.com a écrit :
>>> From: KONRAD Frederic <frederic.konrad@adacore.com>
>>>
>>> Currently "cf-core.xml" is sent to GDB when using any m68k flavor.
>>> Thing is
>>> it uses the "org.gnu.gdb.coldfire.core" feature name and gdb 8.3 then
>>> expects
>>> a coldfire FPU instead of the default m68881 FPU.
>>
>>
>> I checked in gdb sources and there is no cf definition.
>>
>> Moreover if I change only the cf to m68k in QEMU it seems to work in
>> both cases:
>>
>> diff --git a/gdb-xml/cf-core.xml b/gdb-xml/cf-core.xml
>> index b90af3042c..5b092d26de 100644
>> --- a/gdb-xml/cf-core.xml
>> +++ b/gdb-xml/cf-core.xml
>> @@ -5,7 +5,7 @@
>> are permitted in any medium without royalty provided the copyright
>> notice and this notice are preserved. -->
>> <!DOCTYPE feature SYSTEM "gdb-target.dtd">
>> -<feature name="org.gnu.gdb.coldfire.core">
>> +<feature name="org.gnu.gdb.m68k.core">
>> <reg name="d0" bitsize="32"/>
>> <reg name="d1" bitsize="32"/>
>> <reg name="d2" bitsize="32"/>
>
> Doesn't that break gdb with coldfire?
No, it seems to work, but I didn't test this really carefully.
So perhaps we can only change the feature name in the two existing xml
files and it will work for all the cases? (and renaming cf-core.xml to
m68k-core.xml).
The core files are the same for cf and m68k, so according to the sample
code you show, if it finds "org.gnu.gdb.m68k.core" if will use for both.
I think the only bug we have is the feature name is not good in
m68k-fp.xml, and fixing that should be enough.
Thanks,
Laurent
next prev parent reply other threads:[~2020-04-20 20:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 14:01 [PATCH v1] target/m68k: fix gdb for m68xxx frederic.konrad
2020-04-20 14:47 ` Laurent Vivier
2020-04-20 15:46 ` Laurent Vivier
2020-04-20 19:08 ` KONRAD Frederic
2020-04-20 19:59 ` Laurent Vivier [this message]
2020-04-20 20:43 ` Laurent Vivier
2020-04-21 9:47 ` KONRAD Frederic
2020-04-21 14:08 ` Laurent Vivier
2020-04-20 16:13 ` Alex Bennée
2020-04-20 18:54 ` KONRAD Frederic
2020-04-27 7:53 ` Laurent Vivier
2020-04-28 13:19 ` KONRAD Frederic
2020-04-28 14:13 ` Laurent Vivier
2020-04-28 16:46 ` KONRAD Frederic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14d2e9b5-e712-5adb-6715-3f9dba921028@vivier.eu \
--to=laurent@vivier.eu \
--cc=alex.bennee@linaro.org \
--cc=f4bug@amsat.org \
--cc=frederic.konrad@adacore.com \
--cc=huth@tuxfamily.org \
--cc=philmd@redhat.com \
--cc=pierre@freepascal.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).