Re: [PATCH] meson: add tests option

[Paolo Bonzini <pbonzini@redhat.com>]

On 02/03/21 11:22, Thomas Huth wrote:
> On 26/02/2021 23.07, Romain Naour wrote:
>> tests/fp/fp-bench.c use fenv.h that is not always provided
>> by the libc (uClibc).
> 
> For such  problem it might be better to check for the availability of 
> the header and then to only disable the single test that depends on it 
> if the header is not available.
> 
> Anyway, a switch to disable the tests completely could still be handy in 
> some cases, so FWIW:
> 
> Acked-by: Thomas Huth <thuth@redhat.com>

I disagree, without a use case the right thing to do is to check for 
fenv.h.  It's as easy as this:

diff --git a/tests/meson.build b/tests/meson.build
index 0c939f89f7..3b9b2f0483 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -281,7 +281,7 @@ test('decodetree', sh,
       workdir: meson.current_source_dir() / 'decode',
       suite: 'decodetree')

-if 'CONFIG_TCG' in config_all
+if 'CONFIG_TCG' in config_all and cc.has_header('fenv.h')
    subdir('fp')
  endif

Thanks,

Paolo