From: Thomas Huth <thuth@redhat.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] iotests: Tweak 221 sizing for different hole granularities
Date: Tue, 7 May 2019 07:37:30 +0200 [thread overview]
Message-ID: <14ddc8ed-fc20-5434-0e0c-8519ea910777@redhat.com> (raw)
In-Reply-To: <20190506172111.31594-1-eblake@redhat.com>
On 06/05/2019 19.21, Eric Blake wrote:
> For some particular configurations of ext4, sizing an image to 84
> sectors + 1 byte causes test failures when the size of the hole is
> rounded to a 4k alignment. Let's instead size things to 128 sectors +
> 1 byte, as the 64k boundary is more likely to work with various hole
> granularities.
>
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
>
> I have been unable to reproduce Thomas' failure, but suspect that this
> will address it. If I can get a Tested-by, then I'm happy to add it
> through my NBD tree, as I have a couple other iotest fixes ready for a
> pull request.
>
> tests/qemu-iotests/221 | 10 +++++-----
> tests/qemu-iotests/221.out | 20 ++++++++++----------
> 2 files changed, 15 insertions(+), 15 deletions(-)
Thanks, this fixes the issue on my ext4 partition!
Tested-by: Thomas Huth <thuth@redhat.com>
prev parent reply other threads:[~2019-05-07 5:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 17:21 [Qemu-devel] [PATCH] iotests: Tweak 221 sizing for different hole granularities Eric Blake
2019-05-07 5:37 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14ddc8ed-fc20-5434-0e0c-8519ea910777@redhat.com \
--to=thuth@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).