From: Thomas Huth <thuth@redhat.com>
To: David Hildenbrand <david@redhat.com>,
David Miller <dmiller423@gmail.com>,
qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Cc: pasic@linux.ibm.com, borntraeger@linux.ibm.com,
farman@linux.ibm.com, cohuck@redhat.com,
richard.henderson@linaro.org
Subject: Re: [PATCH v6 4/4] tests/tcg/s390x: changed to using .insn for tests requiring z15
Date: Wed, 23 Feb 2022 12:49:47 +0100 [thread overview]
Message-ID: <14eaf7fe-78f7-438e-1502-c646965c024d@redhat.com> (raw)
In-Reply-To: <12e026c0-1c27-db38-2404-85d572ae2bd9@redhat.com>
On 23/02/2022 11.54, David Hildenbrand wrote:
> On 23.02.22 11:44, Thomas Huth wrote:
>> On 18/02/2022 00.17, David Miller wrote:
>>> Signed-off-by: David Miller <dmiller423@gmail.com>
>>> ---
>>> tests/tcg/s390x/mie3-compl.c | 21 +++++++++++----------
>>> tests/tcg/s390x/mie3-mvcrl.c | 2 +-
>>> tests/tcg/s390x/mie3-sel.c | 6 +++---
>>> 3 files changed, 15 insertions(+), 14 deletions(-)
...
>>
>> Reviewed-by: Thomas Huth <thuth@redhat.com>
>>
>> ... maybe best to squash this into the previous patch, though (I can do that
>> when picking up the patch if you agree - no need to resend for this).
>>
>
> Do we need this with my debian11 container change?
I just tried without, but this breaks on s390x hosts with older compilers,
where the TCG tests are run without a container:
https://app.travis-ci.com/github/huth/qemu/jobs/560854945#L12875
Since Ubuntu 20.04 is still a supported s390x build system for QEMU, I
assume it's best if we squash the .insn patch?
Thomas
next prev parent reply other threads:[~2022-02-23 11:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 23:17 [PATCH v6 0/4] s390x: Add partial z15 support and tests David Miller
2022-02-17 23:17 ` [PATCH v6 1/4] s390x/tcg: Implement Miscellaneous-Instruction-Extensions Facility 3 for the s390x David Miller
2022-02-23 13:40 ` Christian Borntraeger
2022-02-23 22:29 ` David Miller
2022-02-24 7:04 ` Christian Borntraeger
2022-02-23 19:40 ` Richard Henderson
2022-02-23 21:11 ` David Miller
2022-02-17 23:17 ` [PATCH v6 2/4] s390x/cpumodel: Bump up QEMU model to a stripped-down IBM z15 GA1 David Miller
2022-02-17 23:17 ` [PATCH v6 3/4] tests/tcg/s390x: Tests for Miscellaneous-Instruction-Extensions Facility 3 David Miller
2022-02-23 19:45 ` Richard Henderson
2022-02-23 20:17 ` David Miller
2022-02-17 23:17 ` [PATCH v6 4/4] tests/tcg/s390x: changed to using .insn for tests requiring z15 David Miller
2022-02-23 10:44 ` Thomas Huth
2022-02-23 10:54 ` David Hildenbrand
2022-02-23 11:49 ` Thomas Huth [this message]
2022-02-23 11:51 ` David Hildenbrand
2022-02-23 11:52 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14eaf7fe-78f7-438e-1502-c646965c024d@redhat.com \
--to=thuth@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=dmiller423@gmail.com \
--cc=farman@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).