qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] add scripts/indent.sh
Date: Mon, 17 Jul 2017 13:14:53 +0200	[thread overview]
Message-ID: <1500290093.12570.6.camel@redhat.com> (raw)
In-Reply-To: <CAJ+F1C+yg2jzSZf4PM8L=5-NBwgg25buHjTS-FBT2hF4jzpkxQ@mail.gmail.com>

On Mon, 2017-07-17 at 10:58 +0000, Marc-André Lureau wrote:
> Hi
> 
> On Mon, Jul 17, 2017 at 12:49 PM Gerd Hoffmann <kraxel@redhat.com>
> wrote:
> > On Mon, 2017-07-17 at 10:36 +0000, Marc-André Lureau wrote:
> > > Hi
> > >
> > > On Mon, Jul 17, 2017 at 12:18 PM Gerd Hoffmann <kraxel@redhat.com
> > >
> > > wrote:
> > > > Script to reformat sources in qemu style.
> > > >
> > > > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> > >
> > > A quite powerful approach would be to use clang-format: https://l
> > ists
> > > .gnu.org/archive/html/qemu-devel/2015-10/msg01278.html 
> > >
> > > It comes with a bunch of editor integration and scripts. My
> > config
> > > could use a bit more tweaking though, I haven't been using it for
> > a
> > > while, and newer version have more options.
> > 
> > Hmm, I want reformat all audio stuff to qemu code style some day,
> > the
> > current situation where patches are either break qemu code style or
> > lead to mixed-style in the audio source files isn't very good.
> > 
> > I don't mind much which tool we use for that, I picked indent
> > mostly
> > because I know that one.  If clang-format can do that too, fine
> > with
> > me.  I'm missing documentation though, there is no man-page and
> > there
> > isn't anything in /usr/share/doc/clang-3.4.2 either ...
> 
> Afaik, most of clang-tools documentation is only in html. The most
> recent version is online at
> https://clang.llvm.org/docs/ClangFormat.html &
> https://clang.llvm.org/docs/ClangFormatStyleOptions.html

Can you add those links as comments to the .clang-format file?

cheers,
  Gerd

  reply	other threads:[~2017-07-17 11:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-17 10:17 [Qemu-devel] [PATCH] add scripts/indent.sh Gerd Hoffmann
2017-07-17 10:36 ` Marc-André Lureau
2017-07-17 10:49   ` Gerd Hoffmann
2017-07-17 10:58     ` Marc-André Lureau
2017-07-17 11:14       ` Gerd Hoffmann [this message]
2017-08-29 16:33         ` Marc-André Lureau
2017-07-17 10:43 ` Peter Maydell
2017-07-17 18:11 ` no-reply
2017-07-17 19:54   ` Peter Maydell
  -- strict thread matches above, loose matches on Subject: below --
2015-09-03 10:42 Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1500290093.12570.6.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=marcandre.lureau@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).