From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55115) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dX3zM-00076C-Td for qemu-devel@nongnu.org; Mon, 17 Jul 2017 07:14:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dX3zL-00067K-Ro for qemu-devel@nongnu.org; Mon, 17 Jul 2017 07:14:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43874) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dX3zL-00065y-Ml for qemu-devel@nongnu.org; Mon, 17 Jul 2017 07:14:55 -0400 Message-ID: <1500290093.12570.6.camel@redhat.com> From: Gerd Hoffmann Date: Mon, 17 Jul 2017 13:14:53 +0200 In-Reply-To: References: <20170717101700.23552-1-kraxel@redhat.com> <1500288560.12570.3.camel@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] add scripts/indent.sh List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Marc-Andr=E9?= Lureau , qemu-devel@nongnu.org On Mon, 2017-07-17 at 10:58 +0000, Marc-Andr=C3=A9 Lureau wrote: > Hi >=20 > On Mon, Jul 17, 2017 at 12:49 PM Gerd Hoffmann > wrote: > > On Mon, 2017-07-17 at 10:36 +0000, Marc-Andr=C3=A9 Lureau wrote: > > > Hi > > > > > > On Mon, Jul 17, 2017 at 12:18 PM Gerd Hoffmann > > > > > wrote: > > > > Script to reformat sources in qemu style. > > > > > > > > Signed-off-by: Gerd Hoffmann > > > > > > A quite powerful approach would be to use clang-format: https://l > > ists > > > .gnu.org/archive/html/qemu-devel/2015-10/msg01278.html=C2=A0 > > > > > > It comes with a bunch of editor integration and scripts. My > > config > > > could use a bit more tweaking though, I haven't been using it for > > a > > > while, and newer version have more options. > >=20 > > Hmm, I want reformat all audio stuff to qemu code style some day, > > the > > current situation where patches are either break qemu code style or > > lead to mixed-style in the audio source files isn't very good. > >=20 > > I don't mind much which tool we use for that, I picked indent > > mostly > > because I know that one.=C2=A0 If clang-format can do that too, fine > > with > > me.=C2=A0 I'm missing documentation though, there is no man-page and > > there > > isn't anything in /usr/share/doc/clang-3.4.2 either ... >=20 > Afaik, most of clang-tools documentation is only in html. The most > recent version is online at > https://clang.llvm.org/docs/ClangFormat.html & > https://clang.llvm.org/docs/ClangFormatStyleOptions.html Can you add those links as comments to the .clang-format file? cheers, Gerd