[Qemu-devel] [PATCH for-2.10 00/10] Correct two minor QMP interface design flaws

qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed

* [Qemu-devel] [PATCH for-2.10 00/10] Correct two minor QMP interface design flaws
@ 2017-07-18 13:41 Markus Armbruster
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 01/10] qapi: Separate type QNull from QObject Markus Armbruster
                   ` (11 more replies)
  0 siblings, 12 replies; 54+ messages in thread
From: Markus Armbruster @ 2017-07-18 13:41 UTC (permalink / raw)
  To: qemu-devel
  Cc: eblake, berrange, kwolf, mreitz, qemu-block, quintela, dgilbert

blockdev-add and migrate-set-parameters overload empty strings to mean
something entirely different.  See my memo "qapi: Stop abusing
"special" values for something entirely different" for details.

    Message-ID: <87379zhrhn.fsf@dusky.pond.sub.org>
    https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg04526.html

This series deprecates these usages of "" in favour of JSON null.
Because we're so close to the 2.10 freeze, the implementation is
intentionally stupid: rewrite null to "" at first opportunity.  The
proper way to do it would be rewriting "" to null, but that requires
fixing up code to work with null.  There are TODO comments for that.
I'm willing to take care of them in the next development cycle.

Markus Armbruster (10):
  qapi: Separate type QNull from QObject
  qapi: Use QNull for a more regular visit_type_null()
  qapi: Introduce a first class 'null' type
  tests/test-qobject-input-visitor: Drop redundant test
  block: Use JSON null instead of "" to disable backing file
  hmp: Clean up and simplify hmp_migrate_set_parameter()
  migration: Clean up around tls_creds, tls_hostname
  migration: Add TODO comments on duplication of QAPI_CLONE()
  migration: Unshare MigrationParameters struct for now
  migration: Use JSON null instead of "" to reset parameter to default

 blockdev.c                              | 14 +++++
 hmp.c                                   | 88 +++++++++++++----------------
 hw/ppc/spapr_drc.c                      |  4 +-
 include/qapi/qmp/qobject.h              | 10 +++-
 include/qapi/visitor-impl.h             |  3 +-
 include/qapi/visitor.h                  |  8 +--
 include/qemu/typedefs.h                 |  1 +
 migration/migration.c                   | 34 ++++++++---
 qapi-schema.json                        | 99 +++++++++++++++++++++++++++++----
 qapi/block-core.json                    | 29 +++++++---
 qapi/qapi-clone-visitor.c               |  5 +-
 qapi/qapi-dealloc-visitor.c             |  6 +-
 qapi/qapi-visit-core.c                  |  7 ++-
 qapi/qobject-input-visitor.c            |  6 +-
 qapi/qobject-output-visitor.c           |  5 +-
 qapi/string-input-visitor.c             |  8 ++-
 qapi/string-output-visitor.c            |  3 +-
 qapi/trace-events                       |  2 +-
 qobject/json-parser.c                   |  2 +-
 qobject/qnull.c                         |  8 ++-
 scripts/qapi.py                         |  5 +-
 target/i386/cpu.c                       |  4 +-
 tests/check-qjson.c                     |  6 +-
 tests/check-qnull.c                     | 27 +++++----
 tests/qapi-schema/qapi-schema-test.json |  3 +-
 tests/qapi-schema/qapi-schema-test.out  |  1 +
 tests/qemu-iotests/085                  |  2 +-
 tests/qemu-iotests/139                  |  2 +-
 tests/test-qobject-input-visitor.c      | 24 ++++----
 tests/test-qobject-output-visitor.c     | 13 ++++-
 30 files changed, 299 insertions(+), 130 deletions(-)

-- 
2.7.5

^ permalink raw reply	[flat|nested] 54+ messages in thread

* [Qemu-devel] [PATCH for-2.10 01/10] qapi: Separate type QNull from QObject
  2017-07-18 13:41 [Qemu-devel] [PATCH for-2.10 00/10] Correct two minor QMP interface design flaws Markus Armbruster
@ 2017-07-18 13:41 ` Markus Armbruster
  2017-07-18 14:24   ` Eric Blake
  2017-07-18 15:44   ` Daniel P. Berrange
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 02/10] qapi: Use QNull for a more regular visit_type_null() Markus Armbruster
                   ` (10 subsequent siblings)
  11 siblings, 2 replies; 54+ messages in thread
From: Markus Armbruster @ 2017-07-18 13:41 UTC (permalink / raw)
  To: qemu-devel
  Cc: eblake, berrange, kwolf, mreitz, qemu-block, quintela, dgilbert

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 include/qapi/qmp/qobject.h    | 10 +++++++---
 qapi/qobject-output-visitor.c |  2 +-
 qobject/json-parser.c         |  2 +-
 qobject/qnull.c               |  8 +++++---
 target/i386/cpu.c             |  4 ++--
 tests/check-qjson.c           |  6 +++---
 tests/check-qnull.c           | 18 +++++++++---------
 7 files changed, 28 insertions(+), 22 deletions(-)

diff --git a/include/qapi/qmp/qobject.h b/include/qapi/qmp/qobject.h
index b8ddbca..3543b55 100644
--- a/include/qapi/qmp/qobject.h
+++ b/include/qapi/qmp/qobject.h
@@ -93,11 +93,15 @@ static inline QType qobject_type(const QObject *obj)
     return obj->type;
 }
 
-extern QObject qnull_;
+typedef struct QNull {
+    QObject base;
+} QNull;
 
-static inline QObject *qnull(void)
+extern QNull qnull_;
+
+static inline QNull *qnull(void)
 {
-    qobject_incref(&qnull_);
+    QINCREF(&qnull_);
     return &qnull_;
 }
 
diff --git a/qapi/qobject-output-visitor.c b/qapi/qobject-output-visitor.c
index 70be84c..398dcb5 100644
--- a/qapi/qobject-output-visitor.c
+++ b/qapi/qobject-output-visitor.c
@@ -190,7 +190,7 @@ static void qobject_output_type_any(Visitor *v, const char *name,
 static void qobject_output_type_null(Visitor *v, const char *name, Error **errp)
 {
     QObjectOutputVisitor *qov = to_qov(v);
-    qobject_output_add_obj(qov, name, qnull());
+    qobject_output_add(qov, name, qnull());
 }
 
 /* Finish building, and return the root object.
diff --git a/qobject/json-parser.c b/qobject/json-parser.c
index 7a417f2..724ca24 100644
--- a/qobject/json-parser.c
+++ b/qobject/json-parser.c
@@ -445,7 +445,7 @@ static QObject *parse_keyword(JSONParserContext *ctxt)
     } else if (!strcmp(token->str, "false")) {
         return QOBJECT(qbool_from_bool(false));
     } else if (!strcmp(token->str, "null")) {
-        return qnull();
+        return QOBJECT(qnull());
     }
     parse_error(ctxt, token, "invalid keyword '%s'", token->str);
     return NULL;
diff --git a/qobject/qnull.c b/qobject/qnull.c
index c124d05..69a21d1 100644
--- a/qobject/qnull.c
+++ b/qobject/qnull.c
@@ -14,7 +14,9 @@
 #include "qemu-common.h"
 #include "qapi/qmp/qobject.h"
 
-QObject qnull_ = {
-    .type = QTYPE_QNULL,
-    .refcnt = 1,
+QNull qnull_ = {
+    .base = {
+        .type = QTYPE_QNULL,
+        .refcnt = 1,
+    },
 };
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index c571772..10e8386 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -2394,7 +2394,7 @@ static QDict *x86_cpu_static_props(void)
 
     d = qdict_new();
     for (i = 0; props[i]; i++) {
-        qdict_put_obj(d, props[i], qnull());
+        qdict_put(d, props[i], qnull());
     }
 
     for (w = 0; w < FEATURE_WORDS; w++) {
@@ -2404,7 +2404,7 @@ static QDict *x86_cpu_static_props(void)
             if (!fi->feat_names[bit]) {
                 continue;
             }
-            qdict_put_obj(d, fi->feat_names[bit], qnull());
+            qdict_put(d, fi->feat_names[bit], qnull());
         }
     }
 
diff --git a/tests/check-qjson.c b/tests/check-qjson.c
index 53f2275..a3a97b0 100644
--- a/tests/check-qjson.c
+++ b/tests/check-qjson.c
@@ -1012,7 +1012,7 @@ static void keyword_literal(void)
 {
     QObject *obj;
     QBool *qbool;
-    QObject *null;
+    QNull *null;
     QString *str;
 
     obj = qobject_from_json("true", &error_abort);
@@ -1053,10 +1053,10 @@ static void keyword_literal(void)
     g_assert(qobject_type(obj) == QTYPE_QNULL);
 
     null = qnull();
-    g_assert(null == obj);
+    g_assert(QOBJECT(null) == obj);
 
     qobject_decref(obj);
-    qobject_decref(null);
+    QDECREF(null);
 }
 
 typedef struct LiteralQDictEntry LiteralQDictEntry;
diff --git a/tests/check-qnull.c b/tests/check-qnull.c
index 8dd1c96..1ab7c98 100644
--- a/tests/check-qnull.c
+++ b/tests/check-qnull.c
@@ -24,14 +24,14 @@ static void qnull_ref_test(void)
 {
     QObject *obj;
 
-    g_assert(qnull_.refcnt == 1);
-    obj = qnull();
+    g_assert(qnull_.base.refcnt == 1);
+    obj = QOBJECT(qnull());
     g_assert(obj);
-    g_assert(obj == &qnull_);
-    g_assert(qnull_.refcnt == 2);
+    g_assert(obj == QOBJECT(&qnull_));
+    g_assert(qnull_.base.refcnt == 2);
     g_assert(qobject_type(obj) == QTYPE_QNULL);
     qobject_decref(obj);
-    g_assert(qnull_.refcnt == 1);
+    g_assert(qnull_.base.refcnt == 1);
 }
 
 static void qnull_visit_test(void)
@@ -45,8 +45,8 @@ static void qnull_visit_test(void)
      * depend on layering violations to check qnull_ refcnt.
      */
 
-    g_assert(qnull_.refcnt == 1);
-    obj = qnull();
+    g_assert(qnull_.base.refcnt == 1);
+    obj = QOBJECT(qnull());
     v = qobject_input_visitor_new(obj);
     qobject_decref(obj);
     visit_type_null(v, NULL, &error_abort);
@@ -55,11 +55,11 @@ static void qnull_visit_test(void)
     v = qobject_output_visitor_new(&obj);
     visit_type_null(v, NULL, &error_abort);
     visit_complete(v, &obj);
-    g_assert(obj == &qnull_);
+    g_assert(obj == QOBJECT(&qnull_));
     qobject_decref(obj);
     visit_free(v);
 
-    g_assert(qnull_.refcnt == 1);
+    g_assert(qnull_.base.refcnt == 1);
 }
 
 int main(int argc, char **argv)
-- 
2.7.5

^ permalink raw reply related	[flat|nested] 54+ messages in thread

* [Qemu-devel] [PATCH for-2.10 02/10] qapi: Use QNull for a more regular visit_type_null()
  2017-07-18 13:41 [Qemu-devel] [PATCH for-2.10 00/10] Correct two minor QMP interface design flaws Markus Armbruster
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 01/10] qapi: Separate type QNull from QObject Markus Armbruster
@ 2017-07-18 13:41 ` Markus Armbruster
  2017-07-18 14:36   ` Eric Blake
  2017-07-18 15:46   ` Daniel P. Berrange
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 03/10] qapi: Introduce a first class 'null' type Markus Armbruster
                   ` (9 subsequent siblings)
  11 siblings, 2 replies; 54+ messages in thread
From: Markus Armbruster @ 2017-07-18 13:41 UTC (permalink / raw)
  To: qemu-devel
  Cc: eblake, berrange, kwolf, mreitz, qemu-block, quintela, dgilbert

Make visit_type_null() take an @obj argument like its buddies.  This
helps keeing the next commit simple.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 hw/ppc/spapr_drc.c                  |  4 +++-
 include/qapi/visitor-impl.h         |  3 ++-
 include/qapi/visitor.h              |  8 ++++----
 qapi/qapi-clone-visitor.c           |  5 +++--
 qapi/qapi-dealloc-visitor.c         |  6 +++++-
 qapi/qapi-visit-core.c              |  7 ++++---
 qapi/qobject-input-visitor.c        |  6 +++++-
 qapi/qobject-output-visitor.c       |  3 ++-
 qapi/string-input-visitor.c         |  8 +++++++-
 qapi/string-output-visitor.c        |  3 ++-
 qapi/trace-events                   |  2 +-
 tests/check-qnull.c                 |  9 +++++++--
 tests/test-qobject-input-visitor.c  | 13 +++++++++----
 tests/test-qobject-output-visitor.c |  3 ++-
 14 files changed, 56 insertions(+), 24 deletions(-)

diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c
index f34355d..169ab0b 100644
--- a/hw/ppc/spapr_drc.c
+++ b/hw/ppc/spapr_drc.c
@@ -267,12 +267,14 @@ static void prop_get_fdt(Object *obj, Visitor *v, const char *name,
                          void *opaque, Error **errp)
 {
     sPAPRDRConnector *drc = SPAPR_DR_CONNECTOR(obj);
+    QNull *null;
     Error *err = NULL;
     int fdt_offset_next, fdt_offset, fdt_depth;
     void *fdt;
 
     if (!drc->fdt) {
-        visit_type_null(v, NULL, errp);
+        visit_type_null(v, NULL, &null, errp);
+        QDECREF(null);
         return;
     }
 
diff --git a/include/qapi/visitor-impl.h b/include/qapi/visitor-impl.h
index dcd656a..8ccb3b6 100644
--- a/include/qapi/visitor-impl.h
+++ b/include/qapi/visitor-impl.h
@@ -103,7 +103,8 @@ struct Visitor
                      Error **errp);
 
     /* Must be set to visit explicit null values.  */
-    void (*type_null)(Visitor *v, const char *name, Error **errp);
+    void (*type_null)(Visitor *v, const char *name, QNull **obj,
+                      Error **errp);
 
     /* Must be set for input visitors to visit structs, optional otherwise.
        The core takes care of the return type in the public interface. */
diff --git a/include/qapi/visitor.h b/include/qapi/visitor.h
index 74768aa..fe9faf4 100644
--- a/include/qapi/visitor.h
+++ b/include/qapi/visitor.h
@@ -618,10 +618,10 @@ void visit_type_any(Visitor *v, const char *name, QObject **obj, Error **errp);
  * @name expresses the relationship of the null value to its parent
  * container; see the general description of @name above.
  *
- * Unlike all other visit_type_* functions, no obj parameter is
- * needed; rather, this is a witness that an explicit null value is
- * expected rather than any other type.
+ * @obj must be non-NULL.  Input visitors set *@obj to the value;
+ * other visitors ignore *@obj.
  */
-void visit_type_null(Visitor *v, const char *name, Error **errp);
+void visit_type_null(Visitor *v, const char *name, QNull **obj,
+                     Error **errp);
 
 #endif
diff --git a/qapi/qapi-clone-visitor.c b/qapi/qapi-clone-visitor.c
index ed16d3a..d8b6279 100644
--- a/qapi/qapi-clone-visitor.c
+++ b/qapi/qapi-clone-visitor.c
@@ -127,12 +127,13 @@ static void qapi_clone_type_number(Visitor *v, const char *name, double *obj,
     /* Value was already cloned by g_memdup() */
 }
 
-static void qapi_clone_type_null(Visitor *v, const char *name, Error **errp)
+static void qapi_clone_type_null(Visitor *v, const char *name, QNull **obj,
+                                 Error **errp)
 {
     QapiCloneVisitor *qcv = to_qcv(v);
 
     assert(qcv->depth);
-    /* Nothing to do */
+    *obj = qnull();
 }
 
 static void qapi_clone_free(Visitor *v)
diff --git a/qapi/qapi-dealloc-visitor.c b/qapi/qapi-dealloc-visitor.c
index fd6f9fb..ed70a01 100644
--- a/qapi/qapi-dealloc-visitor.c
+++ b/qapi/qapi-dealloc-visitor.c
@@ -103,8 +103,12 @@ static void qapi_dealloc_type_anything(Visitor *v, const char *name,
     }
 }
 
-static void qapi_dealloc_type_null(Visitor *v, const char *name, Error **errp)
+static void qapi_dealloc_type_null(Visitor *v, const char *name,
+                                   QNull **obj, Error **errp)
 {
+    if (obj) {
+        QDECREF(*obj);
+    }
 }
 
 static void qapi_dealloc_free(Visitor *v)
diff --git a/qapi/qapi-visit-core.c b/qapi/qapi-visit-core.c
index 935a2c5..ed6d2af 100644
--- a/qapi/qapi-visit-core.c
+++ b/qapi/qapi-visit-core.c
@@ -325,10 +325,11 @@ void visit_type_any(Visitor *v, const char *name, QObject **obj, Error **errp)
     error_propagate(errp, err);
 }
 
-void visit_type_null(Visitor *v, const char *name, Error **errp)
+void visit_type_null(Visitor *v, const char *name, QNull **obj,
+                     Error **errp)
 {
-    trace_visit_type_null(v, name);
-    v->type_null(v, name, errp);
+    trace_visit_type_null(v, name, obj);
+    v->type_null(v, name, obj, errp);
 }
 
 static void output_type_enum(Visitor *v, const char *name, int *obj,
diff --git a/qapi/qobject-input-visitor.c b/qapi/qobject-input-visitor.c
index 35aff78..ee9e47d 100644
--- a/qapi/qobject-input-visitor.c
+++ b/qapi/qobject-input-visitor.c
@@ -587,11 +587,13 @@ static void qobject_input_type_any(Visitor *v, const char *name, QObject **obj,
     *obj = qobj;
 }
 
-static void qobject_input_type_null(Visitor *v, const char *name, Error **errp)
+static void qobject_input_type_null(Visitor *v, const char *name,
+                                    QNull **obj, Error **errp)
 {
     QObjectInputVisitor *qiv = to_qiv(v);
     QObject *qobj = qobject_input_get_object(qiv, name, true, errp);
 
+    *obj = NULL;
     if (!qobj) {
         return;
     }
@@ -599,7 +601,9 @@ static void qobject_input_type_null(Visitor *v, const char *name, Error **errp)
     if (qobject_type(qobj) != QTYPE_QNULL) {
         error_setg(errp, QERR_INVALID_PARAMETER_TYPE,
                    full_name(qiv, name), "null");
+        return;
     }
+    *obj = qnull();
 }
 
 static void qobject_input_type_size_keyval(Visitor *v, const char *name,
diff --git a/qapi/qobject-output-visitor.c b/qapi/qobject-output-visitor.c
index 398dcb5..d325163 100644
--- a/qapi/qobject-output-visitor.c
+++ b/qapi/qobject-output-visitor.c
@@ -187,7 +187,8 @@ static void qobject_output_type_any(Visitor *v, const char *name,
     qobject_output_add_obj(qov, name, *obj);
 }
 
-static void qobject_output_type_null(Visitor *v, const char *name, Error **errp)
+static void qobject_output_type_null(Visitor *v, const char *name,
+                                     QNull **obj, Error **errp)
 {
     QObjectOutputVisitor *qov = to_qov(v);
     qobject_output_add(qov, name, qnull());
diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visitor.c
index 63ae115..67a0a4a 100644
--- a/qapi/string-input-visitor.c
+++ b/qapi/string-input-visitor.c
@@ -326,14 +326,20 @@ static void parse_type_number(Visitor *v, const char *name, double *obj,
     *obj = val;
 }
 
-static void parse_type_null(Visitor *v, const char *name, Error **errp)
+static void parse_type_null(Visitor *v, const char *name, QNull **obj,
+                            Error **errp)
 {
     StringInputVisitor *siv = to_siv(v);
 
+    *obj = NULL;
+
     if (!siv->string || siv->string[0]) {
         error_setg(errp, QERR_INVALID_PARAMETER_TYPE, name ? name : "null",
                    "null");
+        return;
     }
+
+    *obj = qnull();
 }
 
 static void string_input_free(Visitor *v)
diff --git a/qapi/string-output-visitor.c b/qapi/string-output-visitor.c
index af649e1..7ab6446 100644
--- a/qapi/string-output-visitor.c
+++ b/qapi/string-output-visitor.c
@@ -256,7 +256,8 @@ static void print_type_number(Visitor *v, const char *name, double *obj,
     string_output_set(sov, g_strdup_printf("%f", *obj));
 }
 
-static void print_type_null(Visitor *v, const char *name, Error **errp)
+static void print_type_null(Visitor *v, const char *name, QNull **obj,
+                            Error **errp)
 {
     StringOutputVisitor *sov = to_sov(v);
     char *out;
diff --git a/qapi/trace-events b/qapi/trace-events
index 3b57aba..9e9008a 100644
--- a/qapi/trace-events
+++ b/qapi/trace-events
@@ -31,4 +31,4 @@ visit_type_bool(void *v, const char *name, bool *obj) "v=%p name=%s obj=%p"
 visit_type_str(void *v, const char *name, char **obj) "v=%p name=%s obj=%p"
 visit_type_number(void *v, const char *name, double *obj) "v=%p name=%s obj=%p"
 visit_type_any(void *v, const char *name, void *obj) "v=%p name=%s obj=%p"
-visit_type_null(void *v, const char *name) "v=%p name=%s"
+visit_type_null(void *v, const char *name, void *obj) "v=%p name=%s obj=%p"
diff --git a/tests/check-qnull.c b/tests/check-qnull.c
index 1ab7c98..5c6eb0a 100644
--- a/tests/check-qnull.c
+++ b/tests/check-qnull.c
@@ -38,6 +38,7 @@ static void qnull_visit_test(void)
 {
     QObject *obj;
     Visitor *v;
+    QNull *null;
 
     /*
      * Most tests of interactions between QObject and visitors are in
@@ -49,13 +50,17 @@ static void qnull_visit_test(void)
     obj = QOBJECT(qnull());
     v = qobject_input_visitor_new(obj);
     qobject_decref(obj);
-    visit_type_null(v, NULL, &error_abort);
+    visit_type_null(v, NULL, &null, &error_abort);
+    g_assert(obj == QOBJECT(&qnull_));
+    QDECREF(null);
     visit_free(v);
 
+    null = NULL;
     v = qobject_output_visitor_new(&obj);
-    visit_type_null(v, NULL, &error_abort);
+    visit_type_null(v, NULL, &null, &error_abort);
     visit_complete(v, &obj);
     g_assert(obj == QOBJECT(&qnull_));
+    QDECREF(null);
     qobject_decref(obj);
     visit_free(v);
 
diff --git a/tests/test-qobject-input-visitor.c b/tests/test-qobject-input-visitor.c
index 34bab8a..f98caf9 100644
--- a/tests/test-qobject-input-visitor.c
+++ b/tests/test-qobject-input-visitor.c
@@ -510,6 +510,7 @@ static void test_visitor_in_null(TestInputVisitorData *data,
 {
     Visitor *v;
     Error *err = NULL;
+    QNull *null;
     char *tmp;
 
     /*
@@ -524,12 +525,15 @@ static void test_visitor_in_null(TestInputVisitorData *data,
     v = visitor_input_test_init_full(data, false,
                                      "{ 'a': null, 'b': '' }");
     visit_start_struct(v, NULL, NULL, 0, &error_abort);
-    visit_type_null(v, "a", &error_abort);
-    visit_type_null(v, "b", &err);
+    visit_type_null(v, "a", &null, &error_abort);
+    g_assert(qobject_type(QOBJECT(null)) == QTYPE_QNULL);
+    QDECREF(null);
+    visit_type_null(v, "b", &null, &err);
     error_free_or_abort(&err);
+    g_assert(!null);
     visit_type_str(v, "c", &tmp, &err);
-    g_assert(!tmp);
     error_free_or_abort(&err);
+    g_assert(!tmp);
     visit_check_struct(v, &error_abort);
     visit_end_struct(v, NULL);
 }
@@ -1087,6 +1091,7 @@ static void test_visitor_in_fail_struct_missing(TestInputVisitorData *data,
     Error *err = NULL;
     Visitor *v;
     QObject *any;
+    QNull *null;
     GenericAlternate *alt;
     bool present;
     int en;
@@ -1120,7 +1125,7 @@ static void test_visitor_in_fail_struct_missing(TestInputVisitorData *data,
     error_free_or_abort(&err);
     visit_type_any(v, "any", &any, &err);
     error_free_or_abort(&err);
-    visit_type_null(v, "null", &err);
+    visit_type_null(v, "null", &null, &err);
     error_free_or_abort(&err);
     visit_start_list(v, "sub", NULL, 0, &error_abort);
     visit_start_struct(v, NULL, NULL, 0, &error_abort);
diff --git a/tests/test-qobject-output-visitor.c b/tests/test-qobject-output-visitor.c
index 749c540..8f1fcd4 100644
--- a/tests/test-qobject-output-visitor.c
+++ b/tests/test-qobject-output-visitor.c
@@ -445,11 +445,12 @@ static void test_visitor_out_alternate(TestOutputVisitorData *data,
 static void test_visitor_out_null(TestOutputVisitorData *data,
                                   const void *unused)
 {
+    QNull *null = NULL;
     QDict *qdict;
     QObject *nil;
 
     visit_start_struct(data->ov, NULL, NULL, 0, &error_abort);
-    visit_type_null(data->ov, "a", &error_abort);
+    visit_type_null(data->ov, "a", &null, &error_abort);
     visit_check_struct(data->ov, &error_abort);
     visit_end_struct(data->ov, NULL);
     qdict = qobject_to_qdict(visitor_get(data));
-- 
2.7.5

^ permalink raw reply related	[flat|nested] 54+ messages in thread

* [Qemu-devel] [PATCH for-2.10 03/10] qapi: Introduce a first class 'null' type
  2017-07-18 13:41 [Qemu-devel] [PATCH for-2.10 00/10] Correct two minor QMP interface design flaws Markus Armbruster
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 01/10] qapi: Separate type QNull from QObject Markus Armbruster
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 02/10] qapi: Use QNull for a more regular visit_type_null() Markus Armbruster
@ 2017-07-18 13:41 ` Markus Armbruster
  2017-07-18 14:53   ` Eric Blake
  2017-07-18 15:47   ` Daniel P. Berrange
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 04/10] tests/test-qobject-input-visitor: Drop redundant test Markus Armbruster
                   ` (8 subsequent siblings)
  11 siblings, 2 replies; 54+ messages in thread
From: Markus Armbruster @ 2017-07-18 13:41 UTC (permalink / raw)
  To: qemu-devel
  Cc: eblake, berrange, kwolf, mreitz, qemu-block, quintela, dgilbert

I expect the 'null' type to be useful mostly for members of alternate
types.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 include/qapi/qmp/qobject.h              |  4 ++--
 include/qemu/typedefs.h                 |  1 +
 scripts/qapi.py                         |  5 ++++-
 tests/qapi-schema/qapi-schema-test.json |  3 ++-
 tests/qapi-schema/qapi-schema-test.out  |  1 +
 tests/test-qobject-input-visitor.c      |  5 +++++
 tests/test-qobject-output-visitor.c     | 10 ++++++++++
 7 files changed, 25 insertions(+), 4 deletions(-)

diff --git a/include/qapi/qmp/qobject.h b/include/qapi/qmp/qobject.h
index 3543b55..eab29ed 100644
--- a/include/qapi/qmp/qobject.h
+++ b/include/qapi/qmp/qobject.h
@@ -93,9 +93,9 @@ static inline QType qobject_type(const QObject *obj)
     return obj->type;
 }
 
-typedef struct QNull {
+struct QNull {
     QObject base;
-} QNull;
+};
 
 extern QNull qnull_;
 
diff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h
index 2706aab..ba69bd8 100644
--- a/include/qemu/typedefs.h
+++ b/include/qemu/typedefs.h
@@ -87,6 +87,7 @@ typedef struct QEMUSGList QEMUSGList;
 typedef struct QEMUTimer QEMUTimer;
 typedef struct QEMUTimerListGroup QEMUTimerListGroup;
 typedef struct QObject QObject;
+typedef struct QNull QNull;
 typedef struct RAMBlock RAMBlock;
 typedef struct Range Range;
 typedef struct SerialState SerialState;
diff --git a/scripts/qapi.py b/scripts/qapi.py
index 84e2eb4..8aa2775 100644
--- a/scripts/qapi.py
+++ b/scripts/qapi.py
@@ -20,6 +20,7 @@ import sys
 from ordereddict import OrderedDict
 
 builtin_types = {
+    'null':     'QTYPE_QNULL',
     'str':      'QTYPE_QSTRING',
     'int':      'QTYPE_QNUM',
     'number':   'QTYPE_QNUM',
@@ -1056,6 +1057,7 @@ class QAPISchemaType(QAPISchemaEntity):
 
     def alternate_qtype(self):
         json2qtype = {
+            'null':    'QTYPE_QNULL',
             'string':  'QTYPE_QSTRING',
             'number':  'QTYPE_QNUM',
             'int':     'QTYPE_QNUM',
@@ -1515,7 +1517,8 @@ class QAPISchema(object):
                   ('uint64', 'int',     'uint64_t'),
                   ('size',   'int',     'uint64_t'),
                   ('bool',   'boolean', 'bool'),
-                  ('any',    'value',   'QObject' + pointer_suffix)]:
+                  ('any',    'value',   'QObject' + pointer_suffix),
+                  ('null',   'null',    'QNull' + pointer_suffix)]:
             self._def_builtin_type(*t)
         self.the_empty_object_type = QAPISchemaObjectType(
             'q_empty', None, None, None, [], None)
diff --git a/tests/qapi-schema/qapi-schema-test.json b/tests/qapi-schema/qapi-schema-test.json
index 91ffb26..c72dbd8 100644
--- a/tests/qapi-schema/qapi-schema-test.json
+++ b/tests/qapi-schema/qapi-schema-test.json
@@ -93,7 +93,8 @@
 { 'struct': 'WrapAlternate',
   'data': { 'alt': 'UserDefAlternate' } }
 { 'alternate': 'UserDefAlternate',
-  'data': { 'udfu': 'UserDefFlatUnion', 'e': 'EnumOne', 'i': 'int' } }
+  'data': { 'udfu': 'UserDefFlatUnion', 'e': 'EnumOne', 'i': 'int',
+            'n': 'null' } }
 
 { 'struct': 'UserDefC',
   'data': { 'string1': 'str', 'string2': 'str' } }
diff --git a/tests/qapi-schema/qapi-schema-test.out b/tests/qapi-schema/qapi-schema-test.out
index b88b8aa..3b1e908 100644
--- a/tests/qapi-schema/qapi-schema-test.out
+++ b/tests/qapi-schema/qapi-schema-test.out
@@ -64,6 +64,7 @@ alternate UserDefAlternate
     case udfu: UserDefFlatUnion
     case e: EnumOne
     case i: int
+    case n: null
 object UserDefB
     member intb: int optional=False
     member a-b: bool optional=True
diff --git a/tests/test-qobject-input-visitor.c b/tests/test-qobject-input-visitor.c
index f98caf9..f451844 100644
--- a/tests/test-qobject-input-visitor.c
+++ b/tests/test-qobject-input-visitor.c
@@ -583,6 +583,11 @@ static void test_visitor_in_alternate(TestInputVisitorData *data,
     g_assert_cmpint(tmp->u.e, ==, ENUM_ONE_VALUE1);
     qapi_free_UserDefAlternate(tmp);
 
+    v = visitor_input_test_init(data, "null");
+    visit_type_UserDefAlternate(v, NULL, &tmp, &error_abort);
+    g_assert_cmpint(tmp->type, ==, QTYPE_QNULL);
+    qapi_free_UserDefAlternate(tmp);
+
     v = visitor_input_test_init(data, "{'integer':1, 'string':'str', "
                                 "'enum1':'value1', 'boolean':true}");
     visit_type_UserDefAlternate(v, NULL, &tmp, &error_abort);
diff --git a/tests/test-qobject-output-visitor.c b/tests/test-qobject-output-visitor.c
index 8f1fcd4..7eb1620 100644
--- a/tests/test-qobject-output-visitor.c
+++ b/tests/test-qobject-output-visitor.c
@@ -424,6 +424,16 @@ static void test_visitor_out_alternate(TestOutputVisitorData *data,
 
     visitor_reset(data);
     tmp = g_new0(UserDefAlternate, 1);
+    tmp->type = QTYPE_QNULL;
+    tmp->u.n = qnull();
+
+    visit_type_UserDefAlternate(data->ov, NULL, &tmp, &error_abort);
+    g_assert_cmpint(qobject_type(visitor_get(data)), ==, QTYPE_QNULL);
+
+    qapi_free_UserDefAlternate(tmp);
+
+    visitor_reset(data);
+    tmp = g_new0(UserDefAlternate, 1);
     tmp->type = QTYPE_QDICT;
     tmp->u.udfu.integer = 1;
     tmp->u.udfu.string = g_strdup("str");
-- 
2.7.5

^ permalink raw reply related	[flat|nested] 54+ messages in thread

* [Qemu-devel] [PATCH for-2.10 04/10] tests/test-qobject-input-visitor: Drop redundant test
  2017-07-18 13:41 [Qemu-devel] [PATCH for-2.10 00/10] Correct two minor QMP interface design flaws Markus Armbruster
                   ` (2 preceding siblings ...)
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 03/10] qapi: Introduce a first class 'null' type Markus Armbruster
@ 2017-07-18 13:41 ` Markus Armbruster
  2017-07-18 15:13   ` Eric Blake
  2017-07-18 15:47   ` Daniel P. Berrange
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 05/10] block: Use JSON null instead of "" to disable backing file Markus Armbruster
                   ` (7 subsequent siblings)
  11 siblings, 2 replies; 54+ messages in thread
From: Markus Armbruster @ 2017-07-18 13:41 UTC (permalink / raw)
  To: qemu-devel
  Cc: eblake, berrange, kwolf, mreitz, qemu-block, quintela, dgilbert

test_visitor_in_alternate() tests UserDefAlternate with inadmissible
input.  test_visitor_in_fail_alternate() does basically the same.
Drop the former, keep the latter.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 tests/test-qobject-input-visitor.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/tests/test-qobject-input-visitor.c b/tests/test-qobject-input-visitor.c
index f451844..bcf0261 100644
--- a/tests/test-qobject-input-visitor.c
+++ b/tests/test-qobject-input-visitor.c
@@ -567,7 +567,6 @@ static void test_visitor_in_alternate(TestInputVisitorData *data,
                                       const void *unused)
 {
     Visitor *v;
-    Error *err = NULL;
     UserDefAlternate *tmp;
     WrapAlternate *wrap;
 
@@ -599,11 +598,6 @@ static void test_visitor_in_alternate(TestInputVisitorData *data,
     g_assert_cmpint(tmp->u.udfu.u.value1.has_a_b, ==, false);
     qapi_free_UserDefAlternate(tmp);
 
-    v = visitor_input_test_init(data, "false");
-    visit_type_UserDefAlternate(v, NULL, &tmp, &err);
-    error_free_or_abort(&err);
-    qapi_free_UserDefAlternate(tmp);
-
     v = visitor_input_test_init(data, "{ 'alt': 42 }");
     visit_type_WrapAlternate(v, NULL, &wrap, &error_abort);
     g_assert_cmpint(wrap->alt->type, ==, QTYPE_QNUM);
-- 
2.7.5

^ permalink raw reply related	[flat|nested] 54+ messages in thread

* [Qemu-devel] [PATCH for-2.10 05/10] block: Use JSON null instead of "" to disable backing file
  2017-07-18 13:41 [Qemu-devel] [PATCH for-2.10 00/10] Correct two minor QMP interface design flaws Markus Armbruster
                   ` (3 preceding siblings ...)
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 04/10] tests/test-qobject-input-visitor: Drop redundant test Markus Armbruster
@ 2017-07-18 13:41 ` Markus Armbruster
  2017-07-18 15:53   ` Daniel P. Berrange
  2017-07-18 17:27   ` Eric Blake
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 06/10] hmp: Clean up and simplify hmp_migrate_set_parameter() Markus Armbruster
                   ` (6 subsequent siblings)
  11 siblings, 2 replies; 54+ messages in thread
From: Markus Armbruster @ 2017-07-18 13:41 UTC (permalink / raw)
  To: qemu-devel
  Cc: eblake, berrange, kwolf, mreitz, qemu-block, quintela, dgilbert

BlockdevRef is an alternate of BlockdevOptions (inline definition) and
str (reference to an existing block device by name).  BlockdevRef
value "" is special: "no block device should be referenced."  It's
actually interpreted that way in just one place: optional member
@backing of COW formats.  Semantics:

* Present means "use this block device" as backing storage

* Absent means "default to the one stored in the image"

* Except "" means "don't use backing storage at all"

The first two are perfectly normal: when the parameter is absent, it
defaults to an implied value, but the value's meaning is the same.

The third one overloads the parameter with a second meaning.  The
overloading is *implicit*, i.e. it's not visible in the types.  Works
here, because "" is not a value block device ID.

Pressing argument values the schema accepts, but are semantically
invalid, into service to mean "do something else entirely" is not
general, as suitable invalid values need not exist.  I also find it
ugly.

To clean this up, we could add a separate flag argument to suppress
@backing, or add a distinct value to @backing.  This commit implements
the latter: add JSON null to the values of @backing, deprecate "".

Because we're so close to the 2.10 freeze, implement it in the
stupidest way possible: have qmp_blockdev_add() rewrite null to ""
before anything else can see the null.  Works, because BlockdevRef
occurs only within arguments of blockdev-add.  The proper way to do it
would be rewriting "" to null, preferably in a cleaner way, but that
requires fixing up code to work with null.  Add a TODO comment for
that.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 blockdev.c             | 14 ++++++++++++++
 qapi/block-core.json   | 29 ++++++++++++++++++++++-------
 tests/qemu-iotests/085 |  2 +-
 tests/qemu-iotests/139 |  2 +-
 4 files changed, 38 insertions(+), 9 deletions(-)

diff --git a/blockdev.c b/blockdev.c
index 9c6dd27..1c42699 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -3886,6 +3886,7 @@ void qmp_blockdev_add(BlockdevOptions *options, Error **errp)
     QObject *obj;
     Visitor *v = qobject_output_visitor_new(&obj);
     QDict *qdict;
+    const QDictEntry *ent;
     Error *local_err = NULL;
 
     visit_type_BlockdevOptions(v, NULL, &options, &local_err);
@@ -3899,6 +3900,19 @@ void qmp_blockdev_add(BlockdevOptions *options, Error **errp)
 
     qdict_flatten(qdict);
 
+    /*
+     * Rewrite "backing": null to "backing": ""
+     * TODO Rewrite "" to null instead, and perhaps not even here
+     */
+    for (ent = qdict_first(qdict); ent; ent = qdict_next(qdict, ent)) {
+        char *dot = strrchr(ent->key, '.');
+
+        if (!strcmp(dot ? dot + 1 : ent->key, "backing")
+            && qobject_type(ent->value) == QTYPE_QNULL) {
+            qdict_put(qdict, ent->key, qstring_new());
+        }
+    }
+
     if (!qdict_get_try_str(qdict, "node-name")) {
         error_setg(errp, "'node-name' must be specified for the root node");
         goto fail;
diff --git a/qapi/block-core.json b/qapi/block-core.json
index c437aa5..4088041 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -2266,15 +2266,14 @@
 # besides their data source and an optional backing file.
 #
 # @backing:     reference to or definition of the backing file block
-#               device (if missing, taken from the image file content). It is
-#               allowed to pass an empty string here in order to disable the
-#               default backing file.
+#               device, null disables the backing file entirely.
+#               Defaults to the backing file stored the image file.
 #
 # Since: 2.9
 ##
 { 'struct': 'BlockdevOptionsGenericCOWFormat',
   'base': 'BlockdevOptionsGenericFormat',
-  'data': { '*backing': 'BlockdevRef' } }
+  'data': { '*backing': 'BlockdevRefOrNull' } }
 
 ##
 # @Qcow2OverlapCheckMode:
@@ -3113,9 +3112,7 @@
 # Reference to a block device.
 #
 # @definition:      defines a new block device inline
-# @reference:       references the ID of an existing block device. An
-#                   empty string means that no block device should be
-#                   referenced.
+# @reference:       references the ID of an existing block device
 #
 # Since: 2.9
 ##
@@ -3124,6 +3121,24 @@
             'reference': 'str' } }
 
 ##
+# @BlockdevRefOrNull:
+#
+# Reference to a block device.
+#
+# @definition:      defines a new block device inline
+# @reference:       references the ID of an existing block device.
+#                   An empty string means that no block device should
+#                   be referenced.  Deprecated; use null instead.
+# @null:            No block device should be referenced (since 2.10)
+#
+# Since: 2.9
+##
+{ 'alternate': 'BlockdevRefOrNull',
+  'data': { 'definition': 'BlockdevOptions',
+            'reference': 'str',
+            'null': 'null' } }
+
+##
 # @blockdev-add:
 #
 # Creates a new block device. If the @id option is given at the top level, a
diff --git a/tests/qemu-iotests/085 b/tests/qemu-iotests/085
index b97adcd..76e10aa 100755
--- a/tests/qemu-iotests/085
+++ b/tests/qemu-iotests/085
@@ -106,7 +106,7 @@ function add_snapshot_image()
     snapshot_file="${TEST_DIR}/${1}-${snapshot_virt0}"
     _make_test_img -b "${base_image}" "$size"
     mv "${TEST_IMG}" "${snapshot_file}"
-    do_blockdev_add "$1" "'backing': '', " "${snapshot_file}"
+    do_blockdev_add "$1" "'backing': null, " "${snapshot_file}"
 }
 
 # ${1}: unique identifier for the snapshot filename
diff --git a/tests/qemu-iotests/139 b/tests/qemu-iotests/139
index 175d8f0..b2f14db 100644
--- a/tests/qemu-iotests/139
+++ b/tests/qemu-iotests/139
@@ -69,7 +69,7 @@ class TestBlockdevDel(iotests.QMPTestCase):
                          '-b', base_img, new_img, '1M')
         opts = {'driver': iotests.imgfmt,
                 'node-name': node,
-                'backing': '',
+                'backing': None,
                 'file': {'driver': 'file',
                          'filename': new_img}}
         result = self.vm.qmp('blockdev-add', conv_keys = False, **opts)
-- 
2.7.5

^ permalink raw reply related	[flat|nested] 54+ messages in thread

* [Qemu-devel] [PATCH for-2.10 06/10] hmp: Clean up and simplify hmp_migrate_set_parameter()
  2017-07-18 13:41 [Qemu-devel] [PATCH for-2.10 00/10] Correct two minor QMP interface design flaws Markus Armbruster
                   ` (4 preceding siblings ...)
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 05/10] block: Use JSON null instead of "" to disable backing file Markus Armbruster
@ 2017-07-18 13:41 ` Markus Armbruster
  2017-07-18 15:54   ` Daniel P. Berrange
                     ` (2 more replies)
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 07/10] migration: Clean up around tls_creds, tls_hostname Markus Armbruster
                   ` (5 subsequent siblings)
  11 siblings, 3 replies; 54+ messages in thread
From: Markus Armbruster @ 2017-07-18 13:41 UTC (permalink / raw)
  To: qemu-devel
  Cc: eblake, berrange, kwolf, mreitz, qemu-block, quintela, dgilbert

The bulk of hmp_migrate_set_parameter()'s code sets one member of
MigrationParameters according to the command's arguments.  It uses a
string visitor for integer and boolean members, but not for string and
size members.  It calls visit_type_bool() right away, but delays
visit_type_int() some.  The delaying requires a flag variable and a
bit of trickery: we set all integer members instead of just the one we
want, and rely on the has_FOOs to mask the unwanted ones.

Clean this up as follows.  Don't delay calling visit_type_int().  Use
the string visitor for strings, too.  This involves extra allocations
and cleanup, but doing them is simpler and cleaner than avoiding them.

Sadly, using the string visitor for sizes isn't possible, because it
defaults to Bytes rather than Mebibytes.  Add a comment explaining
that.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 hmp.c | 78 ++++++++++++++++++++++++++++---------------------------------------
 1 file changed, 32 insertions(+), 46 deletions(-)

diff --git a/hmp.c b/hmp.c
index 6d32c40..2993586 100644
--- a/hmp.c
+++ b/hmp.c
@@ -1509,90 +1509,75 @@ void hmp_migrate_set_parameter(Monitor *mon, const QDict *qdict)
     const char *param = qdict_get_str(qdict, "parameter");
     const char *valuestr = qdict_get_str(qdict, "value");
     Visitor *v = string_input_visitor_new(valuestr);
+    MigrationParameters *p = g_new0(MigrationParameters, 1);
     uint64_t valuebw = 0;
-    int64_t valueint = 0;
-    bool valuebool = false;
     Error *err = NULL;
-    bool use_int_value = false;
     int i, ret;
 
     for (i = 0; i < MIGRATION_PARAMETER__MAX; i++) {
         if (strcmp(param, MigrationParameter_lookup[i]) == 0) {
-            MigrationParameters p = { 0 };
             switch (i) {
             case MIGRATION_PARAMETER_COMPRESS_LEVEL:
-                p.has_compress_level = true;
-                use_int_value = true;
+                p->has_compress_level = true;
+                visit_type_int(v, param, &p->compress_level, &err);
                 break;
             case MIGRATION_PARAMETER_COMPRESS_THREADS:
-                p.has_compress_threads = true;
-                use_int_value = true;
+                p->has_compress_threads = true;
+                visit_type_int(v, param, &p->compress_threads, &err);
                 break;
             case MIGRATION_PARAMETER_DECOMPRESS_THREADS:
-                p.has_decompress_threads = true;
-                use_int_value = true;
+                p->has_decompress_threads = true;
+                visit_type_int(v, param, &p->decompress_threads, &err);
                 break;
             case MIGRATION_PARAMETER_CPU_THROTTLE_INITIAL:
-                p.has_cpu_throttle_initial = true;
-                use_int_value = true;
+                p->has_cpu_throttle_initial = true;
+                visit_type_int(v, param, &p->cpu_throttle_initial, &err);
                 break;
             case MIGRATION_PARAMETER_CPU_THROTTLE_INCREMENT:
-                p.has_cpu_throttle_increment = true;
-                use_int_value = true;
+                p->has_cpu_throttle_increment = true;
+                visit_type_int(v, param, &p->cpu_throttle_increment, &err);
                 break;
             case MIGRATION_PARAMETER_TLS_CREDS:
-                p.has_tls_creds = true;
-                p.tls_creds = (char *) valuestr;
+                p->has_tls_creds = true;
+                visit_type_str(v, param, &p->tls_creds, &err);
                 break;
             case MIGRATION_PARAMETER_TLS_HOSTNAME:
-                p.has_tls_hostname = true;
-                p.tls_hostname = (char *) valuestr;
+                p->has_tls_hostname = true;
+                visit_type_str(v, param, &p->tls_hostname, &err);
                 break;
             case MIGRATION_PARAMETER_MAX_BANDWIDTH:
-                p.has_max_bandwidth = true;
+                p->has_max_bandwidth = true;
+                /*
+                 * Can't use visit_type_size() here, because it
+                 * defaults to Bytes rather than Mebibytes.
+                 */
                 ret = qemu_strtosz_MiB(valuestr, NULL, &valuebw);
                 if (ret < 0 || valuebw > INT64_MAX
                     || (size_t)valuebw != valuebw) {
                     error_setg(&err, "Invalid size %s", valuestr);
-                    goto cleanup;
+                    break;
                 }
-                p.max_bandwidth = valuebw;
+                p->max_bandwidth = valuebw;
                 break;
             case MIGRATION_PARAMETER_DOWNTIME_LIMIT:
-                p.has_downtime_limit = true;
-                use_int_value = true;
+                p->has_downtime_limit = true;
+                visit_type_int(v, param, &p->downtime_limit, &err);
                 break;
             case MIGRATION_PARAMETER_X_CHECKPOINT_DELAY:
-                p.has_x_checkpoint_delay = true;
-                use_int_value = true;
+                p->has_x_checkpoint_delay = true;
+                visit_type_int(v, param, &p->x_checkpoint_delay, &err);
                 break;
             case MIGRATION_PARAMETER_BLOCK_INCREMENTAL:
-                p.has_block_incremental = true;
-                visit_type_bool(v, param, &valuebool, &err);
-                if (err) {
-                    goto cleanup;
-                }
-                p.block_incremental = valuebool;
+                p->has_block_incremental = true;
+                visit_type_bool(v, param, &p->block_incremental, &err);
                 break;
             }
 
-            if (use_int_value) {
-                visit_type_int(v, param, &valueint, &err);
-                if (err) {
-                    goto cleanup;
-                }
-                /* Set all integers; only one has_FOO will be set, and
-                 * the code ignores the remaining values */
-                p.compress_level = valueint;
-                p.compress_threads = valueint;
-                p.decompress_threads = valueint;
-                p.cpu_throttle_initial = valueint;
-                p.cpu_throttle_increment = valueint;
-                p.downtime_limit = valueint;
-                p.x_checkpoint_delay = valueint;
+            if (err) {
+                goto cleanup;
             }
 
-            qmp_migrate_set_parameters(&p, &err);
+            qmp_migrate_set_parameters(p, &err);
             break;
         }
     }
@@ -1602,6 +1587,7 @@ void hmp_migrate_set_parameter(Monitor *mon, const QDict *qdict)
     }
 
  cleanup:
+    qapi_free_MigrationParameters(p);
     visit_free(v);
     if (err) {
         error_report_err(err);
-- 
2.7.5

^ permalink raw reply related	[flat|nested] 54+ messages in thread

* [Qemu-devel] [PATCH for-2.10 07/10] migration: Clean up around tls_creds, tls_hostname
  2017-07-18 13:41 [Qemu-devel] [PATCH for-2.10 00/10] Correct two minor QMP interface design flaws Markus Armbruster
                   ` (5 preceding siblings ...)
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 06/10] hmp: Clean up and simplify hmp_migrate_set_parameter() Markus Armbruster
@ 2017-07-18 13:41 ` Markus Armbruster
  2017-07-18 15:57   ` Daniel P. Berrange
                     ` (2 more replies)
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 08/10] migration: Add TODO comments on duplication of QAPI_CLONE() Markus Armbruster
                   ` (4 subsequent siblings)
  11 siblings, 3 replies; 54+ messages in thread
From: Markus Armbruster @ 2017-07-18 13:41 UTC (permalink / raw)
  To: qemu-devel
  Cc: eblake, berrange, kwolf, mreitz, qemu-block, quintela, dgilbert

Optional MigrationParameters members tls_creds and tls_hostname can't
actually be absent outside qmp_migrate_set_parameters() since commit
4af245d (v2.9.0).

Note that commit 4af245d reverted the part of commit de63ab6 (v2.8.0)
that made tls_creds and tls_hostname absent instead of "" in the value
of query-migrate-parameters, even though commit de63ab6 called that a
mistake.  What a mess.

Drop the redundant tests for presence, and update documentation.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 hmp.c                 |  6 ++++--
 migration/migration.c |  4 ++--
 qapi-schema.json      | 11 +++++------
 3 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/hmp.c b/hmp.c
index 2993586..2b2db3c 100644
--- a/hmp.c
+++ b/hmp.c
@@ -313,12 +313,14 @@ void hmp_info_migrate_parameters(Monitor *mon, const QDict *qdict)
         monitor_printf(mon, "%s: %" PRId64 "\n",
             MigrationParameter_lookup[MIGRATION_PARAMETER_CPU_THROTTLE_INCREMENT],
             params->cpu_throttle_increment);
+        assert(params->has_tls_creds);
         monitor_printf(mon, "%s: '%s'\n",
             MigrationParameter_lookup[MIGRATION_PARAMETER_TLS_CREDS],
-            params->has_tls_creds ? params->tls_creds : "");
+            params->tls_creds);
+        assert(params->has_tls_hostname);
         monitor_printf(mon, "%s: '%s'\n",
             MigrationParameter_lookup[MIGRATION_PARAMETER_TLS_HOSTNAME],
-            params->has_tls_hostname ? params->tls_hostname : "");
+            params->tls_hostname);
         assert(params->has_max_bandwidth);
         monitor_printf(mon, "%s: %" PRId64 " bytes/second\n",
             MigrationParameter_lookup[MIGRATION_PARAMETER_MAX_BANDWIDTH],
diff --git a/migration/migration.c b/migration/migration.c
index a0db40d..bae9808 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -438,9 +438,9 @@ MigrationParameters *qmp_query_migrate_parameters(Error **errp)
     params->cpu_throttle_initial = s->parameters.cpu_throttle_initial;
     params->has_cpu_throttle_increment = true;
     params->cpu_throttle_increment = s->parameters.cpu_throttle_increment;
-    params->has_tls_creds = !!s->parameters.tls_creds;
+    params->has_tls_creds = true;
     params->tls_creds = g_strdup(s->parameters.tls_creds);
-    params->has_tls_hostname = !!s->parameters.tls_hostname;
+    params->has_tls_hostname = true;
     params->tls_hostname = g_strdup(s->parameters.tls_hostname);
     params->has_max_bandwidth = true;
     params->max_bandwidth = s->parameters.max_bandwidth;
diff --git a/qapi-schema.json b/qapi-schema.json
index 485767f..7b75cf1 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -1054,9 +1054,7 @@
 # @MigrationParameters:
 #
 # Optional members can be omitted on input ('migrate-set-parameters')
-# but most members will always be present on output
-# ('query-migrate-parameters'), with the exception of tls-creds and
-# tls-hostname.
+# but members will always be present on output.
 #
 # @compress-level: compression level
 #
@@ -1077,10 +1075,10 @@
 #             channel. On the outgoing side of the migration, the credentials
 #             must be for a 'client' endpoint, while for the incoming side the
 #             credentials must be for a 'server' endpoint. Setting this
-#             will enable TLS for all migrations. The default is unset,
-#             resulting in unsecured migration at the QEMU level. (Since 2.7)
+#             to a non-empty string enables TLS for all migrations.
 #             An empty string means that QEMU will use plain text mode for
-#             migration, rather than TLS (Since 2.9)
+#             migration, rather than TLS (Since 2.7)
+#             Note: 2.8 reports this by omitting tls-creds instead.
 #
 # @tls-hostname: hostname of the target host for the migration. This
 #                is required when using x509 based TLS credentials and the
@@ -1090,6 +1088,7 @@
 #                certificate identity can be validated. (Since 2.7)
 #                An empty string means that QEMU will use the hostname
 #                associated with the migration URI, if any. (Since 2.9)
+#                Note: 2.8 reports this by omitting tls-hostname instead.
 #
 # @max-bandwidth: to set maximum speed for migration. maximum speed in
 #                 bytes per second. (Since 2.8)
-- 
2.7.5

^ permalink raw reply related	[flat|nested] 54+ messages in thread

* [Qemu-devel] [PATCH for-2.10 08/10] migration: Add TODO comments on duplication of QAPI_CLONE()
  2017-07-18 13:41 [Qemu-devel] [PATCH for-2.10 00/10] Correct two minor QMP interface design flaws Markus Armbruster
                   ` (6 preceding siblings ...)
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 07/10] migration: Clean up around tls_creds, tls_hostname Markus Armbruster
@ 2017-07-18 13:41 ` Markus Armbruster
  2017-07-18 15:57   ` Daniel P. Berrange
  2017-07-18 17:36   ` Eric Blake
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 09/10] migration: Unshare MigrationParameters struct for now Markus Armbruster
                   ` (3 subsequent siblings)
  11 siblings, 2 replies; 54+ messages in thread
From: Markus Armbruster @ 2017-07-18 13:41 UTC (permalink / raw)
  To: qemu-devel
  Cc: eblake, berrange, kwolf, mreitz, qemu-block, quintela, dgilbert

qmp_query_migrate_parameters() and qmp_migrate_set_parameters()
effectively duplicate QAPI_CLONE() inline.  Add suitable TODO
comments.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 migration/migration.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/migration/migration.c b/migration/migration.c
index bae9808..d0a1d13 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -427,6 +427,7 @@ MigrationParameters *qmp_query_migrate_parameters(Error **errp)
     MigrationParameters *params;
     MigrationState *s = migrate_get_current();
 
+    /* TODO use QAPI_CLONE() instead of duplicating it inline */
     params = g_malloc0(sizeof(*params));
     params->has_compress_level = true;
     params->compress_level = s->parameters.compress_level;
@@ -703,6 +704,7 @@ void qmp_migrate_set_parameters(MigrationParameters *params, Error **errp)
                     "is invalid, it should be positive");
     }
 
+    /* TODO use QAPI_CLONE() instead of duplicating it inline */
     if (params->has_compress_level) {
         s->parameters.compress_level = params->compress_level;
     }
-- 
2.7.5

^ permalink raw reply related	[flat|nested] 54+ messages in thread

* [Qemu-devel] [PATCH for-2.10 09/10] migration: Unshare MigrationParameters struct for now
  2017-07-18 13:41 [Qemu-devel] [PATCH for-2.10 00/10] Correct two minor QMP interface design flaws Markus Armbruster
                   ` (7 preceding siblings ...)
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 08/10] migration: Add TODO comments on duplication of QAPI_CLONE() Markus Armbruster
@ 2017-07-18 13:41 ` Markus Armbruster
  2017-07-18 16:01   ` Daniel P. Berrange
  2017-07-18 17:42   ` Eric Blake
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 10/10] migration: Use JSON null instead of "" to reset parameter to default Markus Armbruster
                   ` (2 subsequent siblings)
  11 siblings, 2 replies; 54+ messages in thread
From: Markus Armbruster @ 2017-07-18 13:41 UTC (permalink / raw)
  To: qemu-devel
  Cc: eblake, berrange, kwolf, mreitz, qemu-block, quintela, dgilbert

Commit de63ab6 "migrate: Share common MigrationParameters struct"
reused MigrationParameters for the arguments of
migrate-set-parameters, with the following rationale:

    It is rather verbose, and slightly error-prone, to repeat
    the same set of parameters for input (migrate-set-parameters)
    as for output (query-migrate-parameters), where the only
    difference is whether the members are optional.  We can just
    document that the optional members will always be present
    on output, and then share a common struct between both
    commands.  The next patch can then reduce the amount of
    code needed on input.

I need to unshare them to correct a design flaw in a stupid, but
minimally invasive way, in the next commit.  We can restore the
sharing when we redo that patch in a less stupid way.  Add a suitable
TODO comment.

Note that I revert only the sharing part of commit de63ab6, not the
part that made the members of query-migrate-parameters' result
optional.  The schema (and thus introspection) remains inaccurate for
query-migrate-parameters.  If we decide not to restore the sharing, we
should revert that part, too.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 hmp.c                 |  4 +--
 migration/migration.c | 12 +++++---
 qapi-schema.json      | 85 ++++++++++++++++++++++++++++++++++++++++++++++-----
 3 files changed, 87 insertions(+), 14 deletions(-)

diff --git a/hmp.c b/hmp.c
index 2b2db3c..0a5de75 100644
--- a/hmp.c
+++ b/hmp.c
@@ -1511,7 +1511,7 @@ void hmp_migrate_set_parameter(Monitor *mon, const QDict *qdict)
     const char *param = qdict_get_str(qdict, "parameter");
     const char *valuestr = qdict_get_str(qdict, "value");
     Visitor *v = string_input_visitor_new(valuestr);
-    MigrationParameters *p = g_new0(MigrationParameters, 1);
+    MigrateSetParameters *p = g_new0(MigrateSetParameters, 1);
     uint64_t valuebw = 0;
     Error *err = NULL;
     int i, ret;
@@ -1589,7 +1589,7 @@ void hmp_migrate_set_parameter(Monitor *mon, const QDict *qdict)
     }
 
  cleanup:
-    qapi_free_MigrationParameters(p);
+    qapi_free_MigrateSetParameters(p);
     visit_free(v);
     if (err) {
         error_report_err(err);
diff --git a/migration/migration.c b/migration/migration.c
index d0a1d13..f6a9443 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -644,7 +644,7 @@ void qmp_migrate_set_capabilities(MigrationCapabilityStatusList *params,
     }
 }
 
-void qmp_migrate_set_parameters(MigrationParameters *params, Error **errp)
+void qmp_migrate_set_parameters(MigrateSetParameters *params, Error **errp)
 {
     MigrationState *s = migrate_get_current();
 
@@ -704,7 +704,11 @@ void qmp_migrate_set_parameters(MigrationParameters *params, Error **errp)
                     "is invalid, it should be positive");
     }
 
-    /* TODO use QAPI_CLONE() instead of duplicating it inline */
+    /*
+     * TODO if we fuse MigrateSetParameters back into
+     * MigrationParameters, use QAPI_CLONE() instead of duplicating it
+     * inline
+     */
     if (params->has_compress_level) {
         s->parameters.compress_level = params->compress_level;
     }
@@ -1165,7 +1169,7 @@ int64_t qmp_query_migrate_cache_size(Error **errp)
 
 void qmp_migrate_set_speed(int64_t value, Error **errp)
 {
-    MigrationParameters p = {
+    MigrateSetParameters p = {
         .has_max_bandwidth = true,
         .max_bandwidth = value,
     };
@@ -1185,7 +1189,7 @@ void qmp_migrate_set_downtime(double value, Error **errp)
     value *= 1000; /* Convert to milliseconds */
     value = MAX(0, MIN(INT64_MAX, value));
 
-    MigrationParameters p = {
+    MigrateSetParameters p = {
         .has_downtime_limit = true,
         .downtime_limit = value,
     };
diff --git a/qapi-schema.json b/qapi-schema.json
index 7b75cf1..b5ec942 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -1035,6 +1035,77 @@
            'downtime-limit', 'x-checkpoint-delay', 'block-incremental' ] }
 
 ##
+# @MigrateSetParameters:
+#
+# @compress-level: compression level
+#
+# @compress-threads: compression thread count
+#
+# @decompress-threads: decompression thread count
+#
+# @cpu-throttle-initial: Initial percentage of time guest cpus are
+#                        throttled when migration auto-converge is activated.
+#                        The default value is 20. (Since 2.7)
+#
+# @cpu-throttle-increment: throttle percentage increase each time
+#                          auto-converge detects that migration is not making
+#                          progress. The default value is 10. (Since 2.7)
+#
+# @tls-creds: ID of the 'tls-creds' object that provides credentials
+#             for establishing a TLS connection over the migration data
+#             channel. On the outgoing side of the migration, the credentials
+#             must be for a 'client' endpoint, while for the incoming side the
+#             credentials must be for a 'server' endpoint. Setting this
+#             to a non-empty string enables TLS for all migrations.
+#             An empty string means that QEMU will use plain text mode for
+#             migration, rather than TLS (Since 2.9)
+#             Previously (since 2.7), this was reported by omitting
+#             tls-creds instead.
+#
+# @tls-hostname: hostname of the target host for the migration. This
+#                is required when using x509 based TLS credentials and the
+#                migration URI does not already include a hostname. For
+#                example if using fd: or exec: based migration, the
+#                hostname must be provided so that the server's x509
+#                certificate identity can be validated. (Since 2.7)
+#                An empty string means that QEMU will use the hostname
+#                associated with the migration URI, if any. (Since 2.9)
+#                Previously (since 2.7), this was reported by omitting
+#                tls-hostname instead.
+#
+# @max-bandwidth: to set maximum speed for migration. maximum speed in
+#                 bytes per second. (Since 2.8)
+#
+# @downtime-limit: set maximum tolerated downtime for migration. maximum
+#                  downtime in milliseconds (Since 2.8)
+#
+# @x-checkpoint-delay: the delay time between two COLO checkpoints. (Since 2.8)
+#
+# @block-incremental: Affects how much storage is migrated when the
+# 	block migration capability is enabled.  When false, the entire
+# 	storage backing chain is migrated into a flattened image at
+# 	the destination; when true, only the active qcow2 layer is
+# 	migrated and the destination must already have access to the
+# 	same backing chain as was used on the source.  (since 2.10)
+#
+# Since: 2.4
+##
+# TODO either fuse back into MigrationParameters, or make
+# MigrationParameters members mandatory
+{ 'struct': 'MigrateSetParameters',
+  'data': { '*compress-level': 'int',
+            '*compress-threads': 'int',
+            '*decompress-threads': 'int',
+            '*cpu-throttle-initial': 'int',
+            '*cpu-throttle-increment': 'int',
+            '*tls-creds': 'str',
+            '*tls-hostname': 'str',
+            '*max-bandwidth': 'int',
+            '*downtime-limit': 'int',
+            '*x-checkpoint-delay': 'int',
+            '*block-incremental': 'bool' } }
+
+##
 # @migrate-set-parameters:
 #
 # Set various migration parameters.
@@ -1048,13 +1119,12 @@
 #
 ##
 { 'command': 'migrate-set-parameters', 'boxed': true,
-  'data': 'MigrationParameters' }
+  'data': 'MigrateSetParameters' }
 
 ##
 # @MigrationParameters:
 #
-# Optional members can be omitted on input ('migrate-set-parameters')
-# but members will always be present on output.
+# The optional members aren't actually optional.
 #
 # @compress-level: compression level
 #
@@ -1063,19 +1133,18 @@
 # @decompress-threads: decompression thread count
 #
 # @cpu-throttle-initial: Initial percentage of time guest cpus are
-#                        throttledwhen migration auto-converge is activated.
-#                        The default value is 20. (Since 2.7)
+#                        throttled when migration auto-converge is activated.
+#                        (Since 2.7)
 #
 # @cpu-throttle-increment: throttle percentage increase each time
 #                          auto-converge detects that migration is not making
-#                          progress. The default value is 10. (Since 2.7)
+#                          progress. (Since 2.7)
 #
 # @tls-creds: ID of the 'tls-creds' object that provides credentials
 #             for establishing a TLS connection over the migration data
 #             channel. On the outgoing side of the migration, the credentials
 #             must be for a 'client' endpoint, while for the incoming side the
-#             credentials must be for a 'server' endpoint. Setting this
-#             to a non-empty string enables TLS for all migrations.
+#             credentials must be for a 'server' endpoint.
 #             An empty string means that QEMU will use plain text mode for
 #             migration, rather than TLS (Since 2.7)
 #             Note: 2.8 reports this by omitting tls-creds instead.
-- 
2.7.5

^ permalink raw reply related	[flat|nested] 54+ messages in thread

* [Qemu-devel] [PATCH for-2.10 10/10] migration: Use JSON null instead of "" to reset parameter to default
  2017-07-18 13:41 [Qemu-devel] [PATCH for-2.10 00/10] Correct two minor QMP interface design flaws Markus Armbruster
                   ` (8 preceding siblings ...)
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 09/10] migration: Unshare MigrationParameters struct for now Markus Armbruster
@ 2017-07-18 13:41 ` Markus Armbruster
  2017-07-18 16:03   ` Daniel P. Berrange
                     ` (2 more replies)
  2017-07-18 14:02 ` [Qemu-devel] [PATCH for-2.10 00/10] Correct two minor QMP interface design flaws no-reply
  2017-07-18 16:08 ` Daniel P. Berrange
  11 siblings, 3 replies; 54+ messages in thread
From: Markus Armbruster @ 2017-07-18 13:41 UTC (permalink / raw)
  To: qemu-devel
  Cc: eblake, berrange, kwolf, mreitz, qemu-block, quintela, dgilbert

migrate-set-parameters sets migration parameters according to is
arguments like this:

* Present means "set the parameter to this value"

* Absent means "leave the parameter unchanged"

* Except for parameters tls_creds and tls_hostname, "" means "reset
  the parameter to its default value

The first two are perfectly normal: presence of the parameter makes
the command do something.

The third one overloads the parameter with a second meaning.  The
overloading is *implicit*, i.e. it's not visible in the types.  Works
here, because "" is neither a valid TLS credentials ID, nor a valid
host name.

Pressing argument values the schema accepts, but are semantically
invalid, into service to mean "reset to default" is not general, as
suitable invalid values need not exist.  I also find it ugly.

To clean this up, we could add a separate flag argument to ask for
"reset to default", or add a distinct value to @tls_creds and
@tls_hostname.  This commit implements the latter: add JSON null to
the values of @tls_creds and @tls_hostname, deprecate "".

Because we're so close to the 2.10 freeze, implement it in the
stupidest way possible: have qmp_migrate_set_parameters() rewrite null
to "" before anything else can see the null.  The proper way to do it
would be rewriting "" to null, but that requires fixing up code to
work with null.  Add TODO comments for that.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 hmp.c                 |  8 ++++++--
 migration/migration.c | 18 ++++++++++++++++--
 qapi-schema.json      | 11 +++++++++--
 3 files changed, 31 insertions(+), 6 deletions(-)

diff --git a/hmp.c b/hmp.c
index 0a5de75..40ebeef 100644
--- a/hmp.c
+++ b/hmp.c
@@ -1541,11 +1541,15 @@ void hmp_migrate_set_parameter(Monitor *mon, const QDict *qdict)
                 break;
             case MIGRATION_PARAMETER_TLS_CREDS:
                 p->has_tls_creds = true;
-                visit_type_str(v, param, &p->tls_creds, &err);
+                p->tls_creds = g_new0(StrOrNull, 1);
+                p->tls_creds->type = QTYPE_QSTRING;
+                visit_type_str(v, param, &p->tls_creds->u.s, &err);
                 break;
             case MIGRATION_PARAMETER_TLS_HOSTNAME:
                 p->has_tls_hostname = true;
-                visit_type_str(v, param, &p->tls_hostname, &err);
+                p->tls_hostname = g_new0(StrOrNull, 1);
+                p->tls_hostname->type = QTYPE_QSTRING;
+                visit_type_str(v, param, &p->tls_hostname->u.s, &err);
                 break;
             case MIGRATION_PARAMETER_MAX_BANDWIDTH:
                 p->has_max_bandwidth = true;
diff --git a/migration/migration.c b/migration/migration.c
index f6a9443..e2cfb99 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -703,6 +703,20 @@ void qmp_migrate_set_parameters(MigrateSetParameters *params, Error **errp)
                     "x_checkpoint_delay",
                     "is invalid, it should be positive");
     }
+    /* TODO Rewrite "" to null instead */
+    if (params->has_tls_creds
+        && params->tls_creds->type == QTYPE_QNULL) {
+        QDECREF(params->tls_creds->u.n);
+        params->tls_creds->type = QTYPE_QSTRING;
+        params->tls_creds->u.s = strdup("");
+    }
+    /* TODO Rewrite "" to null instead */
+    if (params->has_tls_hostname
+        && params->tls_hostname->type == QTYPE_QNULL) {
+        QDECREF(params->tls_hostname->u.n);
+        params->tls_hostname->type = QTYPE_QSTRING;
+        params->tls_hostname->u.s = strdup("");
+    }
 
     /*
      * TODO if we fuse MigrateSetParameters back into
@@ -726,11 +740,11 @@ void qmp_migrate_set_parameters(MigrateSetParameters *params, Error **errp)
     }
     if (params->has_tls_creds) {
         g_free(s->parameters.tls_creds);
-        s->parameters.tls_creds = g_strdup(params->tls_creds);
+        s->parameters.tls_creds = g_strdup(params->tls_creds->u.s);
     }
     if (params->has_tls_hostname) {
         g_free(s->parameters.tls_hostname);
-        s->parameters.tls_hostname = g_strdup(params->tls_hostname);
+        s->parameters.tls_hostname = g_strdup(params->tls_hostname->u.s);
     }
     if (params->has_max_bandwidth) {
         s->parameters.max_bandwidth = params->max_bandwidth;
diff --git a/qapi-schema.json b/qapi-schema.json
index b5ec942..247af24 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -116,6 +116,13 @@
 { 'command': 'qmp_capabilities' }
 
 ##
+# @StrOrNull:
+##
+{ 'alternate': 'StrOrNull',
+  'data': { 's': 'str',
+            'n': 'null' } }
+
+##
 # @LostTickPolicy:
 #
 # Policy for handling lost ticks in timer devices.
@@ -1098,8 +1105,8 @@
             '*decompress-threads': 'int',
             '*cpu-throttle-initial': 'int',
             '*cpu-throttle-increment': 'int',
-            '*tls-creds': 'str',
-            '*tls-hostname': 'str',
+            '*tls-creds': 'StrOrNull',
+            '*tls-hostname': 'StrOrNull',
             '*max-bandwidth': 'int',
             '*downtime-limit': 'int',
             '*x-checkpoint-delay': 'int',
-- 
2.7.5

^ permalink raw reply related	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 00/10] Correct two minor QMP interface design flaws
  2017-07-18 13:41 [Qemu-devel] [PATCH for-2.10 00/10] Correct two minor QMP interface design flaws Markus Armbruster
                   ` (9 preceding siblings ...)
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 10/10] migration: Use JSON null instead of "" to reset parameter to default Markus Armbruster
@ 2017-07-18 14:02 ` no-reply
  2017-07-18 16:08 ` Daniel P. Berrange
  11 siblings, 0 replies; 54+ messages in thread
From: no-reply @ 2017-07-18 14:02 UTC (permalink / raw)
  To: armbru; +Cc: famz, qemu-devel, kwolf, qemu-block, quintela, dgilbert, mreitz

Hi,

This series failed build test on s390x host. Please find the details below.

Type: series
Message-id: 1500385286-21142-1-git-send-email-armbru@redhat.com
Subject: [Qemu-devel] [PATCH for-2.10 00/10] Correct two minor QMP interface design flaws

=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked under the git checkout with
# HEAD pointing to a commit that has the patches applied on top of "base"
# branch
set -e
echo "=== ENV ==="
env
echo "=== PACKAGES ==="
rpm -qa
echo "=== TEST BEGIN ==="
CC=$HOME/bin/cc
INSTALL=$PWD/install
BUILD=$PWD/build
echo -n "Using CC: "
realpath $CC
mkdir -p $BUILD $INSTALL
SRC=$PWD
cd $BUILD
$SRC/configure --cc=$CC --prefix=$INSTALL
make -j4
# XXX: we need reliable clean up
# make check -j4 V=1
make install
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/1500385286-21142-1-git-send-email-armbru@redhat.com -> patchew/1500385286-21142-1-git-send-email-armbru@redhat.com
Switched to a new branch 'test'
7a5eb53 migration: Use JSON null instead of "" to reset parameter to default
a69f2ac migration: Unshare MigrationParameters struct for now
0703f98 migration: Add TODO comments on duplication of QAPI_CLONE()
29ec658 migration: Clean up around tls_creds, tls_hostname
0a96980 hmp: Clean up and simplify hmp_migrate_set_parameter()
fb76d92 block: Use JSON null instead of "" to disable backing file
a8d21d9 tests/test-qobject-input-visitor: Drop redundant test
6a7e829 qapi: Introduce a first class 'null' type
12ef616 qapi: Use QNull for a more regular visit_type_null()
17ce7e3 qapi: Separate type QNull from QObject

=== OUTPUT BEGIN ===
=== ENV ===
XDG_SESSION_ID=156248
SHELL=/bin/sh
USER=fam
PATCHEW=/home/fam/patchew/patchew-cli -s http://patchew.org --nodebug
PATH=/usr/bin:/bin
PWD=/var/tmp/patchew-tester-tmp-i5lmtq3u/src
LANG=en_US.UTF-8
HOME=/home/fam
SHLVL=2
LOGNAME=fam
DBUS_SESSION_BUS_ADDRESS=unix:path=/run/user/1012/bus
XDG_RUNTIME_DIR=/run/user/1012
_=/usr/bin/env
=== PACKAGES ===
gpg-pubkey-873529b8-54e386ff
xz-libs-5.2.2-2.fc24.s390x
libxshmfence-1.2-3.fc24.s390x
giflib-4.1.6-15.fc24.s390x
trousers-lib-0.3.13-6.fc24.s390x
ncurses-base-6.0-6.20160709.fc25.noarch
gmp-6.1.1-1.fc25.s390x
libidn-1.33-1.fc25.s390x
slang-2.3.0-7.fc25.s390x
libsemanage-2.5-8.fc25.s390x
pkgconfig-0.29.1-1.fc25.s390x
alsa-lib-1.1.1-2.fc25.s390x
yum-metadata-parser-1.1.4-17.fc25.s390x
python3-slip-dbus-0.6.4-4.fc25.noarch
python2-cssselect-0.9.2-1.fc25.noarch
python-fedora-0.8.0-2.fc25.noarch
createrepo_c-libs-0.10.0-6.fc25.s390x
initscripts-9.69-1.fc25.s390x
wget-1.18-2.fc25.s390x
dhcp-client-4.3.5-1.fc25.s390x
parted-3.2-21.fc25.s390x
flex-2.6.0-3.fc25.s390x
colord-libs-1.3.4-1.fc25.s390x
python-osbs-client-0.33-3.fc25.noarch
perl-Pod-Simple-3.35-1.fc25.noarch
python2-simplejson-3.10.0-1.fc25.s390x
brltty-5.4-2.fc25.s390x
librados2-10.2.4-2.fc25.s390x
tcp_wrappers-7.6-83.fc25.s390x
libcephfs_jni1-10.2.4-2.fc25.s390x
nettle-devel-3.3-1.fc25.s390x
bzip2-devel-1.0.6-21.fc25.s390x
libuuid-2.28.2-2.fc25.s390x
pango-1.40.4-1.fc25.s390x
python3-dnf-1.1.10-6.fc25.noarch
cryptsetup-libs-1.7.4-1.fc25.s390x
texlive-kpathsea-doc-svn41139-33.fc25.1.noarch
netpbm-10.77.00-3.fc25.s390x
openssh-7.4p1-4.fc25.s390x
texlive-kpathsea-bin-svn40473-33.20160520.fc25.1.s390x
texlive-graphics-svn41015-33.fc25.1.noarch
texlive-dvipdfmx-def-svn40328-33.fc25.1.noarch
texlive-mfware-svn40768-33.fc25.1.noarch
texlive-texlive-scripts-svn41433-33.fc25.1.noarch
texlive-euro-svn22191.1.1-33.fc25.1.noarch
texlive-etex-svn37057.0-33.fc25.1.noarch
texlive-iftex-svn29654.0.2-33.fc25.1.noarch
texlive-palatino-svn31835.0-33.fc25.1.noarch
texlive-texlive-docindex-svn41430-33.fc25.1.noarch
texlive-xunicode-svn30466.0.981-33.fc25.1.noarch
texlive-koma-script-svn41508-33.fc25.1.noarch
texlive-pst-grad-svn15878.1.06-33.fc25.1.noarch
texlive-pst-blur-svn15878.2.0-33.fc25.1.noarch
texlive-jknapltx-svn19440.0-33.fc25.1.noarch
netpbm-progs-10.77.00-3.fc25.s390x
texinfo-6.1-4.fc25.s390x
openssl-devel-1.0.2k-1.fc25.s390x
python2-sssdconfig-1.15.2-1.fc25.noarch
gdk-pixbuf2-2.36.6-1.fc25.s390x
mesa-libEGL-13.0.4-3.fc25.s390x
pcre-cpp-8.40-6.fc25.s390x
pcre-utf16-8.40-6.fc25.s390x
glusterfs-extra-xlators-3.10.1-1.fc25.s390x
mesa-libGL-devel-13.0.4-3.fc25.s390x
nss-devel-3.29.3-1.1.fc25.s390x
libaio-0.3.110-6.fc24.s390x
libfontenc-1.1.3-3.fc24.s390x
lzo-2.08-8.fc24.s390x
isl-0.14-5.fc24.s390x
libXau-1.0.8-6.fc24.s390x
linux-atm-libs-2.5.1-14.fc24.s390x
libXext-1.3.3-4.fc24.s390x
libXxf86vm-1.1.4-3.fc24.s390x
bison-3.0.4-4.fc24.s390x
perl-srpm-macros-1-20.fc25.noarch
gawk-4.1.3-8.fc25.s390x
libwayland-client-1.12.0-1.fc25.s390x
perl-Exporter-5.72-366.fc25.noarch
perl-version-0.99.17-1.fc25.s390x
fftw-libs-double-3.3.5-3.fc25.s390x
libssh2-1.8.0-1.fc25.s390x
ModemManager-glib-1.6.4-1.fc25.s390x
newt-python3-0.52.19-2.fc25.s390x
python-munch-2.0.4-3.fc25.noarch
python-bugzilla-1.2.2-4.fc25.noarch
libedit-3.1-16.20160618cvs.fc25.s390x
python-pycurl-7.43.0-4.fc25.s390x
createrepo_c-0.10.0-6.fc25.s390x
device-mapper-multipath-libs-0.4.9-83.fc25.s390x
yum-3.4.3-510.fc25.noarch
dhcp-common-4.3.5-1.fc25.noarch
dracut-config-rescue-044-78.fc25.s390x
teamd-1.26-1.fc25.s390x
mozjs17-17.0.0-16.fc25.s390x
libselinux-2.5-13.fc25.s390x
libgo-devel-6.3.1-1.fc25.s390x
NetworkManager-libnm-1.4.4-3.fc25.s390x
python2-pyparsing-2.1.10-1.fc25.noarch
cairo-gobject-1.14.8-1.fc25.s390x
ethtool-4.8-1.fc25.s390x
xorg-x11-proto-devel-7.7-20.fc25.noarch
brlapi-0.6.5-2.fc25.s390x
librados-devel-10.2.4-2.fc25.s390x
libXinerama-devel-1.1.3-6.fc24.s390x
quota-4.03-7.fc25.s390x
lua-posix-33.3.1-3.fc25.s390x
usbredir-devel-0.7.1-2.fc24.s390x
python-libs-2.7.13-1.fc25.s390x
libX11-devel-1.6.4-4.fc25.s390x
python-devel-2.7.13-1.fc25.s390x
libepoxy-1.4.1-1.fc25.s390x
freetype-devel-2.6.5-3.fc25.s390x
python3-dnf-plugins-core-0.1.21-5.fc25.noarch
perl-macros-5.24.1-385.fc25.s390x
texlive-pdftex-doc-svn41149-33.fc25.1.noarch
mariadb-config-10.1.21-3.fc25.s390x
openssh-clients-7.4p1-4.fc25.s390x
iptables-1.6.0-3.fc25.s390x
texlive-texlive.infra-svn41280-33.fc25.1.noarch
texlive-graphics-cfg-svn40269-33.fc25.1.noarch
texlive-bibtex-svn40768-33.fc25.1.noarch
texlive-mfware-bin-svn40473-33.20160520.fc25.1.s390x
texlive-texlive-scripts-bin-svn29741.0-33.20160520.fc25.1.noarch
texlive-sauerj-svn15878.0-33.fc25.1.noarch
texlive-enctex-svn34957.0-33.fc25.1.noarch
texlive-ifetex-svn24853.1.2-33.fc25.1.noarch
texlive-ntgclass-svn15878.2.1a-33.fc25.1.noarch
texlive-tex-gyre-math-svn41264-33.fc25.1.noarch
texlive-bera-svn20031.0-33.fc25.1.noarch
texlive-ms-svn29849.0-33.fc25.1.noarch
texlive-pst-fill-svn15878.1.01-33.fc25.1.noarch
texlive-ctable-svn38672-33.fc25.1.noarch
texlive-extsizes-svn17263.1.4a-33.fc25.1.noarch
texlive-collection-latexrecommended-svn35765.0-33.20160520.fc25.1.noarch
perl-Filter-1.57-1.fc25.s390x
krb5-workstation-1.14.4-7.fc25.s390x
python2-rpm-macros-3-12.fc25.noarch
audit-libs-2.7.4-1.fc25.s390x
libglvnd-egl-0.2.999-14.20170308git8e6e102.fc25.s390x
libglvnd-opengl-0.2.999-14.20170308git8e6e102.fc25.s390x
pcre-devel-8.40-6.fc25.s390x
gdbm-1.13-1.fc25.s390x
mesa-libGLES-devel-13.0.4-3.fc25.s390x
java-1.8.0-openjdk-1.8.0.121-10.b14.fc25.s390x
gpg-pubkey-efe550f5-5220ba41
gpg-pubkey-81b46521-55b3ca9a
filesystem-3.2-37.fc24.s390x
libffi-3.1-9.fc24.s390x
keyutils-libs-1.5.9-8.fc24.s390x
libnfnetlink-1.0.1-8.fc24.s390x
libtheora-1.1.1-14.fc24.s390x
xml-common-0.6.3-44.fc24.noarch
autoconf-2.69-22.fc24.noarch
libXt-1.1.5-3.fc24.s390x
kbd-legacy-2.0.3-3.fc24.noarch
ghostscript-fonts-5.50-35.fc24.noarch
libXevie-1.0.3-11.fc24.s390x
libcap-2.25-2.fc25.s390x
mpfr-3.1.5-1.fc25.s390x
perl-Carp-1.40-365.fc25.noarch
libmnl-1.0.4-1.fc25.s390x
perl-Unicode-EastAsianWidth-1.33-8.fc25.noarch
libwayland-cursor-1.12.0-1.fc25.s390x
python-krbV-1.0.90-12.fc25.s390x
python2-urllib3-1.15.1-3.fc25.noarch
fipscheck-1.4.1-11.fc25.s390x
libndp-1.6-1.fc25.s390x
gnupg2-2.1.13-2.fc25.s390x
libXfixes-5.0.3-1.fc25.s390x
adwaita-icon-theme-3.22.0-1.fc25.noarch
dconf-0.26.0-1.fc25.s390x
ncurses-devel-6.0-6.20160709.fc25.s390x
dejagnu-1.6-1.fc25.noarch
libstdc++-devel-6.3.1-1.fc25.s390x
python-beautifulsoup4-4.5.3-1.fc25.noarch
device-mapper-1.02.136-3.fc25.s390x
subversion-1.9.5-1.fc25.s390x
libtool-ltdl-2.4.6-13.fc25.s390x
libevent-2.0.22-1.fc25.s390x
atk-devel-2.22.0-1.fc25.s390x
libev-4.24-1.fc25.s390x
xorg-x11-fonts-Type1-7.5-16.fc24.noarch
libtasn1-devel-4.10-1.fc25.s390x
vte291-devel-0.46.1-1.fc25.s390x
brlapi-devel-0.6.5-2.fc25.s390x
pulseaudio-libs-10.0-2.fc25.s390x
libnl3-cli-3.2.29-2.fc25.s390x
perl-libs-5.24.1-385.fc25.s390x
glib2-2.50.3-1.fc25.s390x
python3-firewall-0.4.4.4-1.fc25.noarch
python2-rpm-4.13.0.1-1.fc25.s390x
gnutls-3.5.10-1.fc25.s390x
pango-devel-1.40.4-1.fc25.s390x
dnf-1.1.10-6.fc25.noarch
texlive-metafont-bin-svn40987-33.20160520.fc25.1.s390x
texlive-xkeyval-svn35741.2.7a-33.fc25.1.noarch
texlive-euler-svn17261.2.5-33.fc25.1.noarch
texlive-mptopdf-svn41282-33.fc25.1.noarch
texlive-wasy-svn35831.0-33.fc25.1.noarch
texlive-avantgar-svn31835.0-33.fc25.1.noarch
texlive-eurosym-svn17265.1.4_subrfix-33.fc25.1.noarch
texlive-knuth-lib-svn35820.0-33.fc25.1.noarch
texlive-parallel-svn15878.0-33.fc25.1.noarch
texlive-texlive-msg-translations-svn41431-33.fc25.1.noarch
texlive-latex-svn40218-33.fc25.1.noarch
texlive-lualatex-math-svn40621-33.fc25.1.noarch
texlive-auto-pst-pdf-svn23723.0.6-33.fc25.1.noarch
texlive-powerdot-svn38984-33.fc25.1.noarch
texlive-wasysym-svn15878.2.0-33.fc25.1.noarch
ImageMagick-libs-6.9.3.0-6.fc25.s390x
geoclue2-2.4.5-1.fc25.s390x
perl-IO-Socket-IP-0.39-1.fc25.noarch
gdb-7.12.1-47.fc25.s390x
python2-pyasn1-0.2.3-1.fc25.noarch
libglvnd-0.2.999-14.20170308git8e6e102.fc25.s390x
libglvnd-gles-0.2.999-14.20170308git8e6e102.fc25.s390x
gdk-pixbuf2-devel-2.36.6-1.fc25.s390x
libidn2-2.0.0-1.fc25.s390x
system-python-libs-3.5.3-4.fc25.s390x
GeoIP-1.6.10-1.fc25.s390x
at-spi2-core-devel-2.22.1-1.fc25.s390x
gpg-pubkey-34ec9cba-54e38751
gpg-pubkey-030d5aed-55b577f0
basesystem-11-2.fc24.noarch
libmpc-1.0.2-5.fc24.s390x
libunistring-0.9.4-3.fc24.s390x
libmodman-2.0.1-12.fc24.s390x
lsscsi-0.28-3.fc24.s390x
kbd-misc-2.0.3-3.fc24.noarch
rpmconf-base-1.0.18-2.fc25.noarch
libxml2-2.9.3-4.fc25.s390x
kmod-23-1.fc25.s390x
newt-0.52.19-2.fc25.s390x
perl-Text-Unidecode-1.27-3.fc25.noarch
plymouth-core-libs-0.9.3-0.6.20160620git0e65b86c.fc25.s390x
which-2.21-1.fc25.s390x
python3-slip-0.6.4-4.fc25.noarch
python3-systemd-232-1.fc25.s390x
python-lockfile-0.11.0-4.fc25.noarch
python2-requests-2.10.0-4.fc25.noarch
libarchive-3.2.2-1.fc25.s390x
libnghttp2-1.13.0-2.fc25.s390x
python-urlgrabber-3.10.1-9.fc25.noarch
iputils-20161105-1.fc25.s390x
rest-0.8.0-1.fc25.s390x
adwaita-cursor-theme-3.22.0-1.fc25.noarch
authconfig-6.2.10-14.fc25.s390x
expat-devel-2.2.0-1.fc25.s390x
automake-1.15-7.fc25.noarch
shared-mime-info-1.8-1.fc25.s390x
pigz-2.3.4-1.fc25.s390x
device-mapper-libs-1.02.136-3.fc25.s390x
dnsmasq-2.76-2.fc25.s390x
fedora-packager-0.6.0.1-1.fc25.noarch
gcc-c++-6.3.1-1.fc25.s390x
libwebp-0.5.2-1.fc25.s390x
boost-system-1.60.0-10.fc25.s390x
libasyncns-0.8-10.fc24.s390x
libXau-devel-1.0.8-6.fc24.s390x
libverto-libev-0.2.6-6.fc24.s390x
python3-html5lib-0.999-9.fc25.noarch
ttmkfdir-3.0.9-48.fc24.s390x
pulseaudio-libs-glib2-10.0-2.fc25.s390x
wpa_supplicant-2.6-1.fc25.s390x
texlive-lib-2016-33.20160520.fc25.s390x
libXi-devel-1.7.9-1.fc25.s390x
python3-distro-1.0.3-1.fc25.noarch
rpm-plugin-systemd-inhibit-4.13.0.1-1.fc25.s390x
gnutls-c++-3.5.10-1.fc25.s390x
texlive-texlive-common-doc-svn40682-33.fc25.1.noarch
packagedb-cli-2.14.1-1.fc25.noarch
rpcbind-0.2.4-5.fc25.s390x
texlive-metafont-svn40793-33.fc25.1.noarch
texlive-tools-svn40934-33.fc25.1.noarch
texlive-enumitem-svn24146.3.5.2-33.fc25.1.noarch
texlive-mptopdf-bin-svn18674.0-33.20160520.fc25.1.noarch
texlive-underscore-svn18261.0-33.fc25.1.noarch
texlive-anysize-svn15878.0-33.fc25.1.noarch
texlive-euenc-svn19795.0.1h-33.fc25.1.noarch
texlive-kastrup-svn15878.0-33.fc25.1.noarch
texlive-paralist-svn39247-33.fc25.1.noarch
texlive-texlive-en-svn41185-33.fc25.1.noarch
texlive-tipa-svn29349.1.3-33.fc25.1.noarch
texlive-currfile-svn40725-33.fc25.1.noarch
texlive-pst-node-svn40743-33.fc25.1.noarch
texlive-pst-slpe-svn24391.1.31-33.fc25.1.noarch
texlive-typehtml-svn17134.0-33.fc25.1.noarch
SDL2-devel-2.0.5-3.fc25.s390x
perl-Module-CoreList-5.20170320-1.fc25.noarch
libcroco-0.6.11-3.fc25.s390x
publicsuffix-list-dafsa-20170206-1.fc25.noarch
pcre-8.40-6.fc25.s390x
cups-libs-2.2.0-8.fc25.s390x
gtk-update-icon-cache-3.22.11-1.fc25.s390x
libcurl-7.51.0-6.fc25.s390x
python3-libs-3.5.3-4.fc25.s390x
bluez-libs-devel-5.44-1.fc25.s390x
kernel-4.10.8-200.fc25.s390x
fontpackages-filesystem-1.44-17.fc24.noarch
groff-base-1.22.3-8.fc24.s390x
ilmbase-2.2.0-5.fc24.s390x
OpenEXR-libs-2.2.0-5.fc24.s390x
hesiod-3.2.1-6.fc24.s390x
sysfsutils-2.1.0-19.fc24.s390x
ocaml-srpm-macros-2-4.fc24.noarch
mailx-12.5-19.fc24.s390x
ncurses-libs-6.0-6.20160709.fc25.s390x
ipset-libs-6.29-1.fc25.s390x
gmp-devel-6.1.1-1.fc25.s390x
python-pip-8.1.2-2.fc25.noarch
harfbuzz-1.3.2-1.fc25.s390x
python2-iniparse-0.4-20.fc25.noarch
python3-iniparse-0.4-20.fc25.noarch
python3-kickstart-2.32-1.fc25.noarch
perl-Net-SSLeay-1.78-1.fc25.s390x
drpm-0.3.0-3.fc25.s390x
glib-networking-2.50.0-1.fc25.s390x
webkitgtk3-2.4.11-3.fc25.s390x
libXaw-1.0.13-4.fc25.s390x
xorg-x11-font-utils-7.5-32.fc25.s390x
hardlink-1.1-1.fc25.s390x
libcom_err-1.43.3-1.fc25.s390x
python2-dateutil-2.6.0-1.fc25.noarch
libXpm-3.5.12-1.fc25.s390x
python2-smmap-2.0.1-1.fc25.noarch
poppler-data-0.4.7-6.fc25.noarch
nspr-devel-4.13.1-1.fc25.s390x
librbd1-10.2.4-2.fc25.s390x
libsndfile-1.0.27-1.fc25.s390x
perl-Digest-MD5-2.55-2.fc25.s390x
wayland-protocols-devel-1.7-1.fc25.noarch
libacl-devel-2.2.52-11.fc24.s390x
texi2html-5.0-4.fc24.noarch
libxkbcommon-0.7.1-1.fc25.s390x
freetype-2.6.5-3.fc25.s390x
libuuid-devel-2.28.2-2.fc25.s390x
coreutils-common-8.25-16.fc25.s390x
gdb-headless-7.12.1-47.fc25.s390x
libcacard-2.5.3-1.fc25.s390x
perl-threads-shared-1.55-1.fc25.s390x
python2-rpkg-1.49-2.fc25.noarch
libwmf-lite-0.2.8.4-50.fc25.s390x
unbound-libs-1.6.0-6.fc25.s390x
texlive-tetex-svn41059-33.fc25.1.noarch
texlive-thumbpdf-svn34621.3.16-33.fc25.1.noarch
texlive-carlisle-svn18258.0-33.fc25.1.noarch
texlive-makeindex-bin-svn40473-33.20160520.fc25.1.s390x
texlive-pdftex-svn41149-33.fc25.1.noarch
texlive-csquotes-svn39538-33.fc25.1.noarch
texlive-courier-svn35058.0-33.fc25.1.noarch
texlive-helvetic-svn31835.0-33.fc25.1.noarch
texlive-mfnfss-svn19410.0-33.fc25.1.noarch
texlive-sepnum-svn20186.2.0-33.fc25.1.noarch
texlive-utopia-svn15878.0-33.fc25.1.noarch
texlive-luatexbase-svn38550-33.fc25.1.noarch
texlive-pst-3d-svn17257.1.10-33.fc25.1.noarch
texlive-latex-bin-bin-svn14050.0-33.20160520.fc25.1.noarch
texlive-l3experimental-svn41163-33.fc25.1.noarch
bind99-libs-9.9.9-4.P6.fc25.s390x
net-tools-2.0-0.40.20160329git.fc25.s390x
perl-Pod-Perldoc-3.28-1.fc25.noarch
openssl-1.0.2k-1.fc25.s390x
man-pages-4.06-4.fc25.noarch
libdrm-2.4.77-1.fc25.s390x
p11-kit-0.23.2-3.fc25.s390x
glusterfs-cli-3.10.1-1.fc25.s390x
git-core-2.9.3-3.fc25.s390x
python3-3.5.3-4.fc25.s390x
python3-magic-5.29-4.fc25.noarch
p11-kit-trust-0.23.2-3.fc25.s390x
gpg-pubkey-95a43f54-5284415a
dejavu-fonts-common-2.35-3.fc24.noarch
libSM-1.2.2-4.fc24.s390x
diffutils-3.3-13.fc24.s390x
libogg-1.3.2-5.fc24.s390x
hunspell-en-US-0.20140811.1-5.fc24.noarch
libdaemon-0.14-10.fc24.s390x
patch-2.7.5-3.fc24.s390x
libsysfs-2.1.0-19.fc24.s390x
procmail-3.22-39.fc24.s390x
libXdamage-1.1.4-8.fc24.s390x
libotf-0.9.13-7.fc24.s390x
urw-fonts-2.4-22.fc24.noarch
crontabs-1.11-12.20150630git.fc24.noarch
ppp-2.4.7-9.fc24.s390x
polkit-0.113-5.fc24.s390x
cyrus-sasl-2.1.26-26.2.fc24.s390x
zlib-devel-1.2.8-10.fc24.s390x
time-1.7-49.fc24.s390x
gpg-pubkey-fdb19c98-56fd6333
fedora-release-25-1.noarch
libcap-ng-0.7.8-1.fc25.s390x
binutils-2.26.1-1.fc25.s390x
lcms2-2.8-2.fc25.s390x
libcomps-0.1.7-5.fc25.s390x
less-481-6.fc25.s390x
apr-1.5.2-4.fc25.s390x
perl-constant-1.33-367.fc25.noarch
perl-Data-Dumper-2.161-1.fc25.s390x
ipcalc-0.1.8-1.fc25.s390x
libteam-1.26-1.fc25.s390x
gmp-c++-6.1.1-1.fc25.s390x
fontconfig-2.12.1-1.fc25.s390x
enchant-1.6.0-14.fc25.s390x
pyliblzma-0.5.3-16.fc25.s390x
libsepol-devel-2.5-10.fc25.s390x
python3-ordered-set-2.0.0-4.fc25.noarch
python3-rpmconf-1.0.18-2.fc25.noarch
python-ipaddress-1.0.16-3.fc25.noarch
python2-kerberos-1.2.5-1.fc25.s390x
python2-pysocks-1.5.6-5.fc25.noarch
fipscheck-lib-1.4.1-11.fc25.s390x
libatomic_ops-7.4.4-1.fc25.s390x
net-snmp-agent-libs-5.7.3-13.fc25.s390x
dracut-044-78.fc25.s390x
python2-pygpgme-0.3-18.fc25.s390x
libsoup-2.56.0-2.fc25.s390x
orc-0.4.26-1.fc25.s390x
yum-utils-1.1.31-511.fc25.noarch
libXrender-0.9.10-1.fc25.s390x
libXrandr-1.5.1-1.fc25.s390x
go-srpm-macros-2-7.fc25.noarch
gnupg2-smime-2.1.13-2.fc25.s390x
guile-devel-2.0.13-1.fc25.s390x
uboot-tools-2016.09.01-2.fc25.s390x
pykickstart-2.32-1.fc25.noarch
python-bunch-1.0.1-9.fc25.noarch
perl-generators-1.10-1.fc25.noarch
perl-Mozilla-CA-20160104-3.fc25.noarch
glibc-all-langpacks-2.24-4.fc25.s390x
bzip2-libs-1.0.6-21.fc25.s390x
libpng-1.6.27-1.fc25.s390x
desktop-file-utils-0.23-2.fc25.s390x
python2-cccolutils-1.4-1.fc25.s390x
python2-lxml-3.7.2-1.fc25.s390x
redhat-rpm-config-45-1.fc25.noarch
elfutils-libs-0.168-1.fc25.s390x
device-mapper-event-libs-1.02.136-3.fc25.s390x
lvm2-libs-2.02.167-3.fc25.s390x
elfutils-0.168-1.fc25.s390x
python2-gitdb-2.0.0-1.fc25.noarch
gcc-gfortran-6.3.1-1.fc25.s390x
libselinux-python-2.5-13.fc25.s390x
openjpeg2-2.1.2-3.fc25.s390x
js-jquery-2.2.4-1.fc25.noarch
boost-thread-1.60.0-10.fc25.s390x
json-c-0.12-7.fc24.s390x
librbd-devel-10.2.4-2.fc25.s390x
libXcursor-devel-1.1.14-6.fc24.s390x
python3-beautifulsoup4-4.5.3-1.fc25.noarch
latex2html-2012-7.fc24.noarch
lksctp-tools-1.0.16-5.fc24.s390x
vte291-0.46.1-1.fc25.s390x
libfdt-1.4.2-1.fc25.s390x
libXft-devel-2.3.2-4.fc24.s390x
libattr-devel-2.4.47-16.fc24.s390x
libiscsi-devel-1.15.0-2.fc24.s390x
gettext-0.19.8.1-3.fc25.s390x
libjpeg-turbo-devel-1.5.1-0.fc25.s390x
libX11-1.6.4-4.fc25.s390x
pulseaudio-libs-devel-10.0-2.fc25.s390x
ccache-3.3.3-1.fc25.s390x
systemd-libs-231-14.fc25.s390x
nss-softokn-freebl-3.29.3-1.0.fc25.s390x
libepoxy-devel-1.4.1-1.fc25.s390x
krb5-libs-1.14.4-7.fc25.s390x
libmount-2.28.2-2.fc25.s390x
python3-decorator-4.0.11-1.fc25.noarch
rpm-plugin-selinux-4.13.0.1-1.fc25.s390x
perl-threads-2.15-1.fc25.s390x
tzdata-java-2017b-1.fc25.noarch
python-srpm-macros-3-12.fc25.noarch
libsmartcols-2.28.2-2.fc25.s390x
kernel-core-4.10.5-200.fc25.s390x
kernel-modules-4.10.5-200.fc25.s390x
texlive-kpathsea-svn41139-33.fc25.1.noarch
texlive-amsmath-svn41561-33.fc25.1.noarch
texlive-thumbpdf-bin-svn6898.0-33.20160520.fc25.1.noarch
texlive-psnfss-svn33946.9.2a-33.fc25.1.noarch
texlive-subfig-svn15878.1.3-33.fc25.1.noarch
texlive-fancybox-svn18304.1.4-33.fc25.1.noarch
texlive-lua-alt-getopt-svn29349.0.7.0-33.fc25.1.noarch
texlive-natbib-svn20668.8.31b-33.fc25.1.noarch
texlive-pdftex-bin-svn40987-33.20160520.fc25.1.s390x
texlive-xdvi-svn40768-33.fc25.1.noarch
texlive-crop-svn15878.1.5-33.fc25.1.noarch
texlive-babel-english-svn30264.3.3p-33.fc25.1.noarch
texlive-cmextra-svn32831.0-33.fc25.1.noarch
texlive-fancyhdr-svn15878.3.1-33.fc25.1.noarch
texlive-luatex-svn40963-33.fc25.1.noarch
texlive-knuth-local-svn38627-33.fc25.1.noarch
texlive-mflogo-font-svn36898.1.002-33.fc25.1.noarch
texlive-parskip-svn19963.2.0-33.fc25.1.noarch
texlive-section-svn20180.0-33.fc25.1.noarch
texlive-textcase-svn15878.0-33.fc25.1.noarch
texlive-updmap-map-svn41159-33.fc25.1.noarch
texlive-attachfile-svn38830-33.fc25.1.noarch
nss-3.29.3-1.1.fc25.s390x
glusterfs-client-xlators-3.10.1-1.fc25.s390x
libglvnd-glx-0.2.999-14.20170308git8e6e102.fc25.s390x
libtiff-4.0.7-4.fc25.s390x
dbus-devel-1.11.12-1.fc25.s390x
java-1.8.0-openjdk-headless-1.8.0.121-10.b14.fc25.s390x
pcre2-utf16-10.23-5.fc25.s390x
git-core-doc-2.9.3-3.fc25.s390x
iproute-4.10.0-1.fc25.s390x
nfs-utils-2.1.1-3.rc1.fc25.s390x
libglvnd-core-devel-0.2.999-14.20170308git8e6e102.fc25.s390x
python-magic-5.29-4.fc25.noarch
pcre2-devel-10.23-5.fc25.s390x
p11-kit-devel-0.23.2-3.fc25.s390x
texlive-luaotfload-svn40902-33.fc25.1.noarch
texlive-unicode-math-svn38462-33.fc25.1.noarch
texlive-fancyvrb-svn18492.2.8-33.fc25.1.noarch
texlive-pst-pdf-bin-svn7838.0-33.20160520.fc25.1.noarch
texlive-amscls-svn36804.0-33.fc25.1.noarch
texlive-ltxmisc-svn21927.0-33.fc25.1.noarch
texlive-breqn-svn38099.0.98d-33.fc25.1.noarch
texlive-xetex-def-svn40327-33.fc25.1.noarch
openssh-server-7.4p1-4.fc25.s390x
sendmail-8.15.2-8.fc25.s390x
python-firewall-0.4.4.4-1.fc25.noarch
python3-sssdconfig-1.15.2-1.fc25.noarch
tzdata-2017b-1.fc25.noarch
hunspell-1.4.1-2.fc25.s390x
gpg-pubkey-8e1431d5-53bcbac7
zlib-1.2.8-10.fc24.s390x
sed-4.2.2-15.fc24.s390x
psmisc-22.21-8.fc24.s390x
gpm-libs-1.20.7-9.fc24.s390x
zip-3.0-16.fc24.s390x
hostname-3.15-7.fc24.s390x
libyubikey-1.13-2.fc24.s390x
sg3_utils-libs-1.41-3.fc24.s390x
polkit-pkla-compat-0.1-7.fc24.s390x
passwd-0.79-8.fc24.s390x
trousers-0.3.13-6.fc24.s390x
grubby-8.40-3.fc24.s390x
rootfiles-8.1-19.fc24.noarch
nettle-3.3-1.fc25.s390x
jansson-2.9-1.fc25.s390x
libksba-1.3.5-1.fc25.s390x
perl-Text-ParseWords-3.30-365.fc25.noarch
perl-PathTools-3.63-366.fc25.s390x
perl-File-Temp-0.23.04-365.fc25.noarch
fuse-libs-2.9.7-1.fc25.s390x
perl-Pod-Escapes-1.07-365.fc25.noarch
perl-Term-ANSIColor-4.05-2.fc25.noarch
perl-URI-1.71-5.fc25.noarch
libXfont-1.5.2-1.fc25.s390x
python-six-1.10.0-3.fc25.noarch
dbus-glib-0.108-1.fc25.s390x
gobject-introspection-1.50.0-1.fc25.s390x
libpwquality-1.3.0-6.fc25.s390x
python-gobject-base-3.22.0-1.fc25.s390x
python-html5lib-0.999-9.fc25.noarch
python3-dbus-1.2.4-2.fc25.s390x
python3-chardet-2.3.0-1.fc25.noarch
python3-urllib3-1.15.1-3.fc25.noarch
python-offtrac-0.1.0-7.fc25.noarch
python2-cryptography-1.5.3-3.fc25.s390x
python2-requests-kerberos-0.10.0-2.fc25.noarch
libserf-1.3.9-1.fc25.s390x
libdatrie-0.2.9-3.fc25.s390x
s390utils-base-1.36.0-1.fc25.s390x
kpartx-0.4.9-83.fc25.s390x
s390utils-cpuplugd-1.36.0-1.fc25.s390x
rpmconf-1.0.18-2.fc25.noarch
s390utils-osasnmpd-1.36.0-1.fc25.s390x
python-dnf-plugins-extras-common-0.0.12-4.fc25.noarch
fpc-srpm-macros-1.0-1.fc25.noarch
libuser-0.62-4.fc25.s390x
man-db-2.7.5-3.fc25.s390x
sqlite-3.14.2-1.fc25.s390x
python-systemd-doc-232-1.fc25.s390x
libdb-5.3.28-16.fc25.s390x
lz4-1.7.5-1.fc25.s390x
tar-1.29-3.fc25.s390x
emacs-common-25.1-3.fc25.s390x
unzip-6.0-31.fc25.s390x
bodhi-client-0.9.12.2-6.fc25.noarch
glibc-headers-2.24-4.fc25.s390x
cairo-1.14.8-1.fc25.s390x
ca-certificates-2017.2.11-1.0.fc25.noarch
NetworkManager-glib-1.4.4-3.fc25.s390x
gcc-go-6.3.1-1.fc25.s390x
cracklib-dicts-2.9.6-4.fc25.s390x
libselinux-python3-2.5-13.fc25.s390x
python2-enchant-1.6.8-1.fc25.noarch
boost-iostreams-1.60.0-10.fc25.s390x
userspace-rcu-0.9.2-2.fc25.s390x
libXext-devel-1.3.3-4.fc24.s390x
libXrandr-devel-1.5.1-1.fc25.s390x
perl-XML-XPath-1.39-1.fc25.noarch
python3-lxml-3.7.2-1.fc25.s390x
vte-profile-0.46.1-1.fc25.s390x
sqlite-devel-3.14.2-1.fc25.s390x
libiscsi-1.15.0-2.fc24.s390x
fontconfig-devel-2.12.1-1.fc25.s390x
libfdt-devel-1.4.2-1.fc25.s390x
ceph-devel-compat-10.2.4-2.fc25.s390x
zlib-static-1.2.8-10.fc24.s390x
chrpath-0.16-3.fc24.s390x
python-2.7.13-1.fc25.s390x
kernel-core-4.9.5-200.fc25.s390x
info-6.1-4.fc25.s390x
iptables-libs-1.6.0-3.fc25.s390x
bind-license-9.10.4-4.P6.fc25.noarch
lua-5.3.4-1.fc25.s390x
libfdisk-2.28.2-2.fc25.s390x
dnf-plugins-core-0.1.21-5.fc25.noarch
selinux-policy-3.13.1-225.11.fc25.noarch
perl-Errno-1.25-385.fc25.s390x
perl-Storable-2.56-368.fc25.s390x
python2-decorator-4.0.11-1.fc25.noarch
mariadb-common-10.1.21-3.fc25.s390x
systemtap-client-3.1-2.fc25.s390x
libnetfilter_conntrack-1.0.6-2.fc25.s390x
texlive-texlive.infra-bin-svn40312-33.20160520.fc25.1.s390x
texlive-ifluatex-svn41346-33.fc25.1.noarch
texlive-fp-svn15878.0-33.fc25.1.noarch
texlive-latex-fonts-svn28888.0-33.fc25.1.noarch
texlive-bibtex-bin-svn40473-33.20160520.fc25.1.s390x
texlive-glyphlist-svn28576.0-33.fc25.1.noarch
texlive-marvosym-svn29349.2.2a-33.fc25.1.noarch
texlive-tex-bin-svn40987-33.20160520.fc25.1.s390x
texlive-texconfig-svn40768-33.fc25.1.noarch
texlive-wasy2-ps-svn35830.0-33.fc25.1.noarch
texlive-psfrag-svn15878.3.04-33.fc25.1.noarch
texlive-charter-svn15878.0-33.fc25.1.noarch
texlive-ec-svn25033.1.0-33.fc25.1.noarch
texlive-lineno-svn21442.4.41-33.fc25.1.noarch
texlive-hyphen-base-svn41138-33.fc25.1.noarch
texlive-manfnt-font-svn35799.0-33.fc25.1.noarch
texlive-ncntrsbk-svn31835.0-33.fc25.1.noarch
texlive-pst-math-svn34786.0.63-33.fc25.1.noarch
texlive-symbol-svn31835.0-33.fc25.1.noarch
texlive-environ-svn33821.0.3-33.fc25.1.noarch
texlive-algorithms-svn38085.0.1-33.fc25.1.noarch
glusterfs-libs-3.10.1-1.fc25.s390x
mesa-libwayland-egl-13.0.4-3.fc25.s390x
glusterfs-api-3.10.1-1.fc25.s390x
kernel-core-4.10.8-200.fc25.s390x
mesa-libwayland-egl-devel-13.0.4-3.fc25.s390x
nss-tools-3.29.3-1.1.fc25.s390x
pcre2-10.23-5.fc25.s390x
perl-Git-2.9.3-3.fc25.noarch
gssproxy-0.7.0-3.fc25.s390x
glusterfs-server-3.10.1-1.fc25.s390x
libglvnd-devel-0.2.999-14.20170308git8e6e102.fc25.s390x
python3-hawkey-0.6.4-3.fc25.s390x
vim-enhanced-8.0.514-1.fc25.s390x
mesa-libgbm-devel-13.0.4-3.fc25.s390x
texlive-ifplatform-svn21156.0.4-33.fc25.1.noarch
texlive-eso-pic-svn37925.2.0g-33.fc25.1.noarch
texlive-xcolor-svn41044-33.fc25.1.noarch
texlive-pst-eps-svn15878.1.0-33.fc25.1.noarch
texlive-pst-text-svn15878.1.00-33.fc25.1.noarch
texlive-rotating-svn16832.2.16b-33.fc25.1.noarch
texlive-pdfpages-svn40638-33.fc25.1.noarch
texlive-cm-super-svn15878.0-33.fc25.1.noarch
texlive-xetex-svn41438-33.fc25.1.noarch
dnf-yum-1.1.10-6.fc25.noarch
mariadb-libs-10.1.21-3.fc25.s390x
rpmlint-1.9-8.fc25.noarch
systemtap-sdt-devel-3.1-2.fc25.s390x
libseccomp-devel-2.3.2-1.fc25.s390x
telnet-0.17-67.fc25.s390x
gpgme-1.8.0-10.fc25.s390x
apr-util-1.5.4-3.fc24.s390x
rsync-3.1.2-2.fc24.s390x
jbigkit-libs-2.1-5.fc24.s390x
pixman-0.34.0-2.fc24.s390x
dwz-0.12-2.fc24.s390x
expect-5.45-22.fc24.s390x
libsigsegv-2.10-10.fc24.s390x
fakeroot-libs-1.20.2-4.fc24.s390x
m17n-lib-1.7.0-5.fc24.s390x
libverto-0.2.6-6.fc24.s390x
libXmu-1.1.2-4.fc24.s390x
libXcursor-1.1.14-6.fc24.s390x
python-kitchen-1.2.4-2.fc24.noarch
polkit-libs-0.113-5.fc24.s390x
fakeroot-1.20.2-4.fc24.s390x
blktrace-1.1.0-3.fc24.s390x
usermode-1.111-8.fc24.s390x
kbd-2.0.3-3.fc24.s390x
libaio-devel-0.3.110-6.fc24.s390x
web-assets-filesystem-5-4.fc24.noarch
expat-2.2.0-1.fc25.s390x
libgpg-error-1.24-1.fc25.s390x
libgcrypt-1.6.6-1.fc25.s390x
findutils-4.6.0-8.fc25.s390x
libassuan-2.4.3-1.fc25.s390x
libusbx-1.0.21-1.fc25.s390x
libxslt-1.1.28-13.fc25.s390x
libmetalink-0.1.3-1.fc25.s390x
perl-File-Path-2.12-365.fc25.noarch
perl-MIME-Base64-3.15-365.fc25.s390x
ncurses-6.0-6.20160709.fc25.s390x
libwayland-server-1.12.0-1.fc25.s390x
perl-Fedora-VSP-0.001-4.fc25.noarch
perl-libintl-perl-1.26-1.fc25.s390x
shadow-utils-4.2.1-11.fc25.s390x
atk-2.22.0-1.fc25.s390x
pam-1.3.0-1.fc25.s390x
harfbuzz-icu-1.3.2-1.fc25.s390x
libsecret-0.18.5-2.fc25.s390x
s390utils-iucvterm-1.36.0-1.fc25.s390x
python3-requests-2.10.0-4.fc25.noarch
pyusb-1.0.0-2.fc25.noarch
python-enum34-1.0.4-6.fc25.noarch
pyOpenSSL-16.0.0-2.fc25.noarch
pyxattr-0.5.3-8.fc25.s390x
libbabeltrace-1.4.0-3.fc25.s390x
libthai-0.1.25-1.fc25.s390x
deltarpm-3.6-17.fc25.s390x
s390utils-mon_statd-1.36.0-1.fc25.s390x
device-mapper-multipath-0.4.9-83.fc25.s390x
python3-pygpgme-0.3-18.fc25.s390x
libreport-filesystem-2.8.0-1.fc25.s390x
ghc-srpm-macros-1.4.2-4.fc25.noarch
rpmdevtools-8.9-1.fc25.noarch
python-dnf-plugins-extras-migrate-0.0.12-4.fc25.noarch
perl-IO-Socket-SSL-2.038-1.fc25.noarch
perl-File-ShareDir-1.102-7.fc25.noarch
tcl-8.6.6-1.fc25.s390x
glibc-2.24-4.fc25.s390x
elfutils-libelf-0.168-1.fc25.s390x
perl-Scalar-List-Utils-1.47-1.fc25.s390x
bzip2-1.0.6-21.fc25.s390x
libss-1.43.3-1.fc25.s390x
libselinux-utils-2.5-13.fc25.s390x
koji-1.11.0-1.fc25.noarch
python3-enchant-1.6.8-1.fc25.noarch
python2-dockerfile-parse-0.0.5-7.fc25.noarch
systemd-bootchart-231-2.fc25.s390x
gcc-objc-6.3.1-1.fc25.s390x
e2fsprogs-1.43.3-1.fc25.s390x
libstdc++-static-6.3.1-1.fc25.s390x
libpng-devel-1.6.27-1.fc25.s390x
perl-XML-Parser-2.44-5.fc25.s390x
lttng-ust-2.8.1-2.fc25.s390x
libXfixes-devel-5.0.3-1.fc25.s390x
libXcomposite-devel-0.4.4-8.fc24.s390x
quota-nls-4.03-7.fc25.noarch
python3-javapackages-4.7.0-6.1.fc25.noarch
libcephfs_jni-devel-10.2.4-2.fc25.s390x
keyutils-libs-devel-1.5.9-8.fc24.s390x
libicu-devel-57.1-4.fc25.s390x
harfbuzz-devel-1.3.2-1.fc25.s390x
libidn-devel-1.33-1.fc25.s390x
libnfs-1.9.8-2.fc24.s390x
libssh2-devel-1.8.0-1.fc25.s390x
qemu-sanity-check-nodeps-1.1.5-5.fc24.s390x
alsa-lib-devel-1.1.1-2.fc25.s390x
libnl3-3.2.29-2.fc25.s390x
kernel-modules-4.9.5-200.fc25.s390x
libpsl-0.17.0-1.fc25.s390x
lua-libs-5.3.4-1.fc25.s390x
libseccomp-2.3.2-1.fc25.s390x
nss-softokn-freebl-devel-3.29.3-1.0.fc25.s390x
copy-jdk-configs-2.2-2.fc25.noarch
json-glib-1.2.6-1.fc25.s390x
python2-dnf-1.1.10-6.fc25.noarch
bind-libs-lite-9.10.4-4.P6.fc25.s390x
perl-IO-1.36-385.fc25.s390x
python2-GitPython-2.1.3-1.fc25.noarch
linux-firmware-20170313-72.git695f2d6d.fc25.noarch
systemd-container-231-14.fc25.s390x
gnutls-dane-3.5.10-1.fc25.s390x
texlive-tetex-bin-svn36770.0-33.20160520.fc25.1.noarch
texlive-amsfonts-svn29208.3.04-33.fc25.1.noarch
texlive-babel-svn40706-33.fc25.1.noarch
texlive-colortbl-svn29803.v1.0a-33.fc25.1.noarch
texlive-babelbib-svn25245.1.31-33.fc25.1.noarch
texlive-footmisc-svn23330.5.5b-33.fc25.1.noarch
texlive-makeindex-svn40768-33.fc25.1.noarch
texlive-plain-svn40274-33.fc25.1.noarch
texlive-texconfig-bin-svn29741.0-33.20160520.fc25.1.noarch
texlive-zapfding-svn31835.0-33.fc25.1.noarch
texlive-microtype-svn41127-33.fc25.1.noarch
texlive-bookman-svn31835.0-33.fc25.1.noarch
texlive-dvisvgm-def-svn41011-33.fc25.1.noarch
texlive-finstrut-svn21719.0.5-33.fc25.1.noarch
texlive-hyph-utf8-svn41189-33.fc25.1.noarch
texlive-lualibs-svn40370-33.fc25.1.noarch
glusterfs-3.10.1-1.fc25.s390x
mesa-libglapi-13.0.4-3.fc25.s390x
mesa-libgbm-13.0.4-3.fc25.s390x
kernel-modules-4.10.8-200.fc25.s390x
glusterfs-fuse-3.10.1-1.fc25.s390x
openldap-2.4.44-10.fc25.s390x
pcre-utf32-8.40-6.fc25.s390x
git-2.9.3-3.fc25.s390x
python2-gluster-3.10.1-1.fc25.s390x
glusterfs-devel-3.10.1-1.fc25.s390x
mesa-libEGL-devel-13.0.4-3.fc25.s390x
glusterfs-api-devel-3.10.1-1.fc25.s390x
sudo-1.8.19p2-1.fc25.s390x
python2-hawkey-0.6.4-3.fc25.s390x
texlive-mparhack-svn15878.1.4-33.fc25.1.noarch
texlive-pspicture-svn15878.0-33.fc25.1.noarch
texlive-soul-svn15878.2.4-33.fc25.1.noarch
texlive-trimspaces-svn15878.1.1-33.fc25.1.noarch
texlive-varwidth-svn24104.0.92-33.fc25.1.noarch
texlive-geometry-svn19716.5.6-33.fc25.1.noarch
texlive-memoir-svn41203-33.fc25.1.noarch
texlive-pgf-svn40966-33.fc25.1.noarch
texlive-pst-coil-svn37377.1.07-33.fc25.1.noarch
texlive-pst-plot-svn41242-33.fc25.1.noarch
texlive-latex-bin-svn41438-33.fc25.1.noarch
texlive-ucs-svn35853.2.2-33.fc25.1.noarch
texlive-ae-svn15878.1.4-33.fc25.1.noarch
texlive-xetex-bin-svn41091-33.20160520.fc25.1.s390x
fedora-upgrade-26.1-1.fc25.noarch
fedpkg-1.28-1.fc25.noarch
perl-Thread-Queue-3.12-1.fc25.noarch
gstreamer1-plugins-base-1.10.4-1.fc25.s390x
screen-4.5.1-1.fc25.s390x
strace-4.16-1.fc25.s390x
fedora-repos-25-3.noarch
libacl-2.2.52-11.fc24.s390x
cdparanoia-libs-10.2-21.fc24.s390x
ustr-1.0.4-21.fc24.s390x
libusb-0.1.5-7.fc24.s390x
readline-devel-6.3-8.fc24.s390x
chkconfig-1.8-1.fc25.s390x
avahi-libs-0.6.32-4.fc25.s390x
perl-Unicode-Normalize-1.25-365.fc25.s390x
perl-libnet-3.10-1.fc25.noarch
perl-podlators-4.09-1.fc25.noarch
graphite2-1.3.6-1.fc25.s390x
dbus-python-1.2.4-2.fc25.s390x
libgnome-keyring-3.12.0-7.fc25.s390x
python-backports-1.0-8.fc25.s390x
python-pycparser-2.14-7.fc25.noarch
plymouth-scripts-0.9.3-0.6.20160620git0e65b86c.fc25.s390x
cronie-1.5.1-2.fc25.s390x
python2-librepo-1.7.18-3.fc25.s390x
libXv-1.0.11-1.fc25.s390x
python2-ndg_httpsclient-0.4.0-4.fc25.noarch
btrfs-progs-4.6.1-1.fc25.s390x
libgcc-6.3.1-1.fc25.s390x
libgomp-6.3.1-1.fc25.s390x
perl-Encode-2.88-5.fc25.s390x
cracklib-2.9.6-4.fc25.s390x
libobjc-6.3.1-1.fc25.s390x
gcc-6.3.1-1.fc25.s390x
python3-dnf-plugin-system-upgrade-0.7.1-4.fc25.noarch
NetworkManager-1.4.4-3.fc25.s390x
glibc-static-2.24-4.fc25.s390x
boost-random-1.60.0-10.fc25.s390x
libref_array-0.1.5-29.fc25.s390x
libXrender-devel-0.9.10-1.fc25.s390x
javapackages-tools-4.7.0-6.1.fc25.noarch
keyutils-1.5.9-8.fc24.s390x
libcom_err-devel-1.43.3-1.fc25.s390x
graphite2-devel-1.3.6-1.fc25.s390x
lzo-minilzo-2.08-8.fc24.s390x
libusbx-devel-1.0.21-1.fc25.s390x
virglrenderer-devel-0.5.0-1.20160411git61846f92f.fc25.s390x
acpica-tools-20160831-1.fc25.s390x
grep-2.27-2.fc25.s390x
dnf-conf-1.1.10-6.fc25.noarch
crypto-policies-20160921-4.gitf3018dd.fc25.noarch
rpm-build-libs-4.13.0.1-1.fc25.s390x
libnfsidmap-0.27-1.fc25.s390x
systemtap-devel-3.1-2.fc25.s390x
systemd-231-14.fc25.s390x
SDL2-2.0.5-3.fc25.s390x
texlive-etex-pkg-svn39355-33.fc25.1.noarch
texlive-multido-svn18302.1.42-33.fc25.1.noarch
texlive-gsftopk-svn40768-33.fc25.1.noarch
texlive-pst-ovl-svn40873-33.fc25.1.noarch
texlive-ltabptch-svn17533.1.74d-33.fc25.1.noarch
texlive-cite-svn36428.5.5-33.fc25.1.noarch
texlive-fpl-svn15878.1.002-33.fc25.1.noarch
texlive-mathpazo-svn15878.1.003-33.fc25.1.noarch
texlive-rcs-svn15878.0-33.fc25.1.noarch
texlive-type1cm-svn21820.0-33.fc25.1.noarch
texlive-l3kernel-svn41246-33.fc25.1.noarch
texlive-hyperref-svn41396-33.fc25.1.noarch
texlive-pst-tree-svn24142.1.12-33.fc25.1.noarch
texlive-sansmathaccent-svn30187.0-33.fc25.1.noarch
texlive-dvipdfmx-bin-svn40273-33.20160520.fc25.1.s390x
texlive-zapfchan-svn31835.0-33.fc25.1.noarch
firewalld-0.4.4.4-1.fc25.noarch
glib2-static-2.50.3-1.fc25.s390x
libmicrohttpd-0.9.52-3.fc25.s390x
perl-open-1.10-385.fc25.noarch
bash-completion-2.5-1.fc25.noarch
libsolv-0.6.26-3.fc25.s390x
ghostscript-core-9.20-7.fc25.s390x
nss-util-devel-3.29.3-1.1.fc25.s390x
kernel-headers-4.10.8-200.fc25.s390x
system-python-3.5.3-4.fc25.s390x
iproute-tc-4.10.0-1.fc25.s390x
audit-2.7.4-1.fc25.s390x
gpg-pubkey-a29cb19c-53bcbba6
m4-1.4.17-9.fc24.s390x
liblockfile-1.09-4.fc24.s390x
sg3_utils-1.41-3.fc24.s390x
libXinerama-1.1.3-6.fc24.s390x
libXft-2.3.2-4.fc24.s390x
tcp_wrappers-libs-7.6-83.fc25.s390x
perl-Text-Tabs+Wrap-2013.0523-365.fc25.noarch
perl-Error-0.17024-7.fc25.noarch
perl-Term-Cap-1.17-365.fc25.noarch
perl-Pod-Usage-1.69-1.fc25.noarch
device-mapper-persistent-data-0.6.3-1.fc25.s390x
net-snmp-libs-5.7.3-13.fc25.s390x
libgusb-0.2.9-1.fc25.s390x
python3-six-1.10.0-3.fc25.noarch
python3-pysocks-1.5.6-5.fc25.noarch
python-chardet-2.3.0-1.fc25.noarch
python2-cffi-1.7.0-2.fc25.s390x
gc-devel-7.4.4-1.fc25.s390x
plymouth-0.9.3-0.6.20160620git0e65b86c.fc25.s390x
ebtables-2.0.10-21.fc25.s390x
python3-librepo-1.7.18-3.fc25.s390x
net-snmp-5.7.3-13.fc25.s390x
at-spi2-atk-2.22.0-1.fc25.s390x
avahi-autoipd-0.6.32-4.fc25.s390x
libcrypt-nss-2.24-4.fc25.s390x
libgo-6.3.1-1.fc25.s390x
cpp-6.3.1-1.fc25.s390x
glibc-devel-2.24-4.fc25.s390x
emacs-25.1-3.fc25.s390x
pyparsing-2.1.10-1.fc25.noarch
libproxy-0.4.14-1.fc25.s390x
python3-pyparsing-2.1.10-1.fc25.noarch
libcollection-0.7.0-29.fc25.s390x
libcephfs-devel-10.2.4-2.fc25.s390x
libXdamage-devel-1.1.4-8.fc24.s390x
libverto-devel-0.2.6-6.fc24.s390x
snappy-1.1.3-2.fc24.s390x
cairo-gobject-devel-1.14.8-1.fc25.s390x
cyrus-sasl-devel-2.1.26-26.2.fc24.s390x
kernel-devel-4.9.5-200.fc25.s390x
libXi-1.7.9-1.fc25.s390x
distribution-gpg-keys-1.11-1.fc25.noarch
texlive-base-2016-33.20160520.fc25.noarch
gstreamer1-1.10.4-1.fc25.s390x
python3-rpm-4.13.0.1-1.fc25.s390x
systemtap-runtime-3.1-2.fc25.s390x
perl-SelfLoader-1.23-385.fc25.noarch
bind99-license-9.9.9-4.P6.fc25.noarch
texlive-booktabs-svn40846-33.fc25.1.noarch
texlive-lm-svn28119.2.004-33.fc25.1.noarch
texlive-gsftopk-bin-svn40473-33.20160520.fc25.1.s390x
texlive-tex-svn40793-33.fc25.1.noarch
texlive-fancyref-svn15878.0.9c-33.fc25.1.noarch
texlive-chngcntr-svn17157.1.0a-33.fc25.1.noarch
texlive-fix2col-svn38770-33.fc25.1.noarch
texlive-marginnote-svn41382-33.fc25.1.noarch
texlive-pxfonts-svn15878.0-33.fc25.1.noarch
texlive-txfonts-svn15878.0-33.fc25.1.noarch
texlive-l3packages-svn41246-33.fc25.1.noarch
texlive-oberdiek-svn41346-33.fc25.1.noarch
texlive-pst-tools-svn34067.0.05-33.fc25.1.noarch
texlive-tex-gyre-svn18651.2.004-33.fc25.1.noarch
texlive-dvipdfmx-svn41149-33.fc25.1.noarch
texlive-collection-fontsrecommended-svn35830.0-33.20160520.fc25.1.noarch
gnutls-devel-3.5.10-1.fc25.s390x
libcacard-devel-2.5.3-1.fc25.s390x
selinux-policy-targeted-3.13.1-225.11.fc25.noarch
ykpers-1.18.0-2.fc25.s390x
python2-idna-2.5-1.fc25.noarch
dbus-libs-1.11.12-1.fc25.s390x
ghostscript-x11-9.20-7.fc25.s390x
vim-minimal-8.0.514-1.fc25.s390x
libdrm-devel-2.4.77-1.fc25.s390x
file-libs-5.29-4.fc25.s390x
gtk3-devel-3.22.11-1.fc25.s390x
policycoreutils-2.5-20.fc25.s390x
python-async-0.6.1-9.fc22.s390x
dejavu-sans-mono-fonts-2.35-3.fc24.noarch
popt-1.16-7.fc24.s390x
cyrus-sasl-lib-2.1.26-26.2.fc24.s390x
xz-5.2.2-2.fc24.s390x
libpipeline-1.4.1-2.fc24.s390x
pinentry-0.9.7-2.fc24.s390x
pth-2.0.7-27.fc24.s390x
libsepol-2.5-10.fc25.s390x
sqlite-libs-3.14.2-1.fc25.s390x
libxcb-1.12-1.fc25.s390x
libicu-57.1-4.fc25.s390x
perl-Getopt-Long-2.49.1-1.fc25.noarch
avahi-glib-0.6.32-4.fc25.s390x
python3-pip-8.1.2-2.fc25.noarch
python3-libcomps-0.1.7-5.fc25.s390x
python-slip-0.6.4-4.fc25.noarch
python2-libcomps-0.1.7-5.fc25.s390x
gc-7.4.4-1.fc25.s390x
s390utils-cmsfs-1.36.0-1.fc25.s390x
newt-python-0.52.19-2.fc25.s390x
valgrind-3.12.0-1.fc25.s390x
emacs-filesystem-25.1-3.fc25.noarch
libdb-utils-5.3.28-16.fc25.s390x
qt5-srpm-macros-5.7.1-1.fc25.noarch
elfutils-default-yama-scope-0.168-1.fc25.noarch
device-mapper-event-1.02.136-3.fc25.s390x
perl-Class-Inspector-1.31-2.fc25.noarch
poppler-0.45.0-2.fc25.s390x
libbasicobjects-0.1.1-29.fc25.s390x
libradosstriper1-10.2.4-2.fc25.s390x
libXxf86vm-devel-1.1.4-3.fc24.s390x
gsm-1.0.16-1.fc25.s390x
zziplib-0.13.62-7.fc24.s390x
libpaper-1.1.24-12.fc24.s390x
libini_config-1.3.0-29.fc25.s390x
snappy-devel-1.1.3-2.fc24.s390x
libcap-ng-devel-0.7.8-1.fc25.s390x
libxkbcommon-devel-0.7.1-1.fc25.s390x
kernel-4.9.5-200.fc25.s390x
nss-softokn-3.29.3-1.0.fc25.s390x
openssl-libs-1.0.2k-1.fc25.s390x
libkadm5-1.14.4-7.fc25.s390x
rpm-libs-4.13.0.1-1.fc25.s390x
perl-5.24.1-385.fc25.s390x
util-linux-2.28.2-2.fc25.s390x
libICE-1.0.9-8.fc25.s390x
texlive-etoolbox-svn38031.2.2a-33.fc25.1.noarch
texlive-dvips-svn41149-33.fc25.1.noarch
texlive-latexconfig-svn40274-33.fc25.1.noarch
texlive-tex-ini-files-svn40533-33.fc25.1.noarch
texlive-qstest-svn15878.0-33.fc25.1.noarch
texlive-cmap-svn41168-33.fc25.1.noarch
texlive-luatex-bin-svn41091-33.20160520.fc25.1.s390x
texlive-mflogo-svn38628-33.fc25.1.noarch
texlive-sansmath-svn17997.1.1-33.fc25.1.noarch
texlive-unicode-data-svn39808-33.fc25.1.noarch
texlive-luaotfload-bin-svn34647.0-33.20160520.fc25.1.noarch
texlive-listings-svn37534.1.6-33.fc25.1.noarch
texlive-pstricks-svn41321-33.fc25.1.noarch
texlive-metalogo-svn18611.0.12-33.fc25.1.noarch
texlive-collection-latex-svn41011-33.20160520.fc25.1.noarch
kernel-4.10.5-200.fc25.s390x
python2-dnf-plugins-core-0.1.21-5.fc25.noarch
xkeyboard-config-2.20-2.fc25.noarch
nss-util-3.29.3-1.1.fc25.s390x
dbus-1.11.12-1.fc25.s390x
ghostscript-9.20-7.fc25.s390x
vim-filesystem-8.0.514-1.fc25.s390x
jasper-libs-1.900.13-3.fc25.s390x
file-5.29-4.fc25.s390x
curl-7.51.0-6.fc25.s390x
perl-Test-Harness-3.39-1.fc25.noarch
libattr-2.4.47-16.fc24.s390x
acl-2.2.52-11.fc24.s390x
libvisual-0.4.0-20.fc24.s390x
libpcap-1.7.4-2.fc24.s390x
libutempter-1.1.6-8.fc24.s390x
libgudev-230-3.fc24.s390x
popt-devel-1.16-7.fc24.s390x
make-4.1-5.fc24.s390x
hicolor-icon-theme-0.15-3.fc24.noarch
setup-2.10.4-1.fc25.noarch
bash-4.3.43-4.fc25.s390x
nspr-4.13.1-1.fc25.s390x
libjpeg-turbo-1.5.1-0.fc25.s390x
perl-Socket-2.024-1.fc25.s390x
perl-HTTP-Tiny-0.070-1.fc25.noarch
ipset-6.29-1.fc25.s390x
python2-setuptools-25.1.1-1.fc25.noarch
gsettings-desktop-schemas-3.22.0-1.fc25.s390x
python3-setuptools-25.1.1-1.fc25.noarch
python-slip-dbus-0.6.4-4.fc25.noarch
python2-ply-3.8-2.fc25.noarch
dtc-1.4.2-1.fc25.s390x
guile-2.0.13-1.fc25.s390x
cronie-anacron-1.5.1-2.fc25.s390x
libXtst-1.2.3-1.fc25.s390x
iso-codes-3.70-1.fc25.noarch
s390utils-1.36.0-1.fc25.s390x
python-backports-ssl_match_hostname-3.5.0.1-3.fc25.noarch
fedora-cert-0.6.0.1-1.fc25.noarch
libstdc++-6.3.1-1.fc25.s390x
subversion-libs-1.9.5-1.fc25.s390x
libgfortran-6.3.1-1.fc25.s390x
libtasn1-4.10-1.fc25.s390x
dnf-plugin-system-upgrade-0.7.1-4.fc25.noarch
lvm2-2.02.167-3.fc25.s390x
libselinux-devel-2.5-13.fc25.s390x
perl-Time-Local-1.250-1.fc25.noarch
libtirpc-1.0.1-3.rc3.fc25.s390x
libradosstriper-devel-10.2.4-2.fc25.s390x
flac-libs-1.3.2-1.fc25.s390x
perl-Digest-1.17-366.fc25.noarch
teckit-2.5.1-15.fc24.s390x
libpath_utils-0.2.1-29.fc25.s390x
attr-2.4.47-16.fc24.s390x
usbredir-0.7.1-2.fc24.s390x
cairo-devel-1.14.8-1.fc25.s390x
lzo-devel-2.08-8.fc24.s390x
libcap-devel-2.25-2.fc25.s390x
opus-1.1.3-2.fc25.s390x
firewalld-filesystem-0.4.4.4-1.fc25.noarch
coreutils-8.25-16.fc25.s390x
krb5-devel-1.14.4-7.fc25.s390x
rpm-4.13.0.1-1.fc25.s390x
kernel-devel-4.10.5-200.fc25.s390x
systemd-pam-231-14.fc25.s390x
libbsd-0.8.3-1.fc25.s390x
texlive-url-svn32528.3.4-33.fc25.1.noarch
texlive-dvips-bin-svn40987-33.20160520.fc25.1.s390x
texlive-index-svn24099.4.1beta-33.fc25.1.noarch
texlive-setspace-svn24881.6.7a-33.fc25.1.noarch
texlive-mathtools-svn38833-33.fc25.1.noarch
texlive-cm-svn32865.0-33.fc25.1.noarch
texlive-graphics-def-svn41879-33.fc25.1.noarch
texlive-mdwtools-svn15878.1.05.4-33.fc25.1.noarch
texlive-rsfs-svn15878.0-33.fc25.1.noarch
texlive-ucharcat-svn38907-33.fc25.1.noarch
texlive-fontspec-svn41262-33.fc25.1.noarch
texlive-showexpl-svn32737.v0.3l-33.fc25.1.noarch
texlive-pstricks-add-svn40744-33.fc25.1.noarch
texlive-beamer-svn36461.3.36-33.fc25.1.noarch
texlive-collection-basic-svn41149-33.20160520.fc25.1.noarch
mock-1.3.4-1.fc25.noarch
rpm-build-4.13.0.1-1.fc25.s390x
xemacs-filesystem-21.5.34-20.20170124hgf412e9f093d4.fc25.noarch
nss-sysinit-3.29.3-1.1.fc25.s390x
hawkey-0.6.4-3.fc25.s390x
mesa-libGLES-13.0.4-3.fc25.s390x
vim-common-8.0.514-1.fc25.s390x
gdk-pixbuf2-modules-2.36.6-1.fc25.s390x
bluez-libs-5.44-1.fc25.s390x
libcurl-devel-7.51.0-6.fc25.s390x
mc-4.8.19-1.fc25.s390x
gpg-pubkey-a0a7badb-52844296
readline-6.3-8.fc24.s390x
cpio-2.12-3.fc24.s390x
qrencode-libs-3.4.2-6.fc24.s390x
libXcomposite-0.4.4-8.fc24.s390x
procps-ng-3.3.10-11.fc24.s390x
GConf2-3.2.6-16.fc24.s390x
xz-devel-5.2.2-2.fc24.s390x
fedora-logos-22.0.0-3.fc24.s390x
gpg-pubkey-e372e838-56fd7943
kmod-libs-23-1.fc25.s390x
perl-parent-0.236-1.fc25.noarch
perl-TermReadKey-2.37-1.fc25.s390x
dhcp-libs-4.3.5-1.fc25.s390x
ncurses-c++-libs-6.0-6.20160709.fc25.s390x
gzip-1.8-1.fc25.s390x
python3-gobject-base-3.22.0-1.fc25.s390x
python2-yubico-1.3.2-3.fc25.noarch
s390utils-ziomon-1.36.0-1.fc25.s390x
librepo-1.7.18-3.fc25.s390x
librsvg2-2.40.16-2.fc25.s390x
gnat-srpm-macros-4-1.fc25.noarch
python-decoratortools-1.8-12.fc25.noarch
m17n-db-1.7.0-7.fc25.noarch
glibc-common-2.24-4.fc25.s390x
e2fsprogs-libs-1.43.3-1.fc25.s390x
libvorbis-1.3.5-1.fc25.s390x
gcc-gdb-plugin-6.3.1-1.fc25.s390x
perl-Time-HiRes-1.9741-1.fc25.s390x
npth-1.3-1.fc25.s390x
libcephfs1-10.2.4-2.fc25.s390x
wayland-devel-1.12.0-1.fc25.s390x
libxcb-devel-1.12-1.fc25.s390x
perl-encoding-2.19-5.fc25.s390x
python3-cssselect-0.9.2-1.fc25.noarch
gettext-libs-0.19.8.1-3.fc25.s390x
at-spi2-atk-devel-2.22.0-1.fc25.s390x
virglrenderer-0.5.0-1.20160411git61846f92f.fc25.s390x
pixman-devel-0.34.0-2.fc24.s390x
libnfs-devel-1.9.8-2.fc24.s390x
libX11-common-1.6.4-4.fc25.noarch
nss-softokn-devel-3.29.3-1.0.fc25.s390x
libblkid-2.28.2-2.fc25.s390x
bind-libs-9.10.4-4.P6.fc25.s390x
glib2-devel-2.50.3-1.fc25.s390x
systemd-udev-231-14.fc25.s390x
texlive-ifxetex-svn19685.0.5-33.fc25.1.noarch
texlive-caption-svn41409-33.fc25.1.noarch
texlive-float-svn15878.1.3d-33.fc25.1.noarch
texlive-pdftex-def-svn22653.0.06d-33.fc25.1.noarch
texlive-xdvi-bin-svn40750-33.20160520.fc25.1.s390x
texlive-beton-svn15878.0-33.fc25.1.noarch
texlive-filecontents-svn24250.1.3-33.fc25.1.noarch
texlive-lm-math-svn36915.1.959-33.fc25.1.noarch
texlive-pslatex-svn16416.0-33.fc25.1.noarch
texlive-times-svn35058.0-33.fc25.1.noarch
texlive-breakurl-svn29901.1.40-33.fc25.1.noarch
texlive-filehook-svn24280.0.5d-33.fc25.1.noarch
texlive-pst-pdf-svn31660.1.1v-33.fc25.1.noarch
texlive-seminar-svn34011.1.62-33.fc25.1.noarch
texlive-xetexconfig-svn41133-33.fc25.1.noarch
systemtap-3.1-2.fc25.s390x
python-rpm-macros-3-12.fc25.noarch
rpm-devel-4.13.0.1-1.fc25.s390x
nss-pem-1.0.3-3.fc25.s390x
mesa-libGL-13.0.4-3.fc25.s390x
at-spi2-core-2.22.1-1.fc25.s390x
pcre2-utf32-10.23-5.fc25.s390x
gtk3-3.22.11-1.fc25.s390x
GeoIP-GeoLite-data-2017.04-1.fc25.noarch
pcre-static-8.40-6.fc25.s390x
kernel-devel-4.10.8-200.fc25.s390x
=== TEST BEGIN ===
Using CC: /home/fam/bin/cc
Install prefix    /var/tmp/patchew-tester-tmp-i5lmtq3u/src/install
BIOS directory    /var/tmp/patchew-tester-tmp-i5lmtq3u/src/install/share/qemu
binary directory  /var/tmp/patchew-tester-tmp-i5lmtq3u/src/install/bin
library directory /var/tmp/patchew-tester-tmp-i5lmtq3u/src/install/lib
module directory  /var/tmp/patchew-tester-tmp-i5lmtq3u/src/install/lib/qemu
libexec directory /var/tmp/patchew-tester-tmp-i5lmtq3u/src/install/libexec
include directory /var/tmp/patchew-tester-tmp-i5lmtq3u/src/install/include
config directory  /var/tmp/patchew-tester-tmp-i5lmtq3u/src/install/etc
local state directory   /var/tmp/patchew-tester-tmp-i5lmtq3u/src/install/var
Manual directory  /var/tmp/patchew-tester-tmp-i5lmtq3u/src/install/share/man
ELF interp prefix /usr/gnemul/qemu-%M
Source path       /var/tmp/patchew-tester-tmp-i5lmtq3u/src
C compiler        /home/fam/bin/cc
Host C compiler   cc
C++ compiler      c++
Objective-C compiler /home/fam/bin/cc
ARFLAGS           rv
CFLAGS            -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -g 
QEMU_CFLAGS       -I/usr/include/pixman-1  -Werror -DHAS_LIBSSH2_SFTP_FSYNC -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -DNCURSES_WIDECHAR -D_GNU_SOURCE -m64 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv  -Wendif-labels -Wno-shift-negative-value -Wno-missing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-declaration -Wold-style-definition -Wtype-limits -fstack-protector-strong -I/usr/include/p11-kit-1    -I/usr/include/libpng16 -I/usr/include/libdrm  -I/usr/include/cacard -I/usr/include/nss3 -I/usr/include/nspr4 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/libusb-1.0 
LDFLAGS           -Wl,--warn-common -m64 -g 
make              make
install           install
python            python -B
smbd              /usr/sbin/smbd
module support    no
host CPU          s390x
host big endian   yes
target list       aarch64-softmmu alpha-softmmu arm-softmmu cris-softmmu i386-softmmu lm32-softmmu m68k-softmmu microblazeel-softmmu microblaze-softmmu mips64el-softmmu mips64-softmmu mipsel-softmmu mips-softmmu moxie-softmmu nios2-softmmu or1k-softmmu ppc64-softmmu ppcemb-softmmu ppc-softmmu s390x-softmmu sh4eb-softmmu sh4-softmmu sparc64-softmmu sparc-softmmu tricore-softmmu unicore32-softmmu x86_64-softmmu xtensaeb-softmmu xtensa-softmmu aarch64-linux-user alpha-linux-user armeb-linux-user arm-linux-user cris-linux-user hppa-linux-user i386-linux-user m68k-linux-user microblazeel-linux-user microblaze-linux-user mips64el-linux-user mips64-linux-user mipsel-linux-user mips-linux-user mipsn32el-linux-user mipsn32-linux-user nios2-linux-user or1k-linux-user ppc64abi32-linux-user ppc64le-linux-user ppc64-linux-user ppc-linux-user s390x-linux-user sh4eb-linux-user sh4-linux-user sparc32plus-linux-user sparc64-linux-user sparc-linux-user tilegx-linux-user x86_64-linux-user
gprof enabled     no
sparse enabled    no
strip binaries    yes
profiler          no
static build      no
pixman            system
SDL support       yes (2.0.5)
GTK support       yes (3.22.11)
GTK GL support    yes
VTE support       yes (0.46.1)
TLS priority      NORMAL
GNUTLS support    yes
GNUTLS rnd        yes
libgcrypt         no
libgcrypt kdf     no
nettle            yes (3.3)
nettle kdf        yes
libtasn1          yes
curses support    yes
virgl support     yes
curl support      yes
mingw32 support   no
Audio drivers     oss
Block whitelist (rw) 
Block whitelist (ro) 
VirtFS support    yes
VNC support       yes
VNC SASL support  yes
VNC JPEG support  yes
VNC PNG support   yes
xen support       no
brlapi support    yes
bluez  support    yes
Documentation     yes
PIE               no
vde support       no
netmap support    no
Linux AIO support yes
ATTR/XATTR support yes
Install blobs     yes
KVM support       yes
HAX support       no
TCG support       yes
TCG debug enabled no
TCG interpreter   no
RDMA support      no
fdt support       yes
preadv support    yes
fdatasync         yes
madvise           yes
posix_madvise     yes
libcap-ng support yes
vhost-net support yes
vhost-scsi support yes
vhost-vsock support yes
Trace backends    log
spice support     no 
rbd support       yes
xfsctl support    no
smartcard support yes
libusb            yes
usb net redir     yes
OpenGL support    yes
OpenGL dmabufs    yes
libiscsi support  yes
libnfs support    yes
build guest agent yes
QGA VSS support   no
QGA w32 disk info no
QGA MSI support   no
seccomp support   no
coroutine backend ucontext
coroutine pool    yes
debug stack usage no
GlusterFS support yes
gcov              gcov
gcov enabled      no
TPM support       yes
libssh2 support   yes
TPM passthrough   no
QOM debugging     yes
Live block migration yes
lzo support       yes
snappy support    yes
bzip2 support     yes
NUMA host support no
tcmalloc support  no
jemalloc support  no
avx2 optimization no
replication support yes
VxHS block device no
  GEN     aarch64-softmmu/config-devices.mak.tmp
  GEN     alpha-softmmu/config-devices.mak.tmp
  GEN     cris-softmmu/config-devices.mak.tmp
  GEN     arm-softmmu/config-devices.mak.tmp
  GEN     cris-softmmu/config-devices.mak
  GEN     i386-softmmu/config-devices.mak.tmp
  GEN     alpha-softmmu/config-devices.mak
  GEN     lm32-softmmu/config-devices.mak.tmp
  GEN     arm-softmmu/config-devices.mak
  GEN     aarch64-softmmu/config-devices.mak
  GEN     m68k-softmmu/config-devices.mak.tmp
  GEN     lm32-softmmu/config-devices.mak
  GEN     microblazeel-softmmu/config-devices.mak.tmp
  GEN     i386-softmmu/config-devices.mak
  GEN     microblaze-softmmu/config-devices.mak.tmp
  GEN     m68k-softmmu/config-devices.mak
  GEN     mips64el-softmmu/config-devices.mak.tmp
  GEN     mips64-softmmu/config-devices.mak.tmp
  GEN     microblaze-softmmu/config-devices.mak
  GEN     microblazeel-softmmu/config-devices.mak
  GEN     mipsel-softmmu/config-devices.mak.tmp
  GEN     mips-softmmu/config-devices.mak.tmp
  GEN     mips64el-softmmu/config-devices.mak
  GEN     moxie-softmmu/config-devices.mak.tmp
  GEN     mips64-softmmu/config-devices.mak
  GEN     nios2-softmmu/config-devices.mak.tmp
  GEN     moxie-softmmu/config-devices.mak
  GEN     mipsel-softmmu/config-devices.mak
  GEN     or1k-softmmu/config-devices.mak.tmp
  GEN     ppc64-softmmu/config-devices.mak.tmp
  GEN     mips-softmmu/config-devices.mak
  GEN     nios2-softmmu/config-devices.mak
  GEN     ppcemb-softmmu/config-devices.mak.tmp
  GEN     ppc-softmmu/config-devices.mak.tmp
  GEN     or1k-softmmu/config-devices.mak
  GEN     s390x-softmmu/config-devices.mak.tmp
  GEN     ppc64-softmmu/config-devices.mak
  GEN     s390x-softmmu/config-devices.mak
  GEN     sh4eb-softmmu/config-devices.mak.tmp
  GEN     ppcemb-softmmu/config-devices.mak
  GEN     ppc-softmmu/config-devices.mak
  GEN     sh4-softmmu/config-devices.mak.tmp
  GEN     sparc64-softmmu/config-devices.mak.tmp
  GEN     sparc-softmmu/config-devices.mak.tmp
  GEN     sparc-softmmu/config-devices.mak
  GEN     sh4eb-softmmu/config-devices.mak
  GEN     tricore-softmmu/config-devices.mak.tmp
  GEN     sparc64-softmmu/config-devices.mak
  GEN     sh4-softmmu/config-devices.mak
  GEN     unicore32-softmmu/config-devices.mak.tmp
  GEN     x86_64-softmmu/config-devices.mak.tmp
  GEN     xtensaeb-softmmu/config-devices.mak.tmp
  GEN     tricore-softmmu/config-devices.mak
  GEN     unicore32-softmmu/config-devices.mak
  GEN     xtensa-softmmu/config-devices.mak.tmp
  GEN     xtensaeb-softmmu/config-devices.mak
  GEN     aarch64-linux-user/config-devices.mak.tmp
  GEN     x86_64-softmmu/config-devices.mak
  GEN     alpha-linux-user/config-devices.mak.tmp
  GEN     xtensa-softmmu/config-devices.mak
  GEN     armeb-linux-user/config-devices.mak.tmp
  GEN     aarch64-linux-user/config-devices.mak
  GEN     arm-linux-user/config-devices.mak.tmp
  GEN     cris-linux-user/config-devices.mak.tmp
  GEN     alpha-linux-user/config-devices.mak
  GEN     hppa-linux-user/config-devices.mak.tmp
  GEN     arm-linux-user/config-devices.mak
  GEN     armeb-linux-user/config-devices.mak
  GEN     i386-linux-user/config-devices.mak.tmp
  GEN     m68k-linux-user/config-devices.mak.tmp
  GEN     cris-linux-user/config-devices.mak
  GEN     hppa-linux-user/config-devices.mak
  GEN     i386-linux-user/config-devices.mak
  GEN     microblaze-linux-user/config-devices.mak.tmp
  GEN     microblazeel-linux-user/config-devices.mak.tmp
  GEN     mips64el-linux-user/config-devices.mak.tmp
  GEN     m68k-linux-user/config-devices.mak
  GEN     mips64-linux-user/config-devices.mak.tmp
  GEN     microblazeel-linux-user/config-devices.mak
  GEN     mips64el-linux-user/config-devices.mak
  GEN     microblaze-linux-user/config-devices.mak
  GEN     mipsel-linux-user/config-devices.mak.tmp
  GEN     mipsn32el-linux-user/config-devices.mak.tmp
  GEN     mips-linux-user/config-devices.mak.tmp
  GEN     mips64-linux-user/config-devices.mak
  GEN     mipsn32-linux-user/config-devices.mak.tmp
  GEN     mipsel-linux-user/config-devices.mak
  GEN     mips-linux-user/config-devices.mak
  GEN     nios2-linux-user/config-devices.mak.tmp
  GEN     mipsn32el-linux-user/config-devices.mak
  GEN     or1k-linux-user/config-devices.mak.tmp
  GEN     ppc64abi32-linux-user/config-devices.mak.tmp
  GEN     mipsn32-linux-user/config-devices.mak
  GEN     nios2-linux-user/config-devices.mak
  GEN     ppc64le-linux-user/config-devices.mak.tmp
  GEN     or1k-linux-user/config-devices.mak
  GEN     ppc64-linux-user/config-devices.mak.tmp
  GEN     ppc64abi32-linux-user/config-devices.mak
  GEN     s390x-linux-user/config-devices.mak.tmp
  GEN     ppc-linux-user/config-devices.mak.tmp
  GEN     ppc64le-linux-user/config-devices.mak
  GEN     ppc64-linux-user/config-devices.mak
  GEN     sh4-linux-user/config-devices.mak.tmp
  GEN     sh4eb-linux-user/config-devices.mak.tmp
  GEN     ppc-linux-user/config-devices.mak
  GEN     sparc32plus-linux-user/config-devices.mak.tmp
  GEN     s390x-linux-user/config-devices.mak
  GEN     sh4eb-linux-user/config-devices.mak
  GEN     sh4-linux-user/config-devices.mak
  GEN     sparc64-linux-user/config-devices.mak.tmp
  GEN     sparc-linux-user/config-devices.mak.tmp
  GEN     sparc32plus-linux-user/config-devices.mak
  GEN     tilegx-linux-user/config-devices.mak.tmp
  GEN     x86_64-linux-user/config-devices.mak.tmp
  GEN     sparc64-linux-user/config-devices.mak
  GEN     sparc-linux-user/config-devices.mak
  GEN     config-host.h
  GEN     tilegx-linux-user/config-devices.mak
  GEN     x86_64-linux-user/config-devices.mak
  GEN     qemu-options.def
  GEN     qmp-commands.h
  GEN     qapi-types.h
  GEN     qapi-visit.h
  GEN     qapi-event.h
  GEN     qmp-marshal.c
  GEN     qapi-types.c
  GEN     qapi-visit.c
  GEN     qapi-event.c
  GEN     qmp-introspect.h
  GEN     qmp-introspect.c
  GEN     trace/generated-tcg-tracers.h
  GEN     trace/generated-helpers-wrappers.h
  GEN     trace/generated-helpers.h
  GEN     trace/generated-helpers.c
  GEN     module_block.h
  GEN     tests/test-qapi-types.h
  GEN     tests/test-qapi-visit.h
  GEN     tests/test-qmp-commands.h
  GEN     tests/test-qapi-event.h
  GEN     tests/test-qmp-introspect.h
  GEN     trace-root.h
  GEN     util/trace.h
  GEN     crypto/trace.h
  GEN     io/trace.h
  GEN     migration/trace.h
  GEN     block/trace.h
  GEN     chardev/trace.h
  GEN     hw/block/trace.h
  GEN     hw/block/dataplane/trace.h
  GEN     hw/char/trace.h
  GEN     hw/intc/trace.h
  GEN     hw/net/trace.h
  GEN     hw/virtio/trace.h
  GEN     hw/audio/trace.h
  GEN     hw/misc/trace.h
  GEN     hw/usb/trace.h
  GEN     hw/scsi/trace.h
  GEN     hw/nvram/trace.h
  GEN     hw/display/trace.h
  GEN     hw/input/trace.h
  GEN     hw/timer/trace.h
  GEN     hw/sparc/trace.h
  GEN     hw/dma/trace.h
  GEN     hw/sd/trace.h
  GEN     hw/isa/trace.h
  GEN     hw/mem/trace.h
  GEN     hw/i386/xen/trace.h
  GEN     hw/i386/trace.h
  GEN     hw/9pfs/trace.h
  GEN     hw/ppc/trace.h
  GEN     hw/pci/trace.h
  GEN     hw/s390x/trace.h
  GEN     hw/vfio/trace.h
  GEN     hw/acpi/trace.h
  GEN     hw/arm/trace.h
  GEN     hw/alpha/trace.h
  GEN     hw/xen/trace.h
  GEN     audio/trace.h
  GEN     ui/trace.h
  GEN     net/trace.h
  GEN     target/arm/trace.h
  GEN     target/i386/trace.h
  GEN     target/mips/trace.h
  GEN     target/sparc/trace.h
  GEN     target/s390x/trace.h
  GEN     target/ppc/trace.h
  GEN     qom/trace.h
  GEN     linux-user/trace.h
  GEN     qapi/trace.h
  GEN     accel/tcg/trace.h
  GEN     accel/kvm/trace.h
  GEN     nbd/trace.h
  GEN     trace-root.c
  GEN     crypto/trace.c
  GEN     util/trace.c
  GEN     io/trace.c
  GEN     migration/trace.c
  GEN     block/trace.c
  GEN     chardev/trace.c
  GEN     hw/block/trace.c
  GEN     hw/block/dataplane/trace.c
  GEN     hw/char/trace.c
  GEN     hw/intc/trace.c
  GEN     hw/net/trace.c
  GEN     hw/virtio/trace.c
  GEN     hw/audio/trace.c
  GEN     hw/misc/trace.c
  GEN     hw/usb/trace.c
  GEN     hw/scsi/trace.c
  GEN     hw/nvram/trace.c
  GEN     hw/display/trace.c
  GEN     hw/input/trace.c
  GEN     hw/timer/trace.c
  GEN     hw/dma/trace.c
  GEN     hw/sparc/trace.c
  GEN     hw/sd/trace.c
  GEN     hw/isa/trace.c
  GEN     hw/mem/trace.c
  GEN     hw/i386/trace.c
  GEN     hw/i386/xen/trace.c
  GEN     hw/9pfs/trace.c
  GEN     hw/pci/trace.c
  GEN     hw/ppc/trace.c
  GEN     hw/s390x/trace.c
  GEN     hw/vfio/trace.c
  GEN     hw/acpi/trace.c
  GEN     hw/alpha/trace.c
  GEN     hw/arm/trace.c
  GEN     hw/xen/trace.c
  GEN     ui/trace.c
  GEN     audio/trace.c
  GEN     net/trace.c
  GEN     target/arm/trace.c
  GEN     target/i386/trace.c
  GEN     target/mips/trace.c
  GEN     target/sparc/trace.c
  GEN     target/s390x/trace.c
  GEN     target/ppc/trace.c
  GEN     qom/trace.c
  GEN     linux-user/trace.c
  GEN     qapi/trace.c
  GEN     accel/tcg/trace.c
  GEN     accel/kvm/trace.c
  GEN     nbd/trace.c
  GEN     config-all-devices.mak
  CC      tests/qemu-iotests/socket_scm_helper.o
  GEN     qemu-options.texi
  GEN     docs/version.texi
  GEN     qemu-monitor.texi
  GEN     qemu-img-cmds.texi
  GEN     qemu-monitor-info.texi
  GEN     qemu-img.1
  GEN     qemu-nbd.8
  GEN     qemu-ga.8
  GEN     docs/interop/qemu-qmp-qapi.texi
  GEN     docs/interop/qemu-ga-qapi.texi
  GEN     fsdev/virtfs-proxy-helper.1
  GEN     qga/qapi-generated/qga-qapi-types.h
  GEN     qga/qapi-generated/qga-qapi-visit.h
  GEN     qga/qapi-generated/qga-qmp-commands.h
  GEN     qga/qapi-generated/qga-qapi-types.c
  GEN     qga/qapi-generated/qga-qapi-visit.c
  GEN     qga/qapi-generated/qga-qmp-marshal.c
  CC      qmp-introspect.o
  CC      qapi-types.o
  CC      qapi-visit.o
  CC      qapi-event.o
  CC      qapi/qapi-visit-core.o
  CC      qapi/qapi-dealloc-visitor.o
  CC      qapi/qobject-output-visitor.o
  CC      qapi/qobject-input-visitor.o
  CC      qapi/qmp-registry.o
  CC      qapi/qmp-dispatch.o
  CC      qapi/string-input-visitor.o
  CC      qapi/string-output-visitor.o
  CC      qapi/opts-visitor.o
  CC      qapi/qapi-clone-visitor.o
  CC      qapi/qmp-event.o
  CC      qapi/qapi-util.o
  CC      qobject/qnull.o
  CC      qobject/qnum.o
  CC      qobject/qstring.o
  CC      qobject/qdict.o
  CC      qobject/qlist.o
  CC      qobject/qbool.o
  CC      qobject/qjson.o
  CC      qobject/qobject.o
  CC      qobject/json-lexer.o
  CC      qobject/json-streamer.o
  CC      qobject/json-parser.o
  CC      trace/qmp.o
  CC      trace/control.o
  CC      util/osdep.o
  CC      util/cutils.o
  CC      util/unicode.o
  CC      util/qemu-timer-common.o
  CC      util/bufferiszero.o
  CC      util/lockcnt.o
  CC      util/aiocb.o
  CC      util/async.o
  CC      util/thread-pool.o
  CC      util/qemu-timer.o
  CC      util/main-loop.o
  CC      util/iohandler.o
  CC      util/compatfd.o
  CC      util/aio-posix.o
  CC      util/event_notifier-posix.o
  CC      util/mmap-alloc.o
  CC      util/oslib-posix.o
  CC      util/qemu-openpty.o
  CC      util/qemu-thread-posix.o
  CC      util/memfd.o
  CC      util/envlist.o
  CC      util/path.o
  CC      util/module.o
  CC      util/host-utils.o
  CC      util/bitmap.o
  CC      util/bitops.o
  CC      util/hbitmap.o
  CC      util/fifo8.o
  CC      util/acl.o
  CC      util/cacheinfo.o
  CC      util/error.o
  CC      util/qemu-error.o
  CC      util/id.o
  CC      util/iov.o
  CC      util/qemu-config.o
  CC      util/qemu-sockets.o
  CC      util/uri.o
  CC      util/notify.o
  CC      util/qemu-option.o
  CC      util/qemu-progress.o
  CC      util/keyval.o
  CC      util/hexdump.o
  CC      util/crc32c.o
  CC      util/uuid.o
  CC      util/throttle.o
  CC      util/getauxval.o
  CC      util/readline.o
  CC      util/rcu.o
  CC      util/qemu-coroutine.o
  CC      util/qemu-coroutine-lock.o
  CC      util/qemu-coroutine-io.o
  CC      util/qemu-coroutine-sleep.o
  CC      util/coroutine-ucontext.o
  CC      util/buffer.o
  CC      util/base64.o
  CC      util/timed-average.o
  CC      util/log.o
  CC      util/qht.o
  CC      util/qdist.o
  CC      util/range.o
  CC      util/stats64.o
  CC      util/systemd.o
  CC      trace-root.o
  CC      util/trace.o
  CC      crypto/trace.o
  CC      io/trace.o
  CC      migration/trace.o
  CC      block/trace.o
  CC      chardev/trace.o
  CC      hw/block/trace.o
  CC      hw/char/trace.o
  CC      hw/block/dataplane/trace.o
  CC      hw/intc/trace.o
  CC      hw/net/trace.o
  CC      hw/audio/trace.o
  CC      hw/virtio/trace.o
  CC      hw/misc/trace.o
  CC      hw/usb/trace.o
  CC      hw/scsi/trace.o
  CC      hw/nvram/trace.o
  CC      hw/input/trace.o
  CC      hw/display/trace.o
  CC      hw/timer/trace.o
  CC      hw/dma/trace.o
  CC      hw/sparc/trace.o
  CC      hw/sd/trace.o
  CC      hw/isa/trace.o
  CC      hw/mem/trace.o
  CC      hw/i386/trace.o
  CC      hw/i386/xen/trace.o
  CC      hw/9pfs/trace.o
  CC      hw/ppc/trace.o
  CC      hw/pci/trace.o
  CC      hw/s390x/trace.o
  CC      hw/vfio/trace.o
  CC      hw/acpi/trace.o
  CC      hw/arm/trace.o
  CC      hw/alpha/trace.o
  CC      hw/xen/trace.o
  CC      ui/trace.o
  CC      net/trace.o
  CC      audio/trace.o
  CC      target/arm/trace.o
  CC      target/mips/trace.o
  CC      target/i386/trace.o
  CC      target/sparc/trace.o
  CC      target/s390x/trace.o
  CC      target/ppc/trace.o
  CC      qom/trace.o
  CC      linux-user/trace.o
  CC      qapi/trace.o
  CC      accel/tcg/trace.o
  CC      accel/kvm/trace.o
  CC      nbd/trace.o
  CC      crypto/pbkdf-stub.o
  CC      stubs/arch-query-cpu-def.o
  CC      stubs/arch-query-cpu-model-expansion.o
  CC      stubs/arch-query-cpu-model-comparison.o
  CC      stubs/bdrv-next-monitor-owned.o
  CC      stubs/arch-query-cpu-model-baseline.o
  CC      stubs/blk-commit-all.o
  CC      stubs/blockdev-close-all-bdrv-states.o
  CC      stubs/clock-warp.o
  CC      stubs/cpu-get-clock.o
  CC      stubs/cpu-get-icount.o
  CC      stubs/dump.o
  CC      stubs/fdset.o
  CC      stubs/error-printf.o
  CC      stubs/get-vm-name.o
  CC      stubs/gdbstub.o
  CC      stubs/iothread.o
  CC      stubs/iothread-lock.o
  CC      stubs/is-daemonized.o
  CC      stubs/linux-aio.o
  CC      stubs/machine-init-done.o
  CC      stubs/migr-blocker.o
  CC      stubs/monitor.o
  CC      stubs/notify-event.o
  CC      stubs/qtest.o
  CC      stubs/replay.o
  CC      stubs/runstate-check.o
  CC      stubs/set-fd-handler.o
  CC      stubs/slirp.o
  CC      stubs/sysbus.o
  CC      stubs/trace-control.o
  CC      stubs/uuid.o
  CC      stubs/vm-stop.o
  CC      stubs/vmstate.o
  CC      stubs/qmp_pc_dimm_device_list.o
  CC      stubs/target-monitor-defs.o
  CC      stubs/target-get-monitor-def.o
  CC      stubs/vmgenid.o
  CC      stubs/pc_madt_cpu_entry.o
  CC      stubs/xen-common.o
  CC      stubs/xen-hvm.o
  CC      contrib/ivshmem-client/ivshmem-client.o
  CC      contrib/ivshmem-client/main.o
  CC      contrib/ivshmem-server/ivshmem-server.o
  CC      contrib/ivshmem-server/main.o
  CC      qemu-nbd.o
  CC      block.o
  CC      blockjob.o
  CC      qemu-io-cmds.o
  CC      block/raw-format.o
  CC      replication.o
  CC      block/qcow.o
  CC      block/vdi.o
  CC      block/vmdk.o
  CC      block/cloop.o
  CC      block/bochs.o
  CC      block/vpc.o
  CC      block/vvfat.o
  CC      block/dmg.o
  CC      block/qcow2.o
  CC      block/qcow2-refcount.o
  CC      block/qcow2-cluster.o
  CC      block/qcow2-snapshot.o
  CC      block/qcow2-cache.o
  CC      block/qcow2-bitmap.o
  CC      block/qed.o
  CC      block/qed-l2-cache.o
  CC      block/qed-table.o
  CC      block/qed-cluster.o
  CC      block/qed-check.o
  CC      block/vhdx.o
  CC      block/vhdx-endian.o
  CC      block/vhdx-log.o
  CC      block/quorum.o
  CC      block/parallels.o
  CC      block/blkdebug.o
  CC      block/blkverify.o
  CC      block/blkreplay.o
  CC      block/block-backend.o
  CC      block/snapshot.o
  CC      block/qapi.o
  CC      block/file-posix.o
  CC      block/linux-aio.o
  CC      block/null.o
  CC      block/mirror.o
  CC      block/commit.o
  CC      block/io.o
  CC      block/throttle-groups.o
  CC      block/nbd.o
  CC      block/nbd-client.o
  CC      block/sheepdog.o
  CC      block/iscsi-opts.o
  CC      block/accounting.o
  CC      block/dirty-bitmap.o
  CC      block/write-threshold.o
  CC      block/backup.o
  CC      block/replication.o
  CC      block/crypto.o
  CC      nbd/server.o
  CC      nbd/client.o
  CC      nbd/common.o
  CC      block/iscsi.o
  CC      block/nfs.o
  CC      block/curl.o
  CC      block/rbd.o
  CC      block/gluster.o
  CC      block/ssh.o
  CC      block/dmg-bz2.o
  CC      crypto/init.o
  CC      crypto/hash.o
  CC      crypto/hash-nettle.o
  CC      crypto/hmac.o
  CC      crypto/hmac-nettle.o
  CC      crypto/aes.o
  CC      crypto/desrfb.o
  CC      crypto/cipher.o
  CC      crypto/tlscreds.o
  CC      crypto/tlscredsanon.o
  CC      crypto/tlscredsx509.o
  CC      crypto/tlssession.o
  CC      crypto/secret.o
  CC      crypto/random-gnutls.o
  CC      crypto/pbkdf.o
  CC      crypto/pbkdf-nettle.o
  CC      crypto/ivgen-essiv.o
  CC      crypto/ivgen-plain.o
  CC      crypto/ivgen.o
  CC      crypto/ivgen-plain64.o
  CC      crypto/afsplit.o
  CC      crypto/xts.o
  CC      crypto/block.o
  CC      crypto/block-qcow.o
  CC      crypto/block-luks.o
  CC      io/channel.o
  CC      io/channel-buffer.o
  CC      io/channel-command.o
  CC      io/channel-file.o
  CC      io/channel-socket.o
  CC      io/channel-tls.o
  CC      io/channel-watch.o
  CC      io/channel-websock.o
  CC      io/channel-util.o
  CC      io/dns-resolver.o
  CC      io/task.o
  CC      qom/object.o
  CC      qom/container.o
  CC      qom/qom-qobject.o
  CC      qom/object_interfaces.o
  GEN     qemu-img-cmds.h
  CC      qemu-io.o
  CC      fsdev/virtfs-proxy-helper.o
  CC      fsdev/9p-marshal.o
  CC      fsdev/9p-iov-marshal.o
  CC      qemu-bridge-helper.o
  CC      blockdev.o
  CC      blockdev-nbd.o
  CC      bootdevice.o
  CC      iothread.o
  CC      qdev-monitor.o
  CC      device-hotplug.o
  CC      os-posix.o
  CC      bt-host.o
  CC      bt-vhci.o
  CC      dma-helpers.o
  CC      vl.o
  CC      tpm.o
  CC      device_tree.o
  CC      qmp-marshal.o
  CC      qmp.o
  CC      hmp.o
  CC      cpus-common.o
  CC      audio/audio.o
  CC      audio/noaudio.o
  CC      audio/wavaudio.o
  CC      audio/mixeng.o
  CC      audio/sdlaudio.o
  CC      audio/ossaudio.o
  CC      audio/wavcapture.o
  CC      backends/rng.o
  CC      backends/rng-egd.o
  CC      backends/rng-random.o
  CC      backends/tpm.o
  CC      backends/hostmem.o
  CC      backends/hostmem-ram.o
  CC      backends/hostmem-file.o
  CC      backends/cryptodev.o
  CC      backends/cryptodev-builtin.o
  CC      chardev/msmouse.o
  CC      block/stream.o
  CC      chardev/wctablet.o
  CC      chardev/testdev.o
  CC      chardev/baum.o
  CC      disas/alpha.o
  CC      disas/arm.o
  CXX     disas/arm-a64.o
  CC      disas/cris.o
  CC      disas/hppa.o
  CC      disas/m68k.o
  CC      disas/i386.o
  CC      disas/microblaze.o
  CC      disas/mips.o
  CC      disas/nios2.o
  CC      disas/moxie.o
  CC      disas/ppc.o
  CC      disas/s390.o
  CC      disas/sh4.o
  CC      disas/sparc.o
  CC      disas/lm32.o
  CXX     disas/libvixl/vixl/utils.o
  CXX     disas/libvixl/vixl/a64/instructions-a64.o
  CXX     disas/libvixl/vixl/compiler-intrinsics.o
  CXX     disas/libvixl/vixl/a64/decoder-a64.o
  CXX     disas/libvixl/vixl/a64/disasm-a64.o
  CC      fsdev/qemu-fsdev.o
  CC      fsdev/qemu-fsdev-opts.o
  CC      fsdev/qemu-fsdev-throttle.o
  CC      fsdev/qemu-fsdev-dummy.o
  CC      hw/9pfs/9p.o
  CC      hw/9pfs/9p-util.o
  CC      hw/9pfs/9p-local.o
  CC      hw/9pfs/9p-xattr.o
  CC      hw/9pfs/9p-xattr-user.o
  CC      hw/9pfs/9p-posix-acl.o
  CC      hw/9pfs/coth.o
  CC      hw/9pfs/cofs.o
  CC      hw/9pfs/codir.o
  CC      hw/9pfs/cofile.o
  CC      hw/9pfs/coxattr.o
  CC      hw/9pfs/9p-synth.o
  CC      hw/9pfs/9p-handle.o
  CC      hw/9pfs/9p-proxy.o
  CC      hw/acpi/core.o
  CC      hw/acpi/piix4.o
  CC      hw/acpi/pcihp.o
  CC      hw/acpi/ich9.o
  CC      hw/acpi/tco.o
  CC      hw/acpi/cpu_hotplug.o
  CC      hw/acpi/memory_hotplug.o
  CC      hw/acpi/cpu.o
  CC      hw/acpi/nvdimm.o
  CC      hw/acpi/vmgenid.o
  CC      hw/acpi/acpi_interface.o
  CC      hw/acpi/bios-linker-loader.o
  CC      hw/acpi/aml-build.o
  CC      hw/acpi/ipmi.o
  CC      hw/acpi/acpi-stub.o
  CC      hw/acpi/ipmi-stub.o
  CC      hw/audio/sb16.o
  CC      hw/audio/es1370.o
  CC      hw/audio/ac97.o
  CC      hw/audio/fmopl.o
  CC      hw/audio/adlib.o
  CC      hw/audio/gus.o
  CC      hw/audio/gusemu_hal.o
  CC      hw/audio/gusemu_mixer.o
  CC      hw/audio/cs4231a.o
  CC      hw/audio/intel-hda.o
  CC      hw/audio/hda-codec.o
  CC      hw/audio/pcspk.o
  CC      hw/audio/wm8750.o
  CC      hw/audio/pl041.o
  CC      hw/audio/lm4549.o
  CC      hw/audio/cs4231.o
  CC      hw/audio/marvell_88w8618.o
  CC      hw/audio/milkymist-ac97.o
  CC      hw/audio/soundhw.o
  CC      hw/block/block.o
  CC      hw/block/cdrom.o
  CC      hw/block/fdc.o
  CC      hw/block/hd-geometry.o
  CC      hw/block/m25p80.o
  CC      hw/block/nand.o
  CC      hw/block/pflash_cfi01.o
  CC      hw/block/pflash_cfi02.o
  CC      hw/block/ecc.o
  CC      hw/block/onenand.o
  CC      hw/block/nvme.o
  CC      hw/bt/core.o
  CC      hw/bt/l2cap.o
  CC      hw/bt/sdp.o
  CC      hw/bt/hci.o
  CC      hw/bt/hid.o
  CC      hw/bt/hci-csr.o
  CC      hw/char/ipoctal232.o
  CC      hw/char/parallel.o
  CC      hw/char/escc.o
  CC      hw/char/pl011.o
  CC      hw/char/serial.o
  CC      hw/char/serial-isa.o
  CC      hw/char/serial-pci.o
  CC      hw/char/virtio-console.o
  CC      hw/char/xilinx_uartlite.o
  CC      hw/char/cadence_uart.o
  CC      hw/char/cmsdk-apb-uart.o
  CC      hw/char/etraxfs_ser.o
  CC      hw/char/debugcon.o
  CC      hw/char/grlib_apbuart.o
  CC      hw/char/imx_serial.o
  CC      hw/char/lm32_juart.o
  CC      hw/char/lm32_uart.o
  CC      hw/char/milkymist-uart.o
  CC      hw/char/sclpconsole.o
  CC      hw/char/sclpconsole-lm.o
  CC      hw/core/qdev.o
  CC      hw/core/qdev-properties.o
  CC      hw/core/bus.o
  CC      hw/core/reset.o
  CC      hw/core/fw-path-provider.o
  CC      hw/core/irq.o
  CC      hw/core/hotplug.o
  CC      hw/core/nmi.o
  CC      hw/core/empty_slot.o
  CC      hw/core/stream.o
  CC      hw/core/ptimer.o
  CC      hw/core/sysbus.o
  CC      hw/core/machine.o
  CC      hw/core/loader.o
  CC      hw/core/loader-fit.o
  CC      hw/core/register.o
  CC      hw/core/qdev-properties-system.o
  CC      hw/core/or-irq.o
  CC      hw/core/platform-bus.o
  CC      hw/cpu/core.o
  CC      hw/display/ads7846.o
  CC      hw/display/cirrus_vga.o
  CC      hw/display/g364fb.o
  CC      hw/display/jazz_led.o
  CC      hw/display/pl110.o
  CC      hw/display/ssd0303.o
  CC      hw/display/ssd0323.o
  CC      hw/display/vga-pci.o
  CC      hw/display/vga-isa.o
  CC      hw/display/vga-isa-mm.o
  CC      hw/display/vmware_vga.o
  CC      hw/display/blizzard.o
  CC      hw/display/exynos4210_fimd.o
  CC      hw/display/framebuffer.o
  CC      hw/display/milkymist-vgafb.o
  CC      hw/display/tc6393xb.o
  CC      hw/display/milkymist-tmu2.o
  CC      hw/dma/puv3_dma.o
  CC      hw/dma/rc4030.o
  CC      hw/dma/pl080.o
  CC      hw/dma/pl330.o
  CC      hw/dma/i82374.o
  CC      hw/dma/i8257.o
  CC      hw/dma/xilinx_axidma.o
  CC      hw/dma/xlnx-zynq-devcfg.o
  CC      hw/dma/etraxfs_dma.o
  CC      hw/dma/sparc32_dma.o
  CC      hw/dma/sun4m_iommu.o
  CC      hw/gpio/max7310.o
  CC      hw/gpio/puv3_gpio.o
  CC      hw/gpio/pl061.o
  CC      hw/gpio/zaurus.o
  CC      hw/gpio/mpc8xxx.o
  CC      hw/gpio/gpio_key.o
  CC      hw/i2c/core.o
  CC      hw/i2c/smbus.o
  CC      hw/i2c/smbus_eeprom.o
  CC      hw/i2c/i2c-ddc.o
  CC      hw/i2c/versatile_i2c.o
  CC      hw/i2c/smbus_ich9.o
  CC      hw/i2c/pm_smbus.o
  CC      hw/i2c/bitbang_i2c.o
  CC      hw/i2c/exynos4210_i2c.o
  CC      hw/i2c/imx_i2c.o
  CC      hw/i2c/aspeed_i2c.o
  CC      hw/ide/core.o
  CC      hw/ide/atapi.o
  CC      hw/ide/qdev.o
  CC      hw/ide/pci.o
  CC      hw/ide/isa.o
  CC      hw/ide/piix.o
  CC      hw/ide/cmd646.o
  CC      hw/ide/macio.o
  CC      hw/ide/mmio.o
  CC      hw/ide/via.o
  CC      hw/ide/microdrive.o
  CC      hw/ide/ich.o
  CC      hw/ide/ahci.o
  CC      hw/input/adb.o
  CC      hw/input/hid.o
  CC      hw/input/lm832x.o
  CC      hw/input/pl050.o
  CC      hw/input/pckbd.o
  CC      hw/input/ps2.o
  CC      hw/input/stellaris_input.o
  CC      hw/input/tsc2005.o
  CC      hw/input/vmmouse.o
  CC      hw/input/virtio-input.o
  CC      hw/input/virtio-input-host.o
  CC      hw/input/virtio-input-hid.o
  CC      hw/intc/heathrow_pic.o
  CC      hw/intc/i8259_common.o
  CC      hw/intc/i8259.o
  CC      hw/intc/pl190.o
  CC      hw/intc/puv3_intc.o
  CC      hw/intc/xilinx_intc.o
  CC      hw/intc/etraxfs_pic.o
  CC      hw/intc/imx_avic.o
  CC      hw/intc/lm32_pic.o
  CC      hw/intc/realview_gic.o
  CC      hw/intc/slavio_intctl.o
  CC      hw/intc/ioapic_common.o
  CC      hw/intc/arm_gic_common.o
  CC      hw/intc/arm_gic.o
  CC      hw/intc/arm_gicv2m.o
  CC      hw/intc/arm_gicv3.o
  CC      hw/intc/arm_gicv3_common.o
  CC      hw/intc/arm_gicv3_dist.o
  CC      hw/intc/arm_gicv3_its_common.o
  CC      hw/intc/arm_gicv3_redist.o
  CC      hw/intc/openpic.o
  CC      hw/intc/intc.o
  CC      hw/ipack/ipack.o
  CC      hw/ipack/tpci200.o
  CC      hw/ipmi/ipmi.o
  CC      hw/ipmi/ipmi_bmc_sim.o
  CC      hw/ipmi/ipmi_bmc_extern.o
  CC      hw/ipmi/isa_ipmi_kcs.o
  CC      hw/ipmi/isa_ipmi_bt.o
  CC      hw/isa/isa-bus.o
  CC      hw/isa/apm.o
  CC      hw/isa/i82378.o
  CC      hw/isa/pc87312.o
  CC      hw/isa/piix4.o
  CC      hw/isa/vt82c686.o
  CC      hw/mem/pc-dimm.o
  CC      hw/mem/nvdimm.o
  CC      hw/misc/applesmc.o
  CC      hw/misc/max111x.o
  CC      hw/misc/tmp105.o
  CC      hw/misc/tmp421.o
  CC      hw/misc/debugexit.o
  CC      hw/misc/sga.o
  CC      hw/misc/pc-testdev.o
  CC      hw/misc/pci-testdev.o
  CC      hw/misc/edu.o
  CC      hw/misc/unimp.o
  CC      hw/misc/arm_l2x0.o
  CC      hw/misc/arm_integrator_debug.o
  CC      hw/misc/a9scu.o
  CC      hw/misc/arm11scu.o
  CC      hw/misc/puv3_pm.o
  CC      hw/misc/macio/macio.o
  CC      hw/misc/macio/cuda.o
  CC      hw/misc/macio/mac_dbdma.o
  CC      hw/net/dp8393x.o
  CC      hw/net/ne2000.o
  CC      hw/net/eepro100.o
  CC      hw/net/pcnet-pci.o
  CC      hw/net/pcnet.o
  CC      hw/net/e1000.o
  CC      hw/net/e1000x_common.o
  CC      hw/net/net_tx_pkt.o
  CC      hw/net/net_rx_pkt.o
  CC      hw/net/e1000e.o
  CC      hw/net/e1000e_core.o
  CC      hw/net/rtl8139.o
  CC      hw/net/vmxnet3.o
  CC      hw/net/smc91c111.o
  CC      hw/net/lan9118.o
  CC      hw/net/ne2000-isa.o
  CC      hw/net/opencores_eth.o
  CC      hw/net/xgmac.o
  CC      hw/net/mipsnet.o
  CC      hw/net/xilinx_axienet.o
  CC      hw/net/allwinner_emac.o
  CC      hw/net/imx_fec.o
  CC      hw/net/cadence_gem.o
  CC      hw/net/stellaris_enet.o
  CC      hw/net/lance.o
  CC      hw/net/ftgmac100.o
  CC      hw/net/rocker/rocker.o
  CC      hw/net/rocker/rocker_desc.o
  CC      hw/net/rocker/rocker_fp.o
  CC      hw/net/rocker/rocker_world.o
  CC      hw/net/rocker/rocker_of_dpa.o
  CC      hw/nvram/ds1225y.o
  CC      hw/nvram/eeprom93xx.o
  CC      hw/nvram/fw_cfg.o
  CC      hw/nvram/chrp_nvram.o
  CC      hw/nvram/mac_nvram.o
  CC      hw/pci-bridge/pci_bridge_dev.o
  CC      hw/pci-bridge/pcie_root_port.o
  CC      hw/pci-bridge/gen_pcie_root_port.o
  CC      hw/pci-bridge/pci_expander_bridge.o
  CC      hw/pci-bridge/xio3130_upstream.o
  CC      hw/pci-bridge/xio3130_downstream.o
  CC      hw/pci-bridge/ioh3420.o
  CC      hw/pci-bridge/i82801b11.o
  CC      hw/pci-bridge/dec.o
  CC      hw/pci-host/pam.o
  CC      hw/pci-host/prep.o
  CC      hw/pci-host/grackle.o
  CC      hw/pci-host/uninorth.o
  CC      hw/pci-host/ppce500.o
  CC      hw/pci-host/versatile.o
  CC      hw/pci-host/apb.o
  CC      hw/pci-host/bonito.o
  CC      hw/pci-host/piix.o
  CC      hw/pci-host/q35.o
  CC      hw/pci-host/xilinx-pcie.o
  CC      hw/pci-host/gpex.o
  CC      hw/pci/pci.o
  CC      hw/pci/msix.o
  CC      hw/pci/pci_bridge.o
  CC      hw/pci/msi.o
  CC      hw/pci/shpc.o
  CC      hw/pci/slotid_cap.o
  CC      hw/pci/pci_host.o
  CC      hw/pci/pcie_host.o
  CC      hw/pci/pcie_aer.o
  CC      hw/pci/pcie.o
  CC      hw/pci/pcie_port.o
  CC      hw/pci/pci-stub.o
  CC      hw/pcmcia/pcmcia.o
  CC      hw/scsi/scsi-disk.o
  CC      hw/scsi/scsi-generic.o
  CC      hw/scsi/scsi-bus.o
  CC      hw/scsi/lsi53c895a.o
  CC      hw/scsi/mptsas.o
  CC      hw/scsi/mptconfig.o
  CC      hw/scsi/mptendian.o
  CC      hw/scsi/megasas.o
  CC      hw/scsi/vmw_pvscsi.o
  CC      hw/scsi/esp.o
  CC      hw/scsi/esp-pci.o
  CC      hw/sd/pl181.o
  CC      hw/sd/ssi-sd.o
  CC      hw/sd/sd.o
  CC      hw/sd/core.o
  CC      hw/sd/sdhci.o
  CC      hw/smbios/smbios.o
  CC      hw/smbios/smbios_type_38.o
  CC      hw/smbios/smbios-stub.o
  CC      hw/smbios/smbios_type_38-stub.o
  CC      hw/ssi/pl022.o
  CC      hw/ssi/ssi.o
  CC      hw/ssi/xilinx_spi.o
  CC      hw/ssi/xilinx_spips.o
  CC      hw/ssi/aspeed_smc.o
  CC      hw/ssi/stm32f2xx_spi.o
  CC      hw/timer/arm_mptimer.o
  CC      hw/timer/arm_timer.o
  CC      hw/timer/armv7m_systick.o
  CC      hw/timer/a9gtimer.o
  CC      hw/timer/cadence_ttc.o
  CC      hw/timer/ds1338.o
  CC      hw/timer/hpet.o
  CC      hw/timer/i8254.o
  CC      hw/timer/i8254_common.o
  CC      hw/timer/m48t59.o
  CC      hw/timer/m48t59-isa.o
  CC      hw/timer/pl031.o
  CC      hw/timer/puv3_ost.o
  CC      hw/timer/twl92230.o
  CC      hw/timer/xilinx_timer.o
  CC      hw/timer/slavio_timer.o
  CC      hw/timer/etraxfs_timer.o
  CC      hw/timer/grlib_gptimer.o
  CC      hw/timer/imx_epit.o
  CC      hw/timer/imx_gpt.o
  CC      hw/timer/lm32_timer.o
  CC      hw/timer/milkymist-sysctl.o
  CC      hw/timer/stm32f2xx_timer.o
  CC      hw/timer/aspeed_timer.o
  CC      hw/timer/sun4v-rtc.o
  CC      hw/timer/cmsdk-apb-timer.o
  CC      hw/tpm/tpm_tis.o
  CC      hw/usb/core.o
  CC      hw/usb/combined-packet.o
  CC      hw/usb/bus.o
  CC      hw/usb/libhw.o
  CC      hw/usb/desc.o
  CC      hw/usb/desc-msos.o
  CC      hw/usb/hcd-uhci.o
  CC      hw/usb/hcd-ohci.o
  CC      hw/usb/hcd-ehci.o
  CC      hw/usb/hcd-ehci-pci.o
  CC      hw/usb/hcd-ehci-sysbus.o
  CC      hw/usb/hcd-xhci.o
  CC      hw/usb/hcd-xhci-nec.o
  CC      hw/usb/hcd-musb.o
  CC      hw/usb/dev-hub.o
  CC      hw/usb/dev-hid.o
  CC      hw/usb/dev-wacom.o
  CC      hw/usb/dev-storage.o
  CC      hw/usb/dev-uas.o
  CC      hw/usb/dev-audio.o
  CC      hw/usb/dev-serial.o
  CC      hw/usb/dev-network.o
  CC      hw/usb/dev-bluetooth.o
  CC      hw/usb/dev-smartcard-reader.o
  CC      hw/usb/ccid-card-passthru.o
  CC      hw/usb/ccid-card-emulated.o
  CC      hw/usb/dev-mtp.o
  CC      hw/usb/redirect.o
  CC      hw/usb/quirks.o
  CC      hw/usb/host-libusb.o
  CC      hw/usb/host-legacy.o
  CC      hw/virtio/virtio-rng.o
  CC      hw/virtio/virtio-bus.o
  CC      hw/virtio/virtio-pci.o
  CC      hw/virtio/virtio-mmio.o
  CC      hw/virtio/vhost-stub.o
  CC      hw/watchdog/watchdog.o
  CC      hw/watchdog/wdt_i6300esb.o
  CC      hw/watchdog/wdt_ib700.o
  CC      hw/watchdog/wdt_diag288.o
  CC      hw/watchdog/wdt_aspeed.o
  CC      migration/migration.o
  CC      migration/socket.o
  CC      migration/fd.o
  CC      migration/exec.o
  CC      migration/tls.o
  CC      migration/channel.o
  CC      migration/savevm.o
  CC      migration/colo-comm.o
  CC      migration/colo.o
  CC      migration/colo-failover.o
  CC      migration/vmstate.o
  CC      migration/vmstate-types.o
  CC      migration/page_cache.o
  CC      migration/qemu-file.o
  CC      migration/global_state.o
  CC      migration/qemu-file-channel.o
  CC      migration/postcopy-ram.o
  CC      migration/xbzrle.o
  CC      migration/qjson.o
  CC      migration/block.o
  CC      net/net.o
  CC      net/queue.o
  CC      net/checksum.o
  CC      net/util.o
  CC      net/hub.o
  CC      net/socket.o
  CC      net/eth.o
  CC      net/dump.o
  CC      net/l2tpv3.o
  CC      net/vhost-user.o
  CC      net/slirp.o
  CC      net/filter-buffer.o
  CC      net/filter.o
  CC      net/filter-mirror.o
  CC      net/colo-compare.o
  CC      net/filter-rewriter.o
  CC      net/colo.o
  CC      net/filter-replay.o
  CC      net/tap.o
  CC      net/tap-linux.o
  CC      qom/cpu.o
  CC      replay/replay.o
  CC      replay/replay-internal.o
  CC      replay/replay-events.o
  CC      replay/replay-time.o
  CC      replay/replay-input.o
  CC      replay/replay-snapshot.o
  CC      replay/replay-char.o
  CC      replay/replay-net.o
  CC      replay/replay-audio.o
  CC      slirp/cksum.o
  CC      slirp/if.o
  CC      slirp/ip_icmp.o
  CC      slirp/ip6_input.o
  CC      slirp/ip6_icmp.o
  CC      slirp/ip6_output.o
  CC      slirp/ip_input.o
  CC      slirp/ip_output.o
  CC      slirp/dnssearch.o
  CC      slirp/dhcpv6.o
  CC      slirp/slirp.o
  CC      slirp/mbuf.o
  CC      slirp/misc.o
  CC      slirp/sbuf.o
  CC      slirp/socket.o
  CC      slirp/tcp_input.o
  CC      slirp/tcp_output.o
  CC      slirp/tcp_subr.o
  CC      slirp/tcp_timer.o
  CC      slirp/udp.o
  CC      slirp/udp6.o
  CC      slirp/bootp.o
  CC      slirp/tftp.o
  CC      slirp/ndp_table.o
  CC      slirp/arp_table.o
  CC      slirp/ncsi.o
  CC      ui/keymaps.o
  CC      ui/console.o
  CC      ui/cursor.o
  CC      ui/qemu-pixman.o
  CC      ui/input.o
  CC      ui/input-keymap.o
  CC      ui/input-legacy.o
  CC      ui/input-linux.o
  CC      ui/sdl2.o
  CC      ui/sdl2-input.o
  CC      ui/sdl2-2d.o
  CC      ui/sdl2-gl.o
  CC      ui/x_keymap.o
  CC      ui/curses.o
  CC      ui/vnc.o
  CC      ui/vnc-enc-zlib.o
  CC      ui/vnc-enc-hextile.o
  CC      ui/vnc-enc-tight.o
  CC      ui/vnc-palette.o
  CC      ui/vnc-enc-zrle.o
  CC      ui/vnc-auth-vencrypt.o
  CC      ui/vnc-auth-sasl.o
  CC      ui/vnc-jobs.o
  CC      ui/vnc-ws.o
  CC      ui/gtk.o
  CC      ui/shader.o
  VERT    ui/shader/texture-blit-vert.h
  FRAG    ui/shader/texture-blit-frag.h
  CC      ui/egl-helpers.o
  CC      ui/egl-context.o
  CC      ui/egl-headless.o
  CC      ui/gtk-gl-area.o
  CC      chardev/char.o
  CC      chardev/char-fd.o
  CC      chardev/char-fe.o
  CC      chardev/char-file.o
  CC      chardev/char-io.o
  CC      chardev/char-mux.o
  CC      chardev/char-null.o
  CC      chardev/char-parallel.o
  CC      chardev/char-pipe.o
  CC      chardev/char-pty.o
  CC      chardev/char-serial.o
  CC      chardev/char-ringbuf.o
  CC      chardev/char-socket.o
  CC      chardev/char-stdio.o
  CC      chardev/char-udp.o
  CCAS    s390-ccw/start.o
  CC      s390-ccw/main.o
  CC      s390-ccw/bootmap.o
  LINK    tests/qemu-iotests/socket_scm_helper
  GEN     qemu-doc.html
  GEN     qemu-doc.txt
  CC      s390-ccw/sclp.o
  CC      s390-ccw/virtio.o
  CC      s390-ccw/virtio-scsi.o
  CC      s390-ccw/virtio-blkdev.o
s390-netboot.img not built since roms/SLOF/ is not available.
  BUILD   s390-ccw/s390-ccw.elf
  GEN     qemu.1
  STRIP   s390-ccw/s390-ccw.img
  GEN     docs/interop/qemu-qmp-ref.html
  GEN     docs/interop/qemu-qmp-ref.txt
  GEN     docs/interop/qemu-qmp-ref.7
  GEN     docs/interop/qemu-ga-ref.html
  GEN     docs/interop/qemu-ga-ref.txt
  GEN     docs/interop/qemu-ga-ref.7
  CC      qga/commands.o
  CC      qga/guest-agent-command-state.o
  CC      qga/main.o
  CC      qga/commands-posix.o
  CC      qga/channel-posix.o
  CC      qga/qapi-generated/qga-qapi-types.o
  CC      qga/qapi-generated/qga-qapi-visit.o
  CC      qga/qapi-generated/qga-qmp-marshal.o
  AR      libqemuutil.a
  AR      libqemustub.a
  CC      qemu-img.o
  CC      ui/console-gl.o
  LINK    ivshmem-client
  LINK    ivshmem-server
  LINK    qemu-nbd
  LINK    qemu-io
  LINK    fsdev/virtfs-proxy-helper
  LINK    qemu-bridge-helper
  GEN     aarch64-softmmu/hmp-commands.h
  GEN     aarch64-softmmu/hmp-commands-info.h
  GEN     aarch64-softmmu/config-target.h
  CC      aarch64-softmmu/exec.o
  GEN     alpha-softmmu/hmp-commands.h
  GEN     arm-softmmu/hmp-commands.h
  GEN     alpha-softmmu/hmp-commands-info.h
  GEN     arm-softmmu/hmp-commands-info.h
  GEN     alpha-softmmu/config-target.h
  GEN     arm-softmmu/config-target.h
  GEN     cris-softmmu/hmp-commands.h
  CC      alpha-softmmu/exec.o
  CC      arm-softmmu/exec.o
  GEN     cris-softmmu/hmp-commands-info.h
  GEN     cris-softmmu/config-target.h
  CC      cris-softmmu/exec.o
  CC      aarch64-softmmu/tcg/tcg.o
  CC      alpha-softmmu/tcg/tcg.o
  CC      arm-softmmu/tcg/tcg.o
  CC      cris-softmmu/tcg/tcg.o
  CC      aarch64-softmmu/tcg/tcg-op.o
  CC      alpha-softmmu/tcg/tcg-op.o
  CC      arm-softmmu/tcg/tcg-op.o
  CC      cris-softmmu/tcg/tcg-op.o
  CC      aarch64-softmmu/tcg/optimize.o
  CC      alpha-softmmu/tcg/optimize.o
  CC      arm-softmmu/tcg/optimize.o
  CC      cris-softmmu/tcg/optimize.o
  CC      aarch64-softmmu/tcg/tcg-common.o
  CC      aarch64-softmmu/tcg/tcg-runtime.o
  CC      alpha-softmmu/tcg/tcg-common.o
  CC      alpha-softmmu/tcg/tcg-runtime.o
  CC      arm-softmmu/tcg/tcg-common.o
  CC      cris-softmmu/tcg/tcg-common.o
  CC      aarch64-softmmu/fpu/softfloat.o
  CC      arm-softmmu/tcg/tcg-runtime.o
  CC      cris-softmmu/tcg/tcg-runtime.o
  CC      alpha-softmmu/fpu/softfloat.o
  CC      cris-softmmu/fpu/softfloat.o
  CC      arm-softmmu/fpu/softfloat.o
  CC      aarch64-softmmu/disas.o
  CC      alpha-softmmu/disas.o
  CC      alpha-softmmu/hax-stub.o
  GEN     aarch64-softmmu/gdbstub-xml.c
  CC      cris-softmmu/disas.o
  CC      alpha-softmmu/arch_init.o
  CC      aarch64-softmmu/hax-stub.o
  CC      cris-softmmu/hax-stub.o
  CC      alpha-softmmu/cpus.o
  CC      aarch64-softmmu/arch_init.o
  CC      cris-softmmu/arch_init.o
  CC      cris-softmmu/cpus.o
  CC      arm-softmmu/disas.o
  CC      aarch64-softmmu/cpus.o
  CC      alpha-softmmu/monitor.o
  GEN     arm-softmmu/gdbstub-xml.c
  CC      arm-softmmu/hax-stub.o
  CC      cris-softmmu/monitor.o
  CC      aarch64-softmmu/monitor.o
  CC      arm-softmmu/arch_init.o
  CC      alpha-softmmu/gdbstub.o
  CC      arm-softmmu/cpus.o
  CC      cris-softmmu/gdbstub.o
  CC      alpha-softmmu/balloon.o
  CC      aarch64-softmmu/gdbstub.o
  CC      alpha-softmmu/ioport.o
  CC      arm-softmmu/monitor.o
  CC      cris-softmmu/balloon.o
  CC      alpha-softmmu/numa.o
  CC      aarch64-softmmu/balloon.o
  CC      cris-softmmu/ioport.o
  CC      alpha-softmmu/qtest.o
  CC      aarch64-softmmu/ioport.o
  CC      cris-softmmu/numa.o
  CC      alpha-softmmu/memory.o
  CC      cris-softmmu/qtest.o
  CC      arm-softmmu/gdbstub.o
  CC      aarch64-softmmu/numa.o
  CC      cris-softmmu/memory.o
  CC      aarch64-softmmu/qtest.o
  CC      arm-softmmu/balloon.o
  CC      alpha-softmmu/memory_mapping.o
  CC      aarch64-softmmu/memory.o
  CC      arm-softmmu/ioport.o
  CC      alpha-softmmu/dump.o
  CC      arm-softmmu/numa.o
  CC      cris-softmmu/memory_mapping.o
  CC      arm-softmmu/qtest.o
  CC      cris-softmmu/dump.o
  CC      alpha-softmmu/migration/ram.o
  CC      aarch64-softmmu/memory_mapping.o
  CC      arm-softmmu/memory.o
  CC      aarch64-softmmu/dump.o
  CC      cris-softmmu/migration/ram.o
  CC      alpha-softmmu/accel/accel.o
  CC      aarch64-softmmu/migration/ram.o
  CC      alpha-softmmu/accel/stubs/kvm-stub.o
  CC      arm-softmmu/memory_mapping.o
  CC      cris-softmmu/accel/accel.o
  CC      alpha-softmmu/accel/tcg/tcg-all.o
  CC      arm-softmmu/dump.o
  CC      cris-softmmu/accel/stubs/kvm-stub.o
  CC      alpha-softmmu/accel/tcg/cputlb.o
  CC      cris-softmmu/accel/tcg/tcg-all.o
  CC      aarch64-softmmu/accel/accel.o
  CC      cris-softmmu/accel/tcg/cputlb.o
  CC      arm-softmmu/migration/ram.o
  CC      aarch64-softmmu/accel/stubs/kvm-stub.o
  CC      aarch64-softmmu/accel/tcg/tcg-all.o
  CC      alpha-softmmu/accel/tcg/cpu-exec.o
  CC      arm-softmmu/accel/accel.o
  CC      aarch64-softmmu/accel/tcg/cputlb.o
  CC      arm-softmmu/accel/stubs/kvm-stub.o
  CC      alpha-softmmu/accel/tcg/cpu-exec-common.o
  CC      cris-softmmu/accel/tcg/cpu-exec.o
  CC      arm-softmmu/accel/tcg/tcg-all.o
  CC      alpha-softmmu/accel/tcg/translate-all.o
  CC      cris-softmmu/accel/tcg/cpu-exec-common.o
  CC      arm-softmmu/accel/tcg/cputlb.o
  CC      cris-softmmu/accel/tcg/translate-all.o
  CC      alpha-softmmu/hw/9pfs/virtio-9p-device.o
  CC      alpha-softmmu/hw/block/virtio-blk.o
  CC      aarch64-softmmu/accel/tcg/cpu-exec.o
  CC      cris-softmmu/hw/core/generic-loader.o
  CC      alpha-softmmu/hw/block/dataplane/virtio-blk.o
  CC      cris-softmmu/hw/core/null-machine.o
  CC      arm-softmmu/accel/tcg/cpu-exec.o
  CC      aarch64-softmmu/accel/tcg/cpu-exec-common.o
  CC      cris-softmmu/hw/misc/mmio_interface.o
  CC      aarch64-softmmu/accel/tcg/translate-all.o
  CC      alpha-softmmu/hw/char/virtio-serial-bus.o
  CC      cris-softmmu/hw/net/etraxfs_eth.o
  CC      cris-softmmu/hw/net/vhost_net.o
  CC      cris-softmmu/hw/net/rocker/qmp-norocker.o
  CC      arm-softmmu/accel/tcg/cpu-exec-common.o
  CC      cris-softmmu/hw/vfio/common.o
  CC      aarch64-softmmu/hw/9pfs/virtio-9p-device.o
  CC      alpha-softmmu/hw/core/generic-loader.o
  CC      arm-softmmu/accel/tcg/translate-all.o
  CC      aarch64-softmmu/hw/adc/stm32f2xx_adc.o
  CC      alpha-softmmu/hw/core/null-machine.o
  CC      alpha-softmmu/hw/display/vga.o
  CC      cris-softmmu/hw/vfio/platform.o
  CC      aarch64-softmmu/hw/block/virtio-blk.o
  CC      arm-softmmu/hw/9pfs/virtio-9p-device.o
  CC      cris-softmmu/hw/vfio/spapr.o
  CC      arm-softmmu/hw/adc/stm32f2xx_adc.o
  CC      arm-softmmu/hw/block/virtio-blk.o
  CC      aarch64-softmmu/hw/block/dataplane/virtio-blk.o
  CC      cris-softmmu/hw/cris/boot.o
  CC      alpha-softmmu/hw/display/virtio-gpu.o
  CC      aarch64-softmmu/hw/char/exynos4210_uart.o
  CC      arm-softmmu/hw/block/dataplane/virtio-blk.o
  CC      cris-softmmu/hw/cris/axis_dev88.o
  CC      aarch64-softmmu/hw/char/omap_uart.o
  CC      arm-softmmu/hw/char/exynos4210_uart.o
  CC      cris-softmmu/target/cris/translate.o
  CC      aarch64-softmmu/hw/char/digic-uart.o
  CC      arm-softmmu/hw/char/omap_uart.o
  CC      alpha-softmmu/hw/display/virtio-gpu-3d.o
  CC      aarch64-softmmu/hw/char/stm32f2xx_usart.o
  CC      arm-softmmu/hw/char/digic-uart.o
  CC      aarch64-softmmu/hw/char/bcm2835_aux.o
  CC      aarch64-softmmu/hw/char/virtio-serial-bus.o
  CC      arm-softmmu/hw/char/stm32f2xx_usart.o
  CC      alpha-softmmu/hw/display/virtio-gpu-pci.o
  CC      arm-softmmu/hw/char/bcm2835_aux.o
  CC      aarch64-softmmu/hw/core/generic-loader.o
  CC      alpha-softmmu/hw/misc/ivshmem.o
  CC      cris-softmmu/target/cris/op_helper.o
  CC      aarch64-softmmu/hw/core/null-machine.o
  CC      arm-softmmu/hw/char/virtio-serial-bus.o
  CC      aarch64-softmmu/hw/cpu/arm11mpcore.o
  CC      alpha-softmmu/hw/misc/mmio_interface.o
  CC      cris-softmmu/target/cris/helper.o
  CC      alpha-softmmu/hw/net/virtio-net.o
  CC      arm-softmmu/hw/core/generic-loader.o
  CC      aarch64-softmmu/hw/cpu/realview_mpcore.o
  CC      cris-softmmu/target/cris/cpu.o
  CC      aarch64-softmmu/hw/cpu/a9mpcore.o
  CC      arm-softmmu/hw/core/null-machine.o
  CC      cris-softmmu/target/cris/gdbstub.o
  CC      aarch64-softmmu/hw/cpu/a15mpcore.o
  CC      alpha-softmmu/hw/net/vhost_net.o
  CC      arm-softmmu/hw/cpu/arm11mpcore.o
  CC      alpha-softmmu/hw/scsi/virtio-scsi.o
  CC      cris-softmmu/target/cris/mmu.o
  CC      arm-softmmu/hw/cpu/realview_mpcore.o
  CC      aarch64-softmmu/hw/display/omap_dss.o
  CC      arm-softmmu/hw/cpu/a9mpcore.o
  CC      alpha-softmmu/hw/scsi/virtio-scsi-dataplane.o
  CC      cris-softmmu/target/cris/machine.o
  CC      arm-softmmu/hw/cpu/a15mpcore.o
  CC      aarch64-softmmu/hw/display/omap_lcdc.o
  CC      alpha-softmmu/hw/scsi/vhost-scsi-common.o
  CC      arm-softmmu/hw/display/omap_dss.o
  GEN     trace/generated-helpers.c
  CC      cris-softmmu/trace/control-target.o
  CC      alpha-softmmu/hw/scsi/vhost-scsi.o
  CC      aarch64-softmmu/hw/display/pxa2xx_lcd.o
  CC      cris-softmmu/trace/generated-helpers.o
  CC      arm-softmmu/hw/display/omap_lcdc.o
  CC      alpha-softmmu/hw/scsi/vhost-user-scsi.o
  LINK    cris-softmmu/qemu-system-cris
  CC      alpha-softmmu/hw/timer/mc146818rtc.o
  CC      arm-softmmu/hw/display/pxa2xx_lcd.o
  CC      aarch64-softmmu/hw/display/bcm2835_fb.o
  CC      alpha-softmmu/hw/vfio/common.o
  CC      alpha-softmmu/hw/vfio/pci.o
  CC      aarch64-softmmu/hw/display/vga.o
  CC      arm-softmmu/hw/display/bcm2835_fb.o
  CC      alpha-softmmu/hw/vfio/pci-quirks.o
  CC      alpha-softmmu/hw/vfio/platform.o
  CC      arm-softmmu/hw/display/vga.o
  CC      aarch64-softmmu/hw/display/virtio-gpu.o
  CC      alpha-softmmu/hw/vfio/spapr.o
  CC      alpha-softmmu/hw/virtio/virtio.o
  GEN     i386-softmmu/hmp-commands.h
  GEN     i386-softmmu/hmp-commands-info.h
  GEN     i386-softmmu/config-target.h
  CC      aarch64-softmmu/hw/display/virtio-gpu-3d.o
  CC      i386-softmmu/exec.o
  CC      arm-softmmu/hw/display/virtio-gpu.o
  CC      aarch64-softmmu/hw/display/virtio-gpu-pci.o
  CC      alpha-softmmu/hw/virtio/virtio-balloon.o
  CC      arm-softmmu/hw/display/virtio-gpu-3d.o
  CC      aarch64-softmmu/hw/display/dpcd.o
  CC      alpha-softmmu/hw/virtio/vhost.o
  CC      aarch64-softmmu/hw/display/xlnx_dp.o
  CC      arm-softmmu/hw/display/virtio-gpu-pci.o
  CC      alpha-softmmu/hw/virtio/vhost-backend.o
  CC      i386-softmmu/tcg/tcg.o
  CC      aarch64-softmmu/hw/dma/xlnx_dpdma.o
  CC      alpha-softmmu/hw/virtio/vhost-user.o
  CC      arm-softmmu/hw/dma/omap_dma.o
  CC      alpha-softmmu/hw/virtio/vhost-vsock.o
  CC      aarch64-softmmu/hw/dma/omap_dma.o
  CC      arm-softmmu/hw/dma/soc_dma.o
  CC      alpha-softmmu/hw/virtio/virtio-crypto.o
  CC      aarch64-softmmu/hw/dma/soc_dma.o
  CC      arm-softmmu/hw/dma/pxa2xx_dma.o
  CC      alpha-softmmu/hw/virtio/virtio-crypto-pci.o
  CC      aarch64-softmmu/hw/dma/pxa2xx_dma.o
  CC      i386-softmmu/tcg/tcg-op.o
  CC      arm-softmmu/hw/dma/bcm2835_dma.o
  CC      alpha-softmmu/hw/alpha/dp264.o
  CC      aarch64-softmmu/hw/dma/bcm2835_dma.o
  CC      arm-softmmu/hw/gpio/omap_gpio.o
  CC      aarch64-softmmu/hw/gpio/omap_gpio.o
  CC      alpha-softmmu/hw/alpha/pci.o
  CC      arm-softmmu/hw/gpio/imx_gpio.o
  CC      aarch64-softmmu/hw/gpio/imx_gpio.o
  CC      aarch64-softmmu/hw/gpio/bcm2835_gpio.o
  CC      alpha-softmmu/hw/alpha/typhoon.o
  CC      arm-softmmu/hw/gpio/bcm2835_gpio.o
  CC      aarch64-softmmu/hw/i2c/omap_i2c.o
  CC      arm-softmmu/hw/i2c/omap_i2c.o
  CC      alpha-softmmu/target/alpha/machine.o
  CC      aarch64-softmmu/hw/input/pxa2xx_keypad.o
  CC      arm-softmmu/hw/input/pxa2xx_keypad.o
  CC      alpha-softmmu/target/alpha/translate.o
  CC      arm-softmmu/hw/input/tsc210x.o
  CC      aarch64-softmmu/hw/input/tsc210x.o
  CC      i386-softmmu/tcg/optimize.o
  CC      aarch64-softmmu/hw/intc/armv7m_nvic.o
  CC      arm-softmmu/hw/intc/armv7m_nvic.o
  CC      alpha-softmmu/target/alpha/helper.o
  CC      i386-softmmu/tcg/tcg-common.o
  CC      aarch64-softmmu/hw/intc/exynos4210_gic.o
  CC      alpha-softmmu/target/alpha/cpu.o
  CC      arm-softmmu/hw/intc/exynos4210_gic.o
  CC      i386-softmmu/tcg/tcg-runtime.o
  CC      aarch64-softmmu/hw/intc/exynos4210_combiner.o
  CC      arm-softmmu/hw/intc/exynos4210_combiner.o
  CC      alpha-softmmu/target/alpha/int_helper.o
  CC      i386-softmmu/fpu/softfloat.o
  CC      aarch64-softmmu/hw/intc/omap_intc.o
  CC      arm-softmmu/hw/intc/omap_intc.o
  CC      alpha-softmmu/target/alpha/fpu_helper.o
  CC      aarch64-softmmu/hw/intc/bcm2835_ic.o
  CC      alpha-softmmu/target/alpha/vax_helper.o
  CC      arm-softmmu/hw/intc/bcm2835_ic.o
  CC      aarch64-softmmu/hw/intc/bcm2836_control.o
  CC      alpha-softmmu/target/alpha/sys_helper.o
  CC      arm-softmmu/hw/intc/bcm2836_control.o
  CC      aarch64-softmmu/hw/intc/allwinner-a10-pic.o
  CC      alpha-softmmu/target/alpha/mem_helper.o
  CC      arm-softmmu/hw/intc/allwinner-a10-pic.o
  CC      aarch64-softmmu/hw/intc/aspeed_vic.o
  CC      arm-softmmu/hw/intc/aspeed_vic.o
  CC      alpha-softmmu/target/alpha/gdbstub.o
  CC      aarch64-softmmu/hw/intc/arm_gicv3_cpuif.o
  CC      arm-softmmu/hw/intc/arm_gicv3_cpuif.o
  GEN     trace/generated-helpers.c
  CC      alpha-softmmu/trace/control-target.o
  CC      i386-softmmu/disas.o
  GEN     i386-softmmu/gdbstub-xml.c
  CC      alpha-softmmu/trace/generated-helpers.o
  CC      i386-softmmu/hax-stub.o
  CC      aarch64-softmmu/hw/misc/ivshmem.o
  CC      i386-softmmu/arch_init.o
  CC      arm-softmmu/hw/misc/ivshmem.o
  LINK    alpha-softmmu/qemu-system-alpha
  CC      aarch64-softmmu/hw/misc/arm_sysctl.o
  CC      i386-softmmu/cpus.o
  CC      arm-softmmu/hw/misc/arm_sysctl.o
  CC      aarch64-softmmu/hw/misc/cbus.o
  CC      arm-softmmu/hw/misc/cbus.o
  CC      aarch64-softmmu/hw/misc/exynos4210_pmu.o
  CC      arm-softmmu/hw/misc/exynos4210_pmu.o
  CC      i386-softmmu/monitor.o
  CC      arm-softmmu/hw/misc/exynos4210_clk.o
  CC      aarch64-softmmu/hw/misc/exynos4210_clk.o
  CC      aarch64-softmmu/hw/misc/exynos4210_rng.o
  CC      arm-softmmu/hw/misc/exynos4210_rng.o
  CC      aarch64-softmmu/hw/misc/imx_ccm.o
  CC      arm-softmmu/hw/misc/imx_ccm.o
  CC      aarch64-softmmu/hw/misc/imx31_ccm.o
  CC      arm-softmmu/hw/misc/imx31_ccm.o
  GEN     lm32-softmmu/hmp-commands.h
  GEN     lm32-softmmu/hmp-commands-info.h
  CC      aarch64-softmmu/hw/misc/imx25_ccm.o
  GEN     lm32-softmmu/config-target.h
  CC      lm32-softmmu/exec.o
  CC      arm-softmmu/hw/misc/imx25_ccm.o
  CC      aarch64-softmmu/hw/misc/imx6_ccm.o
  CC      i386-softmmu/gdbstub.o
  CC      arm-softmmu/hw/misc/imx6_ccm.o
  CC      aarch64-softmmu/hw/misc/imx6_src.o
  CC      arm-softmmu/hw/misc/imx6_src.o
  CC      aarch64-softmmu/hw/misc/mst_fpga.o
  CC      i386-softmmu/balloon.o
  CC      arm-softmmu/hw/misc/mst_fpga.o
  CC      aarch64-softmmu/hw/misc/omap_clk.o
  CC      arm-softmmu/hw/misc/omap_clk.o
  CC      i386-softmmu/ioport.o
  CC      aarch64-softmmu/hw/misc/omap_gpmc.o
  CC      arm-softmmu/hw/misc/omap_gpmc.o
  CC      i386-softmmu/numa.o
  CC      aarch64-softmmu/hw/misc/omap_l4.o
  CC      aarch64-softmmu/hw/misc/omap_sdrc.o
  CC      lm32-softmmu/tcg/tcg.o
  CC      arm-softmmu/hw/misc/omap_l4.o
  CC      i386-softmmu/qtest.o
  CC      aarch64-softmmu/hw/misc/omap_tap.o
  CC      arm-softmmu/hw/misc/omap_sdrc.o
  CC      arm-softmmu/hw/misc/omap_tap.o
  CC      i386-softmmu/memory.o
  CC      aarch64-softmmu/hw/misc/bcm2835_mbox.o
  CC      arm-softmmu/hw/misc/bcm2835_mbox.o
  CC      aarch64-softmmu/hw/misc/bcm2835_property.o
  CC      arm-softmmu/hw/misc/bcm2835_property.o
  CC      aarch64-softmmu/hw/misc/bcm2835_rng.o
  CC      lm32-softmmu/tcg/tcg-op.o
  CC      aarch64-softmmu/hw/misc/zynq_slcr.o
  CC      i386-softmmu/memory_mapping.o
  CC      arm-softmmu/hw/misc/bcm2835_rng.o
  CC      i386-softmmu/dump.o
  CC      arm-softmmu/hw/misc/zynq_slcr.o
  CC      aarch64-softmmu/hw/misc/zynq-xadc.o
  CC      arm-softmmu/hw/misc/zynq-xadc.o
  CC      aarch64-softmmu/hw/misc/stm32f2xx_syscfg.o
  CC      aarch64-softmmu/hw/misc/mps2-scc.o
  CC      arm-softmmu/hw/misc/stm32f2xx_syscfg.o
  CC      i386-softmmu/migration/ram.o
  CC      arm-softmmu/hw/misc/mps2-scc.o
  CC      aarch64-softmmu/hw/misc/auxbus.o
  CC      arm-softmmu/hw/misc/aspeed_scu.o
  CC      aarch64-softmmu/hw/misc/aspeed_scu.o
  CC      aarch64-softmmu/hw/misc/aspeed_sdmc.o
  CC      i386-softmmu/accel/accel.o
  CC      lm32-softmmu/tcg/optimize.o
  CC      aarch64-softmmu/hw/misc/mmio_interface.o
  CC      arm-softmmu/hw/misc/aspeed_sdmc.o
  CC      i386-softmmu/accel/stubs/kvm-stub.o
  CC      aarch64-softmmu/hw/net/virtio-net.o
  CC      arm-softmmu/hw/misc/mmio_interface.o
  CC      i386-softmmu/accel/tcg/tcg-all.o
  CC      i386-softmmu/accel/tcg/cputlb.o
  CC      lm32-softmmu/tcg/tcg-common.o
  CC      arm-softmmu/hw/net/virtio-net.o
  CC      lm32-softmmu/tcg/tcg-runtime.o
  CC      aarch64-softmmu/hw/net/vhost_net.o
  CC      aarch64-softmmu/hw/pcmcia/pxa2xx.o
  CC      lm32-softmmu/fpu/softfloat.o
  CC      aarch64-softmmu/hw/scsi/virtio-scsi.o
  CC      arm-softmmu/hw/net/vhost_net.o
  CC      arm-softmmu/hw/pcmcia/pxa2xx.o
  CC      aarch64-softmmu/hw/scsi/virtio-scsi-dataplane.o
  CC      i386-softmmu/accel/tcg/cpu-exec.o
  CC      arm-softmmu/hw/scsi/virtio-scsi.o
  CC      aarch64-softmmu/hw/scsi/vhost-scsi-common.o
  CC      i386-softmmu/accel/tcg/cpu-exec-common.o
  CC      arm-softmmu/hw/scsi/virtio-scsi-dataplane.o
  CC      i386-softmmu/accel/tcg/translate-all.o
  CC      aarch64-softmmu/hw/scsi/vhost-scsi.o
  CC      arm-softmmu/hw/scsi/vhost-scsi-common.o
  CC      aarch64-softmmu/hw/scsi/vhost-user-scsi.o
  CC      i386-softmmu/hw/9pfs/virtio-9p-device.o
  CC      aarch64-softmmu/hw/sd/omap_mmc.o
  CC      arm-softmmu/hw/scsi/vhost-scsi.o
  CC      aarch64-softmmu/hw/sd/pxa2xx_mmci.o
  CC      i386-softmmu/hw/block/virtio-blk.o
  CC      lm32-softmmu/disas.o
  CC      arm-softmmu/hw/scsi/vhost-user-scsi.o
  CC      aarch64-softmmu/hw/sd/bcm2835_sdhost.o
  CC      lm32-softmmu/hax-stub.o
  CC      aarch64-softmmu/hw/ssi/omap_spi.o
  CC      i386-softmmu/hw/block/dataplane/virtio-blk.o
  CC      arm-softmmu/hw/sd/omap_mmc.o
  CC      lm32-softmmu/arch_init.o
  CC      aarch64-softmmu/hw/ssi/imx_spi.o
  CC      i386-softmmu/hw/char/virtio-serial-bus.o
  CC      arm-softmmu/hw/sd/pxa2xx_mmci.o
  CC      lm32-softmmu/cpus.o
  CC      aarch64-softmmu/hw/timer/exynos4210_mct.o
  CC      arm-softmmu/hw/sd/bcm2835_sdhost.o
  CC      lm32-softmmu/monitor.o
  CC      i386-softmmu/hw/core/generic-loader.o
  CC      aarch64-softmmu/hw/timer/exynos4210_pwm.o
  CC      arm-softmmu/hw/ssi/omap_spi.o
  CC      aarch64-softmmu/hw/timer/exynos4210_rtc.o
  CC      i386-softmmu/hw/core/null-machine.o
  CC      arm-softmmu/hw/ssi/imx_spi.o
  CC      aarch64-softmmu/hw/timer/omap_gptimer.o
  CC      i386-softmmu/hw/display/vga.o
  CC      arm-softmmu/hw/timer/exynos4210_mct.o
  CC      aarch64-softmmu/hw/timer/omap_synctimer.o
  CC      arm-softmmu/hw/timer/exynos4210_pwm.o
  CC      lm32-softmmu/gdbstub.o
  CC      aarch64-softmmu/hw/timer/pxa2xx_timer.o
  CC      arm-softmmu/hw/timer/exynos4210_rtc.o
  CC      lm32-softmmu/balloon.o
  CC      i386-softmmu/hw/display/virtio-gpu.o
  CC      arm-softmmu/hw/timer/omap_gptimer.o
  CC      aarch64-softmmu/hw/timer/digic-timer.o
  CC      lm32-softmmu/ioport.o
  CC      aarch64-softmmu/hw/timer/allwinner-a10-pit.o
  CC      arm-softmmu/hw/timer/omap_synctimer.o
  CC      aarch64-softmmu/hw/usb/tusb6010.o
  CC      arm-softmmu/hw/timer/pxa2xx_timer.o
  CC      lm32-softmmu/numa.o
  CC      i386-softmmu/hw/display/virtio-gpu-3d.o
  CC      aarch64-softmmu/hw/vfio/common.o
  CC      lm32-softmmu/qtest.o
  CC      arm-softmmu/hw/timer/digic-timer.o
  CC      i386-softmmu/hw/display/virtio-gpu-pci.o
  CC      aarch64-softmmu/hw/vfio/pci.o
  CC      arm-softmmu/hw/timer/allwinner-a10-pit.o
  CC      lm32-softmmu/memory.o
  CC      i386-softmmu/hw/display/virtio-vga.o
  CC      arm-softmmu/hw/usb/tusb6010.o
  CC      i386-softmmu/hw/intc/apic.o
  CC      aarch64-softmmu/hw/vfio/pci-quirks.o
  CC      arm-softmmu/hw/vfio/common.o
  CC      lm32-softmmu/memory_mapping.o
  CC      i386-softmmu/hw/intc/apic_common.o
  CC      arm-softmmu/hw/vfio/pci.o
  CC      aarch64-softmmu/hw/vfio/platform.o
  CC      lm32-softmmu/dump.o
  CC      i386-softmmu/hw/intc/ioapic.o
  CC      aarch64-softmmu/hw/vfio/calxeda-xgmac.o
  CC      aarch64-softmmu/hw/vfio/amd-xgbe.o
  CC      lm32-softmmu/migration/ram.o
  CC      arm-softmmu/hw/vfio/pci-quirks.o
  CC      i386-softmmu/hw/isa/lpc_ich9.o
  CC      aarch64-softmmu/hw/vfio/spapr.o
  CC      i386-softmmu/hw/misc/vmport.o
  CC      lm32-softmmu/accel/accel.o
  CC      arm-softmmu/hw/vfio/platform.o
  CC      aarch64-softmmu/hw/virtio/virtio.o
  CC      lm32-softmmu/accel/stubs/kvm-stub.o
  CC      i386-softmmu/hw/misc/ivshmem.o
  CC      arm-softmmu/hw/vfio/calxeda-xgmac.o
  CC      lm32-softmmu/accel/tcg/tcg-all.o
  CC      arm-softmmu/hw/vfio/amd-xgbe.o
  CC      i386-softmmu/hw/misc/pvpanic.o
  CC      lm32-softmmu/accel/tcg/cputlb.o
  CC      arm-softmmu/hw/vfio/spapr.o
  CC      aarch64-softmmu/hw/virtio/virtio-balloon.o
  CC      i386-softmmu/hw/misc/mmio_interface.o
  CC      arm-softmmu/hw/virtio/virtio.o
  CC      i386-softmmu/hw/net/virtio-net.o
  CC      aarch64-softmmu/hw/virtio/vhost.o
  CC      arm-softmmu/hw/virtio/virtio-balloon.o
  CC      aarch64-softmmu/hw/virtio/vhost-backend.o
  CC      i386-softmmu/hw/net/vhost_net.o
  CC      lm32-softmmu/accel/tcg/cpu-exec.o
  CC      i386-softmmu/hw/scsi/virtio-scsi.o
  CC      aarch64-softmmu/hw/virtio/vhost-user.o
  CC      arm-softmmu/hw/virtio/vhost.o
  CC      lm32-softmmu/accel/tcg/cpu-exec-common.o
  CC      lm32-softmmu/accel/tcg/translate-all.o
  CC      aarch64-softmmu/hw/virtio/vhost-vsock.o
  CC      i386-softmmu/hw/scsi/virtio-scsi-dataplane.o
  CC      arm-softmmu/hw/virtio/vhost-backend.o
  CC      aarch64-softmmu/hw/virtio/virtio-crypto.o
  CC      lm32-softmmu/hw/core/generic-loader.o
  CC      i386-softmmu/hw/scsi/vhost-scsi-common.o
  CC      arm-softmmu/hw/virtio/vhost-user.o
  CC      i386-softmmu/hw/scsi/vhost-scsi.o
  CC      lm32-softmmu/hw/core/null-machine.o
  CC      aarch64-softmmu/hw/virtio/virtio-crypto-pci.o
  CC      i386-softmmu/hw/scsi/vhost-user-scsi.o
  CC      arm-softmmu/hw/virtio/vhost-vsock.o
  CC      lm32-softmmu/hw/input/milkymist-softusb.o
  CC      i386-softmmu/hw/timer/mc146818rtc.o
  CC      aarch64-softmmu/hw/arm/boot.o
  CC      arm-softmmu/hw/virtio/virtio-crypto.o
  CC      lm32-softmmu/hw/misc/milkymist-hpdmc.o
  CC      i386-softmmu/hw/vfio/common.o
  CC      aarch64-softmmu/hw/arm/collie.o
  CC      arm-softmmu/hw/virtio/virtio-crypto-pci.o
  CC      lm32-softmmu/hw/misc/milkymist-pfpu.o
  CC      aarch64-softmmu/hw/arm/exynos4_boards.o
  CC      i386-softmmu/hw/vfio/pci.o
  CC      aarch64-softmmu/hw/arm/gumstix.o
  CC      arm-softmmu/hw/arm/boot.o
  CC      lm32-softmmu/hw/misc/mmio_interface.o
  CC      aarch64-softmmu/hw/arm/highbank.o
  CC      lm32-softmmu/hw/net/milkymist-minimac2.o
  CC      arm-softmmu/hw/arm/collie.o
  CC      aarch64-softmmu/hw/arm/digic_boards.o
  CC      lm32-softmmu/hw/net/vhost_net.o
  CC      arm-softmmu/hw/arm/exynos4_boards.o
  CC      aarch64-softmmu/hw/arm/integratorcp.o
  CC      i386-softmmu/hw/vfio/pci-quirks.o
  CC      arm-softmmu/hw/arm/gumstix.o
  CC      lm32-softmmu/hw/net/rocker/qmp-norocker.o
  CC      arm-softmmu/hw/arm/highbank.o
  CC      aarch64-softmmu/hw/arm/mainstone.o
  CC      lm32-softmmu/hw/sd/milkymist-memcard.o
  CC      arm-softmmu/hw/arm/digic_boards.o
  CC      lm32-softmmu/hw/vfio/common.o
  CC      i386-softmmu/hw/vfio/platform.o
  CC      aarch64-softmmu/hw/arm/musicpal.o
  CC      arm-softmmu/hw/arm/integratorcp.o
  CC      i386-softmmu/hw/vfio/spapr.o
  CC      lm32-softmmu/hw/vfio/platform.o
  CC      aarch64-softmmu/hw/arm/nseries.o
  CC      arm-softmmu/hw/arm/mainstone.o
  CC      i386-softmmu/hw/virtio/virtio.o
  CC      arm-softmmu/hw/arm/musicpal.o
  CC      lm32-softmmu/hw/vfio/spapr.o
  CC      aarch64-softmmu/hw/arm/omap_sx1.o
  CC      lm32-softmmu/hw/lm32/lm32_boards.o
  CC      arm-softmmu/hw/arm/nseries.o
  CC      i386-softmmu/hw/virtio/virtio-balloon.o
  CC      aarch64-softmmu/hw/arm/palm.o
  CC      lm32-softmmu/hw/lm32/milkymist.o
  CC      i386-softmmu/hw/virtio/vhost.o
  CC      aarch64-softmmu/hw/arm/realview.o
  CC      arm-softmmu/hw/arm/omap_sx1.o
  CC      lm32-softmmu/target/lm32/translate.o
  CC      arm-softmmu/hw/arm/palm.o
  CC      aarch64-softmmu/hw/arm/spitz.o
  CC      i386-softmmu/hw/virtio/vhost-backend.o
  CC      i386-softmmu/hw/virtio/vhost-user.o
  CC      arm-softmmu/hw/arm/realview.o
  CC      lm32-softmmu/target/lm32/op_helper.o
  CC      arm-softmmu/hw/arm/spitz.o
  CC      lm32-softmmu/target/lm32/helper.o
  CC      aarch64-softmmu/hw/arm/stellaris.o
  CC      i386-softmmu/hw/virtio/vhost-vsock.o
  CC      lm32-softmmu/target/lm32/cpu.o
  CC      i386-softmmu/hw/virtio/virtio-crypto.o
  CC      arm-softmmu/hw/arm/stellaris.o
  CC      lm32-softmmu/target/lm32/gdbstub.o
  CC      aarch64-softmmu/hw/arm/tosa.o
  CC      lm32-softmmu/target/lm32/lm32-semi.o
  CC      arm-softmmu/hw/arm/tosa.o
  CC      aarch64-softmmu/hw/arm/versatilepb.o
  CC      i386-softmmu/hw/virtio/virtio-crypto-pci.o
  CC      lm32-softmmu/target/lm32/machine.o
  CC      arm-softmmu/hw/arm/versatilepb.o
  CC      aarch64-softmmu/hw/arm/vexpress.o
  CC      arm-softmmu/hw/arm/vexpress.o
  GEN     trace/generated-helpers.c
  CC      lm32-softmmu/trace/control-target.o
  CC      aarch64-softmmu/hw/arm/virt.o
  CC      i386-softmmu/hw/i386/multiboot.o
  CC      arm-softmmu/hw/arm/virt.o
  CC      lm32-softmmu/trace/generated-helpers.o
  CC      i386-softmmu/hw/i386/pc.o
  CC      aarch64-softmmu/hw/arm/xilinx_zynq.o
  LINK    lm32-softmmu/qemu-system-lm32
  CC      arm-softmmu/hw/arm/xilinx_zynq.o
  CC      aarch64-softmmu/hw/arm/z2.o
  CC      arm-softmmu/hw/arm/z2.o
  CC      i386-softmmu/hw/i386/pc_piix.o
  CC      aarch64-softmmu/hw/arm/virt-acpi-build.o
  CC      aarch64-softmmu/hw/arm/netduino2.o
  CC      i386-softmmu/hw/i386/pc_q35.o
  CC      arm-softmmu/hw/arm/virt-acpi-build.o
  CC      aarch64-softmmu/hw/arm/sysbus-fdt.o
  CC      i386-softmmu/hw/i386/pc_sysfw.o
  CC      aarch64-softmmu/hw/arm/armv7m.o
  GEN     m68k-softmmu/hmp-commands.h
  GEN     m68k-softmmu/hmp-commands-info.h
  GEN     m68k-softmmu/config-target.h
  CC      m68k-softmmu/exec.o
  CC      i386-softmmu/hw/i386/x86-iommu.o
  CC      arm-softmmu/hw/arm/netduino2.o
  CC      aarch64-softmmu/hw/arm/exynos4210.o
  CC      i386-softmmu/hw/i386/intel_iommu.o
  CC      aarch64-softmmu/hw/arm/pxa2xx.o
  CC      arm-softmmu/hw/arm/sysbus-fdt.o
  CC      arm-softmmu/hw/arm/armv7m.o
  CC      aarch64-softmmu/hw/arm/pxa2xx_gpio.o
  CC      i386-softmmu/hw/i386/amd_iommu.o
  CC      arm-softmmu/hw/arm/exynos4210.o
  CC      aarch64-softmmu/hw/arm/pxa2xx_pic.o
  CC      m68k-softmmu/tcg/tcg.o
  CC      i386-softmmu/hw/i386/kvmvapic.o
  CC      arm-softmmu/hw/arm/pxa2xx.o
  CC      aarch64-softmmu/hw/arm/digic.o
  CC      i386-softmmu/hw/i386/acpi-build.o
  CC      aarch64-softmmu/hw/arm/omap1.o
  CC      arm-softmmu/hw/arm/pxa2xx_gpio.o
  CC      aarch64-softmmu/hw/arm/omap2.o
  CC      i386-softmmu/hw/i386/pci-assign-load-rom.o
  CC      arm-softmmu/hw/arm/pxa2xx_pic.o
  CC      m68k-softmmu/tcg/tcg-op.o
  CC      i386-softmmu/target/i386/helper.o
  CC      aarch64-softmmu/hw/arm/strongarm.o
  CC      arm-softmmu/hw/arm/digic.o
  CC      arm-softmmu/hw/arm/omap1.o
  CC      i386-softmmu/target/i386/cpu.o
  CC      aarch64-softmmu/hw/arm/allwinner-a10.o
  CC      aarch64-softmmu/hw/arm/cubieboard.o
  CC      i386-softmmu/target/i386/gdbstub.o
  CC      arm-softmmu/hw/arm/omap2.o
  CC      i386-softmmu/target/i386/xsave_helper.o
  CC      aarch64-softmmu/hw/arm/bcm2835_peripherals.o
  CC      i386-softmmu/target/i386/translate.o
  CC      m68k-softmmu/tcg/optimize.o
  CC      arm-softmmu/hw/arm/strongarm.o
  CC      aarch64-softmmu/hw/arm/bcm2836.o
  CC      arm-softmmu/hw/arm/allwinner-a10.o
  CC      m68k-softmmu/tcg/tcg-common.o
  CC      arm-softmmu/hw/arm/cubieboard.o
  CC      aarch64-softmmu/hw/arm/raspi.o
  CC      arm-softmmu/hw/arm/bcm2835_peripherals.o
  CC      m68k-softmmu/tcg/tcg-runtime.o
  CC      aarch64-softmmu/hw/arm/stm32f205_soc.o
  CC      arm-softmmu/hw/arm/bcm2836.o
  CC      m68k-softmmu/fpu/softfloat.o
  CC      aarch64-softmmu/hw/arm/xlnx-zynqmp.o
  CC      arm-softmmu/hw/arm/raspi.o
  CC      aarch64-softmmu/hw/arm/xlnx-ep108.o
  CC      arm-softmmu/hw/arm/stm32f205_soc.o
  CC      aarch64-softmmu/hw/arm/fsl-imx25.o
  CC      arm-softmmu/hw/arm/fsl-imx25.o
  CC      aarch64-softmmu/hw/arm/imx25_pdk.o
  CC      arm-softmmu/hw/arm/imx25_pdk.o
  CC      aarch64-softmmu/hw/arm/fsl-imx31.o
  CC      aarch64-softmmu/hw/arm/kzm.o
  CC      arm-softmmu/hw/arm/fsl-imx31.o
  CC      m68k-softmmu/disas.o
  CC      aarch64-softmmu/hw/arm/fsl-imx6.o
  CC      arm-softmmu/hw/arm/kzm.o
  GEN     m68k-softmmu/gdbstub-xml.c
  CC      i386-softmmu/target/i386/bpt_helper.o
  CC      arm-softmmu/hw/arm/fsl-imx6.o
  CC      aarch64-softmmu/hw/arm/sabrelite.o
  CC      m68k-softmmu/hax-stub.o
  CC      i386-softmmu/target/i386/cc_helper.o
  CC      aarch64-softmmu/hw/arm/aspeed_soc.o
  CC      m68k-softmmu/arch_init.o
  CC      arm-softmmu/hw/arm/sabrelite.o
  CC      m68k-softmmu/cpus.o
  CC      aarch64-softmmu/hw/arm/aspeed.o
  CC      i386-softmmu/target/i386/excp_helper.o
  CC      arm-softmmu/hw/arm/aspeed_soc.o
  CC      i386-softmmu/target/i386/fpu_helper.o
  CC      aarch64-softmmu/hw/arm/mps2.o
  CC      m68k-softmmu/monitor.o
  CC      arm-softmmu/hw/arm/aspeed.o
  CC      aarch64-softmmu/target/arm/arm-semi.o
  CC      arm-softmmu/hw/arm/mps2.o
  CC      arm-softmmu/target/arm/arm-semi.o
  CC      aarch64-softmmu/target/arm/machine.o
  CC      arm-softmmu/target/arm/machine.o
  CC      m68k-softmmu/gdbstub.o
  CC      aarch64-softmmu/target/arm/psci.o
  CC      arm-softmmu/target/arm/psci.o
  CC      aarch64-softmmu/target/arm/arch_dump.o
  CC      m68k-softmmu/balloon.o
  CC      arm-softmmu/target/arm/arch_dump.o
  CC      aarch64-softmmu/target/arm/monitor.o
  CC      i386-softmmu/target/i386/int_helper.o
  CC      m68k-softmmu/ioport.o
  CC      aarch64-softmmu/target/arm/kvm-stub.o
  CC      arm-softmmu/target/arm/monitor.o
  CC      i386-softmmu/target/i386/mem_helper.o
  CC      aarch64-softmmu/target/arm/translate.o
  CC      arm-softmmu/target/arm/kvm-stub.o
  CC      m68k-softmmu/numa.o
  CC      arm-softmmu/target/arm/translate.o
  CC      i386-softmmu/target/i386/misc_helper.o
  CC      m68k-softmmu/qtest.o
  CC      i386-softmmu/target/i386/mpx_helper.o
  CC      m68k-softmmu/memory.o
  CC      i386-softmmu/target/i386/seg_helper.o
  CC      m68k-softmmu/memory_mapping.o
  CC      m68k-softmmu/dump.o
  CC      i386-softmmu/target/i386/smm_helper.o
  CC      m68k-softmmu/migration/ram.o
  CC      i386-softmmu/target/i386/svm_helper.o
  CC      i386-softmmu/target/i386/machine.o
  CC      m68k-softmmu/accel/accel.o
  CC      arm-softmmu/target/arm/op_helper.o
  CC      i386-softmmu/target/i386/arch_memory_mapping.o
  CC      aarch64-softmmu/target/arm/op_helper.o
  CC      i386-softmmu/target/i386/arch_dump.o
  CC      m68k-softmmu/accel/stubs/kvm-stub.o
  CC      i386-softmmu/target/i386/monitor.o
  CC      m68k-softmmu/accel/tcg/tcg-all.o
  CC      arm-softmmu/target/arm/helper.o
  CC      i386-softmmu/target/i386/kvm-stub.o
  CC      m68k-softmmu/accel/tcg/cputlb.o
  GEN     trace/generated-helpers.c
  CC      i386-softmmu/trace/control-target.o
  CC      aarch64-softmmu/target/arm/helper.o
  CC      i386-softmmu/gdbstub-xml.o
  CC      m68k-softmmu/accel/tcg/cpu-exec.o
  CC      i386-softmmu/trace/generated-helpers.o
  CC      m68k-softmmu/accel/tcg/cpu-exec-common.o
  CC      m68k-softmmu/accel/tcg/translate-all.o
  LINK    i386-softmmu/qemu-system-i386
  CC      arm-softmmu/target/arm/cpu.o
  CC      m68k-softmmu/hw/char/mcf_uart.o
  CC      aarch64-softmmu/target/arm/cpu.o
  CC      arm-softmmu/target/arm/neon_helper.o
  CC      m68k-softmmu/hw/core/generic-loader.o
  CC      aarch64-softmmu/target/arm/neon_helper.o
  CC      m68k-softmmu/hw/core/null-machine.o
  CC      m68k-softmmu/hw/misc/mmio_interface.o
  GEN     microblazeel-softmmu/hmp-commands.h
  GEN     microblazeel-softmmu/hmp-commands-info.h
  CC      m68k-softmmu/hw/net/mcf_fec.o
  GEN     microblazeel-softmmu/config-target.h
  CC      microblazeel-softmmu/exec.o
  CC      m68k-softmmu/hw/net/vhost_net.o
  CC      arm-softmmu/target/arm/iwmmxt_helper.o
  CC      aarch64-softmmu/target/arm/iwmmxt_helper.o
  CC      m68k-softmmu/hw/net/rocker/qmp-norocker.o
  CC      m68k-softmmu/hw/vfio/common.o
  CC      aarch64-softmmu/target/arm/gdbstub.o
  CC      arm-softmmu/target/arm/gdbstub.o
  CC      aarch64-softmmu/target/arm/cpu64.o
  CC      m68k-softmmu/hw/vfio/platform.o
  CC      arm-softmmu/target/arm/crypto_helper.o
  CC      aarch64-softmmu/target/arm/translate-a64.o
  CC      microblazeel-softmmu/tcg/tcg.o
  CC      arm-softmmu/target/arm/arm-powerctl.o
  CC      m68k-softmmu/hw/vfio/spapr.o
  CC      m68k-softmmu/hw/m68k/an5206.o
  GEN     trace/generated-helpers.c
  CC      m68k-softmmu/hw/m68k/mcf5208.o
  CC      arm-softmmu/trace/control-target.o
  CC      m68k-softmmu/hw/m68k/mcf5206.o
  CC      arm-softmmu/gdbstub-xml.o
  CC      m68k-softmmu/hw/m68k/mcf_intc.o
  CC      microblazeel-softmmu/tcg/tcg-op.o
  CC      arm-softmmu/trace/generated-helpers.o
  CC      m68k-softmmu/target/m68k/m68k-semi.o
  LINK    arm-softmmu/qemu-system-arm
  CC      m68k-softmmu/target/m68k/translate.o
  CC      aarch64-softmmu/target/arm/helper-a64.o
  CC      microblazeel-softmmu/tcg/optimize.o
  CC      aarch64-softmmu/target/arm/gdbstub64.o
  CC      aarch64-softmmu/target/arm/crypto_helper.o
  GEN     microblaze-softmmu/hmp-commands.h
  GEN     microblaze-softmmu/hmp-commands-info.h
  GEN     microblaze-softmmu/config-target.h
  CC      microblazeel-softmmu/tcg/tcg-common.o
  CC      microblaze-softmmu/exec.o
  CC      m68k-softmmu/target/m68k/op_helper.o
  CC      microblazeel-softmmu/tcg/tcg-runtime.o
  CC      aarch64-softmmu/target/arm/arm-powerctl.o
  CC      microblazeel-softmmu/fpu/softfloat.o
  CC      m68k-softmmu/target/m68k/helper.o
  GEN     trace/generated-helpers.c
  CC      aarch64-softmmu/trace/control-target.o
  CC      aarch64-softmmu/gdbstub-xml.o
  CC      m68k-softmmu/target/m68k/cpu.o
  CC      aarch64-softmmu/trace/generated-helpers.o
  CC      m68k-softmmu/target/m68k/fpu_helper.o
  LINK    aarch64-softmmu/qemu-system-aarch64
  CC      microblaze-softmmu/tcg/tcg.o
  CC      m68k-softmmu/target/m68k/gdbstub.o
  GEN     trace/generated-helpers.c
  CC      m68k-softmmu/trace/control-target.o
  CC      microblazeel-softmmu/disas.o
  CC      m68k-softmmu/gdbstub-xml.o
  CC      microblazeel-softmmu/hax-stub.o
  CC      m68k-softmmu/trace/generated-helpers.o
  CC      microblazeel-softmmu/arch_init.o
  LINK    m68k-softmmu/qemu-system-m68k
  CC      microblaze-softmmu/tcg/tcg-op.o
  CC      microblazeel-softmmu/cpus.o
  GEN     mips64el-softmmu/hmp-commands.h
  GEN     mips64el-softmmu/hmp-commands-info.h
  GEN     mips64el-softmmu/config-target.h
  CC      mips64el-softmmu/exec.o
  CC      microblazeel-softmmu/monitor.o
  CC      mips64el-softmmu/tcg/tcg.o
  CC      microblaze-softmmu/tcg/optimize.o
  CC      microblazeel-softmmu/gdbstub.o
  CC      microblazeel-softmmu/balloon.o
  CC      microblazeel-softmmu/ioport.o
  CC      mips64el-softmmu/tcg/tcg-op.o
  GEN     mips64-softmmu/hmp-commands.h
  CC      microblaze-softmmu/tcg/tcg-common.o
  GEN     mips64-softmmu/hmp-commands-info.h
  GEN     mips64-softmmu/config-target.h
  CC      microblaze-softmmu/tcg/tcg-runtime.o
  CC      microblazeel-softmmu/numa.o
  CC      mips64-softmmu/exec.o
  CC      microblaze-softmmu/fpu/softfloat.o
  CC      microblazeel-softmmu/qtest.o
  CC      microblazeel-softmmu/memory.o
  CC      mips64-softmmu/tcg/tcg.o
  CC      microblazeel-softmmu/memory_mapping.o
  CC      mips64el-softmmu/tcg/optimize.o
  CC      microblazeel-softmmu/dump.o
  CC      microblazeel-softmmu/migration/ram.o
  CC      microblaze-softmmu/disas.o
  CC      mips64el-softmmu/tcg/tcg-common.o
  CC      microblaze-softmmu/hax-stub.o
  CC      mips64el-softmmu/tcg/tcg-runtime.o
  CC      microblaze-softmmu/arch_init.o
  CC      mips64el-softmmu/fpu/softfloat.o
  CC      microblazeel-softmmu/accel/accel.o
  CC      microblaze-softmmu/cpus.o
  CC      mips64-softmmu/tcg/tcg-op.o
  CC      microblazeel-softmmu/accel/stubs/kvm-stub.o
  CC      microblazeel-softmmu/accel/tcg/tcg-all.o
  CC      microblazeel-softmmu/accel/tcg/cputlb.o
  CC      microblaze-softmmu/monitor.o
  CC      microblazeel-softmmu/accel/tcg/cpu-exec.o
  CC      mips64el-softmmu/disas.o
  CC      microblaze-softmmu/gdbstub.o
  CC      mips64-softmmu/tcg/optimize.o
  CC      microblazeel-softmmu/accel/tcg/cpu-exec-common.o
  CC      microblazeel-softmmu/accel/tcg/translate-all.o
  CC      mips64el-softmmu/hax-stub.o
  CC      mips64el-softmmu/arch_init.o
  CC      microblaze-softmmu/balloon.o
  CC      mips64el-softmmu/cpus.o
  CC      microblazeel-softmmu/hw/core/generic-loader.o
  CC      microblaze-softmmu/ioport.o
  CC      mips64-softmmu/tcg/tcg-common.o
  CC      microblazeel-softmmu/hw/core/null-machine.o
  CC      mips64-softmmu/tcg/tcg-runtime.o
  CC      mips64el-softmmu/monitor.o
  CC      microblaze-softmmu/numa.o
  CC      microblazeel-softmmu/hw/misc/mmio_interface.o
  CC      mips64-softmmu/fpu/softfloat.o
  CC      microblaze-softmmu/qtest.o
  CC      microblazeel-softmmu/hw/net/xilinx_ethlite.o
  CC      microblaze-softmmu/memory.o
  CC      microblazeel-softmmu/hw/net/vhost_net.o
  CC      mips64el-softmmu/gdbstub.o
  CC      microblazeel-softmmu/hw/net/rocker/qmp-norocker.o
  CC      microblazeel-softmmu/hw/vfio/common.o
  CC      mips64el-softmmu/balloon.o
  CC      microblaze-softmmu/memory_mapping.o
  CC      mips64el-softmmu/ioport.o
  CC      microblazeel-softmmu/hw/vfio/platform.o
  CC      microblaze-softmmu/dump.o
  CC      mips64-softmmu/disas.o
  CC      mips64el-softmmu/numa.o
  CC      microblazeel-softmmu/hw/vfio/spapr.o
  CC      mips64-softmmu/hax-stub.o
  CC      microblazeel-softmmu/hw/microblaze/petalogix_s3adsp1800_mmu.o
  CC      microblaze-softmmu/migration/ram.o
  CC      mips64-softmmu/arch_init.o
  CC      mips64el-softmmu/qtest.o
  CC      microblazeel-softmmu/hw/microblaze/petalogix_ml605_mmu.o
  CC      mips64-softmmu/cpus.o
  CC      microblazeel-softmmu/hw/microblaze/boot.o
  CC      mips64el-softmmu/memory.o
  CC      microblazeel-softmmu/target/microblaze/translate.o
  CC      microblaze-softmmu/accel/accel.o
  CC      mips64-softmmu/monitor.o
  CC      microblaze-softmmu/accel/stubs/kvm-stub.o
  CC      microblazeel-softmmu/target/microblaze/op_helper.o
  CC      microblaze-softmmu/accel/tcg/tcg-all.o
  CC      mips64el-softmmu/memory_mapping.o
  CC      microblaze-softmmu/accel/tcg/cputlb.o
  CC      microblazeel-softmmu/target/microblaze/helper.o
  CC      microblazeel-softmmu/target/microblaze/cpu.o
  CC      mips64-softmmu/gdbstub.o
  CC      mips64el-softmmu/dump.o
  CC      microblazeel-softmmu/target/microblaze/gdbstub.o
  CC      mips64-softmmu/balloon.o
  CC      microblazeel-softmmu/target/microblaze/mmu.o
  CC      mips64-softmmu/ioport.o
  CC      mips64el-softmmu/migration/ram.o
  CC      microblaze-softmmu/accel/tcg/cpu-exec.o
  GEN     trace/generated-helpers.c
  CC      microblazeel-softmmu/trace/control-target.o
  CC      mips64-softmmu/numa.o
  CC      microblazeel-softmmu/trace/generated-helpers.o
  CC      microblaze-softmmu/accel/tcg/cpu-exec-common.o
  LINK    microblazeel-softmmu/qemu-system-microblazeel
  CC      mips64el-softmmu/accel/accel.o
  CC      mips64-softmmu/qtest.o
  CC      microblaze-softmmu/accel/tcg/translate-all.o
  CC      mips64el-softmmu/accel/stubs/kvm-stub.o
  CC      mips64-softmmu/memory.o
  CC      mips64el-softmmu/accel/tcg/tcg-all.o
  CC      microblaze-softmmu/hw/core/generic-loader.o
  CC      mips64el-softmmu/accel/tcg/cputlb.o
  CC      microblaze-softmmu/hw/core/null-machine.o
  CC      microblaze-softmmu/hw/misc/mmio_interface.o
  CC      microblaze-softmmu/hw/net/xilinx_ethlite.o
  CC      mips64-softmmu/memory_mapping.o
  GEN     mipsel-softmmu/hmp-commands.h
  GEN     mipsel-softmmu/hmp-commands-info.h
  GEN     mipsel-softmmu/config-target.h
  CC      mipsel-softmmu/exec.o
  CC      mips64-softmmu/dump.o
  CC      microblaze-softmmu/hw/net/vhost_net.o
  CC      mips64el-softmmu/accel/tcg/cpu-exec.o
  CC      microblaze-softmmu/hw/net/rocker/qmp-norocker.o
  CC      mips64-softmmu/migration/ram.o
  CC      microblaze-softmmu/hw/vfio/common.o
  CC      mips64el-softmmu/accel/tcg/cpu-exec-common.o
  CC      microblaze-softmmu/hw/vfio/platform.o
  CC      mipsel-softmmu/tcg/tcg.o
  CC      mips64el-softmmu/accel/tcg/translate-all.o
  CC      mips64-softmmu/accel/accel.o
  CC      microblaze-softmmu/hw/vfio/spapr.o
  CC      mips64-softmmu/accel/stubs/kvm-stub.o
  CC      mips64el-softmmu/hw/9pfs/virtio-9p-device.o
  CC      mips64-softmmu/accel/tcg/tcg-all.o
  CC      microblaze-softmmu/hw/microblaze/petalogix_s3adsp1800_mmu.o
  CC      mips64-softmmu/accel/tcg/cputlb.o
  CC      mips64el-softmmu/hw/block/virtio-blk.o
  CC      microblaze-softmmu/hw/microblaze/petalogix_ml605_mmu.o
  CC      mips64el-softmmu/hw/block/dataplane/virtio-blk.o
  CC      microblaze-softmmu/hw/microblaze/boot.o
  CC      microblaze-softmmu/target/microblaze/translate.o
  CC      mipsel-softmmu/tcg/tcg-op.o
  CC      mips64el-softmmu/hw/char/virtio-serial-bus.o
  CC      mips64-softmmu/accel/tcg/cpu-exec.o
  CC      mips64el-softmmu/hw/core/generic-loader.o
  CC      microblaze-softmmu/target/microblaze/op_helper.o
  CC      mips64-softmmu/accel/tcg/cpu-exec-common.o
  CC      mips64el-softmmu/hw/core/null-machine.o
  CC      mips64-softmmu/accel/tcg/translate-all.o
  CC      mips64el-softmmu/hw/display/vga.o
  CC      microblaze-softmmu/target/microblaze/helper.o
  CC      mips64-softmmu/hw/9pfs/virtio-9p-device.o
  CC      microblaze-softmmu/target/microblaze/cpu.o
  CC      mips64-softmmu/hw/block/virtio-blk.o
  CC      mips64el-softmmu/hw/display/virtio-gpu.o
  CC      microblaze-softmmu/target/microblaze/gdbstub.o
  CC      mipsel-softmmu/tcg/optimize.o
  CC      microblaze-softmmu/target/microblaze/mmu.o
  CC      mips64-softmmu/hw/block/dataplane/virtio-blk.o
  GEN     trace/generated-helpers.c
  CC      microblaze-softmmu/trace/control-target.o
  CC      mips64el-softmmu/hw/display/virtio-gpu-3d.o
  CC      mips64-softmmu/hw/char/virtio-serial-bus.o
  CC      microblaze-softmmu/trace/generated-helpers.o
  CC      mips64el-softmmu/hw/display/virtio-gpu-pci.o
  CC      mipsel-softmmu/tcg/tcg-common.o
  CC      mips64-softmmu/hw/core/generic-loader.o
  LINK    microblaze-softmmu/qemu-system-microblaze
  CC      mips64-softmmu/hw/core/null-machine.o
  CC      mipsel-softmmu/tcg/tcg-runtime.o
  CC      mips64el-softmmu/hw/intc/mips_gic.o
  CC      mips64-softmmu/hw/display/vga.o
  CC      mipsel-softmmu/fpu/softfloat.o
  CC      mips64el-softmmu/hw/misc/ivshmem.o
  CC      mips64-softmmu/hw/display/virtio-gpu.o
  CC      mips64el-softmmu/hw/misc/mips_cmgcr.o
  CC      mips64el-softmmu/hw/misc/mips_cpc.o
  CC      mips64-softmmu/hw/display/virtio-gpu-3d.o
  GEN     mips-softmmu/hmp-commands.h
  CC      mips64el-softmmu/hw/misc/mips_itu.o
  GEN     mips-softmmu/hmp-commands-info.h
  GEN     mips-softmmu/config-target.h
  CC      mips-softmmu/exec.o
  CC      mips64el-softmmu/hw/misc/mmio_interface.o
  CC      mips64-softmmu/hw/display/virtio-gpu-pci.o
  CC      mips64el-softmmu/hw/net/virtio-net.o
  CC      mipsel-softmmu/disas.o
  CC      mips64-softmmu/hw/intc/mips_gic.o
  CC      mips64el-softmmu/hw/net/vhost_net.o
  CC      mipsel-softmmu/hax-stub.o
  CC      mips64-softmmu/hw/misc/ivshmem.o
  CC      mipsel-softmmu/arch_init.o
  CC      mips64el-softmmu/hw/scsi/virtio-scsi.o
  CC      mips-softmmu/tcg/tcg.o
  CC      mipsel-softmmu/cpus.o
  CC      mips64-softmmu/hw/misc/mips_cmgcr.o
  CC      mips64-softmmu/hw/misc/mips_cpc.o
  CC      mips64el-softmmu/hw/scsi/virtio-scsi-dataplane.o
  CC      mips64-softmmu/hw/misc/mips_itu.o
  CC      mipsel-softmmu/monitor.o
  CC      mips64el-softmmu/hw/scsi/vhost-scsi-common.o
  CC      mips64el-softmmu/hw/scsi/vhost-scsi.o
  CC      mips64-softmmu/hw/misc/mmio_interface.o
  CC      mips64el-softmmu/hw/scsi/vhost-user-scsi.o
  CC      mips64el-softmmu/hw/timer/mips_gictimer.o
  CC      mips64-softmmu/hw/net/virtio-net.o
  CC      mips64el-softmmu/hw/timer/mc146818rtc.o
  CC      mips-softmmu/tcg/tcg-op.o
  CC      mipsel-softmmu/gdbstub.o
  CC      mips64el-softmmu/hw/vfio/common.o
  CC      mips64-softmmu/hw/net/vhost_net.o
  CC      mips64el-softmmu/hw/vfio/pci.o
  CC      mips64-softmmu/hw/scsi/virtio-scsi.o
  CC      mipsel-softmmu/balloon.o
  CC      mips64-softmmu/hw/scsi/virtio-scsi-dataplane.o
  CC      mipsel-softmmu/ioport.o
  CC      mipsel-softmmu/numa.o
  CC      mips64-softmmu/hw/scsi/vhost-scsi-common.o
  CC      mips64el-softmmu/hw/vfio/pci-quirks.o
  CC      mips-softmmu/tcg/optimize.o
  CC      mipsel-softmmu/qtest.o
  CC      mips64-softmmu/hw/scsi/vhost-scsi.o
  CC      mips64el-softmmu/hw/vfio/platform.o
  CC      mipsel-softmmu/memory.o
  CC      mips64-softmmu/hw/scsi/vhost-user-scsi.o
  CC      mips64el-softmmu/hw/vfio/spapr.o
  CC      mips-softmmu/tcg/tcg-common.o
  CC      mips64-softmmu/hw/timer/mips_gictimer.o
  CC      mips-softmmu/tcg/tcg-runtime.o
  CC      mips64-softmmu/hw/timer/mc146818rtc.o
  CC      mips64el-softmmu/hw/virtio/virtio.o
  CC      mipsel-softmmu/memory_mapping.o
  CC      mips-softmmu/fpu/softfloat.o
  CC      mips64-softmmu/hw/vfio/common.o
  CC      mipsel-softmmu/dump.o
  CC      mips64el-softmmu/hw/virtio/virtio-balloon.o
  CC      mipsel-softmmu/migration/ram.o
  CC      mips64-softmmu/hw/vfio/pci.o
  CC      mips64el-softmmu/hw/virtio/vhost.o
  CC      mipsel-softmmu/accel/accel.o
  CC      mips64-softmmu/hw/vfio/pci-quirks.o
  CC      mips64el-softmmu/hw/virtio/vhost-backend.o
  CC      mipsel-softmmu/accel/stubs/kvm-stub.o
  CC      mips64el-softmmu/hw/virtio/vhost-user.o
  CC      mips-softmmu/disas.o
  CC      mipsel-softmmu/accel/tcg/tcg-all.o
  CC      mips64-softmmu/hw/vfio/platform.o
  CC      mips64el-softmmu/hw/virtio/vhost-vsock.o
  CC      mips-softmmu/hax-stub.o
  CC      mipsel-softmmu/accel/tcg/cputlb.o
  CC      mips-softmmu/arch_init.o
  CC      mips64el-softmmu/hw/virtio/virtio-crypto.o
  CC      mips64-softmmu/hw/vfio/spapr.o
  CC      mips-softmmu/cpus.o
  CC      mips64-softmmu/hw/virtio/virtio.o
  CC      mips64el-softmmu/hw/virtio/virtio-crypto-pci.o
  CC      mips-softmmu/monitor.o
  CC      mips64-softmmu/hw/virtio/virtio-balloon.o
  CC      mipsel-softmmu/accel/tcg/cpu-exec.o
  CC      mips64el-softmmu/hw/mips/mips_r4k.o
  CC      mips64el-softmmu/hw/mips/mips_malta.o
  CC      mipsel-softmmu/accel/tcg/cpu-exec-common.o
  CC      mips64-softmmu/hw/virtio/vhost.o
  CC      mipsel-softmmu/accel/tcg/translate-all.o
  CC      mips-softmmu/gdbstub.o
  CC      mips64el-softmmu/hw/mips/mips_mipssim.o
  CC      mips64-softmmu/hw/virtio/vhost-backend.o
  CC      mipsel-softmmu/hw/9pfs/virtio-9p-device.o
  CC      mips-softmmu/balloon.o
  CC      mips64-softmmu/hw/virtio/vhost-user.o
  CC      mips64el-softmmu/hw/mips/addr.o
  CC      mipsel-softmmu/hw/block/virtio-blk.o
  CC      mips-softmmu/ioport.o
  CC      mips64el-softmmu/hw/mips/cputimer.o
  CC      mips64-softmmu/hw/virtio/vhost-vsock.o
  CC      mips-softmmu/numa.o
  CC      mips64el-softmmu/hw/mips/mips_int.o
  CC      mips64-softmmu/hw/virtio/virtio-crypto.o
  CC      mipsel-softmmu/hw/block/dataplane/virtio-blk.o
  CC      mips64el-softmmu/hw/mips/mips_jazz.o
  CC      mips-softmmu/qtest.o
  CC      mipsel-softmmu/hw/char/virtio-serial-bus.o
  CC      mips64-softmmu/hw/virtio/virtio-crypto-pci.o
  CC      mips64el-softmmu/hw/mips/mips_fulong2e.o
  CC      mips-softmmu/memory.o
  CC      mips64-softmmu/hw/mips/mips_r4k.o
  CC      mips64el-softmmu/hw/mips/gt64xxx_pci.o
  CC      mipsel-softmmu/hw/core/generic-loader.o
  CC      mipsel-softmmu/hw/core/null-machine.o
  CC      mips64-softmmu/hw/mips/mips_malta.o
  CC      mips64el-softmmu/hw/mips/cps.o
  CC      mipsel-softmmu/hw/display/vga.o
  CC      mips64el-softmmu/hw/mips/boston.o
  CC      mips64-softmmu/hw/mips/mips_mipssim.o
  CC      mips64-softmmu/hw/mips/addr.o
  CC      mips-softmmu/memory_mapping.o
  CC      mips64el-softmmu/target/mips/translate.o
  CC      mips64-softmmu/hw/mips/cputimer.o
  CC      mips-softmmu/dump.o
  CC      mips64-softmmu/hw/mips/mips_int.o
  CC      mips64-softmmu/hw/mips/mips_jazz.o
  CC      mipsel-softmmu/hw/display/virtio-gpu.o
  CC      mips-softmmu/migration/ram.o
  CC      mips64-softmmu/hw/mips/gt64xxx_pci.o
  CC      mips64-softmmu/hw/mips/cps.o
  CC      mipsel-softmmu/hw/display/virtio-gpu-3d.o
  CC      mips64-softmmu/target/mips/translate.o
  CC      mips-softmmu/accel/accel.o
  CC      mipsel-softmmu/hw/display/virtio-gpu-pci.o
  CC      mips-softmmu/accel/stubs/kvm-stub.o
  CC      mipsel-softmmu/hw/intc/mips_gic.o
  CC      mips-softmmu/accel/tcg/tcg-all.o
  CC      mipsel-softmmu/hw/misc/ivshmem.o
  CC      mips-softmmu/accel/tcg/cputlb.o
  CC      mipsel-softmmu/hw/misc/mips_cmgcr.o
  CC      mipsel-softmmu/hw/misc/mips_cpc.o
  CC      mips-softmmu/accel/tcg/cpu-exec.o
  CC      mipsel-softmmu/hw/misc/mips_itu.o
  CC      mipsel-softmmu/hw/misc/mmio_interface.o
  CC      mips-softmmu/accel/tcg/cpu-exec-common.o
  CC      mipsel-softmmu/hw/net/virtio-net.o
  CC      mips-softmmu/accel/tcg/translate-all.o
  CC      mips64el-softmmu/target/mips/dsp_helper.o
  CC      mips-softmmu/hw/9pfs/virtio-9p-device.o
  CC      mipsel-softmmu/hw/net/vhost_net.o
  CC      mips-softmmu/hw/block/virtio-blk.o
  CC      mipsel-softmmu/hw/scsi/virtio-scsi.o
  CC      mips-softmmu/hw/block/dataplane/virtio-blk.o
  CC      mips64el-softmmu/target/mips/op_helper.o
  CC      mips64-softmmu/target/mips/dsp_helper.o
  CC      mipsel-softmmu/hw/scsi/virtio-scsi-dataplane.o
  CC      mips-softmmu/hw/char/virtio-serial-bus.o
  CC      mipsel-softmmu/hw/scsi/vhost-scsi-common.o
  CC      mips-softmmu/hw/core/generic-loader.o
  CC      mipsel-softmmu/hw/scsi/vhost-scsi.o
  CC      mips-softmmu/hw/core/null-machine.o
  CC      mipsel-softmmu/hw/scsi/vhost-user-scsi.o
  CC      mips-softmmu/hw/display/vga.o
  CC      mips64-softmmu/target/mips/op_helper.o
  CC      mipsel-softmmu/hw/timer/mips_gictimer.o
  CC      mipsel-softmmu/hw/timer/mc146818rtc.o
  CC      mips64el-softmmu/target/mips/lmi_helper.o
  CC      mipsel-softmmu/hw/vfio/common.o
  CC      mips-softmmu/hw/display/virtio-gpu.o
  CC      mips64el-softmmu/target/mips/helper.o
  CC      mipsel-softmmu/hw/vfio/pci.o
  CC      mips-softmmu/hw/display/virtio-gpu-3d.o
  CC      mips64el-softmmu/target/mips/cpu.o
  CC      mips64el-softmmu/target/mips/gdbstub.o
  CC      mips64-softmmu/target/mips/lmi_helper.o
  CC      mips64el-softmmu/target/mips/msa_helper.o
  CC      mips-softmmu/hw/display/virtio-gpu-pci.o
  CC      mipsel-softmmu/hw/vfio/pci-quirks.o
  CC      mips64-softmmu/target/mips/helper.o
  CC      mips64-softmmu/target/mips/cpu.o
  CC      mips-softmmu/hw/intc/mips_gic.o
  CC      mipsel-softmmu/hw/vfio/platform.o
  CC      mips64-softmmu/target/mips/gdbstub.o
  CC      mips-softmmu/hw/misc/ivshmem.o
  CC      mips64-softmmu/target/mips/msa_helper.o
  CC      mipsel-softmmu/hw/vfio/spapr.o
  CC      mips-softmmu/hw/misc/mips_cmgcr.o
  CC      mipsel-softmmu/hw/virtio/virtio.o
  CC      mips-softmmu/hw/misc/mips_cpc.o
  CC      mips-softmmu/hw/misc/mips_itu.o
  CC      mipsel-softmmu/hw/virtio/virtio-balloon.o
  CC      mips-softmmu/hw/misc/mmio_interface.o
  CC      mipsel-softmmu/hw/virtio/vhost.o
  CC      mips64el-softmmu/target/mips/mips-semi.o
  CC      mips-softmmu/hw/net/virtio-net.o
  CC      mipsel-softmmu/hw/virtio/vhost-backend.o
  CC      mips64el-softmmu/target/mips/machine.o
  CC      mips-softmmu/hw/net/vhost_net.o
  CC      mipsel-softmmu/hw/virtio/vhost-user.o
  CC      mips-softmmu/hw/scsi/virtio-scsi.o
  GEN     trace/generated-helpers.c
  CC      mips64el-softmmu/trace/control-target.o
  CC      mipsel-softmmu/hw/virtio/vhost-vsock.o
  CC      mips64el-softmmu/trace/generated-helpers.o
  CC      mips64-softmmu/target/mips/mips-semi.o
  CC      mips-softmmu/hw/scsi/virtio-scsi-dataplane.o
  CC      mipsel-softmmu/hw/virtio/virtio-crypto.o
  CC      mips64-softmmu/target/mips/machine.o
  CC      mips-softmmu/hw/scsi/vhost-scsi-common.o
  LINK    mips64el-softmmu/qemu-system-mips64el
  CC      mipsel-softmmu/hw/virtio/virtio-crypto-pci.o
  CC      mips-softmmu/hw/scsi/vhost-scsi.o
  GEN     trace/generated-helpers.c
  CC      mips64-softmmu/trace/control-target.o
  CC      mips-softmmu/hw/scsi/vhost-user-scsi.o
  CC      mipsel-softmmu/hw/mips/mips_r4k.o
  CC      mips-softmmu/hw/timer/mips_gictimer.o
  CC      mips64-softmmu/trace/generated-helpers.o
  CC      mipsel-softmmu/hw/mips/mips_malta.o
  CC      mips-softmmu/hw/timer/mc146818rtc.o
  LINK    mips64-softmmu/qemu-system-mips64
  CC      mips-softmmu/hw/vfio/common.o
  CC      mipsel-softmmu/hw/mips/mips_mipssim.o
  CC      mipsel-softmmu/hw/mips/addr.o
  CC      mips-softmmu/hw/vfio/pci.o
  CC      mipsel-softmmu/hw/mips/cputimer.o
  CC      mipsel-softmmu/hw/mips/mips_int.o
  CC      mipsel-softmmu/hw/mips/gt64xxx_pci.o
  CC      mipsel-softmmu/hw/mips/cps.o
  CC      mips-softmmu/hw/vfio/pci-quirks.o
  CC      mipsel-softmmu/target/mips/translate.o
  GEN     moxie-softmmu/hmp-commands.h
  GEN     moxie-softmmu/hmp-commands-info.h
  GEN     moxie-softmmu/config-target.h
  CC      moxie-softmmu/exec.o
  GEN     nios2-softmmu/hmp-commands.h
  GEN     nios2-softmmu/hmp-commands-info.h
  GEN     nios2-softmmu/config-target.h
  CC      mips-softmmu/hw/vfio/platform.o
  CC      nios2-softmmu/exec.o
  CC      mips-softmmu/hw/vfio/spapr.o
  CC      mips-softmmu/hw/virtio/virtio.o
  CC      moxie-softmmu/tcg/tcg.o
  CC      nios2-softmmu/tcg/tcg.o
  CC      mips-softmmu/hw/virtio/virtio-balloon.o
  CC      mips-softmmu/hw/virtio/vhost.o
  CC      moxie-softmmu/tcg/tcg-op.o
  CC      nios2-softmmu/tcg/tcg-op.o
  CC      mips-softmmu/hw/virtio/vhost-backend.o
  CC      mipsel-softmmu/target/mips/dsp_helper.o
  CC      mips-softmmu/hw/virtio/vhost-user.o
  CC      mipsel-softmmu/target/mips/op_helper.o
  CC      mips-softmmu/hw/virtio/vhost-vsock.o
  CC      nios2-softmmu/tcg/optimize.o
  CC      mips-softmmu/hw/virtio/virtio-crypto.o
  CC      moxie-softmmu/tcg/optimize.o
  CC      mips-softmmu/hw/virtio/virtio-crypto-pci.o
  CC      nios2-softmmu/tcg/tcg-common.o
  CC      moxie-softmmu/tcg/tcg-common.o
  CC      nios2-softmmu/tcg/tcg-runtime.o
  CC      mips-softmmu/hw/mips/mips_r4k.o
  CC      moxie-softmmu/tcg/tcg-runtime.o
  CC      mipsel-softmmu/target/mips/lmi_helper.o
  CC      nios2-softmmu/fpu/softfloat.o
  CC      mips-softmmu/hw/mips/mips_malta.o
  CC      moxie-softmmu/fpu/softfloat.o
  CC      mipsel-softmmu/target/mips/helper.o
  CC      mips-softmmu/hw/mips/mips_mipssim.o
  CC      mips-softmmu/hw/mips/addr.o
  CC      mipsel-softmmu/target/mips/cpu.o
  CC      mips-softmmu/hw/mips/cputimer.o
  CC      mipsel-softmmu/target/mips/gdbstub.o
  CC      mips-softmmu/hw/mips/mips_int.o
  CC      mipsel-softmmu/target/mips/msa_helper.o
  CC      mips-softmmu/hw/mips/gt64xxx_pci.o
  CC      nios2-softmmu/disas.o
  CC      mips-softmmu/hw/mips/cps.o
  CC      moxie-softmmu/disas.o
  CC      nios2-softmmu/hax-stub.o
  CC      nios2-softmmu/arch_init.o
  CC      mips-softmmu/target/mips/translate.o
  CC      moxie-softmmu/hax-stub.o
  CC      nios2-softmmu/cpus.o
  CC      moxie-softmmu/arch_init.o
  CC      nios2-softmmu/monitor.o
  CC      moxie-softmmu/cpus.o
  CC      moxie-softmmu/monitor.o
  CC      nios2-softmmu/gdbstub.o
  CC      mipsel-softmmu/target/mips/mips-semi.o
  CC      nios2-softmmu/balloon.o
  CC      mipsel-softmmu/target/mips/machine.o
  CC      nios2-softmmu/ioport.o
  GEN     trace/generated-helpers.c
  CC      moxie-softmmu/gdbstub.o
  CC      mipsel-softmmu/trace/control-target.o
  CC      nios2-softmmu/numa.o
  CC      mipsel-softmmu/trace/generated-helpers.o
  CC      nios2-softmmu/qtest.o
  CC      moxie-softmmu/balloon.o
  CC      nios2-softmmu/memory.o
  LINK    mipsel-softmmu/qemu-system-mipsel
  CC      moxie-softmmu/ioport.o
  CC      moxie-softmmu/numa.o
  CC      mips-softmmu/target/mips/dsp_helper.o
  CC      moxie-softmmu/qtest.o
  CC      nios2-softmmu/memory_mapping.o
  CC      mips-softmmu/target/mips/op_helper.o
  CC      nios2-softmmu/dump.o
  CC      moxie-softmmu/memory.o
  CC      moxie-softmmu/memory_mapping.o
  CC      nios2-softmmu/migration/ram.o
  CC      moxie-softmmu/dump.o
  CC      nios2-softmmu/accel/accel.o
  CC      moxie-softmmu/migration/ram.o
  CC      moxie-softmmu/accel/accel.o
  CC      nios2-softmmu/accel/stubs/kvm-stub.o
  CC      mips-softmmu/target/mips/lmi_helper.o
  CC      nios2-softmmu/accel/tcg/tcg-all.o
  CC      moxie-softmmu/accel/stubs/kvm-stub.o
  CC      nios2-softmmu/accel/tcg/cputlb.o
  CC      moxie-softmmu/accel/tcg/tcg-all.o
  CC      mips-softmmu/target/mips/cpu.o
  CC      mips-softmmu/target/mips/helper.o
  CC      moxie-softmmu/accel/tcg/cputlb.o
  CC      mips-softmmu/target/mips/gdbstub.o
  CC      nios2-softmmu/accel/tcg/cpu-exec.o
  CC      mips-softmmu/target/mips/msa_helper.o
  CC      nios2-softmmu/accel/tcg/cpu-exec-common.o
  CC      nios2-softmmu/accel/tcg/translate-all.o
  CC      moxie-softmmu/accel/tcg/cpu-exec.o
  GEN     or1k-softmmu/hmp-commands.h
  GEN     or1k-softmmu/hmp-commands-info.h
  CC      nios2-softmmu/hw/core/generic-loader.o
  GEN     or1k-softmmu/config-target.h
  CC      or1k-softmmu/exec.o
  CC      nios2-softmmu/hw/core/null-machine.o
  CC      moxie-softmmu/accel/tcg/cpu-exec-common.o
  CC      nios2-softmmu/hw/intc/nios2_iic.o
  CC      moxie-softmmu/accel/tcg/translate-all.o
  CC      nios2-softmmu/hw/misc/mmio_interface.o
  CC      nios2-softmmu/hw/net/vhost_net.o
  CC      moxie-softmmu/hw/core/generic-loader.o
  CC      moxie-softmmu/hw/core/null-machine.o
  CC      nios2-softmmu/hw/net/rocker/qmp-norocker.o
  CC      nios2-softmmu/hw/timer/altera_timer.o
  CC      moxie-softmmu/hw/display/vga.o
  CC      or1k-softmmu/tcg/tcg.o
  CC      nios2-softmmu/hw/vfio/common.o
  CC      mips-softmmu/target/mips/mips-semi.o
  CC      nios2-softmmu/hw/vfio/platform.o
  CC      moxie-softmmu/hw/misc/mmio_interface.o
  CC      mips-softmmu/target/mips/machine.o
  CC      moxie-softmmu/hw/net/vhost_net.o
  CC      nios2-softmmu/hw/vfio/spapr.o
  GEN     trace/generated-helpers.c
  CC      or1k-softmmu/tcg/tcg-op.o
  CC      mips-softmmu/trace/control-target.o
  CC      moxie-softmmu/hw/net/rocker/qmp-norocker.o
  CC      nios2-softmmu/hw/nios2/boot.o
  CC      moxie-softmmu/hw/timer/mc146818rtc.o
  CC      nios2-softmmu/hw/nios2/cpu_pic.o
  CC      mips-softmmu/trace/generated-helpers.o
  CC      nios2-softmmu/hw/nios2/10m50_devboard.o
  CC      moxie-softmmu/hw/vfio/common.o
  CC      nios2-softmmu/target/nios2/translate.o
  LINK    mips-softmmu/qemu-system-mips
  CC      moxie-softmmu/hw/vfio/platform.o
  CC      nios2-softmmu/target/nios2/op_helper.o
  CC      moxie-softmmu/hw/vfio/spapr.o
  CC      or1k-softmmu/tcg/optimize.o
  CC      nios2-softmmu/target/nios2/helper.o
  CC      nios2-softmmu/target/nios2/cpu.o
  CC      moxie-softmmu/hw/moxie/moxiesim.o
  CC      moxie-softmmu/target/moxie/translate.o
  CC      nios2-softmmu/target/nios2/mmu.o
  CC      nios2-softmmu/target/nios2/monitor.o
  CC      moxie-softmmu/target/moxie/helper.o
  CC      or1k-softmmu/tcg/tcg-common.o
  GEN     trace/generated-helpers.c
  CC      nios2-softmmu/trace/control-target.o
  CC      or1k-softmmu/tcg/tcg-runtime.o
  CC      moxie-softmmu/target/moxie/machine.o
  CC      nios2-softmmu/trace/generated-helpers.o
  CC      or1k-softmmu/fpu/softfloat.o
  CC      moxie-softmmu/target/moxie/cpu.o
  GEN     ppc64-softmmu/hmp-commands.h
  GEN     ppc64-softmmu/hmp-commands-info.h
  GEN     ppc64-softmmu/config-target.h
  CC      ppc64-softmmu/exec.o
  LINK    nios2-softmmu/qemu-system-nios2
  CC      moxie-softmmu/target/moxie/mmu.o
  GEN     trace/generated-helpers.c
  CC      ppc64-softmmu/tcg/tcg.o
  CC      moxie-softmmu/trace/control-target.o
  CC      moxie-softmmu/trace/generated-helpers.o
  LINK    moxie-softmmu/qemu-system-moxie
  CC      or1k-softmmu/disas.o
  CC      or1k-softmmu/hax-stub.o
  CC      or1k-softmmu/arch_init.o
  GEN     ppcemb-softmmu/hmp-commands.h
  GEN     ppcemb-softmmu/hmp-commands-info.h
  GEN     ppcemb-softmmu/config-target.h
  CC      ppcemb-softmmu/exec.o
  CC      or1k-softmmu/cpus.o
  CC      ppc64-softmmu/tcg/tcg-op.o
  CC      or1k-softmmu/monitor.o
  GEN     ppc-softmmu/hmp-commands.h
  GEN     ppc-softmmu/hmp-commands-info.h
  GEN     ppc-softmmu/config-target.h
  CC      ppc-softmmu/exec.o
  CC      ppcemb-softmmu/tcg/tcg.o
  CC      or1k-softmmu/gdbstub.o
  CC      ppc64-softmmu/tcg/optimize.o
  CC      ppc-softmmu/tcg/tcg.o
  CC      or1k-softmmu/balloon.o
  CC      or1k-softmmu/ioport.o
  CC      ppcemb-softmmu/tcg/tcg-op.o
  CC      or1k-softmmu/numa.o
  CC      ppc64-softmmu/tcg/tcg-common.o
  CC      ppc64-softmmu/tcg/tcg-runtime.o
  CC      or1k-softmmu/qtest.o
  CC      or1k-softmmu/memory.o
  CC      ppc64-softmmu/fpu/softfloat.o
  CC      ppc-softmmu/tcg/tcg-op.o
  CC      ppcemb-softmmu/tcg/optimize.o
  CC      or1k-softmmu/memory_mapping.o
  CC      or1k-softmmu/dump.o
  CC      ppcemb-softmmu/tcg/tcg-common.o
  CC      ppc64-softmmu/disas.o
  GEN     ppc64-softmmu/gdbstub-xml.c
  CC      ppcemb-softmmu/tcg/tcg-runtime.o
  CC      or1k-softmmu/migration/ram.o
  CC      ppc-softmmu/tcg/optimize.o
  CC      ppcemb-softmmu/fpu/softfloat.o
  CC      ppc64-softmmu/hax-stub.o
  CC      ppc64-softmmu/libdecnumber/decContext.o
  CC      or1k-softmmu/accel/accel.o
  CC      or1k-softmmu/accel/stubs/kvm-stub.o
  CC      ppc64-softmmu/libdecnumber/decNumber.o
  CC      ppc-softmmu/tcg/tcg-common.o
  CC      or1k-softmmu/accel/tcg/tcg-all.o
  CC      ppc-softmmu/tcg/tcg-runtime.o
  CC      or1k-softmmu/accel/tcg/cputlb.o
  CC      ppc-softmmu/fpu/softfloat.o
  CC      ppc64-softmmu/libdecnumber/dpd/decimal32.o
  CC      ppcemb-softmmu/disas.o
  CC      or1k-softmmu/accel/tcg/cpu-exec.o
  CC      ppc64-softmmu/libdecnumber/dpd/decimal64.o
  GEN     ppcemb-softmmu/gdbstub-xml.c
  CC      or1k-softmmu/accel/tcg/cpu-exec-common.o
  CC      ppc64-softmmu/libdecnumber/dpd/decimal128.o
  CC      or1k-softmmu/accel/tcg/translate-all.o
  CC      ppcemb-softmmu/hax-stub.o
  CC      ppc64-softmmu/arch_init.o
  CC      ppc64-softmmu/cpus.o
  CC      ppcemb-softmmu/libdecnumber/decContext.o
  CC      or1k-softmmu/hw/core/generic-loader.o
  CC      ppcemb-softmmu/libdecnumber/decNumber.o
  CC      or1k-softmmu/hw/core/null-machine.o
  CC      ppc64-softmmu/monitor.o
  CC      ppc-softmmu/disas.o
  CC      or1k-softmmu/hw/misc/mmio_interface.o
  GEN     ppc-softmmu/gdbstub-xml.c
  CC      or1k-softmmu/hw/net/vhost_net.o
  CC      or1k-softmmu/hw/net/rocker/qmp-norocker.o
  CC      or1k-softmmu/hw/vfio/common.o
  CC      ppcemb-softmmu/libdecnumber/dpd/decimal32.o
  CC      ppc-softmmu/hax-stub.o
  CC      or1k-softmmu/hw/vfio/platform.o
  CC      ppc-softmmu/libdecnumber/decContext.o
  CC      ppc64-softmmu/gdbstub.o
  CC      ppcemb-softmmu/libdecnumber/dpd/decimal64.o
  CC      ppc-softmmu/libdecnumber/decNumber.o
  CC      or1k-softmmu/hw/vfio/spapr.o
  CC      ppcemb-softmmu/libdecnumber/dpd/decimal128.o
  CC      ppcemb-softmmu/arch_init.o
  CC      ppc64-softmmu/balloon.o
  CC      or1k-softmmu/hw/openrisc/pic_cpu.o
  CC      or1k-softmmu/hw/openrisc/cputimer.o
  CC      ppcemb-softmmu/cpus.o
  CC      ppc64-softmmu/ioport.o
  CC      or1k-softmmu/hw/openrisc/openrisc_sim.o
  CC      or1k-softmmu/target/openrisc/machine.o
  CC      ppc64-softmmu/numa.o
  CC      ppcemb-softmmu/monitor.o
  CC      ppc-softmmu/libdecnumber/dpd/decimal32.o
  CC      or1k-softmmu/target/openrisc/cpu.o
  CC      ppc64-softmmu/qtest.o
  CC      ppc-softmmu/libdecnumber/dpd/decimal64.o
  CC      or1k-softmmu/target/openrisc/exception.o
  CC      ppc-softmmu/libdecnumber/dpd/decimal128.o
  CC      ppc64-softmmu/memory.o
  CC      ppc-softmmu/arch_init.o
  CC      or1k-softmmu/target/openrisc/interrupt.o
  CC      ppc-softmmu/cpus.o
  CC      ppcemb-softmmu/gdbstub.o
  CC      or1k-softmmu/target/openrisc/mmu.o
  CC      or1k-softmmu/target/openrisc/translate.o
  CC      ppc-softmmu/monitor.o
  CC      ppc64-softmmu/memory_mapping.o
  CC      ppcemb-softmmu/balloon.o
  CC      ppcemb-softmmu/ioport.o
  CC      ppc64-softmmu/dump.o
  CC      or1k-softmmu/target/openrisc/exception_helper.o
  CC      ppcemb-softmmu/numa.o
  CC      or1k-softmmu/target/openrisc/fpu_helper.o
  CC      ppc64-softmmu/migration/ram.o
  CC      ppc-softmmu/gdbstub.o
  CC      ppcemb-softmmu/qtest.o
  CC      or1k-softmmu/target/openrisc/interrupt_helper.o
  CC      ppc-softmmu/balloon.o
  CC      ppc64-softmmu/accel/accel.o
  CC      ppcemb-softmmu/memory.o
  CC      or1k-softmmu/target/openrisc/mmu_helper.o
  CC      ppc64-softmmu/accel/stubs/kvm-stub.o
  CC      ppc-softmmu/ioport.o
  CC      or1k-softmmu/target/openrisc/sys_helper.o
  CC      ppc64-softmmu/accel/tcg/tcg-all.o
  CC      or1k-softmmu/target/openrisc/gdbstub.o
  CC      ppc-softmmu/numa.o
  CC      ppc64-softmmu/accel/tcg/cputlb.o
  GEN     trace/generated-helpers.c
  CC      or1k-softmmu/trace/control-target.o
  CC      ppc-softmmu/qtest.o
  CC      ppcemb-softmmu/memory_mapping.o
  CC      or1k-softmmu/trace/generated-helpers.o
  CC      ppc-softmmu/memory.o
  CC      ppcemb-softmmu/dump.o
  LINK    or1k-softmmu/qemu-system-or1k
  CC      ppcemb-softmmu/migration/ram.o
  CC      ppc64-softmmu/accel/tcg/cpu-exec.o
  CC      ppc-softmmu/memory_mapping.o
  CC      ppcemb-softmmu/accel/accel.o
  CC      ppc64-softmmu/accel/tcg/cpu-exec-common.o
  CC      ppc-softmmu/dump.o
  CC      ppc-softmmu/migration/ram.o
  CC      ppcemb-softmmu/accel/stubs/kvm-stub.o
  CC      ppc64-softmmu/accel/tcg/translate-all.o
  CC      ppcemb-softmmu/accel/tcg/tcg-all.o
  CC      ppc64-softmmu/hw/9pfs/virtio-9p-device.o
  CC      ppcemb-softmmu/accel/tcg/cputlb.o
  CC      ppc64-softmmu/hw/block/virtio-blk.o
  CC      ppc-softmmu/accel/accel.o
  CC      ppc-softmmu/accel/stubs/kvm-stub.o
  GEN     s390x-softmmu/hmp-commands.h
  GEN     s390x-softmmu/hmp-commands-info.h
  CC      ppc64-softmmu/hw/block/dataplane/virtio-blk.o
  CC      ppc-softmmu/accel/tcg/tcg-all.o
  CC      s390x-softmmu/gen-features
  GEN     s390x-softmmu/config-target.h
  GEN     s390x-softmmu/gen-features.h
  CC      ppc-softmmu/accel/tcg/cputlb.o
  CC      ppc64-softmmu/hw/char/spapr_vty.o
  CC      s390x-softmmu/exec.o
  CC      ppc64-softmmu/hw/char/virtio-serial-bus.o
  CC      ppcemb-softmmu/accel/tcg/cpu-exec.o
  CC      ppc64-softmmu/hw/core/generic-loader.o
  CC      ppcemb-softmmu/accel/tcg/cpu-exec-common.o
  CC      ppc-softmmu/accel/tcg/cpu-exec.o
  CC      ppc64-softmmu/hw/core/null-machine.o
  CC      ppcemb-softmmu/accel/tcg/translate-all.o
  CC      s390x-softmmu/tcg/tcg.o
  CC      ppc-softmmu/accel/tcg/cpu-exec-common.o
  CC      ppc64-softmmu/hw/display/sm501.o
  CC      ppcemb-softmmu/hw/9pfs/virtio-9p-device.o
  CC      ppc-softmmu/accel/tcg/translate-all.o
  CC      ppc64-softmmu/hw/display/vga.o
  CC      ppcemb-softmmu/hw/block/virtio-blk.o
  CC      ppc-softmmu/hw/9pfs/virtio-9p-device.o
  CC      ppc-softmmu/hw/block/virtio-blk.o
  CC      ppcemb-softmmu/hw/block/dataplane/virtio-blk.o
  CC      s390x-softmmu/tcg/tcg-op.o
  CC      ppc-softmmu/hw/block/dataplane/virtio-blk.o
  CC      ppc64-softmmu/hw/display/virtio-gpu.o
  CC      ppcemb-softmmu/hw/char/virtio-serial-bus.o
  CC      ppc-softmmu/hw/char/virtio-serial-bus.o
  CC      ppcemb-softmmu/hw/core/generic-loader.o
  CC      ppc64-softmmu/hw/display/virtio-gpu-3d.o
  CC      ppc-softmmu/hw/core/generic-loader.o
  CC      ppcemb-softmmu/hw/core/null-machine.o
  CC      ppc-softmmu/hw/core/null-machine.o
  CC      ppcemb-softmmu/hw/display/sm501.o
  CC      ppc-softmmu/hw/display/sm501.o
  CC      ppc64-softmmu/hw/display/virtio-gpu-pci.o
  CC      ppc64-softmmu/hw/display/virtio-vga.o
  CC      s390x-softmmu/tcg/optimize.o
  CC      ppcemb-softmmu/hw/display/vga.o
  CC      ppc-softmmu/hw/display/vga.o
  CC      ppc64-softmmu/hw/intc/xics.o
  CC      s390x-softmmu/tcg/tcg-common.o
  CC      ppc64-softmmu/hw/intc/xics_spapr.o
  CC      s390x-softmmu/tcg/tcg-runtime.o
  CC      ppcemb-softmmu/hw/display/virtio-gpu.o
  CC      ppc-softmmu/hw/display/virtio-gpu.o
  CC      ppc64-softmmu/hw/intc/xics_pnv.o
  CC      s390x-softmmu/fpu/softfloat.o
  CC      ppc64-softmmu/hw/misc/ivshmem.o
  CC      ppcemb-softmmu/hw/display/virtio-gpu-3d.o
  CC      ppc64-softmmu/hw/misc/mmio_interface.o
  CC      ppc-softmmu/hw/display/virtio-gpu-3d.o
  CC      ppc64-softmmu/hw/net/spapr_llan.o
  CC      ppcemb-softmmu/hw/display/virtio-gpu-pci.o
  CC      ppc-softmmu/hw/display/virtio-gpu-pci.o
  CC      ppc64-softmmu/hw/net/xilinx_ethlite.o
  CC      ppcemb-softmmu/hw/misc/ivshmem.o
  CC      ppc64-softmmu/hw/net/virtio-net.o
  CC      ppc-softmmu/hw/misc/ivshmem.o
  CC      s390x-softmmu/disas.o
  CC      ppcemb-softmmu/hw/misc/mmio_interface.o
  CC      ppc-softmmu/hw/misc/mmio_interface.o
  GEN     s390x-softmmu/gdbstub-xml.c
  CC      ppcemb-softmmu/hw/net/xilinx_ethlite.o
  CC      ppc-softmmu/hw/net/xilinx_ethlite.o
  CC      ppcemb-softmmu/hw/net/virtio-net.o
  CC      ppc64-softmmu/hw/net/vhost_net.o
  CC      s390x-softmmu/hax-stub.o
  CC      ppc-softmmu/hw/net/virtio-net.o
  CC      ppc64-softmmu/hw/net/fsl_etsec/etsec.o
  CC      s390x-softmmu/arch_init.o
  CC      ppc64-softmmu/hw/net/fsl_etsec/registers.o
  CC      ppcemb-softmmu/hw/net/vhost_net.o
  CC      s390x-softmmu/cpus.o
  CC      ppcemb-softmmu/hw/scsi/virtio-scsi.o
  CC      ppc64-softmmu/hw/net/fsl_etsec/rings.o
  CC      ppc-softmmu/hw/net/vhost_net.o
  CC      ppc64-softmmu/hw/net/fsl_etsec/miim.o
  CC      s390x-softmmu/monitor.o
  CC      ppcemb-softmmu/hw/scsi/virtio-scsi-dataplane.o
  CC      ppc-softmmu/hw/net/fsl_etsec/etsec.o
  CC      ppc64-softmmu/hw/nvram/spapr_nvram.o
  CC      ppcemb-softmmu/hw/scsi/vhost-scsi-common.o
  CC      ppc-softmmu/hw/net/fsl_etsec/registers.o
  CC      ppc64-softmmu/hw/scsi/spapr_vscsi.o
  CC      ppc-softmmu/hw/net/fsl_etsec/rings.o
  CC      ppcemb-softmmu/hw/scsi/vhost-scsi.o
  CC      ppcemb-softmmu/hw/scsi/vhost-user-scsi.o
  CC      ppc-softmmu/hw/net/fsl_etsec/miim.o
  CC      ppc64-softmmu/hw/scsi/virtio-scsi.o
  CC      ppcemb-softmmu/hw/vfio/common.o
  CC      s390x-softmmu/gdbstub.o
  CC      ppc-softmmu/hw/scsi/virtio-scsi.o
  CC      ppc64-softmmu/hw/scsi/virtio-scsi-dataplane.o
  CC      ppcemb-softmmu/hw/vfio/pci.o
  CC      ppc64-softmmu/hw/scsi/vhost-scsi-common.o
  CC      s390x-softmmu/balloon.o
  CC      ppc-softmmu/hw/scsi/virtio-scsi-dataplane.o
  CC      ppc64-softmmu/hw/scsi/vhost-scsi.o
  CC      s390x-softmmu/ioport.o
  CC      ppc-softmmu/hw/scsi/vhost-scsi-common.o
  CC      ppc64-softmmu/hw/scsi/vhost-user-scsi.o
  CC      ppc-softmmu/hw/scsi/vhost-scsi.o
  CC      ppcemb-softmmu/hw/vfio/pci-quirks.o
  CC      s390x-softmmu/numa.o
  CC      ppc-softmmu/hw/scsi/vhost-user-scsi.o
  CC      ppc64-softmmu/hw/timer/mc146818rtc.o
  CC      s390x-softmmu/qtest.o
  CC      ppc-softmmu/hw/timer/mc146818rtc.o
  CC      ppcemb-softmmu/hw/vfio/platform.o
  CC      ppc64-softmmu/hw/vfio/common.o
  CC      s390x-softmmu/memory.o
  CC      ppcemb-softmmu/hw/vfio/spapr.o
  CC      ppc-softmmu/hw/vfio/common.o
  CC      ppc64-softmmu/hw/vfio/pci.o
  CC      ppcemb-softmmu/hw/virtio/virtio.o
  CC      ppc-softmmu/hw/vfio/pci.o
  CC      ppc64-softmmu/hw/vfio/pci-quirks.o
  CC      s390x-softmmu/memory_mapping.o
  CC      s390x-softmmu/dump.o
  CC      ppc64-softmmu/hw/vfio/platform.o
  CC      ppcemb-softmmu/hw/virtio/virtio-balloon.o
  CC      ppc64-softmmu/hw/vfio/spapr.o
  CC      ppc-softmmu/hw/vfio/pci-quirks.o
  CC      ppcemb-softmmu/hw/virtio/vhost.o
  CC      s390x-softmmu/migration/ram.o
  CC      ppc64-softmmu/hw/virtio/virtio.o
  CC      ppc-softmmu/hw/vfio/platform.o
  CC      ppcemb-softmmu/hw/virtio/vhost-backend.o
  CC      ppcemb-softmmu/hw/virtio/vhost-user.o
  CC      ppc64-softmmu/hw/virtio/virtio-balloon.o
  CC      ppc-softmmu/hw/vfio/spapr.o
  CC      s390x-softmmu/accel/accel.o
  CC      ppc-softmmu/hw/virtio/virtio.o
  CC      ppcemb-softmmu/hw/virtio/vhost-vsock.o
  CC      s390x-softmmu/accel/kvm/kvm-all.o
  CC      ppc64-softmmu/hw/virtio/vhost.o
  CC      ppcemb-softmmu/hw/virtio/virtio-crypto.o
  CC      ppc64-softmmu/hw/virtio/vhost-backend.o
  CC      ppc-softmmu/hw/virtio/virtio-balloon.o
  CC      ppcemb-softmmu/hw/virtio/virtio-crypto-pci.o
  CC      s390x-softmmu/accel/tcg/tcg-all.o
  CC      ppc64-softmmu/hw/virtio/vhost-user.o
  CC      ppc-softmmu/hw/virtio/vhost.o
  CC      ppcemb-softmmu/hw/ppc/ppc.o
  CC      s390x-softmmu/accel/tcg/cputlb.o
  CC      ppc64-softmmu/hw/virtio/vhost-vsock.o
  CC      ppc64-softmmu/hw/virtio/virtio-crypto.o
  CC      ppc-softmmu/hw/virtio/vhost-backend.o
  CC      ppcemb-softmmu/hw/ppc/ppc_booke.o
  CC      ppc-softmmu/hw/virtio/vhost-user.o
  CC      ppc64-softmmu/hw/virtio/virtio-crypto-pci.o
  CC      ppcemb-softmmu/hw/ppc/fdt.o
  CC      ppc-softmmu/hw/virtio/vhost-vsock.o
  CC      ppcemb-softmmu/hw/ppc/ppc405_boards.o
  CC      s390x-softmmu/accel/tcg/cpu-exec.o
  CC      ppc64-softmmu/hw/ppc/ppc.o
  CC      ppc-softmmu/hw/virtio/virtio-crypto.o
  CC      s390x-softmmu/accel/tcg/cpu-exec-common.o
  CC      ppcemb-softmmu/hw/ppc/ppc4xx_devs.o
  CC      s390x-softmmu/accel/tcg/translate-all.o
  CC      ppc64-softmmu/hw/ppc/ppc_booke.o
  CC      ppcemb-softmmu/hw/ppc/ppc405_uc.o
  CC      ppc-softmmu/hw/virtio/virtio-crypto-pci.o
  CC      ppc64-softmmu/hw/ppc/fdt.o
  CC      ppc-softmmu/hw/ppc/ppc.o
  CC      s390x-softmmu/hw/9pfs/virtio-9p-device.o
  CC      ppcemb-softmmu/hw/ppc/ppc440_bamboo.o
  CC      ppc64-softmmu/hw/ppc/spapr.o
  CC      s390x-softmmu/hw/block/virtio-blk.o
  CC      ppcemb-softmmu/hw/ppc/ppc4xx_pci.o
  CC      ppc-softmmu/hw/ppc/ppc_booke.o
  CC      ppcemb-softmmu/hw/ppc/virtex_ml507.o
  CC      ppc-softmmu/hw/ppc/fdt.o
  CC      s390x-softmmu/hw/block/dataplane/virtio-blk.o
  CC      ppcemb-softmmu/target/ppc/cpu-models.o
  CC      ppc-softmmu/hw/ppc/ppc405_boards.o
  CC      ppc64-softmmu/hw/ppc/spapr_vio.o
  CC      s390x-softmmu/hw/char/virtio-serial-bus.o
  CC      ppc-softmmu/hw/ppc/ppc4xx_devs.o
  CC      ppc64-softmmu/hw/ppc/spapr_events.o
  CC      s390x-softmmu/hw/char/terminal3270.o
  CC      ppc-softmmu/hw/ppc/ppc405_uc.o
  CC      ppc64-softmmu/hw/ppc/spapr_hcall.o
  CC      s390x-softmmu/hw/core/generic-loader.o
  CC      ppcemb-softmmu/target/ppc/cpu.o
  CC      s390x-softmmu/hw/core/null-machine.o
  CC      ppc-softmmu/hw/ppc/ppc440_bamboo.o
  CC      ppc64-softmmu/hw/ppc/spapr_iommu.o
  CC      s390x-softmmu/hw/display/virtio-gpu.o
  CC      ppcemb-softmmu/target/ppc/translate.o
  CC      ppc-softmmu/hw/ppc/ppc4xx_pci.o
  CC      ppc-softmmu/hw/ppc/prep.o
  CC      ppc64-softmmu/hw/ppc/spapr_rtas.o
  CC      ppc64-softmmu/hw/ppc/spapr_pci.o
  CC      s390x-softmmu/hw/display/virtio-gpu-3d.o
  CC      ppc-softmmu/hw/ppc/prep_systemio.o
  CC      ppc-softmmu/hw/ppc/rs6000_mc.o
  CC      s390x-softmmu/hw/display/virtio-gpu-pci.o
  CC      ppc64-softmmu/hw/ppc/spapr_rtc.o
  CC      ppc-softmmu/hw/ppc/mac_oldworld.o
  CC      ppc64-softmmu/hw/ppc/spapr_drc.o
  CC      s390x-softmmu/hw/intc/s390_flic.o
  CC      ppc-softmmu/hw/ppc/mac_newworld.o
  CC      ppc64-softmmu/hw/ppc/spapr_rng.o
  CC      s390x-softmmu/hw/intc/s390_flic_kvm.o
  CC      ppc64-softmmu/hw/ppc/spapr_cpu_core.o
  CC      ppc-softmmu/hw/ppc/e500.o
  CC      s390x-softmmu/hw/misc/mmio_interface.o
  CC      ppc-softmmu/hw/ppc/mpc8544ds.o
  CC      ppc64-softmmu/hw/ppc/spapr_ovec.o
  CC      ppc-softmmu/hw/ppc/e500plat.o
  CC      s390x-softmmu/hw/net/virtio-net.o
  CC      ppc64-softmmu/hw/ppc/pnv.o
  CC      ppc-softmmu/hw/ppc/mpc8544_guts.o
  CC      ppc-softmmu/hw/ppc/ppce500_spin.o
  CC      s390x-softmmu/hw/net/vhost_net.o
  CC      ppc64-softmmu/hw/ppc/pnv_xscom.o
  CC      ppc-softmmu/hw/ppc/virtex_ml507.o
  CC      s390x-softmmu/hw/net/rocker/qmp-norocker.o
  CC      ppc64-softmmu/hw/ppc/pnv_core.o
  CC      ppc-softmmu/target/ppc/cpu-models.o
  CC      s390x-softmmu/hw/scsi/virtio-scsi.o
  CC      ppc64-softmmu/hw/ppc/pnv_lpc.o
  CC      s390x-softmmu/hw/scsi/virtio-scsi-dataplane.o
  CC      ppc64-softmmu/hw/ppc/pnv_psi.o
  CC      s390x-softmmu/hw/scsi/vhost-scsi-common.o
  CC      ppc64-softmmu/hw/ppc/pnv_occ.o
  CC      ppc-softmmu/target/ppc/cpu.o
  CC      ppc64-softmmu/hw/ppc/pnv_bmc.o
  CC      s390x-softmmu/hw/scsi/vhost-scsi.o
  CC      ppc-softmmu/target/ppc/translate.o
  CC      s390x-softmmu/hw/scsi/vhost-user-scsi.o
  CC      ppc64-softmmu/hw/ppc/spapr_pci_vfio.o
  CC      s390x-softmmu/hw/vfio/common.o
  CC      ppc64-softmmu/hw/ppc/spapr_rtas_ddw.o
  CC      s390x-softmmu/hw/vfio/pci.o
  CC      ppc64-softmmu/hw/ppc/ppc405_boards.o
  CC      ppc64-softmmu/hw/ppc/ppc4xx_devs.o
  CC      ppc64-softmmu/hw/ppc/ppc405_uc.o
  CC      s390x-softmmu/hw/vfio/pci-quirks.o
  CC      ppc64-softmmu/hw/ppc/ppc440_bamboo.o
  CC      s390x-softmmu/hw/vfio/ccw.o
  CC      s390x-softmmu/hw/vfio/platform.o
  CC      ppc64-softmmu/hw/ppc/ppc4xx_pci.o
  CC      s390x-softmmu/hw/vfio/spapr.o
  CC      ppc64-softmmu/hw/ppc/prep.o
  CC      ppcemb-softmmu/target/ppc/machine.o
  CC      s390x-softmmu/hw/virtio/virtio.o
  CC      ppcemb-softmmu/target/ppc/mmu_helper.o
  CC      ppc64-softmmu/hw/ppc/prep_systemio.o
  CC      ppc64-softmmu/hw/ppc/rs6000_mc.o
  CC      s390x-softmmu/hw/virtio/virtio-balloon.o
  CC      ppc64-softmmu/hw/ppc/mac_oldworld.o
  CC      ppcemb-softmmu/target/ppc/mmu-hash32.o
  CC      s390x-softmmu/hw/virtio/vhost.o
  CC      ppc64-softmmu/hw/ppc/mac_newworld.o
  CC      ppcemb-softmmu/target/ppc/monitor.o
  CC      ppcemb-softmmu/target/ppc/arch_dump.o
  CC      s390x-softmmu/hw/virtio/vhost-backend.o
  CC      ppcemb-softmmu/target/ppc/kvm-stub.o
  CC      ppc64-softmmu/hw/ppc/e500.o
  CC      ppcemb-softmmu/target/ppc/dfp_helper.o
  CC      s390x-softmmu/hw/virtio/vhost-user.o
  CC      ppc64-softmmu/hw/ppc/mpc8544ds.o
  CC      ppcemb-softmmu/target/ppc/excp_helper.o
  CC      ppc64-softmmu/hw/ppc/e500plat.o
  CC      s390x-softmmu/hw/virtio/vhost-vsock.o
  CC      ppc64-softmmu/hw/ppc/mpc8544_guts.o
  CC      s390x-softmmu/hw/virtio/virtio-crypto.o
  CC      ppc64-softmmu/hw/ppc/ppce500_spin.o
  CC      ppcemb-softmmu/target/ppc/fpu_helper.o
  CC      ppc64-softmmu/hw/ppc/virtex_ml507.o
  CC      s390x-softmmu/hw/virtio/virtio-crypto-pci.o
  CC      ppc64-softmmu/target/ppc/cpu-models.o
  CC      s390x-softmmu/hw/s390x/s390-virtio.o
  CC      s390x-softmmu/hw/s390x/s390-virtio-hcall.o
  CC      ppc64-softmmu/target/ppc/cpu.o
  CC      s390x-softmmu/hw/s390x/sclp.o
  CC      ppc64-softmmu/target/ppc/translate.o
  CC      s390x-softmmu/hw/s390x/event-facility.o
  CC      ppc-softmmu/target/ppc/machine.o
  CC      ppc-softmmu/target/ppc/mmu_helper.o
  CC      s390x-softmmu/hw/s390x/sclpquiesce.o
In file included from /var/tmp/patchew-tester-tmp-i5lmtq3u/src/target/ppc/translate.c:6984:0:
/var/tmp/patchew-tester-tmp-i5lmtq3u/src/target/ppc/translate_init.c: In function ‘getset_compat_deprecated’:
/var/tmp/patchew-tester-tmp-i5lmtq3u/src/target/ppc/translate_init.c:8435:5: error: too few arguments to function ‘visit_type_null’
     visit_type_null(v, name, NULL);
     ^~~~~~~~~~~~~~~
In file included from /var/tmp/patchew-tester-tmp-i5lmtq3u/src/target/ppc/translate_init.c:32:0,
                 from /var/tmp/patchew-tester-tmp-i5lmtq3u/src/target/ppc/translate.c:6984:
/var/tmp/patchew-tester-tmp-i5lmtq3u/src/include/qapi/visitor.h:624:6: note: declared here
 void visit_type_null(Visitor *v, const char *name, QNull **obj,
      ^~~~~~~~~~~~~~~
/var/tmp/patchew-tester-tmp-i5lmtq3u/src/rules.mak:66: recipe for target 'target/ppc/translate.o' failed
make[1]: *** [target/ppc/translate.o] Error 1
Makefile:328: recipe for target 'subdir-ppc64-softmmu' failed
make: *** [subdir-ppc64-softmmu] Error 2
make: *** Waiting for unfinished jobs....
  CC      ppc-softmmu/target/ppc/mmu-hash32.o
  CC      s390x-softmmu/hw/s390x/sclpcpu.o
  CC      s390x-softmmu/hw/s390x/ipl.o
  CC      ppc-softmmu/target/ppc/monitor.o
  CC      ppcemb-softmmu/target/ppc/int_helper.o
  CC      ppc-softmmu/target/ppc/arch_dump.o
  CC      ppc-softmmu/target/ppc/kvm-stub.o
  CC      s390x-softmmu/hw/s390x/css.o
  CC      s390x-softmmu/hw/s390x/s390-virtio-ccw.o
  CC      ppc-softmmu/target/ppc/dfp_helper.o
  CC      ppc-softmmu/target/ppc/excp_helper.o
  CC      s390x-softmmu/hw/s390x/3270-ccw.o
  CC      ppcemb-softmmu/target/ppc/timebase_helper.o
  CC      s390x-softmmu/hw/s390x/virtio-ccw.o
  CC      ppc-softmmu/target/ppc/fpu_helper.o
  CC      s390x-softmmu/hw/s390x/css-bridge.o
  CC      ppcemb-softmmu/target/ppc/misc_helper.o
  CC      ppcemb-softmmu/target/ppc/mem_helper.o
  CC      ppc-softmmu/target/ppc/int_helper.o
  CC      s390x-softmmu/hw/s390x/ccw-device.o
  CC      ppcemb-softmmu/target/ppc/gdbstub.o
  CC      s390x-softmmu/hw/s390x/s390-pci-bus.o
  GEN     trace/generated-helpers.c
  CC      ppcemb-softmmu/trace/control-target.o
  CC      s390x-softmmu/hw/s390x/s390-pci-inst.o
  CC      ppcemb-softmmu/gdbstub-xml.o
  CC      s390x-softmmu/hw/s390x/s390-skeys.o
  CC      ppc-softmmu/target/ppc/timebase_helper.o
  CC      ppcemb-softmmu/trace/generated-helpers.o
  CC      s390x-softmmu/hw/s390x/s390-stattrib.o
  CC      s390x-softmmu/hw/s390x/s390-skeys-kvm.o
  CC      ppc-softmmu/target/ppc/misc_helper.o
  LINK    ppcemb-softmmu/qemu-system-ppcemb
  CC      s390x-softmmu/hw/s390x/s390-stattrib-kvm.o
  CC      s390x-softmmu/hw/s390x/s390-ccw.o
  CC      ppc-softmmu/target/ppc/mem_helper.o
  CC      s390x-softmmu/target/s390x/translate.o
  CC      s390x-softmmu/target/s390x/helper.o
  CC      ppc-softmmu/target/ppc/gdbstub.o
  GEN     trace/generated-helpers.c
  CC      ppc-softmmu/trace/control-target.o
  CC      s390x-softmmu/target/s390x/cpu.o
  CC      s390x-softmmu/target/s390x/interrupt.o
  CC      ppc-softmmu/gdbstub-xml.o
  CC      s390x-softmmu/target/s390x/int_helper.o
  CC      ppc-softmmu/trace/generated-helpers.o
  CC      s390x-softmmu/target/s390x/fpu_helper.o
  CC      s390x-softmmu/target/s390x/cc_helper.o
  CC      s390x-softmmu/target/s390x/mem_helper.o
  LINK    ppc-softmmu/qemu-system-ppc
  CC      s390x-softmmu/target/s390x/misc_helper.o
  CC      s390x-softmmu/target/s390x/gdbstub.o
  CC      s390x-softmmu/target/s390x/cpu_models.o
  CC      s390x-softmmu/target/s390x/cpu_features.o
  CC      s390x-softmmu/target/s390x/machine.o
  CC      s390x-softmmu/target/s390x/ioinst.o
  CC      s390x-softmmu/target/s390x/arch_dump.o
  CC      s390x-softmmu/target/s390x/mmu_helper.o
  CC      s390x-softmmu/target/s390x/kvm.o
  GEN     trace/generated-helpers.c
  CC      s390x-softmmu/trace/control-target.o
  CC      s390x-softmmu/gdbstub-xml.o
  CC      s390x-softmmu/trace/generated-helpers.o
  LINK    s390x-softmmu/qemu-system-s390x
=== OUTPUT END ===

Test command exited with code: 2


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org

^ permalink raw reply	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 01/10] qapi: Separate type QNull from QObject
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 01/10] qapi: Separate type QNull from QObject Markus Armbruster
@ 2017-07-18 14:24   ` Eric Blake
  2017-07-18 15:44   ` Daniel P. Berrange
  1 sibling, 0 replies; 54+ messages in thread
From: Eric Blake @ 2017-07-18 14:24 UTC (permalink / raw)
  To: Markus Armbruster, qemu-devel
  Cc: berrange, kwolf, mreitz, qemu-block, quintela, dgilbert

[-- Attachment #1: Type: text/plain, Size: 677 bytes --]

On 07/18/2017 08:41 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  include/qapi/qmp/qobject.h    | 10 +++++++---
>  qapi/qobject-output-visitor.c |  2 +-
>  qobject/json-parser.c         |  2 +-
>  qobject/qnull.c               |  8 +++++---
>  target/i386/cpu.c             |  4 ++--
>  tests/check-qjson.c           |  6 +++---
>  tests/check-qnull.c           | 18 +++++++++---------
>  7 files changed, 28 insertions(+), 22 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]

^ permalink raw reply	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 02/10] qapi: Use QNull for a more regular visit_type_null()
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 02/10] qapi: Use QNull for a more regular visit_type_null() Markus Armbruster
@ 2017-07-18 14:36   ` Eric Blake
  2017-07-18 15:05     ` Markus Armbruster
  2017-07-18 15:46   ` Daniel P. Berrange
  1 sibling, 1 reply; 54+ messages in thread
From: Eric Blake @ 2017-07-18 14:36 UTC (permalink / raw)
  To: Markus Armbruster, qemu-devel
  Cc: berrange, kwolf, mreitz, qemu-block, quintela, dgilbert

[-- Attachment #1: Type: text/plain, Size: 1187 bytes --]

On 07/18/2017 08:41 AM, Markus Armbruster wrote:
> Make visit_type_null() take an @obj argument like its buddies.  This
> helps keeing the next commit simple.

s/keeing/keep/

> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---

> +++ b/qapi/qobject-output-visitor.c
> @@ -187,7 +187,8 @@ static void qobject_output_type_any(Visitor *v, const char *name,
>      qobject_output_add_obj(qov, name, *obj);
>  }
>  
> -static void qobject_output_type_null(Visitor *v, const char *name, Error **errp)
> +static void qobject_output_type_null(Visitor *v, const char *name,
> +                                     QNull **obj, Error **errp)
>  {
>      QObjectOutputVisitor *qov = to_qov(v);
>      qobject_output_add(qov, name, qnull());

would it be any better to call qobject_output_add(qov, name,
QINCREF(*obj)) here, to ensure we are indeed passing in an appropriate
QNull reference?  But your patch is at least self-consistent in stating
we ignore obj in output visitors.

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]

^ permalink raw reply	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 03/10] qapi: Introduce a first class 'null' type
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 03/10] qapi: Introduce a first class 'null' type Markus Armbruster
@ 2017-07-18 14:53   ` Eric Blake
  2017-07-18 14:54     ` Eric Blake
  2017-07-18 15:20     ` Markus Armbruster
  2017-07-18 15:47   ` Daniel P. Berrange
  1 sibling, 2 replies; 54+ messages in thread
From: Eric Blake @ 2017-07-18 14:53 UTC (permalink / raw)
  To: Markus Armbruster, qemu-devel
  Cc: berrange, kwolf, mreitz, qemu-block, quintela, dgilbert

[-- Attachment #1: Type: text/plain, Size: 1140 bytes --]

On 07/18/2017 08:41 AM, Markus Armbruster wrote:
> I expect the 'null' type to be useful mostly for members of alternate
> types.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---

> +++ b/include/qapi/qmp/qobject.h
> @@ -93,9 +93,9 @@ static inline QType qobject_type(const QObject *obj)
>      return obj->type;
>  }
>  
> -typedef struct QNull {
> +struct QNull {

This line was just added...

>      QObject base;
> -} QNull;
> +};
>  
>  extern QNull qnull_;
>  
> diff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h
> index 2706aab..ba69bd8 100644
> --- a/include/qemu/typedefs.h
> +++ b/include/qemu/typedefs.h
> @@ -87,6 +87,7 @@ typedef struct QEMUSGList QEMUSGList;
>  typedef struct QEMUTimer QEMUTimer;
>  typedef struct QEMUTimerListGroup QEMUTimerListGroup;
>  typedef struct QObject QObject;
> +typedef struct QNull QNull;

...is it worth hoisting this typedef into 2/10 for less churn?

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]

^ permalink raw reply	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 03/10] qapi: Introduce a first class 'null' type
  2017-07-18 14:53   ` Eric Blake
@ 2017-07-18 14:54     ` Eric Blake
  2017-07-18 15:21       ` Markus Armbruster
  2017-07-18 15:20     ` Markus Armbruster
  1 sibling, 1 reply; 54+ messages in thread
From: Eric Blake @ 2017-07-18 14:54 UTC (permalink / raw)
  To: Markus Armbruster, qemu-devel
  Cc: berrange, kwolf, mreitz, qemu-block, quintela, dgilbert

[-- Attachment #1: Type: text/plain, Size: 516 bytes --]

On 07/18/2017 09:53 AM, Eric Blake wrote:
> On 07/18/2017 08:41 AM, Markus Armbruster wrote:
>> I expect the 'null' type to be useful mostly for members of alternate
>> types.
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
> 

> Reviewed-by: Eric Blake <eblake@redhat.com>

Actually, do we need to update any qapi docs to mention the new builtin
type?

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]

^ permalink raw reply	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 02/10] qapi: Use QNull for a more regular visit_type_null()
  2017-07-18 14:36   ` Eric Blake
@ 2017-07-18 15:05     ` Markus Armbruster
  0 siblings, 0 replies; 54+ messages in thread
From: Markus Armbruster @ 2017-07-18 15:05 UTC (permalink / raw)
  To: Eric Blake; +Cc: qemu-devel, kwolf, qemu-block, quintela, dgilbert, mreitz

Eric Blake <eblake@redhat.com> writes:

> On 07/18/2017 08:41 AM, Markus Armbruster wrote:
>> Make visit_type_null() take an @obj argument like its buddies.  This
>> helps keeing the next commit simple.
>
> s/keeing/keep/

Will fix.

>> 
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>
>> +++ b/qapi/qobject-output-visitor.c
>> @@ -187,7 +187,8 @@ static void qobject_output_type_any(Visitor *v, const char *name,
>>      qobject_output_add_obj(qov, name, *obj);
>>  }
>>  
>> -static void qobject_output_type_null(Visitor *v, const char *name, Error **errp)
>> +static void qobject_output_type_null(Visitor *v, const char *name,
>> +                                     QNull **obj, Error **errp)
>>  {
>>      QObjectOutputVisitor *qov = to_qov(v);
>>      qobject_output_add(qov, name, qnull());
>
> would it be any better to call qobject_output_add(qov, name,
> QINCREF(*obj)) here, to ensure we are indeed passing in an appropriate
> QNull reference?  But your patch is at least self-consistent in stating
> we ignore obj in output visitors.

A QAPI schema type is connected to a C type (QAPI-generated except for a
few built-in types) and a QObject type.

For QAPI schema type 'null', the QObject type is QNull.

The C type is also QNull, but this is arbitrary.  We could just as well
generate a C struct type for the purpose.  All we need is some non-null
pointer value.  I'm lazy, so I grabbed one we already have: qnull_.

qnull_ is kind of nice because "allocation" / "deallocation" merely
increment / decrement its reference count.

A separate struct could be made less efficient (allocate / deallocate an
instance of the struct) or more efficient (make it a singleton without a
reference count).

To actually answer your question: I didn't feel like coupling the value
qobject_output_type_null() creates to the value it receives, even though
both are actually _qnull.

Precedence for coupling: qobject_output_type_any().  But that one's
different, because the choice of QObject as C type for 'any' is
essential instead of arbitrary.

Does this make some sense?

> Reviewed-by: Eric Blake <eblake@redhat.com>

Thanks!

^ permalink raw reply	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 04/10] tests/test-qobject-input-visitor: Drop redundant test
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 04/10] tests/test-qobject-input-visitor: Drop redundant test Markus Armbruster
@ 2017-07-18 15:13   ` Eric Blake
  2017-07-18 15:47   ` Daniel P. Berrange
  1 sibling, 0 replies; 54+ messages in thread
From: Eric Blake @ 2017-07-18 15:13 UTC (permalink / raw)
  To: Markus Armbruster, qemu-devel
  Cc: berrange, kwolf, mreitz, qemu-block, quintela, dgilbert

[-- Attachment #1: Type: text/plain, Size: 563 bytes --]

On 07/18/2017 08:41 AM, Markus Armbruster wrote:
> test_visitor_in_alternate() tests UserDefAlternate with inadmissible
> input.  test_visitor_in_fail_alternate() does basically the same.
> Drop the former, keep the latter.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  tests/test-qobject-input-visitor.c | 6 ------
>  1 file changed, 6 deletions(-)
> 

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]

^ permalink raw reply	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 03/10] qapi: Introduce a first class 'null' type
  2017-07-18 14:53   ` Eric Blake
  2017-07-18 14:54     ` Eric Blake
@ 2017-07-18 15:20     ` Markus Armbruster
  1 sibling, 0 replies; 54+ messages in thread
From: Markus Armbruster @ 2017-07-18 15:20 UTC (permalink / raw)
  To: Eric Blake; +Cc: qemu-devel, kwolf, qemu-block, quintela, dgilbert, mreitz

Eric Blake <eblake@redhat.com> writes:

> On 07/18/2017 08:41 AM, Markus Armbruster wrote:
>> I expect the 'null' type to be useful mostly for members of alternate
>> types.
>> 
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>
>> +++ b/include/qapi/qmp/qobject.h
>> @@ -93,9 +93,9 @@ static inline QType qobject_type(const QObject *obj)
>>      return obj->type;
>>  }
>>  
>> -typedef struct QNull {
>> +struct QNull {
>
> This line was just added...
>
>>      QObject base;
>> -} QNull;
>> +};
>>  
>>  extern QNull qnull_;
>>  
>> diff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h
>> index 2706aab..ba69bd8 100644
>> --- a/include/qemu/typedefs.h
>> +++ b/include/qemu/typedefs.h
>> @@ -87,6 +87,7 @@ typedef struct QEMUSGList QEMUSGList;
>>  typedef struct QEMUTimer QEMUTimer;
>>  typedef struct QEMUTimerListGroup QEMUTimerListGroup;
>>  typedef struct QObject QObject;
>> +typedef struct QNull QNull;
>
> ...is it worth hoisting this typedef into 2/10 for less churn?

Less code churn, but more commit message explaining, unless we simply
sneak it into typedefs.h without justification.

> Reviewed-by: Eric Blake <eblake@redhat.com>

Thanks!

^ permalink raw reply	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 03/10] qapi: Introduce a first class 'null' type
  2017-07-18 14:54     ` Eric Blake
@ 2017-07-18 15:21       ` Markus Armbruster
  2017-07-18 19:43         ` Markus Armbruster
  0 siblings, 1 reply; 54+ messages in thread
From: Markus Armbruster @ 2017-07-18 15:21 UTC (permalink / raw)
  To: Eric Blake; +Cc: qemu-devel, kwolf, qemu-block, quintela, dgilbert, mreitz

Eric Blake <eblake@redhat.com> writes:

> On 07/18/2017 09:53 AM, Eric Blake wrote:
>> On 07/18/2017 08:41 AM, Markus Armbruster wrote:
>>> I expect the 'null' type to be useful mostly for members of alternate
>>> types.
>>>
>>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>>> ---
>> 
>
>> Reviewed-by: Eric Blake <eblake@redhat.com>
>
> Actually, do we need to update any qapi docs to mention the new builtin
> type?

Yes, we do.  I'll give it a shot.

^ permalink raw reply	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 01/10] qapi: Separate type QNull from QObject
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 01/10] qapi: Separate type QNull from QObject Markus Armbruster
  2017-07-18 14:24   ` Eric Blake
@ 2017-07-18 15:44   ` Daniel P. Berrange
  1 sibling, 0 replies; 54+ messages in thread
From: Daniel P. Berrange @ 2017-07-18 15:44 UTC (permalink / raw)
  To: Markus Armbruster
  Cc: qemu-devel, eblake, kwolf, mreitz, qemu-block, quintela, dgilbert

On Tue, Jul 18, 2017 at 03:41:17PM +0200, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  include/qapi/qmp/qobject.h    | 10 +++++++---
>  qapi/qobject-output-visitor.c |  2 +-
>  qobject/json-parser.c         |  2 +-
>  qobject/qnull.c               |  8 +++++---
>  target/i386/cpu.c             |  4 ++--
>  tests/check-qjson.c           |  6 +++---
>  tests/check-qnull.c           | 18 +++++++++---------
>  7 files changed, 28 insertions(+), 22 deletions(-)

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>



Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

^ permalink raw reply	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 02/10] qapi: Use QNull for a more regular visit_type_null()
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 02/10] qapi: Use QNull for a more regular visit_type_null() Markus Armbruster
  2017-07-18 14:36   ` Eric Blake
@ 2017-07-18 15:46   ` Daniel P. Berrange
  1 sibling, 0 replies; 54+ messages in thread
From: Daniel P. Berrange @ 2017-07-18 15:46 UTC (permalink / raw)
  To: Markus Armbruster
  Cc: qemu-devel, eblake, kwolf, mreitz, qemu-block, quintela, dgilbert

On Tue, Jul 18, 2017 at 03:41:18PM +0200, Markus Armbruster wrote:
> Make visit_type_null() take an @obj argument like its buddies.  This
> helps keeing the next commit simple.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  hw/ppc/spapr_drc.c                  |  4 +++-
>  include/qapi/visitor-impl.h         |  3 ++-
>  include/qapi/visitor.h              |  8 ++++----
>  qapi/qapi-clone-visitor.c           |  5 +++--
>  qapi/qapi-dealloc-visitor.c         |  6 +++++-
>  qapi/qapi-visit-core.c              |  7 ++++---
>  qapi/qobject-input-visitor.c        |  6 +++++-
>  qapi/qobject-output-visitor.c       |  3 ++-
>  qapi/string-input-visitor.c         |  8 +++++++-
>  qapi/string-output-visitor.c        |  3 ++-
>  qapi/trace-events                   |  2 +-
>  tests/check-qnull.c                 |  9 +++++++--
>  tests/test-qobject-input-visitor.c  | 13 +++++++++----
>  tests/test-qobject-output-visitor.c |  3 ++-
>  14 files changed, 56 insertions(+), 24 deletions(-)

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

^ permalink raw reply	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 03/10] qapi: Introduce a first class 'null' type
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 03/10] qapi: Introduce a first class 'null' type Markus Armbruster
  2017-07-18 14:53   ` Eric Blake
@ 2017-07-18 15:47   ` Daniel P. Berrange
  1 sibling, 0 replies; 54+ messages in thread
From: Daniel P. Berrange @ 2017-07-18 15:47 UTC (permalink / raw)
  To: Markus Armbruster
  Cc: qemu-devel, eblake, kwolf, mreitz, qemu-block, quintela, dgilbert

On Tue, Jul 18, 2017 at 03:41:19PM +0200, Markus Armbruster wrote:
> I expect the 'null' type to be useful mostly for members of alternate
> types.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  include/qapi/qmp/qobject.h              |  4 ++--
>  include/qemu/typedefs.h                 |  1 +
>  scripts/qapi.py                         |  5 ++++-
>  tests/qapi-schema/qapi-schema-test.json |  3 ++-
>  tests/qapi-schema/qapi-schema-test.out  |  1 +
>  tests/test-qobject-input-visitor.c      |  5 +++++
>  tests/test-qobject-output-visitor.c     | 10 ++++++++++
>  7 files changed, 25 insertions(+), 4 deletions(-)

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

^ permalink raw reply	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 04/10] tests/test-qobject-input-visitor: Drop redundant test
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 04/10] tests/test-qobject-input-visitor: Drop redundant test Markus Armbruster
  2017-07-18 15:13   ` Eric Blake
@ 2017-07-18 15:47   ` Daniel P. Berrange
  1 sibling, 0 replies; 54+ messages in thread
From: Daniel P. Berrange @ 2017-07-18 15:47 UTC (permalink / raw)
  To: Markus Armbruster
  Cc: qemu-devel, eblake, kwolf, mreitz, qemu-block, quintela, dgilbert

On Tue, Jul 18, 2017 at 03:41:20PM +0200, Markus Armbruster wrote:
> test_visitor_in_alternate() tests UserDefAlternate with inadmissible
> input.  test_visitor_in_fail_alternate() does basically the same.
> Drop the former, keep the latter.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  tests/test-qobject-input-visitor.c | 6 ------
>  1 file changed, 6 deletions(-)

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

^ permalink raw reply	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 05/10] block: Use JSON null instead of "" to disable backing file
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 05/10] block: Use JSON null instead of "" to disable backing file Markus Armbruster
@ 2017-07-18 15:53   ` Daniel P. Berrange
  2017-07-18 17:27   ` Eric Blake
  1 sibling, 0 replies; 54+ messages in thread
From: Daniel P. Berrange @ 2017-07-18 15:53 UTC (permalink / raw)
  To: Markus Armbruster
  Cc: qemu-devel, eblake, kwolf, mreitz, qemu-block, quintela, dgilbert

On Tue, Jul 18, 2017 at 03:41:21PM +0200, Markus Armbruster wrote:
> BlockdevRef is an alternate of BlockdevOptions (inline definition) and
> str (reference to an existing block device by name).  BlockdevRef
> value "" is special: "no block device should be referenced."  It's
> actually interpreted that way in just one place: optional member
> @backing of COW formats.  Semantics:
> 
> * Present means "use this block device" as backing storage
> 
> * Absent means "default to the one stored in the image"
> 
> * Except "" means "don't use backing storage at all"
> 
> The first two are perfectly normal: when the parameter is absent, it
> defaults to an implied value, but the value's meaning is the same.
> 
> The third one overloads the parameter with a second meaning.  The
> overloading is *implicit*, i.e. it's not visible in the types.  Works
> here, because "" is not a value block device ID.
> 
> Pressing argument values the schema accepts, but are semantically
> invalid, into service to mean "do something else entirely" is not
> general, as suitable invalid values need not exist.  I also find it
> ugly.
> 
> To clean this up, we could add a separate flag argument to suppress
> @backing, or add a distinct value to @backing.  This commit implements
> the latter: add JSON null to the values of @backing, deprecate "".
> 
> Because we're so close to the 2.10 freeze, implement it in the
> stupidest way possible: have qmp_blockdev_add() rewrite null to ""
> before anything else can see the null.  Works, because BlockdevRef
> occurs only within arguments of blockdev-add.  The proper way to do it
> would be rewriting "" to null, preferably in a cleaner way, but that
> requires fixing up code to work with null.  Add a TODO comment for
> that.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  blockdev.c             | 14 ++++++++++++++
>  qapi/block-core.json   | 29 ++++++++++++++++++++++-------
>  tests/qemu-iotests/085 |  2 +-
>  tests/qemu-iotests/139 |  2 +-
>  4 files changed, 38 insertions(+), 9 deletions(-)

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>


> 
> diff --git a/blockdev.c b/blockdev.c
> index 9c6dd27..1c42699 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -3886,6 +3886,7 @@ void qmp_blockdev_add(BlockdevOptions *options, Error **errp)
>      QObject *obj;
>      Visitor *v = qobject_output_visitor_new(&obj);
>      QDict *qdict;
> +    const QDictEntry *ent;
>      Error *local_err = NULL;
>  
>      visit_type_BlockdevOptions(v, NULL, &options, &local_err);
> @@ -3899,6 +3900,19 @@ void qmp_blockdev_add(BlockdevOptions *options, Error **errp)
>  
>      qdict_flatten(qdict);
>  
> +    /*
> +     * Rewrite "backing": null to "backing": ""
> +     * TODO Rewrite "" to null instead, and perhaps not even here
> +     */
> +    for (ent = qdict_first(qdict); ent; ent = qdict_next(qdict, ent)) {
> +        char *dot = strrchr(ent->key, '.');
> +
> +        if (!strcmp(dot ? dot + 1 : ent->key, "backing")
> +            && qobject_type(ent->value) == QTYPE_QNULL) {
> +            qdict_put(qdict, ent->key, qstring_new());
> +        }
> +    }

I find it a little yucky that we're modifying the qdict, rather than
the original "options" object, but I guess this is simpler for a quick
hack



Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

^ permalink raw reply	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 06/10] hmp: Clean up and simplify hmp_migrate_set_parameter()
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 06/10] hmp: Clean up and simplify hmp_migrate_set_parameter() Markus Armbruster
@ 2017-07-18 15:54   ` Daniel P. Berrange
  2017-07-18 17:09   ` Dr. David Alan Gilbert
  2017-07-18 17:34   ` Eric Blake
  2 siblings, 0 replies; 54+ messages in thread
From: Daniel P. Berrange @ 2017-07-18 15:54 UTC (permalink / raw)
  To: Markus Armbruster
  Cc: qemu-devel, eblake, kwolf, mreitz, qemu-block, quintela, dgilbert

On Tue, Jul 18, 2017 at 03:41:22PM +0200, Markus Armbruster wrote:
> The bulk of hmp_migrate_set_parameter()'s code sets one member of
> MigrationParameters according to the command's arguments.  It uses a
> string visitor for integer and boolean members, but not for string and
> size members.  It calls visit_type_bool() right away, but delays
> visit_type_int() some.  The delaying requires a flag variable and a
> bit of trickery: we set all integer members instead of just the one we
> want, and rely on the has_FOOs to mask the unwanted ones.
> 
> Clean this up as follows.  Don't delay calling visit_type_int().  Use
> the string visitor for strings, too.  This involves extra allocations
> and cleanup, but doing them is simpler and cleaner than avoiding them.
> 
> Sadly, using the string visitor for sizes isn't possible, because it
> defaults to Bytes rather than Mebibytes.  Add a comment explaining
> that.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  hmp.c | 78 ++++++++++++++++++++++++++++---------------------------------------
>  1 file changed, 32 insertions(+), 46 deletions(-)

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

^ permalink raw reply	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 07/10] migration: Clean up around tls_creds, tls_hostname
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 07/10] migration: Clean up around tls_creds, tls_hostname Markus Armbruster
@ 2017-07-18 15:57   ` Daniel P. Berrange
  2017-07-18 17:36   ` Eric Blake
  2017-07-18 17:37   ` Dr. David Alan Gilbert
  2 siblings, 0 replies; 54+ messages in thread
From: Daniel P. Berrange @ 2017-07-18 15:57 UTC (permalink / raw)
  To: Markus Armbruster
  Cc: qemu-devel, eblake, kwolf, mreitz, qemu-block, quintela, dgilbert

On Tue, Jul 18, 2017 at 03:41:23PM +0200, Markus Armbruster wrote:
> Optional MigrationParameters members tls_creds and tls_hostname can't
> actually be absent outside qmp_migrate_set_parameters() since commit
> 4af245d (v2.9.0).
> 
> Note that commit 4af245d reverted the part of commit de63ab6 (v2.8.0)
> that made tls_creds and tls_hostname absent instead of "" in the value
> of query-migrate-parameters, even though commit de63ab6 called that a
> mistake.  What a mess.
> 
> Drop the redundant tests for presence, and update documentation.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  hmp.c                 |  6 ++++--
>  migration/migration.c |  4 ++--
>  qapi-schema.json      | 11 +++++------
>  3 files changed, 11 insertions(+), 10 deletions(-)

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

^ permalink raw reply	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 08/10] migration: Add TODO comments on duplication of QAPI_CLONE()
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 08/10] migration: Add TODO comments on duplication of QAPI_CLONE() Markus Armbruster
@ 2017-07-18 15:57   ` Daniel P. Berrange
  2017-07-18 17:36   ` Eric Blake
  1 sibling, 0 replies; 54+ messages in thread
From: Daniel P. Berrange @ 2017-07-18 15:57 UTC (permalink / raw)
  To: Markus Armbruster
  Cc: qemu-devel, eblake, kwolf, mreitz, qemu-block, quintela, dgilbert

On Tue, Jul 18, 2017 at 03:41:24PM +0200, Markus Armbruster wrote:
> qmp_query_migrate_parameters() and qmp_migrate_set_parameters()
> effectively duplicate QAPI_CLONE() inline.  Add suitable TODO
> comments.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  migration/migration.c | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

^ permalink raw reply	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 09/10] migration: Unshare MigrationParameters struct for now
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 09/10] migration: Unshare MigrationParameters struct for now Markus Armbruster
@ 2017-07-18 16:01   ` Daniel P. Berrange
  2017-07-18 17:42   ` Eric Blake
  1 sibling, 0 replies; 54+ messages in thread
From: Daniel P. Berrange @ 2017-07-18 16:01 UTC (permalink / raw)
  To: Markus Armbruster
  Cc: qemu-devel, eblake, kwolf, mreitz, qemu-block, quintela, dgilbert

On Tue, Jul 18, 2017 at 03:41:25PM +0200, Markus Armbruster wrote:
> Commit de63ab6 "migrate: Share common MigrationParameters struct"
> reused MigrationParameters for the arguments of
> migrate-set-parameters, with the following rationale:
> 
>     It is rather verbose, and slightly error-prone, to repeat
>     the same set of parameters for input (migrate-set-parameters)
>     as for output (query-migrate-parameters), where the only
>     difference is whether the members are optional.  We can just
>     document that the optional members will always be present
>     on output, and then share a common struct between both
>     commands.  The next patch can then reduce the amount of
>     code needed on input.
> 
> I need to unshare them to correct a design flaw in a stupid, but
> minimally invasive way, in the next commit.  We can restore the
> sharing when we redo that patch in a less stupid way.  Add a suitable
> TODO comment.
> 
> Note that I revert only the sharing part of commit de63ab6, not the
> part that made the members of query-migrate-parameters' result
> optional.  The schema (and thus introspection) remains inaccurate for
> query-migrate-parameters.  If we decide not to restore the sharing, we
> should revert that part, too.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  hmp.c                 |  4 +--
>  migration/migration.c | 12 +++++---
>  qapi-schema.json      | 85 ++++++++++++++++++++++++++++++++++++++++++++++-----
>  3 files changed, 87 insertions(+), 14 deletions(-)

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

^ permalink raw reply	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 10/10] migration: Use JSON null instead of "" to reset parameter to default
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 10/10] migration: Use JSON null instead of "" to reset parameter to default Markus Armbruster
@ 2017-07-18 16:03   ` Daniel P. Berrange
  2017-07-18 17:46   ` Eric Blake
  2017-07-18 17:52   ` Dr. David Alan Gilbert
  2 siblings, 0 replies; 54+ messages in thread
From: Daniel P. Berrange @ 2017-07-18 16:03 UTC (permalink / raw)
  To: Markus Armbruster
  Cc: qemu-devel, eblake, kwolf, mreitz, qemu-block, quintela, dgilbert

On Tue, Jul 18, 2017 at 03:41:26PM +0200, Markus Armbruster wrote:
> migrate-set-parameters sets migration parameters according to is
> arguments like this:
> 
> * Present means "set the parameter to this value"
> 
> * Absent means "leave the parameter unchanged"
> 
> * Except for parameters tls_creds and tls_hostname, "" means "reset
>   the parameter to its default value
> 
> The first two are perfectly normal: presence of the parameter makes
> the command do something.
> 
> The third one overloads the parameter with a second meaning.  The
> overloading is *implicit*, i.e. it's not visible in the types.  Works
> here, because "" is neither a valid TLS credentials ID, nor a valid
> host name.
> 
> Pressing argument values the schema accepts, but are semantically
> invalid, into service to mean "reset to default" is not general, as
> suitable invalid values need not exist.  I also find it ugly.
> 
> To clean this up, we could add a separate flag argument to ask for
> "reset to default", or add a distinct value to @tls_creds and
> @tls_hostname.  This commit implements the latter: add JSON null to
> the values of @tls_creds and @tls_hostname, deprecate "".
> 
> Because we're so close to the 2.10 freeze, implement it in the
> stupidest way possible: have qmp_migrate_set_parameters() rewrite null
> to "" before anything else can see the null.  The proper way to do it
> would be rewriting "" to null, but that requires fixing up code to
> work with null.  Add TODO comments for that.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  hmp.c                 |  8 ++++++--
>  migration/migration.c | 18 ++++++++++++++++--
>  qapi-schema.json      | 11 +++++++++--
>  3 files changed, 31 insertions(+), 6 deletions(-)

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

^ permalink raw reply	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 00/10] Correct two minor QMP interface design flaws
  2017-07-18 13:41 [Qemu-devel] [PATCH for-2.10 00/10] Correct two minor QMP interface design flaws Markus Armbruster
                   ` (10 preceding siblings ...)
  2017-07-18 14:02 ` [Qemu-devel] [PATCH for-2.10 00/10] Correct two minor QMP interface design flaws no-reply
@ 2017-07-18 16:08 ` Daniel P. Berrange
  2017-07-19  6:12   ` Kevin Wolf
  11 siblings, 1 reply; 54+ messages in thread
From: Daniel P. Berrange @ 2017-07-18 16:08 UTC (permalink / raw)
  To: Markus Armbruster
  Cc: qemu-devel, eblake, kwolf, mreitz, qemu-block, quintela, dgilbert

On Tue, Jul 18, 2017 at 03:41:16PM +0200, Markus Armbruster wrote:
> blockdev-add and migrate-set-parameters overload empty strings to mean
> something entirely different.  See my memo "qapi: Stop abusing
> "special" values for something entirely different" for details.
> 
>     Message-ID: <87379zhrhn.fsf@dusky.pond.sub.org>
>     https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg04526.html
> 
> This series deprecates these usages of "" in favour of JSON null.
> Because we're so close to the 2.10 freeze, the implementation is
> intentionally stupid: rewrite null to "" at first opportunity.  The
> proper way to do it would be rewriting "" to null, but that requires
> fixing up code to work with null.  There are TODO comments for that.
> I'm willing to take care of them in the next development cycle.

I tested the migrate-set-parameters QMP command with this applied and
I can still pass "" as the tls-hostname.

When using query-migrate-parameters we still see "" too.

So from POV of avoiding regressions for existing usage, we look OK
here.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

^ permalink raw reply	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 06/10] hmp: Clean up and simplify hmp_migrate_set_parameter()
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 06/10] hmp: Clean up and simplify hmp_migrate_set_parameter() Markus Armbruster
  2017-07-18 15:54   ` Daniel P. Berrange
@ 2017-07-18 17:09   ` Dr. David Alan Gilbert
  2017-07-18 17:34   ` Eric Blake
  2 siblings, 0 replies; 54+ messages in thread
From: Dr. David Alan Gilbert @ 2017-07-18 17:09 UTC (permalink / raw)
  To: Markus Armbruster
  Cc: qemu-devel, eblake, berrange, kwolf, mreitz, qemu-block, quintela

* Markus Armbruster (armbru@redhat.com) wrote:
> The bulk of hmp_migrate_set_parameter()'s code sets one member of
> MigrationParameters according to the command's arguments.  It uses a
> string visitor for integer and boolean members, but not for string and
> size members.  It calls visit_type_bool() right away, but delays
> visit_type_int() some.  The delaying requires a flag variable and a
> bit of trickery: we set all integer members instead of just the one we
> want, and rely on the has_FOOs to mask the unwanted ones.
> 
> Clean this up as follows.  Don't delay calling visit_type_int().  Use
> the string visitor for strings, too.  This involves extra allocations
> and cleanup, but doing them is simpler and cleaner than avoiding them.
> 
> Sadly, using the string visitor for sizes isn't possible, because it
> defaults to Bytes rather than Mebibytes.  Add a comment explaining
> that.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

> ---
>  hmp.c | 78 ++++++++++++++++++++++++++++---------------------------------------
>  1 file changed, 32 insertions(+), 46 deletions(-)
> 
> diff --git a/hmp.c b/hmp.c
> index 6d32c40..2993586 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -1509,90 +1509,75 @@ void hmp_migrate_set_parameter(Monitor *mon, const QDict *qdict)
>      const char *param = qdict_get_str(qdict, "parameter");
>      const char *valuestr = qdict_get_str(qdict, "value");
>      Visitor *v = string_input_visitor_new(valuestr);
> +    MigrationParameters *p = g_new0(MigrationParameters, 1);
>      uint64_t valuebw = 0;
> -    int64_t valueint = 0;
> -    bool valuebool = false;
>      Error *err = NULL;
> -    bool use_int_value = false;
>      int i, ret;
>  
>      for (i = 0; i < MIGRATION_PARAMETER__MAX; i++) {
>          if (strcmp(param, MigrationParameter_lookup[i]) == 0) {
> -            MigrationParameters p = { 0 };
>              switch (i) {
>              case MIGRATION_PARAMETER_COMPRESS_LEVEL:
> -                p.has_compress_level = true;
> -                use_int_value = true;
> +                p->has_compress_level = true;
> +                visit_type_int(v, param, &p->compress_level, &err);
>                  break;
>              case MIGRATION_PARAMETER_COMPRESS_THREADS:
> -                p.has_compress_threads = true;
> -                use_int_value = true;
> +                p->has_compress_threads = true;
> +                visit_type_int(v, param, &p->compress_threads, &err);
>                  break;
>              case MIGRATION_PARAMETER_DECOMPRESS_THREADS:
> -                p.has_decompress_threads = true;
> -                use_int_value = true;
> +                p->has_decompress_threads = true;
> +                visit_type_int(v, param, &p->decompress_threads, &err);
>                  break;
>              case MIGRATION_PARAMETER_CPU_THROTTLE_INITIAL:
> -                p.has_cpu_throttle_initial = true;
> -                use_int_value = true;
> +                p->has_cpu_throttle_initial = true;
> +                visit_type_int(v, param, &p->cpu_throttle_initial, &err);
>                  break;
>              case MIGRATION_PARAMETER_CPU_THROTTLE_INCREMENT:
> -                p.has_cpu_throttle_increment = true;
> -                use_int_value = true;
> +                p->has_cpu_throttle_increment = true;
> +                visit_type_int(v, param, &p->cpu_throttle_increment, &err);
>                  break;
>              case MIGRATION_PARAMETER_TLS_CREDS:
> -                p.has_tls_creds = true;
> -                p.tls_creds = (char *) valuestr;
> +                p->has_tls_creds = true;
> +                visit_type_str(v, param, &p->tls_creds, &err);
>                  break;
>              case MIGRATION_PARAMETER_TLS_HOSTNAME:
> -                p.has_tls_hostname = true;
> -                p.tls_hostname = (char *) valuestr;
> +                p->has_tls_hostname = true;
> +                visit_type_str(v, param, &p->tls_hostname, &err);
>                  break;
>              case MIGRATION_PARAMETER_MAX_BANDWIDTH:
> -                p.has_max_bandwidth = true;
> +                p->has_max_bandwidth = true;
> +                /*
> +                 * Can't use visit_type_size() here, because it
> +                 * defaults to Bytes rather than Mebibytes.
> +                 */
>                  ret = qemu_strtosz_MiB(valuestr, NULL, &valuebw);
>                  if (ret < 0 || valuebw > INT64_MAX
>                      || (size_t)valuebw != valuebw) {
>                      error_setg(&err, "Invalid size %s", valuestr);
> -                    goto cleanup;
> +                    break;
>                  }
> -                p.max_bandwidth = valuebw;
> +                p->max_bandwidth = valuebw;
>                  break;
>              case MIGRATION_PARAMETER_DOWNTIME_LIMIT:
> -                p.has_downtime_limit = true;
> -                use_int_value = true;
> +                p->has_downtime_limit = true;
> +                visit_type_int(v, param, &p->downtime_limit, &err);
>                  break;
>              case MIGRATION_PARAMETER_X_CHECKPOINT_DELAY:
> -                p.has_x_checkpoint_delay = true;
> -                use_int_value = true;
> +                p->has_x_checkpoint_delay = true;
> +                visit_type_int(v, param, &p->x_checkpoint_delay, &err);
>                  break;
>              case MIGRATION_PARAMETER_BLOCK_INCREMENTAL:
> -                p.has_block_incremental = true;
> -                visit_type_bool(v, param, &valuebool, &err);
> -                if (err) {
> -                    goto cleanup;
> -                }
> -                p.block_incremental = valuebool;
> +                p->has_block_incremental = true;
> +                visit_type_bool(v, param, &p->block_incremental, &err);
>                  break;
>              }
>  
> -            if (use_int_value) {
> -                visit_type_int(v, param, &valueint, &err);
> -                if (err) {
> -                    goto cleanup;
> -                }
> -                /* Set all integers; only one has_FOO will be set, and
> -                 * the code ignores the remaining values */
> -                p.compress_level = valueint;
> -                p.compress_threads = valueint;
> -                p.decompress_threads = valueint;
> -                p.cpu_throttle_initial = valueint;
> -                p.cpu_throttle_increment = valueint;
> -                p.downtime_limit = valueint;
> -                p.x_checkpoint_delay = valueint;
> +            if (err) {
> +                goto cleanup;
>              }
>  
> -            qmp_migrate_set_parameters(&p, &err);
> +            qmp_migrate_set_parameters(p, &err);
>              break;
>          }
>      }
> @@ -1602,6 +1587,7 @@ void hmp_migrate_set_parameter(Monitor *mon, const QDict *qdict)
>      }
>  
>   cleanup:
> +    qapi_free_MigrationParameters(p);
>      visit_free(v);
>      if (err) {
>          error_report_err(err);
> -- 
> 2.7.5
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK

^ permalink raw reply	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 05/10] block: Use JSON null instead of "" to disable backing file
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 05/10] block: Use JSON null instead of "" to disable backing file Markus Armbruster
  2017-07-18 15:53   ` Daniel P. Berrange
@ 2017-07-18 17:27   ` Eric Blake
  1 sibling, 0 replies; 54+ messages in thread
From: Eric Blake @ 2017-07-18 17:27 UTC (permalink / raw)
  To: Markus Armbruster, qemu-devel
  Cc: berrange, kwolf, mreitz, qemu-block, quintela, dgilbert

[-- Attachment #1: Type: text/plain, Size: 2026 bytes --]

On 07/18/2017 08:41 AM, Markus Armbruster wrote:
> BlockdevRef is an alternate of BlockdevOptions (inline definition) and
> str (reference to an existing block device by name).  BlockdevRef
> value "" is special: "no block device should be referenced."  It's
> actually interpreted that way in just one place: optional member
> @backing of COW formats.  Semantics:
> 
> * Present means "use this block device" as backing storage
> 
> * Absent means "default to the one stored in the image"
> 
> * Except "" means "don't use backing storage at all"
> 
> The first two are perfectly normal: when the parameter is absent, it
> defaults to an implied value, but the value's meaning is the same.
> 
> The third one overloads the parameter with a second meaning.  The
> overloading is *implicit*, i.e. it's not visible in the types.  Works
> here, because "" is not a value block device ID.
> 
> Pressing argument values the schema accepts, but are semantically
> invalid, into service to mean "do something else entirely" is not
> general, as suitable invalid values need not exist.  I also find it
> ugly.
> 
> To clean this up, we could add a separate flag argument to suppress
> @backing, or add a distinct value to @backing.  This commit implements
> the latter: add JSON null to the values of @backing, deprecate "".
> 
> Because we're so close to the 2.10 freeze, implement it in the
> stupidest way possible: have qmp_blockdev_add() rewrite null to ""
> before anything else can see the null.  Works, because BlockdevRef
> occurs only within arguments of blockdev-add.  The proper way to do it
> would be rewriting "" to null, preferably in a cleaner way, but that
> requires fixing up code to work with null.  Add a TODO comment for
> that.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]

^ permalink raw reply	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 06/10] hmp: Clean up and simplify hmp_migrate_set_parameter()
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 06/10] hmp: Clean up and simplify hmp_migrate_set_parameter() Markus Armbruster
  2017-07-18 15:54   ` Daniel P. Berrange
  2017-07-18 17:09   ` Dr. David Alan Gilbert
@ 2017-07-18 17:34   ` Eric Blake
  2017-07-18 18:28     ` Markus Armbruster
  2 siblings, 1 reply; 54+ messages in thread
From: Eric Blake @ 2017-07-18 17:34 UTC (permalink / raw)
  To: Markus Armbruster, qemu-devel
  Cc: berrange, kwolf, mreitz, qemu-block, quintela, dgilbert

[-- Attachment #1: Type: text/plain, Size: 3161 bytes --]

On 07/18/2017 08:41 AM, Markus Armbruster wrote:
> The bulk of hmp_migrate_set_parameter()'s code sets one member of
> MigrationParameters according to the command's arguments.  It uses a
> string visitor for integer and boolean members, but not for string and
> size members.  It calls visit_type_bool() right away, but delays
> visit_type_int() some.  The delaying requires a flag variable and a
> bit of trickery: we set all integer members instead of just the one we
> want, and rely on the has_FOOs to mask the unwanted ones.
> 
> Clean this up as follows.  Don't delay calling visit_type_int().  Use
> the string visitor for strings, too.  This involves extra allocations
> and cleanup, but doing them is simpler and cleaner than avoiding them.
> 
> Sadly, using the string visitor for sizes isn't possible, because it
> defaults to Bytes rather than Mebibytes.  Add a comment explaining
> that.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  hmp.c | 78 ++++++++++++++++++++++++++++---------------------------------------
>  1 file changed, 32 insertions(+), 46 deletions(-)
>

Diffstat says it's cleaner.

>              case MIGRATION_PARAMETER_MAX_BANDWIDTH:
> -                p.has_max_bandwidth = true;
> +                p->has_max_bandwidth = true;
> +                /*
> +                 * Can't use visit_type_size() here, because it
> +                 * defaults to Bytes rather than Mebibytes.
> +                 */
>                  ret = qemu_strtosz_MiB(valuestr, NULL, &valuebw);

Can we munge valuestr (if it has a suffix, leave it alone; if it has
none, tack on "M"), and then call the size visitor as usual?

>                  if (ret < 0 || valuebw > INT64_MAX
>                      || (size_t)valuebw != valuebw) {
>                      error_setg(&err, "Invalid size %s", valuestr);
> -                    goto cleanup;
> +                    break;
>                  }

But for now, the inline version works.

> -                /* Set all integers; only one has_FOO will be set, and
> -                 * the code ignores the remaining values */
> -                p.compress_level = valueint;
> -                p.compress_threads = valueint;
> -                p.decompress_threads = valueint;
> -                p.cpu_throttle_initial = valueint;
> -                p.cpu_throttle_increment = valueint;
> -                p.downtime_limit = valueint;
> -                p.x_checkpoint_delay = valueint;
> +            if (err) {
> +                goto cleanup;
>              }
>  
> -            qmp_migrate_set_parameters(&p, &err);

The old code is calling qmp_migrate_set_parameters() once per loop
iteration, because it could only parse one integer per loop.

> +            qmp_migrate_set_parameters(p, &err);

But couldn't you now sink this below the loop, and call it only once
after all members are parsed?  Can be a separate patch, though.

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]

^ permalink raw reply	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 07/10] migration: Clean up around tls_creds, tls_hostname
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 07/10] migration: Clean up around tls_creds, tls_hostname Markus Armbruster
  2017-07-18 15:57   ` Daniel P. Berrange
@ 2017-07-18 17:36   ` Eric Blake
  2017-07-18 17:37   ` Dr. David Alan Gilbert
  2 siblings, 0 replies; 54+ messages in thread
From: Eric Blake @ 2017-07-18 17:36 UTC (permalink / raw)
  To: Markus Armbruster, qemu-devel
  Cc: berrange, kwolf, mreitz, qemu-block, quintela, dgilbert

[-- Attachment #1: Type: text/plain, Size: 960 bytes --]

On 07/18/2017 08:41 AM, Markus Armbruster wrote:
> Optional MigrationParameters members tls_creds and tls_hostname can't
> actually be absent outside qmp_migrate_set_parameters() since commit
> 4af245d (v2.9.0).
> 
> Note that commit 4af245d reverted the part of commit de63ab6 (v2.8.0)
> that made tls_creds and tls_hostname absent instead of "" in the value
> of query-migrate-parameters, even though commit de63ab6 called that a
> mistake.  What a mess.
> 
> Drop the redundant tests for presence, and update documentation.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  hmp.c                 |  6 ++++--
>  migration/migration.c |  4 ++--
>  qapi-schema.json      | 11 +++++------
>  3 files changed, 11 insertions(+), 10 deletions(-)
> 

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]

^ permalink raw reply	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 08/10] migration: Add TODO comments on duplication of QAPI_CLONE()
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 08/10] migration: Add TODO comments on duplication of QAPI_CLONE() Markus Armbruster
  2017-07-18 15:57   ` Daniel P. Berrange
@ 2017-07-18 17:36   ` Eric Blake
  1 sibling, 0 replies; 54+ messages in thread
From: Eric Blake @ 2017-07-18 17:36 UTC (permalink / raw)
  To: Markus Armbruster, qemu-devel
  Cc: berrange, kwolf, mreitz, qemu-block, quintela, dgilbert

[-- Attachment #1: Type: text/plain, Size: 510 bytes --]

On 07/18/2017 08:41 AM, Markus Armbruster wrote:
> qmp_query_migrate_parameters() and qmp_migrate_set_parameters()
> effectively duplicate QAPI_CLONE() inline.  Add suitable TODO
> comments.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  migration/migration.c | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]

^ permalink raw reply	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 07/10] migration: Clean up around tls_creds, tls_hostname
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 07/10] migration: Clean up around tls_creds, tls_hostname Markus Armbruster
  2017-07-18 15:57   ` Daniel P. Berrange
  2017-07-18 17:36   ` Eric Blake
@ 2017-07-18 17:37   ` Dr. David Alan Gilbert
  2 siblings, 0 replies; 54+ messages in thread
From: Dr. David Alan Gilbert @ 2017-07-18 17:37 UTC (permalink / raw)
  To: Markus Armbruster
  Cc: qemu-devel, eblake, berrange, kwolf, mreitz, qemu-block, quintela

* Markus Armbruster (armbru@redhat.com) wrote:
> Optional MigrationParameters members tls_creds and tls_hostname can't
> actually be absent outside qmp_migrate_set_parameters() since commit
> 4af245d (v2.9.0).
> 
> Note that commit 4af245d reverted the part of commit de63ab6 (v2.8.0)
> that made tls_creds and tls_hostname absent instead of "" in the value
> of query-migrate-parameters, even though commit de63ab6 called that a
> mistake.  What a mess.
> 
> Drop the redundant tests for presence, and update documentation.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

> ---
>  hmp.c                 |  6 ++++--
>  migration/migration.c |  4 ++--
>  qapi-schema.json      | 11 +++++------
>  3 files changed, 11 insertions(+), 10 deletions(-)
> 
> diff --git a/hmp.c b/hmp.c
> index 2993586..2b2db3c 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -313,12 +313,14 @@ void hmp_info_migrate_parameters(Monitor *mon, const QDict *qdict)
>          monitor_printf(mon, "%s: %" PRId64 "\n",
>              MigrationParameter_lookup[MIGRATION_PARAMETER_CPU_THROTTLE_INCREMENT],
>              params->cpu_throttle_increment);
> +        assert(params->has_tls_creds);
>          monitor_printf(mon, "%s: '%s'\n",
>              MigrationParameter_lookup[MIGRATION_PARAMETER_TLS_CREDS],
> -            params->has_tls_creds ? params->tls_creds : "");
> +            params->tls_creds);
> +        assert(params->has_tls_hostname);
>          monitor_printf(mon, "%s: '%s'\n",
>              MigrationParameter_lookup[MIGRATION_PARAMETER_TLS_HOSTNAME],
> -            params->has_tls_hostname ? params->tls_hostname : "");
> +            params->tls_hostname);
>          assert(params->has_max_bandwidth);
>          monitor_printf(mon, "%s: %" PRId64 " bytes/second\n",
>              MigrationParameter_lookup[MIGRATION_PARAMETER_MAX_BANDWIDTH],
> diff --git a/migration/migration.c b/migration/migration.c
> index a0db40d..bae9808 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -438,9 +438,9 @@ MigrationParameters *qmp_query_migrate_parameters(Error **errp)
>      params->cpu_throttle_initial = s->parameters.cpu_throttle_initial;
>      params->has_cpu_throttle_increment = true;
>      params->cpu_throttle_increment = s->parameters.cpu_throttle_increment;
> -    params->has_tls_creds = !!s->parameters.tls_creds;
> +    params->has_tls_creds = true;
>      params->tls_creds = g_strdup(s->parameters.tls_creds);
> -    params->has_tls_hostname = !!s->parameters.tls_hostname;
> +    params->has_tls_hostname = true;
>      params->tls_hostname = g_strdup(s->parameters.tls_hostname);
>      params->has_max_bandwidth = true;
>      params->max_bandwidth = s->parameters.max_bandwidth;
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 485767f..7b75cf1 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -1054,9 +1054,7 @@
>  # @MigrationParameters:
>  #
>  # Optional members can be omitted on input ('migrate-set-parameters')
> -# but most members will always be present on output
> -# ('query-migrate-parameters'), with the exception of tls-creds and
> -# tls-hostname.
> +# but members will always be present on output.
>  #
>  # @compress-level: compression level
>  #
> @@ -1077,10 +1075,10 @@
>  #             channel. On the outgoing side of the migration, the credentials
>  #             must be for a 'client' endpoint, while for the incoming side the
>  #             credentials must be for a 'server' endpoint. Setting this
> -#             will enable TLS for all migrations. The default is unset,
> -#             resulting in unsecured migration at the QEMU level. (Since 2.7)
> +#             to a non-empty string enables TLS for all migrations.
>  #             An empty string means that QEMU will use plain text mode for
> -#             migration, rather than TLS (Since 2.9)
> +#             migration, rather than TLS (Since 2.7)
> +#             Note: 2.8 reports this by omitting tls-creds instead.
>  #
>  # @tls-hostname: hostname of the target host for the migration. This
>  #                is required when using x509 based TLS credentials and the
> @@ -1090,6 +1088,7 @@
>  #                certificate identity can be validated. (Since 2.7)
>  #                An empty string means that QEMU will use the hostname
>  #                associated with the migration URI, if any. (Since 2.9)
> +#                Note: 2.8 reports this by omitting tls-hostname instead.
>  #
>  # @max-bandwidth: to set maximum speed for migration. maximum speed in
>  #                 bytes per second. (Since 2.8)
> -- 
> 2.7.5
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK

^ permalink raw reply	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 09/10] migration: Unshare MigrationParameters struct for now
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 09/10] migration: Unshare MigrationParameters struct for now Markus Armbruster
  2017-07-18 16:01   ` Daniel P. Berrange
@ 2017-07-18 17:42   ` Eric Blake
  1 sibling, 0 replies; 54+ messages in thread
From: Eric Blake @ 2017-07-18 17:42 UTC (permalink / raw)
  To: Markus Armbruster, qemu-devel
  Cc: berrange, kwolf, mreitz, qemu-block, quintela, dgilbert

[-- Attachment #1: Type: text/plain, Size: 2164 bytes --]

On 07/18/2017 08:41 AM, Markus Armbruster wrote:
> Commit de63ab6 "migrate: Share common MigrationParameters struct"
> reused MigrationParameters for the arguments of
> migrate-set-parameters, with the following rationale:
> 
>     It is rather verbose, and slightly error-prone, to repeat
>     the same set of parameters for input (migrate-set-parameters)
>     as for output (query-migrate-parameters), where the only
>     difference is whether the members are optional.  We can just
>     document that the optional members will always be present
>     on output, and then share a common struct between both
>     commands.  The next patch can then reduce the amount of
>     code needed on input.
> 
> I need to unshare them to correct a design flaw in a stupid, but
> minimally invasive way, in the next commit.  We can restore the
> sharing when we redo that patch in a less stupid way.  Add a suitable
> TODO comment.
> 
> Note that I revert only the sharing part of commit de63ab6, not the
> part that made the members of query-migrate-parameters' result
> optional.  The schema (and thus introspection) remains inaccurate for
> query-migrate-parameters.  If we decide not to restore the sharing, we
> should revert that part, too.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  hmp.c                 |  4 +--
>  migration/migration.c | 12 +++++---
>  qapi-schema.json      | 85 ++++++++++++++++++++++++++++++++++++++++++++++-----
>  3 files changed, 87 insertions(+), 14 deletions(-)

No fun, but when you're up against a release deadline, it beats the
alternative of baking in a design flaw longer than we want.

Reviewed-by: Eric Blake <eblake@redhat.com>

A possible alternative: make a common base class with most of the
members (those that aren't related to tls), then two subclasses, one
with output semantics, one with input semantics, for the tls members.
You share a bit more code that way (and could still QAPI_CLONE the
common base-class members).

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]

^ permalink raw reply	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 10/10] migration: Use JSON null instead of "" to reset parameter to default
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 10/10] migration: Use JSON null instead of "" to reset parameter to default Markus Armbruster
  2017-07-18 16:03   ` Daniel P. Berrange
@ 2017-07-18 17:46   ` Eric Blake
  2017-07-18 18:37     ` Markus Armbruster
  2017-07-18 18:39     ` Markus Armbruster
  2017-07-18 17:52   ` Dr. David Alan Gilbert
  2 siblings, 2 replies; 54+ messages in thread
From: Eric Blake @ 2017-07-18 17:46 UTC (permalink / raw)
  To: Markus Armbruster, qemu-devel
  Cc: berrange, kwolf, mreitz, qemu-block, quintela, dgilbert

[-- Attachment #1: Type: text/plain, Size: 2802 bytes --]

On 07/18/2017 08:41 AM, Markus Armbruster wrote:
> migrate-set-parameters sets migration parameters according to is
> arguments like this:
> 
> * Present means "set the parameter to this value"
> 
> * Absent means "leave the parameter unchanged"
> 
> * Except for parameters tls_creds and tls_hostname, "" means "reset
>   the parameter to its default value
> 
> The first two are perfectly normal: presence of the parameter makes
> the command do something.
> 
> The third one overloads the parameter with a second meaning.  The
> overloading is *implicit*, i.e. it's not visible in the types.  Works
> here, because "" is neither a valid TLS credentials ID, nor a valid
> host name.
> 
> Pressing argument values the schema accepts, but are semantically
> invalid, into service to mean "reset to default" is not general, as
> suitable invalid values need not exist.  I also find it ugly.
> 
> To clean this up, we could add a separate flag argument to ask for
> "reset to default", or add a distinct value to @tls_creds and
> @tls_hostname.  This commit implements the latter: add JSON null to
> the values of @tls_creds and @tls_hostname, deprecate "".
> 
> Because we're so close to the 2.10 freeze, implement it in the
> stupidest way possible: have qmp_migrate_set_parameters() rewrite null
> to "" before anything else can see the null.  The proper way to do it
> would be rewriting "" to null, but that requires fixing up code to
> work with null.  Add TODO comments for that.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> +++ b/qapi-schema.json
> @@ -116,6 +116,13 @@
>  { 'command': 'qmp_capabilities' }
>  
>  ##
> +# @StrOrNull:

A little light on the documentation.

> +##
> +{ 'alternate': 'StrOrNull',
> +  'data': { 's': 'str',
> +            'n': 'null' } }
> +
> +##
>  # @LostTickPolicy:
>  #
>  # Policy for handling lost ticks in timer devices.
> @@ -1098,8 +1105,8 @@
>              '*decompress-threads': 'int',
>              '*cpu-throttle-initial': 'int',
>              '*cpu-throttle-increment': 'int',
> -            '*tls-creds': 'str',
> -            '*tls-hostname': 'str',
> +            '*tls-creds': 'StrOrNull',
> +            '*tls-hostname': 'StrOrNull',
>              '*max-bandwidth': 'int',
>              '*downtime-limit': 'int',
>              '*x-checkpoint-delay': 'int',

By splitting input from output, you guarantee that 'null' won't appear
in the output and break an unsuspecting client, but that new clients can
introspect the existence of null and use that instead of "" on input.

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]

^ permalink raw reply	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 10/10] migration: Use JSON null instead of "" to reset parameter to default
  2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 10/10] migration: Use JSON null instead of "" to reset parameter to default Markus Armbruster
  2017-07-18 16:03   ` Daniel P. Berrange
  2017-07-18 17:46   ` Eric Blake
@ 2017-07-18 17:52   ` Dr. David Alan Gilbert
  2017-07-18 19:24     ` Markus Armbruster
  2 siblings, 1 reply; 54+ messages in thread
From: Dr. David Alan Gilbert @ 2017-07-18 17:52 UTC (permalink / raw)
  To: Markus Armbruster
  Cc: qemu-devel, eblake, berrange, kwolf, mreitz, qemu-block, quintela

* Markus Armbruster (armbru@redhat.com) wrote:
> migrate-set-parameters sets migration parameters according to is
> arguments like this:
> 
> * Present means "set the parameter to this value"
> 
> * Absent means "leave the parameter unchanged"
> 
> * Except for parameters tls_creds and tls_hostname, "" means "reset
>   the parameter to its default value

Is this really what's happening? IMHO the tls_creds and tls_hostname
behaviour isn't that "" resets to the default, it just is the default.
I don't think there's anything special cased for tls_creds and
tls_hostname in the existing code.    It's this patch that's
adding more special casing.

(I'm not going to nack this, but I just don't get why it's such a big
deal)

Dave


> The first two are perfectly normal: presence of the parameter makes
> the command do something.
> 
> The third one overloads the parameter with a second meaning.  The
> overloading is *implicit*, i.e. it's not visible in the types.  Works
> here, because "" is neither a valid TLS credentials ID, nor a valid
> host name.
> 
> Pressing argument values the schema accepts, but are semantically
> invalid, into service to mean "reset to default" is not general, as
> suitable invalid values need not exist.  I also find it ugly.
> 
> To clean this up, we could add a separate flag argument to ask for
> "reset to default", or add a distinct value to @tls_creds and
> @tls_hostname.  This commit implements the latter: add JSON null to
> the values of @tls_creds and @tls_hostname, deprecate "".
> 
> Because we're so close to the 2.10 freeze, implement it in the
> stupidest way possible: have qmp_migrate_set_parameters() rewrite null
> to "" before anything else can see the null.  The proper way to do it
> would be rewriting "" to null, but that requires fixing up code to
> work with null.  Add TODO comments for that.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  hmp.c                 |  8 ++++++--
>  migration/migration.c | 18 ++++++++++++++++--
>  qapi-schema.json      | 11 +++++++++--
>  3 files changed, 31 insertions(+), 6 deletions(-)
> 
> diff --git a/hmp.c b/hmp.c
> index 0a5de75..40ebeef 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -1541,11 +1541,15 @@ void hmp_migrate_set_parameter(Monitor *mon, const QDict *qdict)
>                  break;
>              case MIGRATION_PARAMETER_TLS_CREDS:
>                  p->has_tls_creds = true;
> -                visit_type_str(v, param, &p->tls_creds, &err);
> +                p->tls_creds = g_new0(StrOrNull, 1);
> +                p->tls_creds->type = QTYPE_QSTRING;
> +                visit_type_str(v, param, &p->tls_creds->u.s, &err);
>                  break;
>              case MIGRATION_PARAMETER_TLS_HOSTNAME:
>                  p->has_tls_hostname = true;
> -                visit_type_str(v, param, &p->tls_hostname, &err);
> +                p->tls_hostname = g_new0(StrOrNull, 1);
> +                p->tls_hostname->type = QTYPE_QSTRING;
> +                visit_type_str(v, param, &p->tls_hostname->u.s, &err);
>                  break;
>              case MIGRATION_PARAMETER_MAX_BANDWIDTH:
>                  p->has_max_bandwidth = true;
> diff --git a/migration/migration.c b/migration/migration.c
> index f6a9443..e2cfb99 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -703,6 +703,20 @@ void qmp_migrate_set_parameters(MigrateSetParameters *params, Error **errp)
>                      "x_checkpoint_delay",
>                      "is invalid, it should be positive");
>      }
> +    /* TODO Rewrite "" to null instead */
> +    if (params->has_tls_creds
> +        && params->tls_creds->type == QTYPE_QNULL) {
> +        QDECREF(params->tls_creds->u.n);
> +        params->tls_creds->type = QTYPE_QSTRING;
> +        params->tls_creds->u.s = strdup("");
> +    }
> +    /* TODO Rewrite "" to null instead */
> +    if (params->has_tls_hostname
> +        && params->tls_hostname->type == QTYPE_QNULL) {
> +        QDECREF(params->tls_hostname->u.n);
> +        params->tls_hostname->type = QTYPE_QSTRING;
> +        params->tls_hostname->u.s = strdup("");
> +    }
>  
>      /*
>       * TODO if we fuse MigrateSetParameters back into
> @@ -726,11 +740,11 @@ void qmp_migrate_set_parameters(MigrateSetParameters *params, Error **errp)
>      }
>      if (params->has_tls_creds) {
>          g_free(s->parameters.tls_creds);
> -        s->parameters.tls_creds = g_strdup(params->tls_creds);
> +        s->parameters.tls_creds = g_strdup(params->tls_creds->u.s);
>      }
>      if (params->has_tls_hostname) {
>          g_free(s->parameters.tls_hostname);
> -        s->parameters.tls_hostname = g_strdup(params->tls_hostname);
> +        s->parameters.tls_hostname = g_strdup(params->tls_hostname->u.s);
>      }
>      if (params->has_max_bandwidth) {
>          s->parameters.max_bandwidth = params->max_bandwidth;
> diff --git a/qapi-schema.json b/qapi-schema.json
> index b5ec942..247af24 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -116,6 +116,13 @@
>  { 'command': 'qmp_capabilities' }
>  
>  ##
> +# @StrOrNull:
> +##
> +{ 'alternate': 'StrOrNull',
> +  'data': { 's': 'str',
> +            'n': 'null' } }
> +
> +##
>  # @LostTickPolicy:
>  #
>  # Policy for handling lost ticks in timer devices.
> @@ -1098,8 +1105,8 @@
>              '*decompress-threads': 'int',
>              '*cpu-throttle-initial': 'int',
>              '*cpu-throttle-increment': 'int',
> -            '*tls-creds': 'str',
> -            '*tls-hostname': 'str',
> +            '*tls-creds': 'StrOrNull',
> +            '*tls-hostname': 'StrOrNull',
>              '*max-bandwidth': 'int',
>              '*downtime-limit': 'int',
>              '*x-checkpoint-delay': 'int',
> -- 
> 2.7.5
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK

^ permalink raw reply	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 06/10] hmp: Clean up and simplify hmp_migrate_set_parameter()
  2017-07-18 17:34   ` Eric Blake
@ 2017-07-18 18:28     ` Markus Armbruster
  0 siblings, 0 replies; 54+ messages in thread
From: Markus Armbruster @ 2017-07-18 18:28 UTC (permalink / raw)
  To: Eric Blake; +Cc: qemu-devel, kwolf, qemu-block, quintela, dgilbert, mreitz

Eric Blake <eblake@redhat.com> writes:

> On 07/18/2017 08:41 AM, Markus Armbruster wrote:
>> The bulk of hmp_migrate_set_parameter()'s code sets one member of
>> MigrationParameters according to the command's arguments.  It uses a
>> string visitor for integer and boolean members, but not for string and
>> size members.  It calls visit_type_bool() right away, but delays
>> visit_type_int() some.  The delaying requires a flag variable and a
>> bit of trickery: we set all integer members instead of just the one we
>> want, and rely on the has_FOOs to mask the unwanted ones.
>> 
>> Clean this up as follows.  Don't delay calling visit_type_int().  Use
>> the string visitor for strings, too.  This involves extra allocations
>> and cleanup, but doing them is simpler and cleaner than avoiding them.
>> 
>> Sadly, using the string visitor for sizes isn't possible, because it
>> defaults to Bytes rather than Mebibytes.  Add a comment explaining
>> that.
>> 
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>>  hmp.c | 78 ++++++++++++++++++++++++++++---------------------------------------
>>  1 file changed, 32 insertions(+), 46 deletions(-)
>>
>
> Diffstat says it's cleaner.
>
>>              case MIGRATION_PARAMETER_MAX_BANDWIDTH:
>> -                p.has_max_bandwidth = true;
>> +                p->has_max_bandwidth = true;
>> +                /*
>> +                 * Can't use visit_type_size() here, because it
>> +                 * defaults to Bytes rather than Mebibytes.
>> +                 */
>>                  ret = qemu_strtosz_MiB(valuestr, NULL, &valuebw);
>
> Can we munge valuestr (if it has a suffix, leave it alone; if it has
> none, tack on "M"), and then call the size visitor as usual?

We could, but I expect it to be more complicated than this inline copy.

A possible alternative is adding flags to string_input_visitor_new().  I
suspect that will also be more complicated once you add tests.  Keeping
non-standard suffixes somewhat bothersome will at least help prevent
more of them.

>>                  if (ret < 0 || valuebw > INT64_MAX
>>                      || (size_t)valuebw != valuebw) {
>>                      error_setg(&err, "Invalid size %s", valuestr);
>> -                    goto cleanup;
>> +                    break;
>>                  }
>
> But for now, the inline version works.

>> -                /* Set all integers; only one has_FOO will be set, and
>> -                 * the code ignores the remaining values */
>> -                p.compress_level = valueint;
>> -                p.compress_threads = valueint;
>> -                p.decompress_threads = valueint;
>> -                p.cpu_throttle_initial = valueint;
>> -                p.cpu_throttle_increment = valueint;
>> -                p.downtime_limit = valueint;
>> -                p.x_checkpoint_delay = valueint;
>> +            if (err) {
>> +                goto cleanup;
>>              }
>>  
>> -            qmp_migrate_set_parameters(&p, &err);
>
> The old code is calling qmp_migrate_set_parameters() once per loop
> iteration, because it could only parse one integer per loop.
>
>> +            qmp_migrate_set_parameters(p, &err);
>
> But couldn't you now sink this below the loop, and call it only once
> after all members are parsed?  Can be a separate patch, though.

The whole switch could sink along.  Left for another day.

> Reviewed-by: Eric Blake <eblake@redhat.com>

Thanks!

^ permalink raw reply	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 10/10] migration: Use JSON null instead of "" to reset parameter to default
  2017-07-18 17:46   ` Eric Blake
@ 2017-07-18 18:37     ` Markus Armbruster
  2017-07-18 18:39     ` Markus Armbruster
  1 sibling, 0 replies; 54+ messages in thread
From: Markus Armbruster @ 2017-07-18 18:37 UTC (permalink / raw)
  To: Eric Blake; +Cc: qemu-devel, kwolf, qemu-block, quintela, dgilbert, mreitz

Eric Blake <eblake@redhat.com> writes:

> On 07/18/2017 08:41 AM, Markus Armbruster wrote:
>> migrate-set-parameters sets migration parameters according to is
>> arguments like this:
>> 
>> * Present means "set the parameter to this value"
>> 
>> * Absent means "leave the parameter unchanged"
>> 
>> * Except for parameters tls_creds and tls_hostname, "" means "reset
>>   the parameter to its default value
>> 
>> The first two are perfectly normal: presence of the parameter makes
>> the command do something.
>> 
>> The third one overloads the parameter with a second meaning.  The
>> overloading is *implicit*, i.e. it's not visible in the types.  Works
>> here, because "" is neither a valid TLS credentials ID, nor a valid
>> host name.
>> 
>> Pressing argument values the schema accepts, but are semantically
>> invalid, into service to mean "reset to default" is not general, as
>> suitable invalid values need not exist.  I also find it ugly.
>> 
>> To clean this up, we could add a separate flag argument to ask for
>> "reset to default", or add a distinct value to @tls_creds and
>> @tls_hostname.  This commit implements the latter: add JSON null to
>> the values of @tls_creds and @tls_hostname, deprecate "".
>> 
>> Because we're so close to the 2.10 freeze, implement it in the
>> stupidest way possible: have qmp_migrate_set_parameters() rewrite null
>> to "" before anything else can see the null.  The proper way to do it
>> would be rewriting "" to null, but that requires fixing up code to
>> work with null.  Add TODO comments for that.
>> 
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>> +++ b/qapi-schema.json
>> @@ -116,6 +116,13 @@
>>  { 'command': 'qmp_capabilities' }
>>  
>>  ##
>> +# @StrOrNull:
>
> A little light on the documentation.
>
>> +##
>> +{ 'alternate': 'StrOrNull',
>> +  'data': { 's': 'str',
>> +            'n': 'null' } }
>> +
>> +##
>>  # @LostTickPolicy:
>>  #
>>  # Policy for handling lost ticks in timer devices.
>> @@ -1098,8 +1105,8 @@
>>              '*decompress-threads': 'int',
>>              '*cpu-throttle-initial': 'int',
>>              '*cpu-throttle-increment': 'int',
>> -            '*tls-creds': 'str',
>> -            '*tls-hostname': 'str',
>> +            '*tls-creds': 'StrOrNull',
>> +            '*tls-hostname': 'StrOrNull',
>>              '*max-bandwidth': 'int',
>>              '*downtime-limit': 'int',
>>              '*x-checkpoint-delay': 'int',
>
> By splitting input from output, you guarantee that 'null' won't appear
> in the output and break an unsuspecting client, but that new clients can
> introspect the existence of null and use that instead of "" on input.

Yes.

We don't want null in output.  My unsharing makes that syntactically
impossible.  Nice bonus, not why I went that route.  I did because it
reduces code churn quite a bit, which is what we need right now.

Likewise, we don't want absent members in output.  The sharing (commit
de63ab6) made that syntactically possible.  My unsharing doesn't make it
impossible, because it refrains from removing the '*' from
MigrationParameters.

If we decide not to restore the sharing, we should make absent members
syntactically impossible.

If we decice to restore the sharing, null in output will become
syntactically possible.

We'll have to pick our poison: tighter schema or more concise schema.
We picked concise last time.

> Reviewed-by: Eric Blake <eblake@redhat.com>

Thanks!

^ permalink raw reply	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 10/10] migration: Use JSON null instead of "" to reset parameter to default
  2017-07-18 17:46   ` Eric Blake
  2017-07-18 18:37     ` Markus Armbruster
@ 2017-07-18 18:39     ` Markus Armbruster
  2017-07-18 19:09       ` Eric Blake
  1 sibling, 1 reply; 54+ messages in thread
From: Markus Armbruster @ 2017-07-18 18:39 UTC (permalink / raw)
  To: Eric Blake; +Cc: qemu-devel, kwolf, qemu-block, quintela, dgilbert, mreitz

Eric Blake <eblake@redhat.com> writes:

> On 07/18/2017 08:41 AM, Markus Armbruster wrote:
>> migrate-set-parameters sets migration parameters according to is
>> arguments like this:
>> 
>> * Present means "set the parameter to this value"
>> 
>> * Absent means "leave the parameter unchanged"
>> 
>> * Except for parameters tls_creds and tls_hostname, "" means "reset
>>   the parameter to its default value
>> 
>> The first two are perfectly normal: presence of the parameter makes
>> the command do something.
>> 
>> The third one overloads the parameter with a second meaning.  The
>> overloading is *implicit*, i.e. it's not visible in the types.  Works
>> here, because "" is neither a valid TLS credentials ID, nor a valid
>> host name.
>> 
>> Pressing argument values the schema accepts, but are semantically
>> invalid, into service to mean "reset to default" is not general, as
>> suitable invalid values need not exist.  I also find it ugly.
>> 
>> To clean this up, we could add a separate flag argument to ask for
>> "reset to default", or add a distinct value to @tls_creds and
>> @tls_hostname.  This commit implements the latter: add JSON null to
>> the values of @tls_creds and @tls_hostname, deprecate "".
>> 
>> Because we're so close to the 2.10 freeze, implement it in the
>> stupidest way possible: have qmp_migrate_set_parameters() rewrite null
>> to "" before anything else can see the null.  The proper way to do it
>> would be rewriting "" to null, but that requires fixing up code to
>> work with null.  Add TODO comments for that.
>> 
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>> +++ b/qapi-schema.json
>> @@ -116,6 +116,13 @@
>>  { 'command': 'qmp_capabilities' }
>>  
>>  ##
>> +# @StrOrNull:
>
> A little light on the documentation.

Care to suggest improvements?  I figure the schema is obvious enough
without any, but the generated documentation could perhaps use some.

[...]

^ permalink raw reply	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 10/10] migration: Use JSON null instead of "" to reset parameter to default
  2017-07-18 18:39     ` Markus Armbruster
@ 2017-07-18 19:09       ` Eric Blake
  2017-07-18 19:32         ` Markus Armbruster
  0 siblings, 1 reply; 54+ messages in thread
From: Eric Blake @ 2017-07-18 19:09 UTC (permalink / raw)
  To: Markus Armbruster
  Cc: qemu-devel, kwolf, qemu-block, quintela, dgilbert, mreitz

[-- Attachment #1: Type: text/plain, Size: 786 bytes --]

On 07/18/2017 01:39 PM, Markus Armbruster wrote:

>>> +++ b/qapi-schema.json
>>> @@ -116,6 +116,13 @@
>>>  { 'command': 'qmp_capabilities' }
>>>  
>>>  ##
>>> +# @StrOrNull:
>>
>> A little light on the documentation.
> 
> Care to suggest improvements?  I figure the schema is obvious enough
> without any, but the generated documentation could perhaps use some.

Perhaps:

Specifies a string value or the explicit lack of a string (often used as
an optional parameter type, where omitting the parameter has different
semantics than supplying null).
@s a JSON string
@n an explicit NULL


and certainly worth having

Since: 2.10

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]

^ permalink raw reply	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 10/10] migration: Use JSON null instead of "" to reset parameter to default
  2017-07-18 17:52   ` Dr. David Alan Gilbert
@ 2017-07-18 19:24     ` Markus Armbruster
  2017-07-19  8:32       ` Daniel P. Berrange
  0 siblings, 1 reply; 54+ messages in thread
From: Markus Armbruster @ 2017-07-18 19:24 UTC (permalink / raw)
  To: Dr. David Alan Gilbert; +Cc: kwolf, qemu-block, quintela, qemu-devel, mreitz

"Dr. David Alan Gilbert" <dgilbert@redhat.com> writes:

> * Markus Armbruster (armbru@redhat.com) wrote:
>> migrate-set-parameters sets migration parameters according to is
>> arguments like this:
>> 
>> * Present means "set the parameter to this value"
>> 
>> * Absent means "leave the parameter unchanged"
>> 
>> * Except for parameters tls_creds and tls_hostname, "" means "reset
>>   the parameter to its default value
>
> Is this really what's happening? IMHO the tls_creds and tls_hostname
> behaviour isn't that "" resets to the default, it just is the default.
> I don't think there's anything special cased for tls_creds and
> tls_hostname in the existing code.    It's this patch that's
> adding more special casing.
>
> (I'm not going to nack this, but I just don't get why it's such a big
> deal)

It wouldn't call it a big deal.  In fact, I called it a "minor QMP
interface design flaw".

The implementation encodes "no TLS credentials, do not use TLS" and "no
host name, fall back to the one in the migration URI" as "".  Works
because "" is neither a valid TLS credentials ID, nor a valid host name.

Until commit 4af245d (v2.9.0), the implementation used NULL / optional
absent rather than "".  Cleaner, because it doesn't rely on "" being
invalid.

The reason why commit 4af245d changed it to "" was that
migrate-set-parameters can't do NULL / optional absent.  It can't,
because it already uses optional absent for "do not change this
parameter".

Replacing NULL by "" side-stepped this problem.  I dislike that because
it's not general (only works as long as "" is not a valid value), and
ugly.

Instead of side-stepping the problem, I proposed to tackle it: make JSON
null mean NULL in migrate-set-parameters.  However, the freeze was
literally the other day, we needed *some* solution, and only the one
making "" special was ready.  So I let it pass.

Related: NULL used to be shown as "" in query-migrate-parameters.
Commit de63ab6 (v2.8.0) fixed that oddity, but commit 4af245d (v2.9.0)
regressed the fix, probably unintentionally.

My patch doesn't fix that regression.  It doesn't revert the flip from
NULL to "".  It merely corrects the QAPI interface, in the stupidest way
possible, because that's all I could do for 2.10's soft freeze.

I'm open to fixing the query-migrate-parameters regression during
freeze.

See also

    Message-ID: <87379zhrhn.fsf@dusky.pond.sub.org>
    https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg04526.html

and

    Message-ID: <87bmt3t5r0.fsf@dusky.pond.sub.org>
    https://lists.gnu.org/archive/html/qemu-devel/2017-03/msg02841.html

^ permalink raw reply	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 10/10] migration: Use JSON null instead of "" to reset parameter to default
  2017-07-18 19:09       ` Eric Blake
@ 2017-07-18 19:32         ` Markus Armbruster
  2017-07-18 19:55           ` Eric Blake
  0 siblings, 1 reply; 54+ messages in thread
From: Markus Armbruster @ 2017-07-18 19:32 UTC (permalink / raw)
  To: Eric Blake; +Cc: kwolf, qemu-block, quintela, qemu-devel, dgilbert, mreitz

Eric Blake <eblake@redhat.com> writes:

> On 07/18/2017 01:39 PM, Markus Armbruster wrote:
>
>>>> +++ b/qapi-schema.json
>>>> @@ -116,6 +116,13 @@
>>>>  { 'command': 'qmp_capabilities' }
>>>>  
>>>>  ##
>>>> +# @StrOrNull:
>>>
>>> A little light on the documentation.
>> 
>> Care to suggest improvements?  I figure the schema is obvious enough
>> without any, but the generated documentation could perhaps use some.
>
> Perhaps:
>
> Specifies a string value or the explicit lack of a string (often used as
> an optional parameter type, where omitting the parameter has different
> semantics than supplying null).
> @s a JSON string
> @n an explicit NULL
>
>
> and certainly worth having
>
> Since: 2.10

What about:

##
# @StrOrNull:
#
# This is a string value or the explicit lack of a string (null
# pointer in C).  Intended for cases when 'optional absent' already
# has a different meaning.
#
# @s: the string value
# @n: no string value
#
# Since: 2.10
##

^ permalink raw reply	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 03/10] qapi: Introduce a first class 'null' type
  2017-07-18 15:21       ` Markus Armbruster
@ 2017-07-18 19:43         ` Markus Armbruster
  2017-07-18 19:47           ` Eric Blake
  2017-07-18 20:08           ` Eric Blake
  0 siblings, 2 replies; 54+ messages in thread
From: Markus Armbruster @ 2017-07-18 19:43 UTC (permalink / raw)
  To: Eric Blake; +Cc: qemu-devel, kwolf, qemu-block, quintela, dgilbert, mreitz

Markus Armbruster <armbru@redhat.com> writes:

> Eric Blake <eblake@redhat.com> writes:
>
>> On 07/18/2017 09:53 AM, Eric Blake wrote:
>>> On 07/18/2017 08:41 AM, Markus Armbruster wrote:
>>>> I expect the 'null' type to be useful mostly for members of alternate
>>>> types.
>>>>
>>>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>>>> ---
>>> 
>>
>>> Reviewed-by: Eric Blake <eblake@redhat.com>
>>
>> Actually, do we need to update any qapi docs to mention the new builtin
>> type?
>
> Yes, we do.  I'll give it a shot.

Incremental patch appended.  May I keep your R-by?


diff --git a/docs/devel/qapi-code-gen.txt b/docs/devel/qapi-code-gen.txt
index 52e3874..6d8e00c 100644
--- a/docs/devel/qapi-code-gen.txt
+++ b/docs/devel/qapi-code-gen.txt
@@ -283,6 +283,7 @@ The following types are predefined, and map to C as follows:
                        accepts size suffixes
   bool      bool       JSON true or false
   any       QObject *  any JSON value
+  null      QNull *    JSON null
   QType     QType      JSON string matching enum QType values
 
 
@@ -536,10 +537,11 @@ can only express a choice between types represented differently in
 JSON.  If a branch is typed as the 'bool' built-in, the alternate
 accepts true and false; if it is typed as any of the various numeric
 built-ins, it accepts a JSON number; if it is typed as a 'str'
-built-in or named enum type, it accepts a JSON string; and if it is
-typed as a complex type (struct or union), it accepts a JSON object.
-Two different complex types, for instance, aren't permitted, because
-both are represented as a JSON object.
+built-in or named enum type, it accepts a JSON string; if it is typed
+as the 'null' built-in, it accepts JSON null, and if it is typed as a
+complex type (struct or union), it accepts a JSON object.  Two
+different complex types, for instance, aren't permitted, because both
+are represented as a JSON object.
 
 The example alternate declaration above allows using both of the
 following example objects:

^ permalink raw reply related	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 03/10] qapi: Introduce a first class 'null' type
  2017-07-18 19:43         ` Markus Armbruster
@ 2017-07-18 19:47           ` Eric Blake
  2017-07-18 20:02             ` Markus Armbruster
  2017-07-18 20:08           ` Eric Blake
  1 sibling, 1 reply; 54+ messages in thread
From: Eric Blake @ 2017-07-18 19:47 UTC (permalink / raw)
  To: Markus Armbruster
  Cc: qemu-devel, kwolf, qemu-block, quintela, dgilbert, mreitz

[-- Attachment #1: Type: text/plain, Size: 1450 bytes --]

On 07/18/2017 02:43 PM, Markus Armbruster wrote:
> Markus Armbruster <armbru@redhat.com> writes:
> 
>> Eric Blake <eblake@redhat.com> writes:
>>
>>> On 07/18/2017 09:53 AM, Eric Blake wrote:
>>>> On 07/18/2017 08:41 AM, Markus Armbruster wrote:
>>>>> I expect the 'null' type to be useful mostly for members of alternate
>>>>> types.
>>>>>
>>>>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>>>>> ---
>>>>
>>>
>>>> Reviewed-by: Eric Blake <eblake@redhat.com>
>>>
>>> Actually, do we need to update any qapi docs to mention the new builtin
>>> type?
>>
>> Yes, we do.  I'll give it a shot.
> 
> Incremental patch appended.  May I keep your R-by?
> 
> 
> diff --git a/docs/devel/qapi-code-gen.txt b/docs/devel/qapi-code-gen.txt
> index 52e3874..6d8e00c 100644
> --- a/docs/devel/qapi-code-gen.txt
> +++ b/docs/devel/qapi-code-gen.txt
> @@ -283,6 +283,7 @@ The following types are predefined, and map to C as follows:
>                         accepts size suffixes
>    bool      bool       JSON true or false
>    any       QObject *  any JSON value
> +  null      QNull *    JSON null
>    QType     QType      JSON string matching enum QType values

I might have grouped 'null' next to 'bool', but your layout is also
okay.  Yes, my R-b is still valid with this addition.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]

^ permalink raw reply	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 10/10] migration: Use JSON null instead of "" to reset parameter to default
  2017-07-18 19:32         ` Markus Armbruster
@ 2017-07-18 19:55           ` Eric Blake
  0 siblings, 0 replies; 54+ messages in thread
From: Eric Blake @ 2017-07-18 19:55 UTC (permalink / raw)
  To: Markus Armbruster
  Cc: kwolf, qemu-block, quintela, qemu-devel, dgilbert, mreitz

[-- Attachment #1: Type: text/plain, Size: 498 bytes --]

On 07/18/2017 02:32 PM, Markus Armbruster wrote:
> What about:
> 
> ##
> # @StrOrNull:
> #
> # This is a string value or the explicit lack of a string (null
> # pointer in C).  Intended for cases when 'optional absent' already
> # has a different meaning.
> #
> # @s: the string value
> # @n: no string value
> #
> # Since: 2.10
> ##

Works for me.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]

^ permalink raw reply	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 03/10] qapi: Introduce a first class 'null' type
  2017-07-18 19:47           ` Eric Blake
@ 2017-07-18 20:02             ` Markus Armbruster
  0 siblings, 0 replies; 54+ messages in thread
From: Markus Armbruster @ 2017-07-18 20:02 UTC (permalink / raw)
  To: Eric Blake; +Cc: kwolf, qemu-block, quintela, qemu-devel, dgilbert, mreitz

Eric Blake <eblake@redhat.com> writes:

> On 07/18/2017 02:43 PM, Markus Armbruster wrote:
>> Markus Armbruster <armbru@redhat.com> writes:
>> 
>>> Eric Blake <eblake@redhat.com> writes:
>>>
>>>> On 07/18/2017 09:53 AM, Eric Blake wrote:
>>>>> On 07/18/2017 08:41 AM, Markus Armbruster wrote:
>>>>>> I expect the 'null' type to be useful mostly for members of alternate
>>>>>> types.
>>>>>>
>>>>>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>>>>>> ---
>>>>>
>>>>
>>>>> Reviewed-by: Eric Blake <eblake@redhat.com>
>>>>
>>>> Actually, do we need to update any qapi docs to mention the new builtin
>>>> type?
>>>
>>> Yes, we do.  I'll give it a shot.
>> 
>> Incremental patch appended.  May I keep your R-by?
>> 
>> 
>> diff --git a/docs/devel/qapi-code-gen.txt b/docs/devel/qapi-code-gen.txt
>> index 52e3874..6d8e00c 100644
>> --- a/docs/devel/qapi-code-gen.txt
>> +++ b/docs/devel/qapi-code-gen.txt
>> @@ -283,6 +283,7 @@ The following types are predefined, and map to C as follows:
>>                         accepts size suffixes
>>    bool      bool       JSON true or false
>>    any       QObject *  any JSON value
>> +  null      QNull *    JSON null
>>    QType     QType      JSON string matching enum QType values
>
> I might have grouped 'null' next to 'bool', but your layout is also
> okay.  Yes, my R-b is still valid with this addition.

I like your order better; lines swapped.  Thanks!

^ permalink raw reply	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 03/10] qapi: Introduce a first class 'null' type
  2017-07-18 19:43         ` Markus Armbruster
  2017-07-18 19:47           ` Eric Blake
@ 2017-07-18 20:08           ` Eric Blake
  2017-07-18 20:27             ` Markus Armbruster
  1 sibling, 1 reply; 54+ messages in thread
From: Eric Blake @ 2017-07-18 20:08 UTC (permalink / raw)
  To: Markus Armbruster
  Cc: qemu-devel, kwolf, qemu-block, quintela, dgilbert, mreitz

[-- Attachment #1: Type: text/plain, Size: 1166 bytes --]

On 07/18/2017 02:43 PM, Markus Armbruster wrote:
> @@ -536,10 +537,11 @@ can only express a choice between types represented differently in
>  JSON.  If a branch is typed as the 'bool' built-in, the alternate
>  accepts true and false; if it is typed as any of the various numeric
>  built-ins, it accepts a JSON number; if it is typed as a 'str'
> -built-in or named enum type, it accepts a JSON string; and if it is
> -typed as a complex type (struct or union), it accepts a JSON object.
> -Two different complex types, for instance, aren't permitted, because
> -both are represented as a JSON object.
> +built-in or named enum type, it accepts a JSON string; if it is typed
> +as the 'null' built-in, it accepts JSON null, and if it is typed as a
> +complex type (struct or union), it accepts a JSON object.  Two

Grammar tweak: s/null,/null;/

In a list of phrases that all have commas, it's typical to graduate the
list separator to semicolon, so that it becomes easier to see the flow
of 'a,b; a,b; and a,b'


-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]

^ permalink raw reply	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 03/10] qapi: Introduce a first class 'null' type
  2017-07-18 20:08           ` Eric Blake
@ 2017-07-18 20:27             ` Markus Armbruster
  0 siblings, 0 replies; 54+ messages in thread
From: Markus Armbruster @ 2017-07-18 20:27 UTC (permalink / raw)
  To: Eric Blake; +Cc: kwolf, qemu-block, quintela, qemu-devel, dgilbert, mreitz

Eric Blake <eblake@redhat.com> writes:

> On 07/18/2017 02:43 PM, Markus Armbruster wrote:
>> @@ -536,10 +537,11 @@ can only express a choice between types represented differently in
>>  JSON.  If a branch is typed as the 'bool' built-in, the alternate
>>  accepts true and false; if it is typed as any of the various numeric
>>  built-ins, it accepts a JSON number; if it is typed as a 'str'
>> -built-in or named enum type, it accepts a JSON string; and if it is
>> -typed as a complex type (struct or union), it accepts a JSON object.
>> -Two different complex types, for instance, aren't permitted, because
>> -both are represented as a JSON object.
>> +built-in or named enum type, it accepts a JSON string; if it is typed
>> +as the 'null' built-in, it accepts JSON null, and if it is typed as a
>> +complex type (struct or union), it accepts a JSON object.  Two
>
> Grammar tweak: s/null,/null;/
>
> In a list of phrases that all have commas, it's typical to graduate the
> list separator to semicolon, so that it becomes easier to see the flow
> of 'a,b; a,b; and a,b'

Fixed, thanks!

^ permalink raw reply	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 00/10] Correct two minor QMP interface design flaws
  2017-07-18 16:08 ` Daniel P. Berrange
@ 2017-07-19  6:12   ` Kevin Wolf
  0 siblings, 0 replies; 54+ messages in thread
From: Kevin Wolf @ 2017-07-19  6:12 UTC (permalink / raw)
  To: Daniel P. Berrange
  Cc: Markus Armbruster, qemu-devel, eblake, mreitz, qemu-block,
	quintela, dgilbert

Am 18.07.2017 um 18:08 hat Daniel P. Berrange geschrieben:
> On Tue, Jul 18, 2017 at 03:41:16PM +0200, Markus Armbruster wrote:
> > blockdev-add and migrate-set-parameters overload empty strings to mean
> > something entirely different.  See my memo "qapi: Stop abusing
> > "special" values for something entirely different" for details.
> > 
> >     Message-ID: <87379zhrhn.fsf@dusky.pond.sub.org>
> >     https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg04526.html
> > 
> > This series deprecates these usages of "" in favour of JSON null.
> > Because we're so close to the 2.10 freeze, the implementation is
> > intentionally stupid: rewrite null to "" at first opportunity.  The
> > proper way to do it would be rewriting "" to null, but that requires
> > fixing up code to work with null.  There are TODO comments for that.
> > I'm willing to take care of them in the next development cycle.
> 
> I tested the migrate-set-parameters QMP command with this applied and
> I can still pass "" as the tls-hostname.
> 
> When using query-migrate-parameters we still see "" too.
> 
> So from POV of avoiding regressions for existing usage, we look OK
> here.

Opportunity for a follow-up patch: Automate these tests.

Kevin

^ permalink raw reply	[flat|nested] 54+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 10/10] migration: Use JSON null instead of "" to reset parameter to default
  2017-07-18 19:24     ` Markus Armbruster
@ 2017-07-19  8:32       ` Daniel P. Berrange
  0 siblings, 0 replies; 54+ messages in thread
From: Daniel P. Berrange @ 2017-07-19  8:32 UTC (permalink / raw)
  To: Markus Armbruster
  Cc: Dr. David Alan Gilbert, kwolf, mreitz, qemu-devel, qemu-block,
	quintela

On Tue, Jul 18, 2017 at 09:24:08PM +0200, Markus Armbruster wrote:
> "Dr. David Alan Gilbert" <dgilbert@redhat.com> writes:
> 
> > * Markus Armbruster (armbru@redhat.com) wrote:
> >> migrate-set-parameters sets migration parameters according to is
> >> arguments like this:
> >> 
> >> * Present means "set the parameter to this value"
> >> 
> >> * Absent means "leave the parameter unchanged"
> >> 
> >> * Except for parameters tls_creds and tls_hostname, "" means "reset
> >>   the parameter to its default value
> >
> > Is this really what's happening? IMHO the tls_creds and tls_hostname
> > behaviour isn't that "" resets to the default, it just is the default.
> > I don't think there's anything special cased for tls_creds and
> > tls_hostname in the existing code.    It's this patch that's
> > adding more special casing.
> >
> > (I'm not going to nack this, but I just don't get why it's such a big
> > deal)
> 
> It wouldn't call it a big deal.  In fact, I called it a "minor QMP
> interface design flaw".
> 
> The implementation encodes "no TLS credentials, do not use TLS" and "no
> host name, fall back to the one in the migration URI" as "".  Works
> because "" is neither a valid TLS credentials ID, nor a valid host name.
> 
> Until commit 4af245d (v2.9.0), the implementation used NULL / optional
> absent rather than "".  Cleaner, because it doesn't rely on "" being
> invalid.
> 
> The reason why commit 4af245d changed it to "" was that
> migrate-set-parameters can't do NULL / optional absent.  It can't,
> because it already uses optional absent for "do not change this
> parameter".
> 
> Replacing NULL by "" side-stepped this problem.  I dislike that because
> it's not general (only works as long as "" is not a valid value), and
> ugly.
> 
> Instead of side-stepping the problem, I proposed to tackle it: make JSON
> null mean NULL in migrate-set-parameters.  However, the freeze was
> literally the other day, we needed *some* solution, and only the one
> making "" special was ready.  So I let it pass.
> 
> Related: NULL used to be shown as "" in query-migrate-parameters.
> Commit de63ab6 (v2.8.0) fixed that oddity, but commit 4af245d (v2.9.0)
> regressed the fix, probably unintentionally.

>From libvirt POV we considered de63ab6 to be the regression (from the
original 2.6.0 behaviour), and 4af245d to be the fix for that regression.
Libvirt expected to see "" for tls-hostname in the output - without that
it doesn't know that tls-hostname is even a valida parameter.

> I'm open to fixing the query-migrate-parameters regression during
> freeze.

No please don't. That will break libvirt yet again.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

^ permalink raw reply	[flat|nested] 54+ messages in thread

end of thread, other threads:[~2017-07-19  8:33 UTC | newest]

Thread overview: 54+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-18 13:41 [Qemu-devel] [PATCH for-2.10 00/10] Correct two minor QMP interface design flaws Markus Armbruster
2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 01/10] qapi: Separate type QNull from QObject Markus Armbruster
2017-07-18 14:24   ` Eric Blake
2017-07-18 15:44   ` Daniel P. Berrange
2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 02/10] qapi: Use QNull for a more regular visit_type_null() Markus Armbruster
2017-07-18 14:36   ` Eric Blake
2017-07-18 15:05     ` Markus Armbruster
2017-07-18 15:46   ` Daniel P. Berrange
2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 03/10] qapi: Introduce a first class 'null' type Markus Armbruster
2017-07-18 14:53   ` Eric Blake
2017-07-18 14:54     ` Eric Blake
2017-07-18 15:21       ` Markus Armbruster
2017-07-18 19:43         ` Markus Armbruster
2017-07-18 19:47           ` Eric Blake
2017-07-18 20:02             ` Markus Armbruster
2017-07-18 20:08           ` Eric Blake
2017-07-18 20:27             ` Markus Armbruster
2017-07-18 15:20     ` Markus Armbruster
2017-07-18 15:47   ` Daniel P. Berrange
2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 04/10] tests/test-qobject-input-visitor: Drop redundant test Markus Armbruster
2017-07-18 15:13   ` Eric Blake
2017-07-18 15:47   ` Daniel P. Berrange
2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 05/10] block: Use JSON null instead of "" to disable backing file Markus Armbruster
2017-07-18 15:53   ` Daniel P. Berrange
2017-07-18 17:27   ` Eric Blake
2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 06/10] hmp: Clean up and simplify hmp_migrate_set_parameter() Markus Armbruster
2017-07-18 15:54   ` Daniel P. Berrange
2017-07-18 17:09   ` Dr. David Alan Gilbert
2017-07-18 17:34   ` Eric Blake
2017-07-18 18:28     ` Markus Armbruster
2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 07/10] migration: Clean up around tls_creds, tls_hostname Markus Armbruster
2017-07-18 15:57   ` Daniel P. Berrange
2017-07-18 17:36   ` Eric Blake
2017-07-18 17:37   ` Dr. David Alan Gilbert
2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 08/10] migration: Add TODO comments on duplication of QAPI_CLONE() Markus Armbruster
2017-07-18 15:57   ` Daniel P. Berrange
2017-07-18 17:36   ` Eric Blake
2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 09/10] migration: Unshare MigrationParameters struct for now Markus Armbruster
2017-07-18 16:01   ` Daniel P. Berrange
2017-07-18 17:42   ` Eric Blake
2017-07-18 13:41 ` [Qemu-devel] [PATCH for-2.10 10/10] migration: Use JSON null instead of "" to reset parameter to default Markus Armbruster
2017-07-18 16:03   ` Daniel P. Berrange
2017-07-18 17:46   ` Eric Blake
2017-07-18 18:37     ` Markus Armbruster
2017-07-18 18:39     ` Markus Armbruster
2017-07-18 19:09       ` Eric Blake
2017-07-18 19:32         ` Markus Armbruster
2017-07-18 19:55           ` Eric Blake
2017-07-18 17:52   ` Dr. David Alan Gilbert
2017-07-18 19:24     ` Markus Armbruster
2017-07-19  8:32       ` Daniel P. Berrange
2017-07-18 14:02 ` [Qemu-devel] [PATCH for-2.10 00/10] Correct two minor QMP interface design flaws no-reply
2017-07-18 16:08 ` Daniel P. Berrange
2017-07-19  6:12   ` Kevin Wolf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).